D14692: Use custom QScrollArea with size hint not limited by font size

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Wow, this works perfectly for me. I banged my head against this by trying to pass the sizeHint to the existing scrollview, so it makes sense to me know to know that a regular scrollView

D14692: Use custom QScrollArea with size hint not limited by font size

ngraham added a comment. OK, great! Could you add a comment in the code indicating that the custom scrollview is a workaround for that bug? REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 To: valeriymalov, #frameworks, ngraham Cc: ngraham,

D14663: Give the "invalid directory name" dialog a cancel button

This revision was automatically updated to reflect the committed changes. Closed by commit R241:63178e2fe045: Give the invalid directory name dialog a cancel button (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14663?vs=39275=39311

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:8606d4d97f3e: [recentdocuments:/] Filter out files that cant be browsed with a file manager (authored by ngraham).

D14952: Fix includedDefinitions, handle definition change in context switch

ngraham edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14952 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars,

D14237: Make Konqi look good in HiDPI

ngraham added a reviewer: bruns. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks, #vdg, bruns Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 40099. ngraham added a comment. Simplify, simplify REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=40083=40099 BRANCH hidpi-konqi (branched from master) REVISION DETAIL https://phabricator.kde.org/D14237

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 40104. ngraham added a comment. Un-simplify; the previous version was better REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=40101=40104 BRANCH hidpi-konqi (branched from master) REVISION DETAIL

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 40083. ngraham added a comment. Rebase on current master REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=40081=40083 BRANCH hidpi-konqi (branched from master) REVISION DETAIL

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 40080. ngraham added a comment. Use @bruns' awesome SVG REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=38367=40080 BRANCH hidpi-konqi (branched from master) REVISION DETAIL

D14237: Make Konqi look good in HiDPI

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks, #vdg Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 40101. ngraham added a comment. Simplify even more (maybe this is too much simplification though?) REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=40099=40101 BRANCH hidpi-konqi (branched from master)

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 40081. ngraham added a comment. ...Actually add the SVG image :) REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=40080=40081 BRANCH hidpi-konqi (branched from master) REVISION DETAIL

D14971: Combine display OSD icon files and move to plasma icon theme

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. If we rename the icons, we will need to correspondingly change the OSD code itself to use the new names: https://cgit.kde.org/kscreen.git/tree/kded/qml/OsdSelector.qml#n51

D14971: Combine display OSD icon files and move to plasma icon theme

ngraham added a comment. When I apply this patch and compile and deploy plasma-framework to `/usr/` and then delete the Breeze icons versions, I still don't see the new icons in the switcher. What am I doing wrong? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D12311: Align lock icon with bold message text; reduce overall size of dialog

ngraham added a comment. Are you going to land this? REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham, abetts, #frameworks Cc: stikonas, bruns, ltoscano,

D14237: Make Konqi look good in HiDPI

ngraham closed this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks, #vdg, bruns Cc: svenmauch, aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14237: Make Konqi look good in HiDPI

ngraham added a comment. Ping, is this good to go now? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks, #vdg, bruns Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14940: kformattest: Use plural suffix (s) consequently

ngraham added a comment. FWIW, "1.0 seconds" is what I've always been taught. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14940 To: habacker, aacid Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15000: Display mounted file system type in properties dialog

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Let's move the new "Mounted from:" code to within the conditional that determines whether or not to show "Mounted on:". We should show both or neither, not just one.

D14237: Make Konqi look good in HiDPI

ngraham added a subscriber: svenmauch. REPOSITORY R263 KXmlGui BRANCH hidpi-konqi (branched from master) REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks, #vdg, bruns Cc: svenmauch, aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 40389. ngraham marked an inline comment as done. ngraham added a comment. Correct file permissions REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=40246=40389 BRANCH hidpi-konqi (branched from master)

D15071: Don't draw frames and shadows around images with an alpha channel

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15071: Don't draw frames and shadows around images with an alpha channel

ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin, VDG, broulik, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This patch improves and simplifies the criteria for

D15071: Don't draw frames and shadows around images with transparency

ngraham added a comment. @markg I'm in favor of keeping the conditional logic for the frames. If we think of this from an aesthetic point of view, we should draw frames and shadows around images that actually look better as a result. Those would be square and rectangular images with no

D15071: Don't draw frames and shadows around images with an alpha channel

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck Cc: abetts, bruns, kde-frameworks-devel, michaelh, ngraham

D15071: Don't draw frames and shadows around images with transparency

ngraham retitled this revision from "Don't draw frames and shadows around images with an alpha channel" to "Don't draw frames and shadows around images with transparency". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg,

D13643: Add LabPlot project file icon

ngraham added a comment. Whoops, sorry this was missed. I can merge it for you, since it looks great! In order to do this, I'll need to know your real name and preferred email address. Can you tell me those? REPOSITORY R266 Breeze Icons REVISION DETAIL

D15071: Don't draw frames and shadows around images with transparency

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck Cc: markg, abetts, bruns, kde-frameworks-devel, michaelh, ngraham

D15071: Don't draw frames and shadows around images with an alpha channel

ngraham added a subscriber: markg. ngraham added a comment. @bruns, done. @broulik, @markg I too was concerned about the case of images that have an alpha channel but not actual transparency. I did not actually have any images on my computer that had an alpha channel but no

D13643: Add LabPlot project file icon

ngraham closed this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg, #breeze, ngraham Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

ngraham added a comment. Thanks again for your contribution! Next time, we'll try to be more on the ball about the review. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg, #breeze, ngraham Cc: abetts, asemke, ngraham,

D15000: Display mounted file system type and mounted from fields in properties dialog

ngraham accepted this revision. ngraham added reviewers: Frameworks, cfeck. ngraham added a comment. This revision is now accepted and ready to land. Works great and looks fine to me, and the code seems sensible too given that this dialog is currently implemented with a GridLayout. I'd like

D14449: Modify device usage information

ngraham added a comment. Do you plan to submit a new version of this after the layout has been converted to use `QFormLayout`? I do hope some form of this patch makes it in, since IMHO it's a nice little quality-of-life improvement. REPOSITORY R241 KIO REVISION DETAIL

D14449: Modify device usage information

ngraham added a comment. Great! Are you gonna do the QFormLayout patch, or should I? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D15071: Don't draw frames and shadows around images with transparency

ngraham added a comment. In D15071#315839 , @broulik wrote: > I'm a bit concerned that removing the frame most of the time blurs the lines between "previews of images" and "actual file icons", especially for the SVG case. Thing is, this

D15071: Don't draw frames and shadows around images with transparency

ngraham added a comment. So do we have any firm conclusions here? The current state is already rather broken both conceptually and in practice, as illustrated by the "before" images. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks,

D10937: Retouching of Screen Layout Selection OSD Icons

ngraham added a subscriber: gladhorn. ngraham added a comment. In D10937#311297 , @bruns wrote: > I think this works better if you actually rotate the screen: > F6203935: rotate2.png In KScreen,

D8536: Add more hashing algorithms to KPropertiesDialog

ngraham added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. @petermajchrak, are you going to finish this, or should someone else take over? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak,

D14971: Combine display OSD icon files and move to plasma icon theme

ngraham added a comment. Ah, that did it. So should we bump the version in this patch, then? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14971 To: pstefan, ngraham, #vdg, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14971: Combine display OSD icon files and move to plasma icon theme

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14971 To: pstefan, ngraham, #vdg, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15021: Workaround bug with native rendering and opacity in TextField text

ngraham added a comment. We could also get rid of the `import QtQuick.Window 2.2` line since it only existed to get `Screen.devicePixelRatio`, which this patch removes. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL

D15021: Workaround bug with native rendering and opacity in TextField text

ngraham added a comment. Anyway, confirmed that this works around the problem for me. +1 REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D15021 To: davidedmundson, #plasma, broulik Cc: ngraham,

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

ngraham abandoned this revision. ngraham added a comment. Don't need this; not the right approach. The original motivation for doing this (to work around the broken placeholder text in the PC2 TextField) is being fixed in the PC2 TextField with D15021 and

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

ngraham added a comment. In D14893#311411 , @markg wrote: > It "looks" oke to me, but i don't know this code one bit. Give it a try, it's pretty easy to test with the test plan. REPOSITORY R320 KIO Extras REVISION DETAIL

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

ngraham marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14893 To: ngraham, broulik, #dolphin, #frameworks Cc: markg

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

ngraham updated this revision to Diff 40054. ngraham added a comment. Move comment REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14893?vs=39892=40054 BRANCH arcpatch-D14893 REVISION DETAIL https://phabricator.kde.org/D14893 AFFECTED FILES

D15000: Display mounted file system type in properties dialog

ngraham added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 40246. ngraham added a comment. Use @bruns' latest SVG REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=40104=40246 BRANCH hidpi-konqi (branched from master) REVISION DETAIL

D15071: Don't draw frames and shadows around images with transparency

ngraham added a comment. In D15071#316156 , @bruns wrote: > If we want to avoid **dangerous** confusion, we should not care for previews, but mark executables. This seems like an excellent idea to me. It would improve safety even without

D6512: Add support for proposed tags addition in OCS 1.7

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, shipit! REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D6512 To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra, ngraham Cc: cfeck, ahiemstra,

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

ngraham added a comment. Thanks! BTW, It's now technically acceptable for the `BUG:` keyword to go at the beginning. Sysadmins fixed the bug that was preventing this from working before. @broulik does this patch make sense to you? For me it does not break the case of the same document

D14237: Make Konqi look good in HiDPI

ngraham edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14237: Make Konqi look good in HiDPI

ngraham created this revision. ngraham added reviewers: broulik, cfeck, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Substitute a triple-size Konqi

D14237: Make Konqi look good in HiDPI

ngraham edited the test plan for this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14237: Make Konqi look good in HiDPI

ngraham edited the test plan for this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 38106. ngraham added a comment. Use smooth transformation to slightly improve appearance REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=38105=38106 BRANCH hidpi-konqi (branched from master) REVISION DETAIL

D14237: Make Konqi look good in HiDPI

ngraham edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14118: Improve "Remove this [widget]" text

ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14118 To: ngraham, #plasma, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14118: Improve "Remove this [widget]" text

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This patch adds the word "widget" onto the end of

D14123: Add `drive-optical` icon

ngraham created this revision. ngraham added reviewers: broulik, andreask. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY It's just a symlink to `media-optical`

D14123: Add `drive-optical` icon

ngraham added reviewers: Breeze, VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D14123 To: ngraham, broulik, andreask, #breeze, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D9394: Show "Search wrapped" message in center of view for better visibility

ngraham added a comment. Retroactive +1 on the positioning and wording, but I would have stayed with an Informational (blue) KMessageWidget instead of making it Positive (and hence, green). Eh, not a huge deal. Shoulda piped up sooner! REPOSITORY R39 KTextEditor REVISION DETAIL

D14118: Improve "Remove this [widget]" text

ngraham added a comment. Ping? Is the proposed wording good enough, or should we maybe instead just remove the word "this" and make it use "Remove ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14118 To: ngraham, #plasma, #vdg Cc:

D13805: Present error dialog when user tries to create directory named "." or ".."

ngraham added a comment. @tmarshall, any update on this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks, ngraham, dfaure, elvisangelaccio Cc: cfeck, elvisangelaccio, dfaure, tmarshall, bruns, ngraham, kde-frameworks-devel,

D13805: Present error dialog when user tries to create directory named "." or ".."

ngraham added a comment. Thanks for the update! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks, ngraham, dfaure, elvisangelaccio Cc: cfeck, elvisangelaccio, dfaure, tmarshall, bruns, ngraham, kde-frameworks-devel, michaelh,

D13808: Fix KMainWindow saving incorrect widget settings

ngraham added a comment. Shall we commit this? maxrd2 , can you do it, or does one of us need to commit it for you? REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio,

D13899: KMessageWidget: use theme instead of hardcoded colours

ngraham added a comment. This patch works as advertised, and does not imposes any visual regressions when using the Breeze color scheme. And yet, when trying it out with non-default color schemes, I can't help but wonder what we're actually accomplishing here. While the Positive color

D13773: [KDirOperator] Use alternating background colors for multi-column views

ngraham retitled this revision from "[KDirOperator] Use alternating background colors for list-style views" to "[KDirOperator] Use alternating background colors for multi-column views". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY

D13808: Fix KMainWindow saving incorrect widget settings

ngraham added a comment. Yeah, I say let's remove the test for now so we can commit this, and then you can add the test back in another patch please (in working form, of course!). :) REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL

D14308: [Exe Thumbnailer] Improve icon selection algorithm

ngraham added a comment. What a dramatic set of before-and-after images! It's like we jumped from 1991 to 2018. > Algo is basically copied from Plasma's wallpaper selection Sounds like we should put this in a Framework and re-use it instead of copy-pasting it here. INLINE COMMENTS

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yes, I like it the idea. The chosen shortcut makes sense, and I'm always in favor of standardizing these across apps. Let's hold off on landing this patch (if accepted by everyone) until

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

ngraham added a comment. Hah! Well in that case, that won't be a blocker. REPOSITORY R237 KConfig BRANCH shortcut-actual-size (branched from master) REVISION DETAIL https://phabricator.kde.org/D14201 To: muhlenpfordt, dfaure, broulik, ngraham Cc: rkflx, kde-frameworks-devel,

D14218: Introduce a test to make sure we're not offering duplicated icons

ngraham added a comment. +1 conceptually. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D14218 To: apol, andreaska, mart, vkrause, #breeze, #frameworks Cc: ngraham, andreask, kde-frameworks-devel, michaelh, bruns

D14218: Introduce a test to make sure we're not offering duplicated icons

ngraham edited reviewers, added: Breeze, Frameworks; removed: Framework: Syntax Highlighting. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D14218 To: apol, andreaska, mart, vkrause, #breeze, #frameworks, #framework_syntax_highlighting Cc: andreask,

D13782: RFC: Ignore NTFS hidden flag for root volume

ngraham resigned from this revision. ngraham added a comment. @wbauer, does this work for you now? Or @bruns? Still cannot test as I have no NTFS partitions. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13782 To: broulik, dfaure, yurikoles, bruns Cc: oysteins,

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

ngraham created this revision. ngraham added reviewers: Plasma, mart, davidedmundson. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The PlasmaComponents2

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14345 To: ngraham, #plasma, mart, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14345 To: ngraham, #plasma, mart, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

ngraham added a comment. Oh. Maybe I don't know the history here. Why do we have PC2 and PC3 versions of this control, with the PC2 version using QQC1, and the PC3 version using QQC2, but not having all the features of the PC2 one? And why can't we change the PC3 version at all? REPOSITORY

D14237: Make Konqi look good in HiDPI

ngraham added a comment. Funny story: after multiple attempts to use Inkscape to make an SVG of this, all versions were much larger than the new png! I don't think that's an option. @broulik, does the current approach look sane to you? I wasn't able to make it work simply adding an `@2x`

D14118: Improve "Remove this [widget]" text

ngraham marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) BRANCH remove-this-widget (branched from master) REVISION DETAIL https://phabricator.kde.org/D14118 To: ngraham, #plasma, #vdg, gladhorn Cc: gladhorn, kde-frameworks-devel, michaelh, ngraham, bruns

D14118: Improve "Remove this [widget]" text

ngraham updated this revision to Diff 38365. ngraham added a comment. Use consistent casing REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14118?vs=37768=38365 BRANCH remove-this-widget (branched from master) REVISION DETAIL

D14118: Improve "Remove this [widget]" text

ngraham added a comment. Now that I look at my screenshots more closely, it seems weird to have: Configure Notes... Remove this Notes widget Now I feel like they should match, and be either: Configure Notes... Remove Notes or: Configure this Notes

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

ngraham added a comment. In D14345#297329 , @davidedmundson wrote: > PC3 was previously designed to be a drop in QQC2 implementation. There is currently no new API. > It /might/ have changed after we made plasmastyle instead. Check with

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

ngraham added a comment. Thanks for the history! Two questions: 1. Does this mean that PlasmaComponents is semi or fully deprecated or "legacy", and we should be porting Plasma stuff to Kirigami instead? 2. Since there's no Kirigami `TextField`, what do we do with this patch? Is there

D12311: Align lock icon with bold message text; reduce overall size of dialog

ngraham added a comment. Can we commit this? REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham, abetts, #frameworks Cc: stikonas, bruns, ltoscano, broulik,

D12311: Align lock icon with bold message text; reduce overall size of dialog

ngraham accepted this revision. ngraham added a comment. Go for it then! REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham, abetts, #frameworks Cc:

D7700: Show list of tags in PlacesView

ngraham added a comment. Results of testing: - After I create a new tag, it doesn't show up in the Places panel tag list or under the `tags:/` ioslave until I restart Dolphin. - When I navigate to `tags:/` ioslave using the All Tags item in the Places panel and I click on a tag, its

D13899: KMessageWidget: use theme instead of hardcoded colours

ngraham added a comment. I think the problem here is that while themes have dedicated Positive, Negative, and Neutral colors, for the Informational color we just re-use the active or highlight color from the theme, which may not always be appropriate for use as a background for

D14097: Change default sort order in the download dialog to Rating

ngraham closed this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D14097 To: ngraham, apol, leinir, #knewstuff Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13773: [KDirOperator] Use alternating background colors for list-style views

ngraham added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13773 To: ngraham, #frameworks, #vdg, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14123: Add `drive-optical` icon

ngraham added a comment. @andreask verbally (textually?) approved this in the VDG room; landing it. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D14123 To: ngraham, broulik, andreask, #breeze, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14123: Add `drive-optical` icon

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:ca645a423dbb: Add `drive-optical` icon (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST

D13773: [KDirOperator] Use alternating background colors for multi-column views

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13773 To: ngraham, #frameworks, #vdg, #dolphin, abetts Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 38367. ngraham added a comment. Use `zopflipng` to squeeze the image down even smaller (thanks @bruns!) REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=38106=38367 BRANCH hidpi-konqi (branched from master)

D14237: Make Konqi look good in HiDPI

ngraham edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D10343: Create containment on specified screen

ngraham added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10343 To: hoffmannrobert, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14360: Remove custom icon selection for trash

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This works from Gwenview (for example), but does not work from Dolphin, because sadly Dolphin has its own duplicate of this code. :( Could you submit another patch for Dolphin too? It's

D14360: Remove custom icon selection for trash

ngraham added a reviewer: Dolphin. ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileplaceeditdialog.cpp:123 > m_iconButton = new KIconButton(this); > +m_iconButton->setVisible(url.scheme() !=

<    5   6   7   8   9   10   11   12   13   14   >