D29872: Provide methods to register SecretAgent to NetworkManager with capabilities, specifically with NM_SECRET_AGENT_CAPABILITY_VPN_HINTS

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  https://invent.kde.org/frameworks/networkmanager-qt/-/merge_requests/2

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D29872

To: apol, jgrulich, enriquem
Cc: ngraham, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29872: Provide methods to register SecretAgent to NetworkManager with capabilities, specifically with NM_SECRET_AGENT_CAPABILITY_VPN_HINTS

[Aleix Pol Gonzalez]

apol commandeered this revision.
apol added a reviewer: enriquem.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D29872

To: apol, jgrulich, enriquem
Cc: ngraham, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29872: Provide methods to register SecretAgent to NetworkManager with capabilities, specifically with NM_SECRET_AGENT_CAPABILITY_VPN_HINTS

[Aleix Pol Gonzalez]

apol added a comment.


  We have moved to gitlab, now patches should be uploaded here: 
https://invent.kde.org/frameworks/networkmanager-qt
  
  Sorry for the change (@jgrulich can still review it, but it's better to have 
everything in the new infrastructure).
  
  The patch itself looks okay to me.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D29872

To: enriquem, jgrulich
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27338: Provide an initial implementation for input-method-unstable-v1

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  https://invent.kde.org/plasma/kwayland-server/-/merge_requests/31

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27338

To: apol, #kwin, #frameworks
Cc: davidedmundson, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D22362: Port keystates to use QtWayland's generator

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  Moved to invent for kwayland-server

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22362

To: apol, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28235: Add a simpler example

[Aleix Pol Gonzalez]

apol closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28235

To: apol, vkrause, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D26524: configmodule: Make sure the kcm information is loaded when the qml is created

[Aleix Pol Gonzalez]

apol added a comment.


  hmmm. Ping @mart. :) what do you suggest we do?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26524

To: apol, #plasma, #frameworks
Cc: mart, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28235: Add a simpler example

[Aleix Pol Gonzalez]

apol added a comment.


  Should I understand this is not desired and that I should abandon it?
  
  I know it's not going to make a big difference to the project but it was hard 
for me to adopt it in the first place.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28235

To: apol, vkrause
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29540: plasmawindowmodel: Expose the internal id to the model

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  Will move to gitlab

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29540

To: apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29810: Don't use setenv after fork

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kcrash.cpp:823
> +char** environ_end;
> +for(environ_end = environ; *environ_end; ++environ_end);
> +

Use {} instead of ; for readability.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29810

To: jpalecek, #frameworks
Cc: apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29802: Require out-of-source builds

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  require-in-source-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29802

To: ngraham, #frameworks, #vdg, ognarb, davidre, apol
Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29745: look for kded as runtime dep

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  kded

REVISION DETAIL
  https://phabricator.kde.org/D29745

To: sitter, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29631: [android] Allow specifying APK install location

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  androinstall

REVISION DETAIL
  https://phabricator.kde.org/D29631

To: nicolasfella, #frameworks, #android, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fixbuildwithoutdeprecated

REVISION DETAIL
  https://phabricator.kde.org/D29600

To: kossebau, #plasma, mart, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29631: [android] Allow specifying APK install location

[Aleix Pol Gonzalez]

apol added a comment.


  +1 overall, good idea.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29631

To: nicolasfella, #frameworks, #android, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29631: [android] Allow specifying APK install location

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> Android.cmake:93
>  #
> -# The APK would then be found in ``myapp_build_apk/bin`` in the build 
> directory.
> +# You can specify the APK output directory by setting 
> ANDROID_APK_INSTALL_DIR.
> +# Otherwise the APK can be found in ``myapp_build_apk/`` in the build 
> directory.

ANDROID_APK_INSTALL_DIR should be between quotes like other variables.
Also I'd call the variable ANDROID_APK_OUTPUT_DIR. We have an install concept 
already.

> ECMAndroidDeployQt.cmake:85
>  add_custom_target(install-apk-${QTANDROID_EXPORTED_TARGET}
>  COMMAND adb install -r 
> "${EXPORT_DIR}/${QTANDROID_EXPORTED_TARGET}-${CMAKE_ANDROID_ARCH_ABI}.apk"
>  )

Needs adapting.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29631

To: nicolasfella, #frameworks, #android, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29511: Label: Add ping-pong logic

[Aleix Pol Gonzalez]

apol added a comment.


  I feel like this could break Labels unknowingly. Maybe it would make sense to 
have an extra scrollToFit (?) property or even another separate component to do 
that.
  
  Seeing things bouncing without the author intending could be worse than 
having the text cut off.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29511

To: patrickelectric, #plasma, #vdg, ognarb, davidedmundson
Cc: apol, davidedmundson, ognarb, cblack, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol added a comment.


  Moving to kwayland-server

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich, davidedmundson, zzag
Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol abandoned this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich, davidedmundson, zzag
Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D29540: plasmawindowmodel: Expose the internal id to the model

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  It allows to use this class together with the screencast protocol.
  It's public API on the window anyway so it should probably be exposed.

TEST PLAN
  Used it with the other screencast patches for convenience.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29540

AFFECTED FILES
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h

To: apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kopenwithdialog.cpp:1006
>  // Ensure that the typed binary name actually exists (#81190)
>  if (QStandardPaths::findExecutable(binaryName).isEmpty()) {
> +// Maybe it exists but isn't executable

This patch D29170  suggests that 
findExecutable won't find non-executables.

Something's wrong.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29445

To: broulik, #frameworks, #vdg
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29406: Add X-KDE-Original-Executable to Applications properties

[Aleix Pol Gonzalez]

apol added a comment.


  > If I understand correctly, it is necessary to use dbus spectacle in this 
case, so that dbus can manage the application instance and make sure we end up 
with only one, whether we launch the app, use a shortcut or launch from command 
line.
  
  I don't think that's a good reason. We have lots of applications that do that 
without having to be launched by dbus: plasmashell, krunner, yakuake, etc. It's 
done by using KDBusService.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D29406

To: meven, #frameworks, davidedmundson, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29405: [PoC] Make notifications work without a notifyrc file

[Aleix Pol Gonzalez]

apol added a comment.


  What's the advantage?
  Won't this make it harder to put together the notifications kcm?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29405

To: nicolasfella, #frameworks, broulik, vkrause
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29406: Add X-KDE-Original-Executable to Applications properties

[Aleix Pol Gonzalez]

apol added a comment.


  This should be documented somewhere, as is it's really confusing.
  
  I'm not sure it wouldn't be better to have spectacle launched again there 
instead of going through dbus (which is a change I admittedly don't understand 
very well).

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D29406

To: meven, #frameworks, davidedmundson, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29396: Suppress find_package_handle_standard_args package name mismatch warning.

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  This will make our configure steps readable again. Thanks!

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29396

To: xuetianweng, #frameworks, #build_system, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29201: KCMUtils: Add option to append service file to list of arguments

[Aleix Pol Gonzalez]

apol added a comment.


  I have the feeling there's a missing piece here.
  
  Would it make sense to always pass it? Would it regress in any way?
  
  At the very least, on the API documentation, explain why one would want that.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D29201

To: alex, #plasma, ngraham, meven, broulik
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29361: KCrash: remove debug output which breaks unittests from using ~/.qttest/config for categorized logging

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R285 KCrash

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29361

To: dfaure, kossebau, davidedmundson, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29278: Port KWin to KWaylandServer

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:3a9d7a6e9d75: Port KWin to KWaylandServer (authored by 
apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29278?vs=81574&id=81575#toc

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29278?vs=81574&id=81575

REVISION DETAIL
  https://phabricator.kde.org/D29278

AFFECTED FILES
  CMakeLists.txt
  abstract_client.cpp
  abstract_client.h
  abstract_output.cpp
  abstract_output.h
  abstract_wayland_output.cpp
  abstract_wayland_output.h
  autotests/CMakeLists.txt
  autotests/integration/dont_crash_cursor_physical_size_empty.cpp
  autotests/integration/globalshortcuts_test.cpp
  autotests/integration/idle_inhibition_test.cpp
  autotests/integration/input_stacking_order.cpp
  autotests/integration/internal_window.cpp
  autotests/integration/lockscreen.cpp
  autotests/integration/maximize_test.cpp
  autotests/integration/plasmawindow_test.cpp
  autotests/integration/pointer_constraints_test.cpp
  autotests/integration/pointer_input.cpp
  autotests/integration/scene_opengl_shadow_test.cpp
  autotests/integration/scene_qpainter_shadow_test.cpp
  autotests/integration/scene_qpainter_test.cpp
  autotests/integration/test_helpers.cpp
  autotests/integration/transient_placement.cpp
  autotests/integration/xdgshellclient_test.cpp
  autotests/integration/xwayland_input_test.cpp
  autotests/integration/xwayland_selections_test.cpp
  autotests/mock_effectshandler.h
  autotests/test_window_paint_data.cpp
  composite.cpp
  debug_console.cpp
  decorations/decorationbridge.cpp
  effects.cpp
  effects.h
  effects/backgroundcontrast/contrast.cpp
  effects/backgroundcontrast/contrast.h
  effects/blur/blur.cpp
  effects/blur/blur.h
  effects/desktopgrid/desktopgrid.cpp
  effects/slidingpopups/slidingpopups.cpp
  events.cpp
  idle_inhibition.cpp
  idle_inhibition.h
  input.cpp
  keyboard_input.cpp
  keyboard_repeat.cpp
  libkwineffects/CMakeLists.txt
  libkwineffects/kwineffects.cpp
  libkwineffects/kwineffects.h
  linux_dmabuf.cpp
  linux_dmabuf.h
  main.cpp
  main_wayland.cpp
  platform.cpp
  platform.h
  platformsupport/scenes/opengl/CMakeLists.txt
  platformsupport/scenes/opengl/abstract_egl_backend.cpp
  platformsupport/scenes/opengl/abstract_egl_backend.h
  platformsupport/scenes/opengl/egl_dmabuf.cpp
  platformsupport/scenes/opengl/egl_dmabuf.h
  plugins/platforms/drm/drm_backend.cpp
  plugins/platforms/drm/drm_inputeventfilter.cpp
  plugins/platforms/drm/drm_output.cpp
  plugins/platforms/drm/drm_output.h
  plugins/platforms/drm/egl_stream_backend.cpp
  plugins/platforms/drm/egl_stream_backend.h
  plugins/platforms/drm/remoteaccess_manager.cpp
  plugins/platforms/drm/remoteaccess_manager.h
  plugins/platforms/fbdev/fb_backend.cpp
  plugins/platforms/hwcomposer/hwcomposer_backend.cpp
  plugins/platforms/hwcomposer/hwcomposer_backend.h
  plugins/platforms/virtual/virtual_backend.cpp
  plugins/platforms/virtual/virtual_output.cpp
  plugins/platforms/wayland/egl_wayland_backend.cpp
  plugins/platforms/wayland/wayland_backend.cpp
  plugins/platforms/wayland/wayland_output.cpp
  plugins/platforms/x11/windowed/x11windowed_backend.cpp
  plugins/platforms/x11/windowed/x11windowed_output.cpp
  plugins/scenes/opengl/scene_opengl.cpp
  plugins/scenes/opengl/scene_opengl.h
  plugins/scenes/qpainter/scene_qpainter.cpp
  plugins/scenes/qpainter/scene_qpainter.h
  pointer_input.cpp
  pointer_input.h
  scene.cpp
  scene.h
  shadow.cpp
  shadow.h
  tablet_input.cpp
  toplevel.cpp
  toplevel.h
  touch_input.cpp
  virtualdesktops.cpp
  virtualdesktops.h
  virtualkeyboard.cpp
  wayland_cursor_theme.cpp
  wayland_server.cpp
  wayland_server.h
  xdgshellclient.cpp
  xdgshellclient.h
  xkb.cpp
  xkb.h
  xwl/clipboard.cpp
  xwl/clipboard.h
  xwl/databridge.cpp
  xwl/databridge.h
  xwl/dnd.cpp
  xwl/dnd.h
  xwl/drag_wl.cpp
  xwl/drag_wl.h
  xwl/drag_x.cpp
  xwl/drag_x.h
  xwl/selection_source.cpp
  xwl/selection_source.h
  xwl/transfer.cpp
  xwl/transfer.h

To: apol, #kwin, #plasma, #frameworks, davidedmundson, zzag
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, 
romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29278: Port KWin to KWaylandServer

[Aleix Pol Gonzalez]

apol updated this revision to Diff 81574.
apol added a comment.


  Address @zzag's comments

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29278?vs=81521&id=81574

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29278

AFFECTED FILES
  CMakeLists.txt
  abstract_client.cpp
  abstract_client.h
  abstract_output.cpp
  abstract_output.h
  abstract_wayland_output.cpp
  abstract_wayland_output.h
  autotests/CMakeLists.txt
  autotests/integration/dont_crash_cursor_physical_size_empty.cpp
  autotests/integration/globalshortcuts_test.cpp
  autotests/integration/idle_inhibition_test.cpp
  autotests/integration/input_stacking_order.cpp
  autotests/integration/internal_window.cpp
  autotests/integration/lockscreen.cpp
  autotests/integration/maximize_test.cpp
  autotests/integration/plasmawindow_test.cpp
  autotests/integration/pointer_constraints_test.cpp
  autotests/integration/pointer_input.cpp
  autotests/integration/scene_opengl_shadow_test.cpp
  autotests/integration/scene_qpainter_shadow_test.cpp
  autotests/integration/scene_qpainter_test.cpp
  autotests/integration/test_helpers.cpp
  autotests/integration/transient_placement.cpp
  autotests/integration/xdgshellclient_test.cpp
  autotests/integration/xwayland_input_test.cpp
  autotests/integration/xwayland_selections_test.cpp
  autotests/mock_effectshandler.h
  autotests/test_window_paint_data.cpp
  composite.cpp
  debug_console.cpp
  decorations/decorationbridge.cpp
  effects.cpp
  effects.h
  effects/backgroundcontrast/contrast.cpp
  effects/backgroundcontrast/contrast.h
  effects/blur/blur.cpp
  effects/blur/blur.h
  effects/desktopgrid/desktopgrid.cpp
  effects/slidingpopups/slidingpopups.cpp
  events.cpp
  idle_inhibition.cpp
  idle_inhibition.h
  input.cpp
  keyboard_input.cpp
  keyboard_repeat.cpp
  libkwineffects/CMakeLists.txt
  libkwineffects/kwineffects.cpp
  libkwineffects/kwineffects.h
  linux_dmabuf.cpp
  linux_dmabuf.h
  main.cpp
  main_wayland.cpp
  platform.cpp
  platform.h
  platformsupport/scenes/opengl/CMakeLists.txt
  platformsupport/scenes/opengl/abstract_egl_backend.cpp
  platformsupport/scenes/opengl/abstract_egl_backend.h
  platformsupport/scenes/opengl/egl_dmabuf.cpp
  platformsupport/scenes/opengl/egl_dmabuf.h
  plugins/platforms/drm/drm_backend.cpp
  plugins/platforms/drm/drm_inputeventfilter.cpp
  plugins/platforms/drm/drm_output.cpp
  plugins/platforms/drm/drm_output.h
  plugins/platforms/drm/egl_stream_backend.cpp
  plugins/platforms/drm/egl_stream_backend.h
  plugins/platforms/drm/remoteaccess_manager.cpp
  plugins/platforms/drm/remoteaccess_manager.h
  plugins/platforms/fbdev/fb_backend.cpp
  plugins/platforms/hwcomposer/hwcomposer_backend.cpp
  plugins/platforms/hwcomposer/hwcomposer_backend.h
  plugins/platforms/virtual/virtual_backend.cpp
  plugins/platforms/virtual/virtual_output.cpp
  plugins/platforms/wayland/egl_wayland_backend.cpp
  plugins/platforms/wayland/wayland_backend.cpp
  plugins/platforms/wayland/wayland_output.cpp
  plugins/platforms/x11/windowed/x11windowed_backend.cpp
  plugins/platforms/x11/windowed/x11windowed_output.cpp
  plugins/scenes/opengl/scene_opengl.cpp
  plugins/scenes/opengl/scene_opengl.h
  plugins/scenes/qpainter/scene_qpainter.cpp
  plugins/scenes/qpainter/scene_qpainter.h
  pointer_input.cpp
  pointer_input.h
  scene.cpp
  scene.h
  shadow.cpp
  shadow.h
  tablet_input.cpp
  toplevel.cpp
  toplevel.h
  touch_input.cpp
  virtualdesktops.cpp
  virtualdesktops.h
  virtualkeyboard.cpp
  wayland_cursor_theme.cpp
  wayland_server.cpp
  wayland_server.h
  xdgshellclient.cpp
  xdgshellclient.h
  xkb.cpp
  xkb.h
  xwl/clipboard.cpp
  xwl/clipboard.h
  xwl/databridge.cpp
  xwl/databridge.h
  xwl/dnd.cpp
  xwl/dnd.h
  xwl/drag_wl.cpp
  xwl/drag_wl.h
  xwl/drag_x.cpp
  xwl/drag_x.h
  xwl/selection_source.cpp
  xwl/selection_source.h
  xwl/transfer.cpp
  xwl/transfer.h

To: apol, #kwin, #plasma, #frameworks, davidedmundson
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, 
romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29278: Port KWin to KWaylandServer

[Aleix Pol Gonzalez]

apol marked an inline comment as done.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29278

To: apol, #kwin, #plasma, #frameworks, davidedmundson
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, 
romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29278: Port KWin to KWaylandServer

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: KWin, Plasma, Frameworks.
Herald added a project: KWin.
Herald added a subscriber: kwin.
apol requested review of this revision.

REVISION SUMMARY
  Away from KWayland::Server and KF5WaylandServer.

TEST PLAN
  Builds, ran nested session

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29278

AFFECTED FILES
  CMakeLists.txt
  abstract_client.cpp
  abstract_client.h
  abstract_output.cpp
  abstract_output.h
  abstract_wayland_output.cpp
  abstract_wayland_output.h
  autotests/CMakeLists.txt
  autotests/integration/dont_crash_cursor_physical_size_empty.cpp
  autotests/integration/globalshortcuts_test.cpp
  autotests/integration/idle_inhibition_test.cpp
  autotests/integration/input_stacking_order.cpp
  autotests/integration/internal_window.cpp
  autotests/integration/lockscreen.cpp
  autotests/integration/maximize_test.cpp
  autotests/integration/plasmawindow_test.cpp
  autotests/integration/pointer_constraints_test.cpp
  autotests/integration/pointer_input.cpp
  autotests/integration/scene_opengl_shadow_test.cpp
  autotests/integration/scene_qpainter_shadow_test.cpp
  autotests/integration/scene_qpainter_test.cpp
  autotests/integration/test_helpers.cpp
  autotests/integration/transient_placement.cpp
  autotests/integration/xdgshellclient_test.cpp
  autotests/integration/xwayland_input_test.cpp
  autotests/integration/xwayland_selections_test.cpp
  autotests/mock_effectshandler.h
  autotests/test_window_paint_data.cpp
  composite.cpp
  debug_console.cpp
  decorations/decorationbridge.cpp
  effects.cpp
  effects.h
  effects/backgroundcontrast/contrast.cpp
  effects/backgroundcontrast/contrast.h
  effects/blur/blur.cpp
  effects/blur/blur.h
  effects/desktopgrid/desktopgrid.cpp
  effects/slidingpopups/slidingpopups.cpp
  events.cpp
  idle_inhibition.cpp
  idle_inhibition.h
  input.cpp
  keyboard_input.cpp
  keyboard_repeat.cpp
  libkwineffects/CMakeLists.txt
  libkwineffects/kwineffects.cpp
  libkwineffects/kwineffects.h
  linux_dmabuf.cpp
  linux_dmabuf.h
  main.cpp
  main_wayland.cpp
  platform.cpp
  platform.h
  platformsupport/scenes/opengl/CMakeLists.txt
  platformsupport/scenes/opengl/abstract_egl_backend.cpp
  platformsupport/scenes/opengl/abstract_egl_backend.h
  platformsupport/scenes/opengl/egl_dmabuf.cpp
  platformsupport/scenes/opengl/egl_dmabuf.h
  plugins/platforms/drm/drm_backend.cpp
  plugins/platforms/drm/drm_inputeventfilter.cpp
  plugins/platforms/drm/drm_output.cpp
  plugins/platforms/drm/drm_output.h
  plugins/platforms/drm/egl_stream_backend.cpp
  plugins/platforms/drm/egl_stream_backend.h
  plugins/platforms/drm/remoteaccess_manager.cpp
  plugins/platforms/drm/remoteaccess_manager.h
  plugins/platforms/fbdev/fb_backend.cpp
  plugins/platforms/hwcomposer/hwcomposer_backend.cpp
  plugins/platforms/hwcomposer/hwcomposer_backend.h
  plugins/platforms/virtual/virtual_backend.cpp
  plugins/platforms/virtual/virtual_output.cpp
  plugins/platforms/wayland/egl_wayland_backend.cpp
  plugins/platforms/wayland/wayland_backend.cpp
  plugins/platforms/wayland/wayland_output.cpp
  plugins/platforms/x11/windowed/x11windowed_backend.cpp
  plugins/platforms/x11/windowed/x11windowed_output.cpp
  plugins/scenes/opengl/scene_opengl.cpp
  plugins/scenes/opengl/scene_opengl.h
  plugins/scenes/qpainter/scene_qpainter.cpp
  plugins/scenes/qpainter/scene_qpainter.h
  pointer_input.cpp
  pointer_input.h
  scene.cpp
  scene.h
  shadow.cpp
  shadow.h
  tablet_input.cpp
  toplevel.cpp
  toplevel.h
  touch_input.cpp
  virtualdesktops.cpp
  virtualdesktops.h
  virtualkeyboard.cpp
  wayland_cursor_theme.cpp
  wayland_server.cpp
  wayland_server.h
  xdgshellclient.cpp
  xdgshellclient.h
  xkb.cpp
  xkb.h
  xwl/clipboard.cpp
  xwl/clipboard.h
  xwl/databridge.cpp
  xwl/databridge.h
  xwl/dnd.cpp
  xwl/dnd.h
  xwl/drag_wl.cpp
  xwl/drag_wl.h
  xwl/drag_x.cpp
  xwl/drag_x.h
  xwl/selection_source.cpp
  xwl/selection_source.h
  xwl/transfer.cpp
  xwl/transfer.h

To: apol, #kwin, #plasma, #frameworks
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, 
romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29256: [server] Introduce mapped() signal

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R127 KWayland

BRANCH
  introduce-mapped-signal

REVISION DETAIL
  https://phabricator.kde.org/D29256

To: zzag, #kwin, davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29079: android: include the architecture on the apk name

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:fca97c036c8d: android: include the architecture on the 
apk name (authored by apol).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29079?vs=80829&id=81480

REVISION DETAIL
  https://phabricator.kde.org/D29079

AFFECTED FILES
  toolchain/ECMAndroidDeployQt.cmake

To: apol, #android, #frameworks, nicolasfella
Cc: vkrause, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
bencreasy, michaelh, ngraham, bruns

D29256: [server] Introduce mapped() signal

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> zzag wrote in surface_interface.cpp:333
> We can't use != because mapped() will be emitted each time a new buffer is 
> attached to the surface.

I don't understand, ^ and != are logically equivalent, ^ is the bitwise 
counterpart.

Am I missing something?

REPOSITORY
  R127 KWayland

BRANCH
  introduce-mapped-signal

REVISION DETAIL
  https://phabricator.kde.org/D29256

To: zzag, #kwin, davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29256: [server] Introduce mapped() signal

[Aleix Pol Gonzalez]

apol added a comment.


  +1

INLINE COMMENTS

> surface_interface.cpp:333
>  const bool childrenChanged = source->childrenChanged;
> +const bool visibilityChanged = bool(source->buffer) ^ 
> bool(target->buffer);
>  bool sizeChanged = false;

Using != would probably be more readable and accurate (we're don't need it to 
be bitwise, we're assuming bool changes it to 1 or 0).

REPOSITORY
  R127 KWayland

BRANCH
  introduce-mapped-signal

REVISION DETAIL
  https://phabricator.kde.org/D29256

To: zzag, #kwin, davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> keyboard_shortcuts_inhibit_interface.cpp:144
> +QPair key(surface, seat);
> +if (m_inhibitors.contains(key)) {
> +return m_inhibitors[key];

Just `return m_inhibitors.value({ surface, seat })` to save a look-up and a few 
lines of code.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29231

To: bport, zzag, davidedmundson, apol
Cc: romangg, crossi, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol added a comment.


  > In future, it might be faster to put up just the interface xml for review 
first.
  
  @davidedmundson  @zzag I don't really see how it would have made a 
difference, you only decided to review it 7 to 10 days after I first submitted 
it. 🤷
  
  > What about using existing wl_output objects? The add_source event can be 
simplified quite a lot (even maybe dropped). For windows, we could use string 
handles.
  
  So your proposal would be to pass a random resource id or string and see what 
the compositor spits back?
  My intention was to keep the protocol auto-contained to some extent so every 
client doesn't need to track windows and screens to be able to request a stream.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich, davidedmundson, zzag
Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

[Aleix Pol Gonzalez]

apol added a comment.


  Code looks good overall, I'd say you'll get to polish the weird bits when 
developing the kwin side.
  
  In fact, this probably could be implemented within kwin considering what we 
discussed last week. We could remove the weirdness we have to keep its ABI.

INLINE COMMENTS

> keyboard_shortcuts_inhibit_interface.cpp:25
> +Private(Display *display, SurfaceInterface *surface, SeatInterface 
> *seat, KeyboardShortcutsInhibitorInterface* q)
> +: zwp_keyboard_shortcuts_inhibitor_v1(*display, s_version) // TODO 
> check we want to use display
> +, q(q)

You'll want to connect it to the respective client here, it's not a global 
anymore.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29231

To: bport, zzag, davidedmundson, apol
Cc: crossi, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 81341.
apol added a comment.


  Address review comments

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=81113&id=81341

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich, davidedmundson
Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol marked 2 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich, davidedmundson
Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D29216: Remove dead code since KF5.0: mount/umount devices in their contextmenu

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  2020_04_remove_dead_solid_code

REVISION DETAIL
  https://phabricator.kde.org/D29216

To: dfaure, apol, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29181: Use KFileMetaData for XAttr support instead of private reimplementation

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D29181

To: bruns, #baloo, ngraham, apol
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 81113.
apol added a comment.


  Refactor the protocol as suggested by David and Vlad

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80984&id=81113

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich, davidedmundson
Cc: davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> davidedmundson wrote in screencast.xml:31
> this is racey with create.

Any suggestion on how to do it better?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich, davidedmundson
Cc: davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80984.
apol added a comment.


  Also propagate the buffer size, it's important for the client to know what 
buffer size it will have.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80801&id=80984

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29102: Prefer QIcon::pixmap(QWindow*, ...) overload

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:25ce2b90dab1: Prefer QIcon::pixmap(QWindow*, ...) 
overload (authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29102?vs=80908&id=80945

REVISION DETAIL
  https://phabricator.kde.org/D29102

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/windowthumbnail.cpp

To: apol, #plasma, #frameworks, davidedmundson
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D29102: Prefer QIcon::pixmap(QWindow*, ...) overload

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  It takes into account the dpi of the screen we're rendering to.
  Other overloads assume the window is nullptr and will use the primary 
screen's dpi which can change almost randomly.

TEST PLAN
  Icons still look fine even if I drag windows from a screen to another.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29102

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/windowthumbnail.cpp

To: apol, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args

[Aleix Pol Gonzalez]

apol added a comment.


  +1 makes sense

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  avoidnewwarningsinfindkf5

REVISION DETAIL
  https://phabricator.kde.org/D29097

To: kossebau, #frameworks, #build_system, cgiboudeaux
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks like an improvement

REPOSITORY
  R290 KPackage

BRANCH
  fixXDG_DATA_DIRSextending

REVISION DETAIL
  https://phabricator.kde.org/D29063

To: kossebau, #frameworks, mart, apol, sitter, bcooksley
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29079: android: include the architecture on the apk name

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Android, Frameworks.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Makes them easier to use afterwards.

TEST PLAN
  Tested locally

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29079

AFFECTED FILES
  toolchain/ECMAndroidDeployQt.cmake

To: apol, #android, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29062: Port KToolInvocation::kdeinitExecWait to QProcess

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kded.cpp:67
>  
>  static void runKonfUpdate()
>  {

The function has a typo, should be `runKConfUpdate`, no?

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29062

To: broulik, davidedmundson, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80801.
apol added a comment.


  Hopefully fix the build for Jan

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80798&id=80801

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80798.
apol added a comment.


  - Test Cleanup
  - When a resource is destroyed, emit to close all its streams

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80677&id=80798

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29033: Remove duplicated code

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  My bad, thanks!

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29033

To: apol, #frameworks, zzag
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29033: Remove duplicated code

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Went through it while reviewing some code.

TEST PLAN
  Been running it for a while, including direct testing of the code while 
investigating something else

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29033

AFFECTED FILES
  src/windowsystem/waylandintegration.cpp

To: apol, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29018: Align description in metainfo.yaml with the one of README.md

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R174 KContacts

BRANCH
  fixmetainfodescription

REVISION DETAIL
  https://phabricator.kde.org/D29018

To: kossebau, mlaurent, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80677.
apol added a comment.


  Improve how we initialise the sourceId

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80662&id=80677

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28780: [FstabWatcher] Fix loosing of fstab watcher

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28780

To: bruns, #frameworks, ngraham, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80662.
apol added a comment.


  Iterate tests (which work now) and uses

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80658&id=80662

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80658.
apol added a comment.


  Fix test

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80637&id=80658

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80637.
apol added a comment.


  iterate test

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80605&id=80637

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D29003

To: junghans, kossebau, dfaure, apol
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80605.
apol added a comment.


  oops

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80604&id=80605

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80604.
apol added a comment.


  Include server side, a test (that doesn't pass) and some renaming

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80411&id=80604

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

[Aleix Pol Gonzalez]

apol added a comment.


  I wonder, while this will work with all our uses of DropUrlPatterns, this 
would have been able to work with something like `scheme:/*potato*` which after 
this patch won't work.
  
  In fact, it's called Patterns, not DropUrlWhenStartsWith. I'd appreciate 
feedback from someone else. Code-wise, looks better for sure.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28978

To: ahmadsamir, #plasma, apol
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28956: [QML Monitor] Show remaining time as soon as possible

[Aleix Pol Gonzalez]

apol added a comment.


  You're using QDeadlineTimer weird. Why don't you use 
QDeadlineTimer::remainingTime() and ::setDeadline?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28956

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28955: [FileContentIndexer] Fix state update and signal order

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28955

To: bruns, #baloo, ngraham, apol
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28953: [Extractor] Fix progress reporting

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28953

To: bruns, #baloo, ngraham, mlaurent, apol
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28954: [Monitor] Fix monitor state and signal ordering

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28954

To: bruns, #baloo, ngraham, apol
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28940: [baloo_file] Remove KAboutData from baloo_file

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28940

To: bruns, #baloo, ngraham, leszeklesner, apol
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28900: Fix wayland scanner warnings

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:3734a5368e44: Fix wayland scanner warnings (authored by 
apol).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28900?vs=80334&id=80436

REVISION DETAIL
  https://phabricator.kde.org/D28900

AFFECTED FILES
  find-modules/FindQtWaylandScanner.cmake
  find-modules/FindWaylandScanner.cmake

To: apol, #build_system, #kwin, #frameworks, davidedmundson
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80411.
apol added a comment.


  Include the server side and some renames

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80284&id=80411

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol marked 2 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28919: Drop delayed second phase

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Makes sense, sounds like the second phase is quite arbitrary there.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D28919

To: broulik, #plasma, dfaure, davidedmundson, apol
Cc: apol, kde-frameworks-devel, davidedmundson, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28355: Introduce function ecm_install_configured_file

[Aleix Pol Gonzalez]

apol added a comment.


  Are we stuck somewhere? The patch looks good to me.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28355

To: davidedmundson
Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
cblack, bencreasy, michaelh, ngraham, bruns

D19913: [plasma-framework] make it compiles without foreach

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.

INLINE COMMENTS

> dropmenu.cpp:80
>  } else if (m_menu) {
> -foreach (QAction *action, m_dropActions) {
> +for (QAction *action : qAsConst(m_dropActions)) {
>  m_menu->addAction(action);

`m_menu->addActions(m_dropActions);`

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

To: mlaurent, dfaure, apol
Cc: ahmadsamir, nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D28900: Fix wayland scanner warnings

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Build System, KWin, Frameworks.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Tells cmake not to automoc certain files that don't need it, which would 
become a big fuss on the cmake output.

TEST PLAN
  No warnings

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28900

AFFECTED FILES
  find-modules/FindQtWaylandScanner.cmake
  find-modules/FindWaylandScanner.cmake

To: apol, #build_system, #kwin, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D28883: Add wrapper for wl_global_remove

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28883

To: davidedmundson, #plasma, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80284.
apol added a subscriber: zzag.
apol added a comment.


  renamed protocol as per @zzag's suggestion

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80278&id=80284

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/videostreaming.cpp
  src/client/videostreaming.h

To: apol, #kwin, jgrulich
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol added a dependent revision: D28884: screencasting: Adoption of the 
org_kde_plasma_video_streaming protocol.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: KWin, jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Creates a protocol based on Pipewire that allows us to request feeds to
  be set up by KWin rather than having to do it from a separate process.
  
  This will offer tighter control to KWin to do serve not only outputs but
  also windows as well.

TEST PLAN
  Treat this as a proof of concept to discuss if it's the protocol
  we need right now.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  src/client/CMakeLists.txt
  src/client/protocols/video-streaming.xml
  src/client/videostreaming.cpp
  src/client/videostreaming.h

To: apol, #kwin, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28850: Updated Romanian holidays

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R175:28ad589a1fbe: Updated Romanian holidays (authored by 
sionescu, committed by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28850?vs=80179&id=80220#toc

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28850?vs=80179&id=80220

REVISION DETAIL
  https://phabricator.kde.org/D28850

AFFECTED FILES
  holidays/plan2/holiday_ro_ro

To: sionescu, winterz
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D24956: Consider desktop files with NoDisplay attribute

[Aleix Pol Gonzalez]

apol added a comment.


  +1 This makes sense to me

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D24956

To: meven, mart, #plasma, fvogt, apol
Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28088: Fix warnings

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:298ce0ed7ff4: Fix warnings (authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28088?vs=78630&id=80058

REVISION DETAIL
  https://phabricator.kde.org/D28088

AFFECTED FILES
  src/plasma/containmentactions.cpp
  src/plasma/private/storagethread.cpp
  src/scriptengines/qml/plasmoid/dropmenu.h

To: apol, #frameworks
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  Address the scope of the statics as kai mentioned in D28778 
.
  Or use Q_GLOBAL_STATIC.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28776

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

[Aleix Pol Gonzalez]

apol added a comment.


  In D28778#646791 , @broulik wrote:
  
  > Don't use global statics in library code
  
  
  in case it gets statically compiled?

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28778

To: bruns, #frameworks, apol
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28776

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28780: [FstabWatcher] Fix loosing of fstab watcher

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> fstabwatcher.cpp:110
>  emit fstabChanged();
>  if (!m_fileSystemWatcher->files().contains(s_fstabFile)) {
> +m_isFstabWatched = m_fileSystemWatcher->addPath(s_fstabFile);

Use m_isFstabWatched? Or maybe m_isFstabWatched isn't necessary altogether and 
we can check in other places too.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28780

To: bruns, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28778

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28782: [Fstab] Do not emit deviceAdded twice on fstab/mtab changes

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> fstabmanager.cpp:122
> +
> +qCDebug(FSTAB) << oldlist << "->" << newlist;
> +

The debug seems wrong and probably unnecessary. I'd remove it.

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28782

To: bruns, #frameworks, afiestas, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28779: [Fstab] Use new style connect API

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28779

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28726: [KJS] Port QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R314 KJs

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28726

To: ahmadsamir, #frameworks, porten, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28699: Add startCapture method

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  startCpature (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28699

To: davidre, #frameworks, davidedmundson, broulik, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28637: Use ecm_setup_qtplugin_macro_names

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R295 KCMUtils

BRANCH
  useECMSetupQtPluginMacroNames

REVISION DETAIL
  https://phabricator.kde.org/D28637

To: kossebau, #frameworks, mart, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28620: Add readmes clarifying state of plasma component versions

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28620

To: davidedmundson, #plasma, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28599: [configview] Simplify code / workaround Qt5.15 crash

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

INLINE COMMENTS

> configview.cpp:137
>  
> +
> q->engine()->rootContext()->setContextProperty(QStringLiteral("plasmoid"), 
> applet.data()->property("_plasma_graphicObject").value());
> +
> q->engine()->rootContext()->setContextProperty(QStringLiteral("configDialog"),
>  q);

It could make sense to use the opportunity to change to 
QQmlContext::setContextProperties.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28599

To: davidedmundson, #plasma, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28409: ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28409

To: dfaure, kossebau, apol, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, 
michaelh, ngraham, bruns

D28409: ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows

[Aleix Pol Gonzalez]

apol added a comment.


  Will /tmp then still work on Windows?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28409

To: dfaure, kossebau, apol, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, 
michaelh, ngraham, bruns

D28579: Improve the look of kcachegrind

[Aleix Pol Gonzalez]

apol added a comment.


  +1 much better!

REPOSITORY
  R266 Breeze Icons

BRANCH
  kcachegrind (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28579

To: ndavis, #vdg, cblack, ngraham
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28565: [QueryParser] Replace single-use helper with std::none_of

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28565

To: bruns, #baloo, ngraham, apol
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams