D7563: Add privilegeExecution field to file protocol description

chinmoyr requested changes to this revision. chinmoyr added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > file_unix.cpp:1331 > +KAuth::Action::DetailsMap details; > +details.insert(KAuth::Action::AuthDetail::DetailMessage, >

D7563: Add privilegeExecution field to file protocol description

chinmoyr updated this revision to Diff 80341. chinmoyr marked an inline comment as done. chinmoyr added a comment. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Rebased on master. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D21783: Show more details in warning dialog shown before starting a privileged operation

chinmoyr added a comment. In D21783#581781 , @dfaure wrote: > @chinmoyr This change also breaks the corresponding unittest in CI, please take a look. >

D21783: Show more details in warning dialog shown before starting a privileged operation

This revision was automatically updated to reflect the committed changes. Closed by commit R241:82aae02e2114: Show more details in warning dialog shown before starting a privileged operation (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in slavebase.h:262 > Does this break API docs generation? Suddenly the /** ... */ comment is > separated from the enum. The comment didn't affect the doc generation. But the placement was awkward so I changed it. REPOSITORY

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr updated this revision to Diff 71754. chinmoyr added a comment. updated kf5 version. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21783?vs=71041=71754 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21783 AFFECTED FILES

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr updated this revision to Diff 71041. chinmoyr added a comment. Rebased, compiled and tested. Changes work as expected. Double checked file_unix.cpp. Would be a shame if it happens yet again. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in slaveinterface_p.h:56 > Please explain how, for when the time comes (in case you're not around to do > it). Removing each of its occurence (of which there are 3) and the surrounding `if`. I will add comments where its needed

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr updated this revision to Diff 71025. chinmoyr marked 10 inline comments as done. chinmoyr added a comment. Addressed the issues. Annotated code to be removed in KF6. My build env is outdated so I couldn't compile the new depracation macro. Copied as it is. REPOSITORY R241 KIO

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in jobuidelegateextension.h:279 > Sorry, you can't add a new virtual method to an exported+installed class. > > BIC rules (where "rules" is a noun, not a verb...) ;-) > > Possible solutions: > > - creating a new, separate, type of

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr updated this revision to Diff 70914. chinmoyr marked 4 inline comments as done. chinmoyr added a comment. Addressed the issues. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21783?vs=67955=70914 BRANCH arcpatch-D21783 REVISION DETAIL

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in slavebase.h:964 > Missing "m" prefix like the other members, but wait isn't this BIC? > Adding a new member to an exported class certainly is. This needs to go into > the SlaveBasePrivate class instead. Since we need

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr updated this revision to Diff 67955. chinmoyr marked 3 inline comments as done. chinmoyr added a comment. Addressed the comments. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21783?vs=59738=67955 BRANCH arcpatch-D21783 REVISION DETAIL

D23194: Making FileJob behave consistently.

chinmoyr accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH ConsistentRead (branched from master) REVISION DETAIL https://phabricator.kde.org/D23194 To: feverfew, dfaure, fvogt, chinmoyr, apol Cc: kde-frameworks-devel, LeGast00n, GB_2,

D21795: [KAuth] Add support for action details in Polkit1 backend.

chinmoyr added inline comments. INLINE COMMENTS > sitter wrote in Polkit1Backend.cpp:193 > looks to me this was only added 4 months ago. so this would probably require > a version bump. seeing as we are fairly conservative with frameworks' > requirements it may be better to `if

D17737: [CopyJob] Create clones in btrf/xfs mount

chinmoyr edited reviewers, added: thiago, ossi; removed: davidedmundson. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17737 To: chinmoyr, dfaure, #frameworks, thiago, ossi, davidedmundson Cc: ngraham, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D21795: [KAuth] Add support for action details in Polkit1 backend.

chinmoyr added inline comments. INLINE COMMENTS > sitter wrote in AuthBackend.h:61 > I didn't check super carefully but at a glance the backend api is not public > API so we could probably refactor this right now already. > > Also, shouldn't the callerID be a const ref? the mac backend

D21795: [KAuth] Add support for action details in Polkit1 backend.

chinmoyr updated this revision to Diff 63880. chinmoyr marked 6 inline comments as done. chinmoyr added a comment. Addressed comments. REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21795?vs=59775=63880 BRANCH master REVISION DETAIL

D23194: Making FileJob behave consistently.

chinmoyr requested changes to this revision. chinmoyr added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > filejob.cpp:181 > +slaveDone(); > +// Scheduler::doJob(this); > +q->emitResult(); Nitpick; spacing gotcha > filejob.h:48 > /** > -

D23159: Prevent error() being emitted when purposefully reading 0 bytes

chinmoyr added inline comments. INLINE COMMENTS > file.cpp:524 > while (true) { > QByteArray res = mFile->read(bytes); > This doesn't support error reporting. Why not refactor this loop using read(char *, qint64)? I believe you can accommodate your changes inside the loop

D22708: [WIP] Add a kded module infra for fuse mount services

chinmoyr abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22708 To: chinmoyr Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22708: [WIP] Add a kded module infra for fuse mount services

chinmoyr updated this revision to Diff 62469. chinmoyr added a comment. Added KRun changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22708?vs=62453=62469 BRANCH monitorprotocol REVISION DETAIL https://phabricator.kde.org/D22708 AFFECTED FILES

D22708: [WIP] Add a kded module infra for fuse mount services

chinmoyr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY This module watches the install directories of kded modules and curates a list of modules having plugin

D22555: [RFC] Add a kded module to manage various available fuse mount services

chinmoyr created this revision. chinmoyr added a reviewer: fvogt. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY This module watches the install directories of kded modules and curates a list of

D21782: Add a warning dialog with details, continue, and cancel button

This revision was automatically updated to reflect the committed changes. Closed by commit R236:653192440bf8: Add a warning dialog with a collapsible details section. (authored by chinmoyr). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21782?vs=60264=62033#toc REPOSITORY R236

D21782: Add a warning dialog with details, continue, and cancel button

chinmoyr edited the summary of this revision. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21782 To: chinmoyr, #vdg, #frameworks, dfaure, ngraham, apol Cc: elvisangelaccio, mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, sbergeron,

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr added a comment. In D14467#483848 , @bcooksley wrote: > It would appear that the commit of this change disturbed somethng with FreeBSD builds - see

D21782: Add a warning dialog with details, continue, and cancel button

chinmoyr updated this revision to Diff 60264. chinmoyr added a comment. Updated the implementation. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21782?vs=59735=60264 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21782 AFFECTED

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14467 To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek Cc: maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham,

D14467: Auth Support: Drop privileges if target is not owned by root

This revision was automatically updated to reflect the committed changes. Closed by commit R241:efeede07c8eb: Auth Support: Drop privileges if target is not owned by root (authored by chinmoyr). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14467?vs=60249=60255#toc REPOSITORY R241

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr added a comment. Thanks for your help! REPOSITORY R241 KIO BRANCH arcpatch-D14467 REVISION DETAIL https://phabricator.kde.org/D14467 To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek Cc: maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel,

D21953: Replace "Details" button with KCollapsibleGroupBox

chinmoyr closed this revision. chinmoyr added a comment. https://commits.kde.org/kwidgetsaddons/89606c1ecb571e3ae9137cab18ceadeff57666e3 REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D21953 To: chinmoyr, #vdg, ngraham, GB_2 Cc: kde-frameworks-devel,

D21953: Replace "Details" button with KCollapsibleGroupBox

chinmoyr updated this revision to Diff 60250. chinmoyr added a comment. "More Details" -> "Details" REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21953?vs=60198=60250 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21953 AFFECTED

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr updated this revision to Diff 60249. chinmoyr added a comment. Separated (l)chown since it's to be done with elavated privileges. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14467?vs=60215=60249 BRANCH arcpatch-D14467 REVISION DETAIL

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr added inline comments. INLINE COMMENTS > maltek wrote in filehelper.cpp:133 > For `chown`, dropping privileges here means that the `chown` later can't > succeed - it's not possible to 'gift' a file to another user. I think it > should be handled more like `DEL/RMDIR/MKDIR` etc. Ah!

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr updated this revision to Diff 60215. chinmoyr marked 6 inline comments as done. chinmoyr added a comment. Addresed the issues. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14467?vs=60167=60215 BRANCH arcpatch-D14467 REVISION DETAIL

D21953: Replace "Details" button with KCollapsibleGroupBox

chinmoyr created this revision. chinmoyr added reviewers: VDG, ngraham, GB_2. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY Remove "Details" button and use KCollapsibleGroupBox to display more

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr updated this revision to Diff 60167. chinmoyr marked 5 inline comments as done. chinmoyr added a comment. Thanks @maltek. I've fixed all the issues. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14467?vs=59319=60167 BRANCH arcpatch-D14467

D21882: RFC: [CopyJob] Batch reporting processed amount

chinmoyr accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21882 To: broulik, #frameworks, dfaure, chinmoyr, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr planned changes to this revision. chinmoyr added a comment. TODO - Change the UI of the warning dialog - We still need more details REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: ngraham,

D21795: [KAuth] Add support for action details in Polkit1 backend.

chinmoyr created this revision. chinmoyr added reviewers: apol, bruns, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY KAuth action has a setDetail method. This can be used to

D14464: Cancel privilege operation for read-only target with the current user as owner

chinmoyr closed this revision. chinmoyr added a comment. https://commits.kde.org/kio/14b29cf64611f91f0bc1f5828e4c86392510f0e6 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14464 To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin Cc:

D14464: Cancel privilege operation for read-only target with the current user as owner

chinmoyr updated this revision to Diff 59748. chinmoyr added a comment. Updated frameworks version. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14464?vs=38714=59748 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14464 AFFECTED FILES

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr added a comment. In D14467#479223 , @ngraham wrote: > @mgerstner How is this looking now? Yea/nay? He is not available for the next couple of weeks. However he did ask one of his colleagues to have a look at it. REPOSITORY

D21782: Add a warning dialog with details, continue, and cancel button

chinmoyr added a comment. In D21782#479190 , @GB_2 wrote: > I think a KCollapsibleGroupBox would fit here: http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/ Thanks! I'll give it a shot. REPOSITORY R236 KWidgetsAddons

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr added a comment. In D21783#479187 , @ngraham wrote: > Thanks! Is this for T8075 ? Yes it is. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg,

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr updated this revision to Diff 59738. chinmoyr added a comment. Fix typo REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21783?vs=59737=59738 BRANCH warn REVISION DETAIL https://phabricator.kde.org/D21783 AFFECTED FILES

D21782: Add a warning dialog with details, continue, and cancel button

chinmoyr edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D21782 To: chinmoyr, #vdg, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr created this revision. chinmoyr added reviewers: VDG, Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY Currently it uses the dialog from D21782

D21782: Add a warning dialog with details, continue, and cancel button

chinmoyr created this revision. chinmoyr added reviewers: VDG, Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY F6887442: warningdialog.png

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr updated this revision to Diff 59319. chinmoyr added a comment. use seteuid to make the logic for rename work REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14467?vs=59290=59319 BRANCH arcpatch-D14467 REVISION DETAIL

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr updated this revision to Diff 59290. chinmoyr added a comment. - int -> ActionType - separated the logic in dropPrivileges() to two parts - accepting mode argument in mkdir - used *at() functions - minor cosmetic changes @mgerstner In case of rename, when owners are

D21317: Manipulate bytes instead of characters

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:8e00726eda1f: Manipulate bytes instead of characters (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE

D21317: Manipulate bytes instead of characters

chinmoyr created this revision. chinmoyr added reviewers: bruns, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY D21155 trucates a QString. Since most

D21155: Truncate long filname before creating a link

This revision was automatically updated to reflect the committed changes. Closed by commit R241:092beaf6fbab: Truncate long filname before creating a link (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21155?vs=57929=58069 REVISION DETAIL

D21197: [KCoreDirLister] Remove assert in reinsert method

chinmoyr created this revision. chinmoyr added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY Here I am trying to fix #405461. We reach this assertion in reinsert() after we

D21155: Truncate long filname before creating a link

chinmoyr created this revision. chinmoyr added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY URL of a website can exceed 255 characters. Consequently we cannot create a link

D20062: [RFC] Add support for changing volume label.

chinmoyr added a comment. The issue here is the placement of code. There are no API for changing any volume attributes so adding the changeLabel() method here feels awkward. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20062 To: chinmoyr, #frameworks, bruns,

D20062: [RFC] Add support for changing volume label.

chinmoyr created this revision. chinmoyr added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY Is this the right approach to take? REPOSITORY R245 Solid BRANCH master

D18845: authority: add support for passing details to polkit

chinmoyr added a comment. I would like this patch to land so +1 from me. But I am not familiar with this code so I can't give any meaningful feedback. Sorry. INLINE COMMENTS > polkitqt1-authority.cpp:336 > + > +polkit_details_insert(ret, key.toUtf8().data(), >

D19696: Add blender thumbnailer

This revision was automatically updated to reflect the committed changes. Closed by commit R373:2da545defff9: Add blender thumbnailer (authored by chinmoyr). REPOSITORY R373 Image Thumbnailers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19696?vs=53971=54065 REVISION DETAIL

D19696: Add blender thumbnailer

chinmoyr updated this revision to Diff 53971. chinmoyr added a comment. Removed unused headers. REPOSITORY R373 Image Thumbnailers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19696?vs=53848=53971 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19696 AFFECTED

D19696: Add blender thumbnailer

chinmoyr updated this revision to Diff 53848. chinmoyr marked 3 inline comments as done. chinmoyr added a comment. Issues fixed. REPOSITORY R373 Image Thumbnailers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19696?vs=53820=53848 BRANCH master REVISION DETAIL

D19696: Add blender thumbnailer

chinmoyr added inline comments. INLINE COMMENTS > bruns wrote in blendercreator.cpp:134 > So does the code I linked to. No need to cook your own. Ah, sorry. I misunderstood what was written in doc. It really does swap them. REPOSITORY R373 Image Thumbnailers REVISION DETAIL

D19696: Add blender thumbnailer

chinmoyr updated this revision to Diff 53820. chinmoyr marked 4 inline comments as done. chinmoyr added a comment. Moved to kdegraphics-thumbnailer Got rid of operator>>() and fixed other issues. REPOSITORY R373 Image Thumbnailers CHANGES SINCE LAST UPDATE

D19696: Add blender thumbnailer

chinmoyr added inline comments. INLINE COMMENTS > bruns wrote in blendercreator.cpp:57 > I think this is already done by the calling code - the thumbnailer gets only > called when the mimetype matches. This part is required because blender can save files with gzip compression. Examples here :

D19696: Add blender thumbnailer

chinmoyr edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19696 To: chinmoyr, #frameworks Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp,

D19696: Add blender thumbnailer

chinmoyr created this revision. chinmoyr added a reviewer: Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY This extracts thumbnail from .blend files. Before:

D18904: [FileCopyJob] Clean up after cancelation of file copy operation

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7a79f1531480: [FileCopyJob] Clean up after cancelation of file copy operation (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D18904: [FileCopyJob] Clean up after cancelation of file copy operation

chinmoyr updated this revision to Diff 53605. chinmoyr retitled this revision from "[FileCopyJob] Clean up after file copy operation is cancelled" to "[FileCopyJob] Clean up after cancelation of file copy operation". chinmoyr edited the summary of this revision. chinmoyr added a comment.

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

chinmoyr updated this revision to Diff 53604. chinmoyr marked an inline comment as done. chinmoyr added a comment. Changed m_bFileWriteInProgress -> m_bFileCopyInProgress REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18904?vs=53297=53604 BRANCH

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

chinmoyr added a comment. There's free space check in CopyJob. And Dolphin still gives an error in the said situation. But if some application decides to directly use FileCopyJob then IMO the free space check should be at application's side. Anyway, I tried adding it here and it felt

D19585: [CopyJob] Report results after finishing copy

chinmoyr added a comment. > Opened Dolphin, Ctrl+C on a file, Ctrl+V it into the same folder, let it sit at the "Override?" prompt until the job view in Plasma showed up. >Chose a different filename and continued. > [...] > The URL isn't updated in case of a rename but I bet it just

D19422: Fix upper/lower case rename on case insensitive fs

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ef5b9c6991aa: Fix upper/lower case rename on case insensitive fs (authored by hoffmannrobert, committed by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

chinmoyr updated this revision to Diff 53297. chinmoyr added a comment. Remove unrelated changes commited by mistake. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18904?vs=53291=53297 BRANCH arcpatch-D18904 (branched from master) REVISION DETAIL

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

chinmoyr updated this revision to Diff 53291. chinmoyr added a comment. Delete .part file when Overwrite flag is set. @dfaure please have a look at it again. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18904?vs=51383=53291 BRANCH arcpatch-D18904_1

D19422: Fix upper/lower case rename on case insensitive fs

chinmoyr accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH fix_case_rename REVISION DETAIL https://phabricator.kde.org/D19422 To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19080: Make file overwrite a bit safer

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f34c2cf0abf1: Make file overwrite a bit safer (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19080?vs=53044=53045 REVISION DETAIL

D19080: Make file overwrite a bit safer

chinmoyr updated this revision to Diff 53044. chinmoyr retitled this revision from "[WIP] Make file overwrite a bit safer" to "Make file overwrite a bit safer". chinmoyr edited the summary of this revision. chinmoyr added a comment. Print strerror. REPOSITORY R241 KIO CHANGES SINCE LAST

D18455: Port to new connect syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R241:53bba36a78c4: Port to new connect syntax (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18455?vs=53013=53014 REVISION DETAIL

D18455: Port to new connect syntax

chinmoyr updated this revision to Diff 53013. chinmoyr added a comment. Restore sourceStated in CopyJob. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18455?vs=50058=53013 BRANCH arcpatch-D18455 REVISION DETAIL https://phabricator.kde.org/D18455

D19422: Fix upper/lower case rename on case insensitive fs

chinmoyr requested changes to this revision. chinmoyr added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > copyjob.cpp:1909 > const QString srcDir = QFileInfo(_src).absolutePath(); > -QTemporaryFile tmpFile(srcDir +

D19339: Add option to change drive label to places panel context menu

chinmoyr planned changes to this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D19339 To: chinmoyr, #dolphin, #frameworks Cc: broulik, ngraham, bruns, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

D19339: Add option to change drive label to places panel context menu

chinmoyr created this revision. chinmoyr added reviewers: Dolphin, Frameworks. Herald added a project: Dolphin. Herald added a subscriber: kfm-devel. chinmoyr requested review of this revision. REVISION SUMMARY Uses org.freedesktop.UDisks2 dbus service for changing drive label. REPOSITORY

D19080: [WIP] Make file overwrite a bit safer

chinmoyr added a comment. @dfaure ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19080 To: chinmoyr, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19080: [WIP] Make file overwrite a bit safer

chinmoyr updated this revision to Diff 51939. chinmoyr marked 2 inline comments as done. chinmoyr added a comment. Update. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19080?vs=51876=51939 BRANCH safe-overwrite REVISION DETAIL

D19080: [WIP] Make file overwrite a bit safer

chinmoyr updated this revision to Diff 51876. chinmoyr added a comment. Skip unit test on windows. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19080?vs=51875=51876 BRANCH safe-overwrite REVISION DETAIL https://phabricator.kde.org/D19080 AFFECTED

D19080: [WIP] Make file overwrite a bit safer

chinmoyr updated this revision to Diff 51875. chinmoyr marked 4 inline comments as done. chinmoyr added a comment. Removed warning message. Removed arg(). Added test cases. Used QFile::resize(). Replying to a comment: > This test is called Overwrite, and passes the Overwrite

D19080: [WIP] Make file overwrite a bit safer

chinmoyr added a dependent revision: D18904: [FileCopyJob] Clean up after file copy operation is cancelled. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19080 To: chinmoyr, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

chinmoyr added a dependency: D19080: [WIP] Make file overwrite a bit safer. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18904 To: chinmoyr, dfaure, dmitrio Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D19080: [WIP] Make file overwrite a bit safer

chinmoyr created this revision. chinmoyr added reviewers: dfaure, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY The source is copied to a separate ".part" file, then the original

D18915: Fix batchrename changing extension to lower case

chinmoyr added inline comments. INLINE COMMENTS > abalaji wrote in batchrenamejob.cpp:64 > I wonder if just getting rid of `.toLower()` fixes this bug I agree with @abalaji here. Modifying the code around this line should fix the bug and also address my previous comment. REPOSITORY R241 KIO

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

chinmoyr updated this revision to Diff 51383. chinmoyr marked 4 inline comments as done. chinmoyr added a comment. Fixed all issues. Added test case for suspend. > so the user knows that there data is gone *their REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D18915: Fix batchrename changing extension to lower case

chinmoyr added a comment. @cfoster Thanks for the patch :) There's one more mass-rename related bug here: 1. Create two files; one with a known extension (.cpp) and the other with a random extension (.xyz, anything not in mime db) 2. Rename both. 3. The extension (.xyz) is

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

chinmoyr added a comment. @ngraham The destination file is corrupted as soon as the user clicks overwrite. This patch deletes that file. Is that file supposed to be preserved (to prevent user panic)? My suggestion is to append ".part" or some similar extension when an overwrite starts, so

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

chinmoyr created this revision. chinmoyr added reviewers: dfaure, dmitrio. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY This patch borrows code from D10663 .

D18699: [KIO/RenameDialog] Add new apply behaviour

chinmoyr added a reviewer: VDG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18699 To: chinmoyr, dfaure, ngraham, #vdg Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D18699: [KIO/RenameDialog] Add new apply behaviour

chinmoyr updated this revision to Diff 50778. chinmoyr edited the summary of this revision. chinmoyr added a comment. Add bug id. Remove old code. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18699?vs=50777=50778 BRANCH master REVISION DETAIL

D18699: [KIO/RenameDialog] Add new apply behaviour

chinmoyr created this revision. chinmoyr added reviewers: dfaure, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY This patch removes "Apply to All" checkbox and adds a combobox with

D17737: [CopyJob] Create clones in btrf/xfs mount

chinmoyr added a comment. @bruns ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17737 To: chinmoyr, dfaure, davidedmundson Cc: bruns, kde-frameworks-devel, michaelh, ngraham

  1   2   3   4   5   6   >