D13425: File indexer closing improvements.

2019-06-16 Thread James Smith
smithjd abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien, #baloo, poboiko Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun,

D16579: Remove support for non-standard APE tag field names from the test files

2019-03-11 Thread James Smith
smithjd added a comment. In D16579#428993 , @bruns wrote: > The change, as you pushed it, was never open for review, so there was not even the chance to review. Diff 44708 included these changes for review. No one requested changes then,

D16579: Remove support for non-standard APE tag field names from the test files

2019-03-11 Thread James Smith
smithjd added a comment. The change was ack'ed in this review, and this review closed by the commit. There was no code that required further review, only binary changes. The posted concerns were addressed by D18826 . If you really are that

D16579: Remove support for non-standard APE tag field names from the test files

2019-03-10 Thread James Smith
smithjd added a comment. In D16579#428790 , @ngraham wrote: > Two reviewers had open "Changes Requested" statuses on this patch when you committed it, and from the latest comments, it's not clear that their concerns were addressed first. Can

D16579: Remove support for non-standard APE tag field names from the test files

2019-03-10 Thread James Smith
smithjd retitled this revision from "Remove support for non-standard APE tag field names" to "Remove support for non-standard APE tag field names from the test files". smithjd edited the summary of this revision. smithjd edited the test plan for this revision. REPOSITORY R286 KFileMetaData

D16579: Remove support for non-standard APE tag field names

2019-03-10 Thread James Smith
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R286:4c5c4f5b91ab: Use ALBUM ARTIST field name for APEv2 test files. (authored by smithjd). CHANGED PRIOR TO COMMIT

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

2019-03-10 Thread James Smith
smithjd added a comment. This test fails: FAIL! : TagLibExtractorTest::testMp4(mp4) Compared values are not the same Actual (resultMp4.properties().value(Property::Rating).toInt()): 0 Expected (8) : 8 Loc:

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

2019-02-26 Thread James Smith
smithjd added inline comments. INLINE COMMENTS > astippich wrote in taglibextractor.cpp:195 > I wanted to do so first, but that will require to also put the PropertyMap > into the extractAsfTags method, which I think is not worth it. lstASF = asfTags->attribute("WM/Writer"); ... The existing

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

2019-02-24 Thread James Smith
smithjd added inline comments. INLINE COMMENTS > taglibextractor.cpp:109 > +{ > +if (savedProperties.contains("TITLE")) { > +result->add(Property::Title, > TStringToQString(savedProperties["TITLE"].toString()).trimmed()); This could return early if the property map is empty. >

D16579: Remove support for non-standard APE tag field names

2019-02-23 Thread James Smith
smithjd added a comment. > Anyway, most of this special handling of mimetypes goes away with D18826 , where TagLib will do the conversion automatically. The test files should reflect the most common tag fieldnames; 'albumartist' is used in the APEv2

D16579: Remove support for non-standard APE tag field names

2019-02-20 Thread James Smith
smithjd retitled this revision from "Fix APE tag extraction" to "Remove support for non-standard APE tag field names". smithjd edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16579 To: smithjd, astippich, bruns, mgallien Cc:

D16579: Fix APE tag extraction

2019-02-20 Thread James Smith
smithjd added a comment. I realise that with all the fields referenced here having at least one standard fieldname parsed now that complaining may seem to be flogging a dead horse, but I'd like to re-iterate that identically-purposed fields should not be encouraged. This is at best a

D16579: Fix APE tag extraction

2019-02-20 Thread James Smith
smithjd updated this revision to Diff 52185. smithjd added a comment. - Use the de-facto Album Artist field name for APE tags. Re-base. REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16579?vs=44708=52185 BRANCH master-musepackFixes (branched

D13216: Overhaul the file index scheduler.

2019-01-20 Thread James Smith
smithjd added a comment. "Locking" the scheduler is simpler here than identifying that it "has gone idle". "Locking" only happens here for a small number of runnables (two) that can't run concurrently. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To:

D13216: Overhaul the file index scheduler.

2019-01-20 Thread James Smith
smithjd updated this revision to Diff 49977. smithjd added a comment. - Re-write the file index scheduler. Combine content indexer suspend logic. - Update the balooctl tool with the changed suspend/resume behaviour. - Re-order and use IndexerState to prioritize the indexer thread pool. -

D16579: Fix APE tag extraction

2018-11-03 Thread James Smith
smithjd added a comment. In D16579#352887 , @astippich wrote: > You're doing the exact opposite of what we're asking for. > Look, I'd love to merge the bug fix for the DISC property. But we need compatibility. > I'll give you another

D16579: Fix APE tag extraction

2018-11-02 Thread James Smith
smithjd added a comment. In D16579#352788 , @smithjd wrote: > - Use the de-facto Album Artist field name for APE tags. > > Since the discussion around this patch has also included the Album Artist field, add the changes required for this

D16579: Fix APE tag extraction

2018-11-02 Thread James Smith
smithjd retitled this revision from "Musepack disk number field name is DISC." to "Fix APE tag extraction". smithjd edited the summary of this revision. smithjd edited the test plan for this revision. smithjd added a reviewer: mgallien. REPOSITORY R286 KFileMetaData REVISION DETAIL

D16579: Musepack disk number field name is DISC.

2018-11-02 Thread James Smith
smithjd updated this revision to Diff 44708. smithjd added a comment. - Use the de-facto Album Artist field name for APE tags. Since the discussion around this patch has also included the Album Artist field, add the changes required for this field to this review. REPOSITORY R286

D16579: Musepack disk number field name is DISC.

2018-11-01 Thread James Smith
smithjd added a comment. In D16579#352282 , @bruns wrote: > In D16579#352279 , @smithjd wrote: > > > I would instead recommend a tag editor that properly tags APE files, such as puddletag.

D16579: Musepack disk number field name is DISC.

2018-11-01 Thread James Smith
smithjd added a comment. I would instead recommend a tag editor that properly tags APE files, such as puddletag. APE-using formats are less mainstream than id3 using formats. Users with APE-using formats usually know WHY they use their format of choice, and will know there are potential

D16579: Musepack disk number field name is DISC.

2018-11-01 Thread James Smith
smithjd added a comment. I would also argue that accepting values from tag field names that have identically-purposed, widely-acceptable alternatives is irresponsible. Changing your tags to meet the standard then is a more viable course of action. REPOSITORY R286 KFileMetaData REVISION

D16579: Musepack disk number field name is DISC.

2018-11-01 Thread James Smith
smithjd added a comment. In D16579#352191 , @astippich wrote: > In D16579#352147 , @smithjd wrote: > > > In D16579#351910 , @astippich wrote: > > > >

D16579: Musepack disk number field name is DISC.

2018-11-01 Thread James Smith
smithjd updated this revision to Diff 44638. smithjd added a comment. - Change the unit test to check if the APE 'disc' value is correct. REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16579?vs=44607=44638 BRANCH master-musepackFixes (branched

D16579: Musepack disk number field name is DISC.

2018-11-01 Thread James Smith
smithjd added a comment. In D16579#351910 , @astippich wrote: > The ape tag tests fail with this patch, but the test is actually wrong in that regard. It tests for an empty disc number, which I haven't noticed before. > I've found references

D16579: Musepack disk number field name is DISC.

2018-10-31 Thread James Smith
smithjd added a comment. Useful tag mapping information: https://wiki.hydrogenaud.io/index.php?title=Tag_Mapping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16579 To: smithjd Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16579: Musepack disk number field name is DISC.

2018-10-31 Thread James Smith
smithjd created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REVISION SUMMARY Fix the Musepack disk field. REPOSITORY R286 KFileMetaData BRANCH master-musepackFixes (branched from

D13216: Overhaul the file index scheduler.

2018-10-14 Thread James Smith
smithjd updated this revision to Diff 43623. smithjd added a comment. - Re-write the file index scheduler. Combine content indexer suspend logic. - Update the balooctl tool with the changed suspend/resume behaviour. - Re-order and use IndexerState to prioritize the indexer thread pool. -

D13424: Run a file changed check when the file watches are updated.

2018-10-14 Thread James Smith
smithjd abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D15939: Perform checks for unindexed files and stale index entries on startup

2018-10-14 Thread James Smith
smithjd added a comment. In D15939#341728 , @poboiko wrote: > In D15939#341094 , @smithjd wrote: > > > https://phabricator.kde.org/D11529 was already up for review, implemented the index cleaner

D15939: Perform checks for unindexed files and stale index entries on startup

2018-10-10 Thread James Smith
smithjd added a comment. https://phabricator.kde.org/D11529 was already up for review, implemented the index cleaner and checked for removeable volumes before removing index entries. Exporting the storagedevices object was required: https://phabricator.kde.org/D15047. The alternative,

D13425: File indexer closing improvements.

2018-10-10 Thread James Smith
smithjd updated this revision to Diff 43368. smithjd added a comment. Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=43363=43368 BRANCH master-scheduler-haltonquit (branched from master) REVISION DETAIL

D13425: File indexer closing improvements.

2018-10-10 Thread James Smith
smithjd added a comment. https://bugs.kde.org/show_bug.cgi?id=353559 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien, #baloo, poboiko Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich,

D11529: Balooctl: Deindex unfound files with check command.

2018-10-10 Thread James Smith
smithjd removed a dependency: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik, bruns Cc: bruns, kde-frameworks-devel, mgallien, ashaposhnikov, michaelh, astippich, spoorun,

D13216: Overhaul the file index scheduler.

2018-10-10 Thread James Smith
smithjd removed a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D11529: Balooctl: Deindex unfound files with check command.

2018-10-10 Thread James Smith
smithjd removed a dependency: D15047: Export the StorageDevices object.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik, bruns Cc: bruns, kde-frameworks-devel, mgallien, ashaposhnikov, michaelh, astippich, spoorun,

D15047: Export the StorageDevices object.

2018-10-10 Thread James Smith
smithjd removed a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik, #baloo, bruns, poboiko Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D13425: File indexer closing improvements.

2018-10-10 Thread James Smith
smithjd updated this revision to Diff 43363. smithjd added a comment. Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=43361=43363 BRANCH master-scheduler-watchesInstalled (branched from master) REVISION DETAIL

D13425: File indexer closing improvements.

2018-10-10 Thread James Smith
smithjd updated this revision to Diff 43361. smithjd added a comment. Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=40344=43361 BRANCH master-scheduler-haltonquit (branched from master) REVISION DETAIL

D15047: Export the StorageDevices object.

2018-10-10 Thread James Smith
smithjd updated this revision to Diff 43357. smithjd added a comment. - Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15047?vs=43353=43357 BRANCH master-storageDevicesExport (branched from master) REVISION DETAIL

D13216: Overhaul the file index scheduler.

2018-10-10 Thread James Smith
smithjd updated this revision to Diff 43355. smithjd marked an inline comment as done. smithjd added a comment. - Re-write the file index scheduler. Combine content indexer suspend logic. - Update the balooctl tool with the changed suspend/resume behaviour. - Re-order and use IndexerState

D15047: Export the StorageDevices object.

2018-10-10 Thread James Smith
smithjd updated this revision to Diff 43353. smithjd added a comment. - Re-write the file index scheduler. Combine content indexer suspend logic. - Update the balooctl tool with the changed suspend/resume behaviour. - Re-order and use IndexerState to prioritize the indexer thread pool. -

D15939: Perform checks for unindexed files and stale index entries on startup

2018-10-08 Thread James Smith
smithjd added a comment. Does this run at startup? If so, this will erase the entries of files on a removable volume not already mounted. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15939 To: poboiko, #baloo, #frameworks, vhanda, ngraham Cc: smithjd, bruns,

D11529: Balooctl: Deindex unfound files with check command.

2018-10-08 Thread James Smith
smithjd abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik, bruns Cc: bruns, kde-frameworks-devel, mgallien, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D15843: Allow FileIndexerConfig to check device mounted status by path.

2018-10-01 Thread James Smith
smithjd added a comment. In D15843#334518 , @ngraham wrote: > Perhaps we should discuss the implementation of multi-device indexing in a Phab ticket instead of across the comments of multiple patches. Then we can settle on an agreed-upon

D15843: Allow FileIndexerConfig to check device mounted status by path.

2018-09-30 Thread James Smith
smithjd added a comment. >>> As a side note - cross-device indexing is broken anyway and can never work reliably in the current scheme using device ids as part of the baloo document id. Device ids are not stable. For the home partition it works somewhat reliable as the device setup is

D15843: Allow FileIndexerConfig to check device mounted status by path.

2018-09-30 Thread James Smith
smithjd added a comment. >> There is no need for this, just create a new StorageDevices where you need it. >> Creating a second StorageDevices instance in a process is quite cheap. > > Creating a separate object cluttered the console with duplicated debug output and raised a threading

D15843: Allow FileIndexerConfig to check device mounted status by path.

2018-09-30 Thread James Smith
smithjd added a comment. In D15843#334230 , @bruns wrote: > Most obvious problem with this change - as far as I can deduce from your description, this is about runtime behaviour. The config class is the wrong place to add this method.

D15843: Allow FileIndexerConfig to check device mounted status by path.

2018-09-29 Thread James Smith
smithjd added a comment. In D15843#334024 , @bruns wrote: > Whats the use case exactly? "Some parts" is not sufficient ... The index cleaner for example needs to skip unmounted paths. REPOSITORY R293 Baloo REVISION DETAIL

D15843: Allow FileIndexerConfig to check device mounted status by path.

2018-09-29 Thread James Smith
smithjd created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REVISION SUMMARY Parts of Baloo need some way to check if a path's volume is mounted or not. REPOSITORY R293 Baloo

D15718: Do not index the path if the path has no execute permissions.

2018-09-25 Thread James Smith
smithjd abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15718 To: smithjd, ngraham, #baloo, ltoscano Cc: ltoscano, marten, bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D15718: Do not index the path if the path has no execute permissions.

2018-09-25 Thread James Smith
smithjd added a comment. xattrs are no good for vaults because the xattr is ignored for the mountpoint, only restored when the volume is unmounted. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15718 To: smithjd, ngraham, #baloo, ltoscano Cc: ltoscano, marten,

D15718: Do not index the path if the path has no execute permissions.

2018-09-24 Thread James Smith
smithjd added a comment. > No, because even if the default umask is 002, or 022, POSIX says that the default permissions of a file on creation are going to be 0666, not 0777: Trial-and-error proven. :( In D15718#331449 , @ngraham wrote:

D15718: Do not index the path if the path has no execute permissions.

2018-09-24 Thread James Smith
smithjd added a comment. https://www.freedesktop.org/wiki/CommonExtendedAttributes suggests xattrs to use to store do-not-index information and also requires each file to be explicitly set to be indexed. > user.xdg.robots.index: On a file: "true" to index, "false" to not index. On a

D15583: [Balooctl] remove directory parent check

2018-09-24 Thread James Smith
smithjd added a comment. What was wrong with https://phabricator.kde.org/D15583?id=42018 ? > I could see the case for allowing this behavior to be explicitly overridden by an advanced user who marks ~/foo/ as excluded and then later marks ~foo/bar/ as included, but that would be

D15718: Do not index the path if the path has no execute permissions.

2018-09-23 Thread James Smith
smithjd added a comment. In D15718#330864 , @ngraham wrote: > Making files executable that don't need to be executable is a bad security habit. What if the contents get replaced with something malicious? Suddenly that now-malicious file has

D15718: Do not index the path if the path has no execute permissions.

2018-09-23 Thread James Smith
smithjd added a comment. In D15718#330845 , @ngraham wrote: > In D15718#330844 , @smithjd wrote: > > > In D15718#330836 , @ngraham wrote: > > > > >

D15718: Do not index the path if the path has no execute permissions.

2018-09-23 Thread James Smith
smithjd added a comment. In D15718#330836 , @ngraham wrote: > Wouldn't this have the effect of un-indexing most files? A quick check of my documents (text, word processing, excel, etc) reveals that none of them have the execute bit set. As-is,

D15718: Do not index the path if the path has no execute permissions.

2018-09-23 Thread James Smith
smithjd added a comment. Files/folders should not be automatically indexed if the execute bit is unset. Downloads from most if not all popular browsers are not executable by default. Setting a file unexecutable would be used to prevent automatic indexing of files and most importantly

D15718: Do not index the path if the path has no execute permissions.

2018-09-23 Thread James Smith
smithjd created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REVISION SUMMARY This will prevent automatic indexing of newly downloaded files and can be used to prevent indexing of

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

2018-09-23 Thread James Smith
smithjd added inline comments. INLINE COMMENTS > taglibwritertest.cpp:60 > > -QCOMPARE(extractedTitle, QStringLiteral("Title1")); > -QCOMPARE(extractedArtist, QStringLiteral("Artist1")); > -QCOMPARE(extractedAlbum, QStringLiteral("Album1")); > +QCOMPARE(extractedTitle,

D15583: [Balooctl] remove directory parent check

2018-09-23 Thread James Smith
smithjd added a comment. Technically, this check isn't actually needed, though it does prevent the user from entering a path more than once. At first glance this looks like it should work: if (folder.startsWith(path)) This doesn't prevent the user from also re-specifying valid

D11529: Balooctl: Deindex unfound files with check command.

2018-08-24 Thread James Smith
smithjd updated this revision to Diff 40394. smithjd added a comment. - New DBus method updateIndex(). - Document indexing options. - Prevent a scheduler race condition. - Rebase for separate statechanged functors. Re-base. Drops setting a runnable priority. REPOSITORY R293 Baloo

D13216: Overhaul the file index scheduler.

2018-08-24 Thread James Smith
smithjd updated this revision to Diff 40393. smithjd added a comment. - Revert "Re-order and use IndexerState to prioritize the indexer thread pool." Avoid setting a priority on the runnables. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D13216: Overhaul the file index scheduler.

2018-08-24 Thread James Smith
smithjd added inline comments. INLINE COMMENTS > bruns wrote in fileindexscheduler.cpp:117 > Whats that supposed to do (I have an idea, but thats ugly ...) This starts a QRunnable at a negative priority (in this case the negative integer value for NewFiles) and then calls

D11529: Balooctl: Deindex unfound files with check command.

2018-08-24 Thread James Smith
smithjd added inline comments. INLINE COMMENTS > bruns wrote in indexcleaner.cpp:76 > Undesired detach This example will also detach with or without a const intermediate. > ...returning a copy from a method means that the copy is shared and has > negative side-effects when used with

D15047: Export the StorageDevices object.

2018-08-24 Thread James Smith
smithjd added a comment. In D15047#314741 , @bruns wrote: > In D15047#314485 , @smithjd wrote: > > > In D15047#314477 , @bruns wrote: > > > > > There

D13216: Overhaul the file index scheduler.

2018-08-24 Thread James Smith
smithjd edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D11529: Balooctl: Deindex unfound files with check command.

2018-08-23 Thread James Smith
smithjd updated this revision to Diff 40346. smithjd added a comment. - New DBus method updateIndex(). - Document indexing options. - Prevent a scheduler race condition. - Run de-indexing file check in parallel. - Rebase for separate statechanged functors. REPOSITORY R293 Baloo

D13424: Run a file changed check when the file watches are updated.

2018-08-23 Thread James Smith
smithjd updated this revision to Diff 40345. smithjd added a comment. Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=36703=40345 BRANCH master-scheduler-watchesInstalled (branched from master) REVISION DETAIL

D13425: File indexer closing improvements.

2018-08-23 Thread James Smith
smithjd updated this revision to Diff 40344. smithjd added a comment. Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=36702=40344 BRANCH master-scheduler-haltonquit (branched from master) REVISION DETAIL

D13216: Overhaul the file index scheduler.

2018-08-23 Thread James Smith
smithjd updated this revision to Diff 40343. smithjd added a comment. - Re-write the file index scheduler. Combine content indexer suspend logic. - Update the balooctl tool with the changed suspend/resume behaviour. - Re-order and use IndexerState to prioritize the indexer thread pool. -

D15048: Re-write the file index scheduler. Combine content indexer suspend logic.

2018-08-23 Thread James Smith
smithjd abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15048 To: smithjd Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15048: Re-write the file index scheduler. Combine content indexer suspend logic.

2018-08-23 Thread James Smith
smithjd created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REVISION SUMMARY Update the balooctl tool with the changed suspend/resume behaviour. Re-order and use IndexerState to

D15047: Export the StorageDevices object.

2018-08-23 Thread James Smith
smithjd marked an inline comment as done. smithjd added a comment. In D15047#314477 , @bruns wrote: > There is no need for this, just create a new StorageDevices where you need it. > Creating a second StorageDevices instance in a process is

D15047: Export the StorageDevices object.

2018-08-23 Thread James Smith
smithjd added a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D11529: Balooctl: Deindex unfound files with check command.

2018-08-23 Thread James Smith
smithjd edited dependencies, added: D15047: Export the StorageDevices object., D13216: Overhaul the file index scheduler.; removed: D13424: Run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd,

D13216: Overhaul the file index scheduler.

2018-08-23 Thread James Smith
smithjd added a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D13424: Run a file changed check when the file watches are updated.

2018-08-23 Thread James Smith
smithjd removed a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich,

D15047: Export the StorageDevices object.

2018-08-23 Thread James Smith
smithjd added a reviewer: broulik. smithjd added a comment. This was included in https://phabricator.kde.org/D11529 and is now broken out. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik Cc: kde-frameworks-devel, #baloo, ashaposhnikov,

D15047: Export the StorageDevices object.

2018-08-23 Thread James Smith
smithjd created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REPOSITORY R293 Baloo BRANCH master-storageDevicesExport (branched from master) REVISION DETAIL

D13425: File indexer closing improvements.

2018-06-26 Thread James Smith
smithjd retitled this revision from "file indexer closing inprovements." to "File indexer closing improvements.". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov,

D13424: Run a file changed check when the file watches are updated.

2018-06-26 Thread James Smith
smithjd updated this revision to Diff 36703. smithjd added a comment. Change commit description. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=36418=36703 BRANCH master-scheduler-watchesInstalled (branched from master) REVISION DETAIL

D13425: file indexer closing inprovements.

2018-06-26 Thread James Smith
smithjd updated this revision to Diff 36702. smithjd added a comment. Change git commit description. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=36416=36702 BRANCH master-scheduler-haltonquit (branched from master) REVISION DETAIL

D13216: Overhaul the file index scheduler.

2018-06-26 Thread James Smith
smithjd updated this revision to Diff 36701. smithjd added a comment. re-word commits. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13216?vs=36417=36701 BRANCH master-scheduler (branched from master) REVISION DETAIL https://phabricator.kde.org/D13216

D11529: Balooctl: Deindex unfound files with check command.

2018-06-20 Thread James Smith
smithjd updated this revision to Diff 36419. smithjd added a comment. Rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=35204=36419 BRANCH master-filedeindexer (branched from master) REVISION DETAIL https://phabricator.kde.org/D11529

D13216: Overhaul the file index scheduler.

2018-06-20 Thread James Smith
smithjd removed a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D11529: Balooctl: Deindex unfound files with check command.

2018-06-20 Thread James Smith
smithjd edited dependencies, added: D13424: Run a file changed check when the file watches are updated.; removed: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik Cc:

D13424: Run a file changed check when the file watches are updated.

2018-06-20 Thread James Smith
smithjd added a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich,

D13424: Run a file changed check when the file watches are updated.

2018-06-20 Thread James Smith
smithjd updated this revision to Diff 36418. smithjd added a comment. - Remove a fixme. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=36415=36418 BRANCH master-scheduler-watchesInstalled (branched from master) REVISION DETAIL

D13216: Overhaul the file index scheduler.

2018-06-20 Thread James Smith
smithjd removed a dependent revision: D13424: Run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D13424: Run a file changed check when the file watches are updated.

2018-06-20 Thread James Smith
smithjd edited dependencies, added: D13425: file indexer closing inprovements.; removed: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo,

D13425: file indexer closing inprovements.

2018-06-20 Thread James Smith
smithjd added a dependent revision: D13424: Run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh,

D13425: file indexer closing inprovements.

2018-06-20 Thread James Smith
smithjd removed a dependency: D13424: Run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich,

D13424: Run a file changed check when the file watches are updated.

2018-06-20 Thread James Smith
smithjd removed a dependent revision: D13425: file indexer closing inprovements.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D13216: Overhaul the file index scheduler.

2018-06-20 Thread James Smith
smithjd updated this revision to Diff 36417. smithjd added a comment. - Re-write the the file index scheduler. - Update the balooctl tool with the changed suspend/resume behaviour. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13216?vs=35810=36417 BRANCH

D13425: file indexer closing inprovements.

2018-06-20 Thread James Smith
smithjd updated this revision to Diff 36416. smithjd added a comment. Consolidate file indexer close changes into a single review. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=35813=36416 BRANCH master-scheduler-haltonquit (branched from

D13425: file indexer closing inprovements.

2018-06-20 Thread James Smith
smithjd retitled this revision from "Quit the file indexer when closing." to "file indexer closing inprovements.". smithjd edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien,

D13424: Run a file changed check when the file watches are updated.

2018-06-20 Thread James Smith
smithjd retitled this revision from "On config change halt the file indexer and run a file changed check when the file watches are updated." to "Run a file changed check when the file watches are updated.". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To:

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

2018-06-20 Thread James Smith
smithjd updated this revision to Diff 36415. smithjd added a comment. Run a full check for unindexed files when the watches are installed. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=35812=36415 BRANCH master-scheduler-watchesInstalled

  1   2   >