D19821: Fix breeze dialog background with Qt 5.12.2

[Krešimir Čohar]

rooty added a comment.


  In D19821#434410 , @fvogt wrote:
  
  > In D19821#434405 , @rooty wrote:
  >
  > > This wasn't supposed to land in Plasma 5.15 as well as master?
  >
  >
  > Plasma Framework is (in this case unfortunately) a Framework, so no stable 
branches.
  
  
  My bad!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Krešimir Čohar]

rooty added a comment.


  This wasn't supposed to land in Plasma 5.15 as well as master?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Krešimir Čohar]

rooty accepted this revision.
rooty added a comment.
This revision is now accepted and ready to land.


  If it works for you ship it, I'm nowhere near a computer right now

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Krešimir Čohar]

rooty added a comment.


  In D19821#432780 , @Zren wrote:
  
  > Another option I believe is to keep the 

D17469: Give applications-games and input-gaming more contrast with Breeze Dark

[Krešimir Čohar]

rooty accepted this revision.
rooty added a comment.


  Much better than before

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D17469 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe, ngraham, rooty
Cc: rooty, abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, 
bruns

D19557: Update css

[Krešimir Čohar]

rooty added a comment.


  Can you make it use Noto Sans by any chance?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: rooty, ltoscano, bruns, abetts, broulik, aacid, kde-frameworks-devel, 
kde-doc-english, gennad, michaelh, ngraham, skadinna

D19629: Change media-skip* and media-seek* style

[Krešimir Čohar]

rooty accepted this revision as: rooty.
rooty added a comment.
This revision is now accepted and ready to land.


  A quick google search (mpv, VLC, windows media player, etc.) revealed that 
the change you're proposing is actually more in keeping with the standard than 
what we've been using (Spotify/Winamp). So, +1 from me

REPOSITORY
  R266 Breeze Icons

BRANCH
  window-states (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19629

To: ndavis, #vdg, rooty
Cc: rooty, kde-frameworks-devel, michaelh, ngraham, bruns

D19307: Enforce new muted icon style in all action icons

[Krešimir Čohar]

rooty accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  correct-muted-action-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19307

To: trickyricky26, #vdg, ngraham, rooty
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19599: textfield height based only on clear text

[Krešimir Čohar]

rooty added a dependent revision: D19214: [sddm-theme] Replace login button 
label with icon.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/echo

REVISION DETAIL
  https://phabricator.kde.org/D19599

To: mart, #plasma, ngraham, rooty
Cc: rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19599: textfield height based only on clear text

[Krešimir Čohar]

rooty accepted this revision.
rooty added a comment.


  Good things come to those who wait, thanks for the fix.
  I can also confirm that this doesn't affect any other font adversely in any 
way.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/echo

REVISION DETAIL
  https://phabricator.kde.org/D19599

To: mart, #plasma, ngraham, rooty
Cc: rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19530: Avoid fractionals in GridDelegate sizes and alignments

[Krešimir Čohar]

rooty accepted this revision.
rooty added a comment.


  A lot easier on the eyes now, really nice fix

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19530

To: davidedmundson, #plasma, ngraham, rooty
Cc: rooty, ngraham, filipf, kde-frameworks-devel, michaelh, bruns

D18699: [KIO/RenameDialog] Add new apply behaviour

[Krešimir Čohar]

rooty added a comment.


  I propose that "Apply to" be taken out of the checkbox/combobox, hence Apply 
to: "combobox"
  
  And I propose the labels:
  "This File Only"
  "Every File" (or Every File in Transit)
  "Destination, if Older Than Arrival"
  "Destination, if More Recent Than Arrival"
  
  Otherwise, nice patch! +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18699

To: chinmoyr, dfaure, ngraham, #vdg
Cc: rooty, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19324: Add code-oss icon

[Krešimir Čohar]

rooty added a comment.


  In D19324#421552 , @axionl wrote:
  
  > In D19324#421178 , @ndavis wrote:
  >
  > > Great. Now you just need to get rid of the invisible rectangle. You can 
do that quickly with `sed -i 's|||' code.svg`. After you've done that, 
I can accept and land this.
  > >
  > > BTW, you're meant to put the comment for the diff update at the top, but 
it's not a huge deal. That's why you keep getting this text in all of your 
update comments:
  > >
  > > - Merge branch 'master' into code-oss
  > >  
  > >   # Updating D19324: Add code-oss icon
  > >   #
  > >   # Enter a brief description of the changes included in this update.
  > >   # The first line is used as subject, next lines as comment.
  > >   #
  > >   # If you intended to create a new revision, use:
  > >   #  $ arc diff --create
  > >
  > >
  > > The stuff to the left of the `#` characters is ignored if you put the 
comment at the top.
  >
  >
  > This is my first time to contribute plasma/kde project, I feel sorry for my 
mistakes and thanks for your help.
  
  
  You're doing great, and the icons look amazing, most of this is just icing on 
the cake :D

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Krešimir Čohar]

rooty added a comment.


  There are quick commands/aliases here for how to take quick screenshots 
https://invent.kde.org/ndavis/hig-kde-org/wikis/Icon-Workflow
  
  I ran it and I got F6635927: new.png 
  which looks really nice.
  
  However, is there some reason that it looks different from a Dolphin 
generated thumbnail? F6635929: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Krešimir Čohar]

rooty added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D18986

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty added a comment.


  In D18986#415677 , @trickyricky26 
wrote:
  
  > I will make some minor changes to the 64px design.
  
  
  Sure thing, sorry about being lazy and not updating the screenshots 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: trickyricky26, #vdg, hein, ndavis, rooty
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty updated this revision to Diff 52021.
rooty added a comment.


  Use side view for all three icon versions

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18986?vs=51970=52021

BRANCH
  video-camera-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18986

AFFECTED FILES
  icons-dark/devices/16/camera-video.svg
  icons-dark/devices/22/camera-video.svg
  icons-dark/devices/64/camera-video.svg
  icons/devices/16/camera-video.svg
  icons/devices/22/camera-video.svg
  icons/devices/64/camera-video.svg

To: rooty, #vdg, hein, ndavis
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a dependent revision: D19129: [sddm-theme] Apply new username 
prompt and user list icons.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:3b88babfed6c: [breeze-icons] Use new suspend, hibernate 
and switch user icons in Breeze icon… (authored by rooty).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19074?vs=51996=52002

REVISION DETAIL
  https://phabricator.kde.org/D19074

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/22/system-switch-user.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons-dark/actions/32/system-switch-user.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/22/system-switch-user.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg
  icons/actions/32/system-switch-user.svg

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  In D19020#414802 , @ngraham wrote:
  
  > I love it. Looks perfect to me now.
  
  
  Thanks :D Will be landing it shortly

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51997.
rooty added a comment.


  Use more integers

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51993=51997

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty updated this revision to Diff 51996.
rooty added a comment.


  Make all the Z's bigger

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19074?vs=51986=51996

BRANCH
  arcpatch-D19074

REVISION DETAIL
  https://phabricator.kde.org/D19074

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/22/system-switch-user.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons-dark/actions/32/system-switch-user.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/22/system-switch-user.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg
  icons/actions/32/system-switch-user.svg

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty added a comment.


  In D19074#414750 , @ngraham wrote:
  
  > Or they could all be a bit bigger, and the snowflake versions could simply 
take up a teensy bit more of the snowflake's top-right corner.
  
  
  Yeah I made all the Z's bigger, it should be better now

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51993.
rooty added a comment.


  Make Z's larger

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51985=51993

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty added a comment.


  F6621821: image.png 
  
  I'm gonna edit system.svgz too, for consistency's sake

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty added a comment.


  In D18986#414687 , @ngraham wrote:
  
  > Getting there! I'm not sure the shadow on the top handle works though.
  
  
  Fixed it
  
  F6621810: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty added a comment.


  In D19074#414706 , @ngraham wrote:
  
  > That could work, yeah. Give it a try!
  
  
  22 px or 32 px too?
  
  Because the 32 px version matches the desktop theme 32 px version as is
  
  P.S. What about hibernate? I don't have that icon in Kickoff but other people 
might?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty added a comment.


  In D18986#414687 , @ngraham wrote:
  
  > Getting there! I'm not sure the shadow on the top handle works though.
  
  
  Oh that's just inkscape being difficult - that's not supposed to be there 
hahaha

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty added a comment.


  In D19074#414689 , @ngraham wrote:
  
  > The Zs look a bit small in Kickoff and especially Kicker when using a 
non-high-DPI display:
  >
  > F6621746: Screenshot_20190218_105639.png 

  >
  > F6621748: Screenshot_20190218_105747.png 

  >
  > We might need to simplify the icons for the small sizes and/or make the Zs 
bigger.
  
  
  What about just two (big) Z's?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty updated this revision to Diff 51986.
rooty added a comment.


  Resize 22 px switch user icon

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19074?vs=51910=51986

BRANCH
  arcpatch-D19074

REVISION DETAIL
  https://phabricator.kde.org/D19074

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/22/system-switch-user.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons-dark/actions/32/system-switch-user.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/22/system-switch-user.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg
  icons/actions/32/system-switch-user.svg

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  I actually did resize this one too because you can never be quite sure which 
22 px icon will be used hahahah
  And I grazed the top margin a little bit but I actually managed to stay 
within all the other margins

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51985.
rooty added a comment.


  Resize 22 px switch user icon

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51982=51985

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51982.
rooty added a comment.


  Remove second filled in user from 22 px switch user icon

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51954=51982

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty added a comment.


  More progress. How's this
  
  F6621740: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty added a comment.


  In D18986#414635 , @ngraham wrote:
  
  > I will admit that the current head-on view is more attractive than the 
previous side view version. :)
  
  
  Tongue in cheek :D
  Which size are you talking about though? The monochrome ones or the color one?
  
  P.S.
  F6621699: image.png 
  
  This is a rough draft of what a side view 64 px version would look like with 
a microphone on top (I can't stand film reels in icons, sorry...)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty added a comment.


  In D18986#414602 , @ngraham wrote:
  
  > Doesn't that logic also apply to a head-on-view icon for a video camera? 
It's not re-using the familiarity people generally have with the very common 
side-view video camera icons. A search on flaticon turns up the following, for 
example:
  
  
  I don't know. Using a head-on view might make the icon more consistent with 
the rest of //Plasma// (not what people generally use and are familiar with).
  F6621663: image.png 
  
  Using an icon with the video camera in profile will require us to either 
break consistency with the other camera icons or change the other icons to 
accommodate the new video camera icon.
  
  Most searches turn up this
  
  F6621642: image.png 
  but at the same time turn up something along the lines of
  
  F6621647: image.png 
  
  If you're okay with the inconsistency, I can do a side view. But there 
definitely is an inconsistency.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty updated this revision to Diff 51970.
rooty added a comment.


  Use head-on versions of the 16 px and 22 px icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18986?vs=51636=51970

BRANCH
  video-camera-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18986

AFFECTED FILES
  icons-dark/devices/16/camera-video.svg
  icons-dark/devices/22/camera-video.svg
  icons-dark/devices/64/camera-video.svg
  icons/devices/16/camera-video.svg
  icons/devices/22/camera-video.svg
  icons/devices/64/camera-video.svg

To: rooty, #vdg, hein, ndavis
Cc: trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty added a comment.


  I don't know... I've been mulling this over for the last couple of days 
and... I'm //not// sold on the side view, because any variant of a side view 
will look broadly different from the other camera icons we already have 
(probably because it's harder to flatten a side view and get away with it the 
way you can with a head-on view ?).
  
  For example,
  F6621526: image.png 
  We'd basically have to redo all of them.
  
  So I've decided to change just the 16/22 px icons to make them head-on - it 
looks a lot better when you take the camera-photo icon into consideration:
  
  F6621553: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty closed this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  In D19020#414339 , @ndavis wrote:
  
  > That last little square in the username bothers me.
  
  
  If only I could use text/lettering...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51954.
rooty added a comment.


  Remove second square from username bar

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51938=51954

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  In D19020#414300 , @abetts wrote:
  
  > Well, maybe it is time to call it and be done. I don't think we are going 
to please everyone right now. Maybe our best option is to have you, as the 
proponent of this idea, make the decision after long debate.
  
  
  You're right, and thanks for giving me the nudge I needed :D
  
  Okay so, I propose the icon remain the way it is right now:
  F6620691: image.png 
  because
  (1) we can't use an I beam with or without dots (the label is too vague)
  (2) we could use a long bar, but it looks kind of like a progress bar
  (3) we could use a circle, but we technically don't need to - and this sort 
of stresses the fact that it's an entirely different login screen that it'll 
take you to

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51938.
rooty added a comment.


  Center user prompt icon vertically

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51920=51938

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  In D19020#414285 , @abetts wrote:
  
  > I think the icon is pretty much there. Maybe the label can help the meaning 
come across. What about:
  >
  > "Enter User"
  >  "Type User"
  >  "Change User"
  
  
  haha it was actually changed to Type User then to Other... because we 
couldn't settle on a name, and thr fact that Verb + User sounds worse 
(grammatically) than Verb + Username (and Username is too long)
  
  Change User also doesn't capture what the screen does
  
  I think the label that truly captures that button is "Use Prompt" but it 
looks so ... weird :D

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  In D19020#414231 , @trickyricky26 
wrote:
  
  > As they are now it's long, short, long (exact same length as rectangle 
number 1), shorter than height (which looks bad imo). There are no medium 
lengths and the same length is used twice. I would suggest giving every bar a 
different length.
  >
  > If you're going to remove the spaces, this won't be an issue, but I would 
not remove the spaces until we are certain that spaces are not allowed in the 
real thing.
  
  
  Oh I don't mind removing the spaces
  F6620461: image.png 
  But people have complained that the end result looks like a progress bar...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  In D19020#414224 , @trickyricky26 
wrote:
  
  > I like it!
  >
  > I think the "Type User" Icon would look better if the bars acting as 
placeholder text were a bit less regular in width and would not be shorter than 
they are tall (which is the case for the rightmost rectangle).
  >  Also, can the usernames in the type user field contain spaces? If not, it 
might not be fitting to use multiple split rectangles to represent the 
username, as these gaps represent spaces.
  
  
  You're right about the spaces, I'll remove them
  But what do you mean by less regular in width?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51920.
rooty added a comment.


  Replace "Other..." icon with newer version

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51909=51920

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  @abetts
  
  F6620144: image.png 
  
  This is what I came up for the login/password field idea. What do you think?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty updated this revision to Diff 51910.
rooty added a comment.


  Implement the newer versions of all three icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19074?vs=51889=51910

BRANCH
  arcpatch-D19074

REVISION DETAIL
  https://phabricator.kde.org/D19074

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/22/system-switch-user.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons-dark/actions/32/system-switch-user.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/22/system-switch-user.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg
  icons/actions/32/system-switch-user.svg

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51909.
rooty added a comment.


  Add new switch user icons

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51821=51909

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty updated this revision to Diff 51890.
rooty added a comment.


  Use "-gamepad" instead

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19030?vs=51759=51890

BRANCH
  gamepad-icon-16-22-px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19030

AFFECTED FILES
  icons-dark/devices/16/input-gamepad.svg
  icons-dark/devices/22/input-gamepad.svg
  icons-dark/devices/64/input-gamepad.svg
  icons-dark/devices/symbolic/input-gamepad-symbolic.svg
  icons/devices/16/input-gamepad.svg
  icons/devices/22/input-gamepad.svg
  icons/devices/64/input-gamepad.svg
  icons/devices/symbolic/input-gamepad-symbolic.svg

To: rooty, hein, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty updated this revision to Diff 51889.
rooty added a comment.


  Use symbolic links instead (icons are already present)

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19074?vs=51888=51889

BRANCH
  new-suspend-hibernate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19074

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/22/system-switch-user.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons-dark/actions/32/system-switch-user.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/22/system-switch-user.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg
  icons/actions/32/system-switch-user.svg

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty added a comment.


  In D19074#413824 , @ngraham wrote:
  
  > While you're at it, can you also replace `system-switch-user` in the Breeze 
icon theme with the much better version that's in the Breeze Plasma theme?
  
  
  I'm so sorry, I didn't even notice before making the diff - there are two 
icons in the system.svgz (Breeze desktop theme) that look really similar:
  "system-switch-user" (one user + arrow): F6619519: image.png 

  and "system-users" (two users): F6619521: image.png 

  
  I accidentally replaced system-switch-user in the //icon// theme with 
system-users (not system-switch-user) in the desktop theme.
  
  Should I roll that back? Or should I make the appropriate modifications to 
"look and feel" so the Plasma theme would use the two user icon instead of the 
one user + arrow one?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty retitled this revision from "[breeze-icons] Implement new suspend 
hibernate and switch user icons in Breeze icon theme" to "[breeze-icons] Use 
new suspend, hibernate and switch user icons in Breeze icon theme".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Implement new suspend hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty retitled this revision from "[breeze-icons] Implement new suspend and 
hibernate icons in Breeze icon theme" to "[breeze-icons] Implement new suspend 
hibernate and switch user icons in Breeze icon theme".
rooty edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme

[Krešimir Čohar]

rooty updated this revision to Diff 51888.
rooty added a comment.


  Update system-switch-user with version from system.svgz

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19074?vs=51822=51888

BRANCH
  new-suspend-hibernate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19074

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/22/system-switch-user.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons-dark/actions/32/system-switch-user.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/22/system-switch-user.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg
  icons/actions/32/system-switch-user.svg

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme

[Krešimir Čohar]

rooty added a comment.


  Sure thing... I always did find that weird arrow over the user icon kind of 
weird

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty added a comment.


  @hein thoughts? I'm not keen on deleting that icon, God only knows what 
application might be using it :D

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty added a comment.


  In D19030#413778 , @ngraham wrote:
  
  > I think the idea was that we only needed `input-games` and 
`input-games-symbolic`, and not also `input-gaming` and 
`input-gaming-symbolic`. Right?
  
  
  There already is a 64 px icon called input-gaming in master. What do I do 
with that icon, rename it (remove then add?)?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19074: [breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme

[Krešimir Čohar]

rooty added a dependency: D19020: [breeze-icons] Revamp system.svgz.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a dependent revision: D19074: [breeze-icons] Implement new suspend 
and hibernate icons in Breeze icon theme.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme

[Krešimir Čohar]

rooty edited the summary of this revision.
rooty edited the test plan for this revision.
rooty added reviewers: VDG, ngraham.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch replaces the suspend and hibernate icons in the Breeze icon theme 
with the ones from system.svgz in patch D19020 
.

REPOSITORY
  R266 Breeze Icons

BRANCH
  new-suspend-hibernate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19074

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg

To: rooty
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51821.
rooty added a comment.


  Fix suspend icon height

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51793=51821

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19053: [kio-extras] Use "storage media" instead of "storages"

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:9f79f84d0800: [kio-extras] Use storage media 
instead of storages (authored by rooty).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19053?vs=51796=51798

REVISION DETAIL
  https://phabricator.kde.org/D19053

AFFECTED FILES
  mtp/kio_mtp.cpp

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19053: [kio-extras] Use "storage media" instead of "storages"

[Krešimir Čohar]

rooty updated this revision to Diff 51796.
rooty added a comment.


  Fix my own error (ironic?)

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19053?vs=51795=51796

BRANCH
  typo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19053

AFFECTED FILES
  mtp/kio_mtp.cpp

To: rooty, #vdg
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19053: [kio-extras] Use "storage media" instead of "storages"

[Krešimir Čohar]

rooty edited the summary of this revision.
rooty added a reviewer: VDG.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19053

To: rooty, #vdg
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19053: [kio-extras] Use "storage media" instead of "storages"

[Krešimir Čohar]

rooty created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
rooty requested review of this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  typo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19053

AFFECTED FILES
  mtp/kio_mtp.cpp

To: rooty
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51793.
rooty added a comment.


  Use Zs instead of stars

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51727=51793

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  In D19020#412775 , @ngraham wrote:
  
  > +1 on the List Users icon. Perfect.
  >
  > For the Type User icon, I'm not sure it needs to be in a circle. With the 
new moon-style suspend icon on the left side, it might be better to have a 
non-round icon on the right side to balance it out.
  >
  > I like the moon iconography in general. However I'm not as big a fan of the 
stars. They feel too regular, and the whole effect makes me think of the symbol 
for Islam: F6616841: islam-symbol-300x300.jpg 

  >
  > Likewise, I don't think the new Hibernate symbol works on its own. Alone, 
it's just a snowflake, which to me means "snow" or "cooling" or "winter 
weather".
  >
  > I think both of these symbols would benefit from having three Zs in the 
top-right corner like we discussed earlier. That would tie them both together 
conceptually as well as reinforce the concept that they're both modes of sleep.
  >
  > Something like this (warning: crude icon butchery incoming):
  >
  > F6616845: Screenshot_20190215_074707.png 

  
  
  But you're okay with the snowflake?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty added a comment.


  In D19030#412778 , @ngraham wrote:
  
  > Now we don't need `input-gaming` anymore. :)
  
  
  @hein put the "too" in parentheses :D, I was erring on the side of caution
  
  But what do I do to the 64 px version? Rename it to input-games? It's not a 
symlink

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty updated this revision to Diff 51759.
rooty added a comment.


  Add input-games and input-games-symbolic

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19030?vs=51732=51759

BRANCH
  gamepad-icon-16-22-px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19030

AFFECTED FILES
  icons-dark/devices/16/input-games.svg
  icons-dark/devices/16/input-gaming.svg
  icons-dark/devices/22/input-games.svg
  icons-dark/devices/22/input-gaming.svg
  icons-dark/devices/64/input-games.svg
  icons-dark/devices/symbolic/input-games-symbolic.svg
  icons-dark/devices/symbolic/input-gaming-symbolic.svg
  icons/devices/16/input-games.svg
  icons/devices/16/input-gaming.svg
  icons/devices/22/input-games.svg
  icons/devices/22/input-gaming.svg
  icons/devices/64/input-games.svg
  icons/devices/symbolic/input-games-symbolic.svg
  icons/devices/symbolic/input-gaming-symbolic.svg

To: rooty, hein, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty added a comment.


  In D19030#412562 , @hein wrote:
  
  > Could this maybe be input-games-symbolic (too)? Because I want a monochrome 
version always (my app recolors icons using the Kirigami feature, and that only 
works with monochrome icons).
  
  
  In addition to or instead of -gaming?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty added reviewers: hein, VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rooty requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  gamepad-icon-16-22-px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19030

AFFECTED FILES
  icons-dark/devices/16/input-gaming.svg
  icons-dark/devices/22/input-gaming.svg
  icons-dark/devices/symbolic/input-gaming-symbolic.svg
  icons/devices/16/input-gaming.svg
  icons/devices/22/input-gaming.svg
  icons/devices/symbolic/input-gaming-symbolic.svg

To: rooty
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the summary of this revision.
rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51727.
rooty added a comment.


  Add suspend moon/crescent and hibernate snowflake (thanks Noah!)

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51718=51727

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty retitled this revision from "[breeze-icons] WIP, Add "Type User" and 
"List Users" icons" to "[breeze-icons] Revamp system.svgz".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty added a comment.


  In D19020#412431 , @ngraham wrote:
  
  > The only problem here that is that the label says "Type User" but the icon 
depicts a password field. Maybe the icon could depict both a username field and 
a password field, one on top of the other. Then I bet it would be tall enough 
that we wouldn't feel the need to put it inside a circle.
  
  
  We actually tried that already and it turned out kinda boxy
  
  F6606959: image.png 
  
  Btw I don't think it has to be an accurate depiction seeing as we've got the 
label under it, so we've got more wiggle room that way

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty added a comment.


  F6615636: image.png 
  
  P.s. are you sure about the I beam and the dots inside a password field?
  It might turn out small to make out / appreciate

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty added a comment.


  In D19020#412412 , @abetts wrote:
  
  > Would an icon like this work?
  >
  > F6615590: Group 3.png 
  >
  > Just trying to get to a good final icon for typing your user.
  
  
  hey i like that, kai made fun of my version, but using both dots //and// an i 
beam could work

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty updated this revision to Diff 51718.
rooty added a comment.


  Fix glitch

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51716=51718

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty added a comment.


  In D19020#412387 , @ngraham wrote:
  
  > +1 on that "List Users" icon! Very nice.
  >
  > For the "Type User" icon, I wonder how much we really need that background 
circle. Especially if we wind up improving the suspend icon to have a moon and 
stars or some other kind of sleepytime iconography, then it would be nice to 
have icons without circles on both sides, so it's kinda symmetrical.
  
  
  Oh you don't want the suspend icon to have a circle? Oh well that changes 
things :D
  The I beam thing without the circle is kinda weird to me, but it actually 
looks fine with the circle around it.
  What about putting a circle around the crescent/stars that are going to make 
up the new suspend icon?
  F6615531: image.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty updated this revision to Diff 51716.
rooty added a comment.


  Improve List Users 22 px version

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51714=51716

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty retitled this revision from "Add "Type User" and "List Users" icons" to 
"[breeze-icons] WIP, Add "Type User" and "List Users" icons".
rooty edited the test plan for this revision.
rooty added reviewers: VDG, Plasma, ngraham, abetts.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns