D26424: [kdiroperator] Add method for accessing actions without KActionCollection

2020-11-21 Thread Méven Car
meven added a comment. ping @nicolasfella INLINE COMMENTS > kdiroperator.h:425 > */ > KActionCollection *actionCollection() const; > Mark it deprecated / add a // KF6 TODO remove ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella,

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

2020-10-17 Thread Méven Car
meven abandoned this revision. meven marked 5 inline comments as done. meven added a comment. Moved to https://invent.kde.org/frameworks/kio/-/merge_requests/174 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven, #frameworks, ngraham, broulik, dfaure Cc:

D29526: Thumbnails: make thumbnail generation dpr-aware

2020-09-08 Thread Méven Car
meven added a comment. In D29526#676386 , @bruns wrote: > For all but text the DPR is completely irrelevant, large@1 is identical to normal@2. Yes and that's up to thumbnail creators to decide. To take advantage of this, we would need

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-09-08 Thread Méven Car
meven added a comment. FYI on this patch serie, I am currently focusing on the specification work : https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/35 Then I am thinking about moving my patch serie to gitlab reflecting on the last feedback of course. Those patchs are

D29526: Thumbnails: make thumbnail generation dpr-aware

2020-09-07 Thread Méven Car
meven added a comment. I just sent a specification evolution to cover this use case : https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/35 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29526 To: meven, #frameworks, dfaure, broulik, sitter, ngraham

D28856: Save disabling of desktop file components in kglobalshortcutsrc

2020-06-30 Thread Méven Car
meven added a comment. ping Would be important to land with https://invent.kde.org/frameworks/kglobalaccel/-/merge_requests/2 REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D28856 To: davidre, davidedmundson, fvogt, meven Cc: kde-frameworks-devel,

D28745: Skip caching thumbnails on encrypted filesystems

2020-06-11 Thread Méven Car
meven added a comment. In D28745#675033 , @marcingu wrote: > Ok, so, what I want to do now is to create static method `findByPath` which is going to return Solid::StorageVolume instance (is there a case in which we can expect something

D28745: Skip caching thumbnails on encrypted filesystems

2020-06-07 Thread Méven Car
meven added a comment. In D28745#674827 , @bruns wrote: > In D28745#674711 , @meven wrote: > > > > > > > > > Solid does not provide straight `folder => StorageVolume` yet, but I think

D28745: Skip caching thumbnails on encrypted filesystems

2020-06-06 Thread Méven Car
meven added a comment. In D28745#674294 , @marcingu wrote: > I tried to research Solid using api.kde.org (https://api.kde.org/frameworks/solid/html/classSolid_1_1Device.html,

D29774: Add X-KDE-DBUS-Restricted-Interfaces to Application desktop entry fields

2020-06-05 Thread Méven Car
meven added a comment. In D29774#674668 , @zzag wrote: > > This added field to Application desktop entries allows to declare an access request to a DBUS interface. > > Just to be sure. Does X-KDE-DBUS-Restricted-Interfaces indicate a D-Bus

D29774: Add X-KDE-DBUS-Restricted-Interfaces to Application desktop entry fields

2020-06-05 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R309:cdad4f73ccb7: Add X-KDE-DBUS-Restricted-Interfaces to Application desktop entry fields (authored by meven). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-06-02 Thread Méven Car
meven added a comment. In D29397#674365 , @kossebau wrote: > To not have that block this improvement, you could in parallel for now use a "kde" namespaced directories, say "*@kde2x/", where we/you could just use the for-now-KF-only theme

D29525: Make Previews devicePixelRatio aware

2020-06-01 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R318 Dolphin BRANCH arcpatch-D29525 REVISION DETAIL https://phabricator.kde.org/D29525 To: meven, #dolphin, #frameworks, dfaure, ngraham, elvisangelaccio Cc: kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela,

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven, #frameworks, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n,

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Méven Car
meven added a comment. In D29805#674225 , @pino wrote: > In D29805#674218 , @meven wrote: > > > In D29805#674206 , @pino wrote: > > > > > In

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Méven Car
meven added a comment. In D29805#674206 , @pino wrote: > In D29805#674205 , @meven wrote: > > > In D29805#674204 , @pino wrote: > > > > > > FIXED-IN:

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Méven Car
meven added a comment. In D29805#674204 , @pino wrote: > > FIXED-IN: 20.08 > > still for 20.08... Yes kio-extra is released with KDE Applications REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Méven Car
meven marked 2 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven, #frameworks, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n,

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Méven Car
meven updated this revision to Diff 83177. meven marked an inline comment as done. meven added a comment. Remove brackets REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29805?vs=83018=83177 BRANCH arcpatch-D29805 REVISION DETAIL

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Méven Car
meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > pino wrote in djvucreator.cpp:52-54 > extra brackets I'd like to use instead the Framework coding style to improve homogenizing coding styles.

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

2020-05-30 Thread Méven Car
meven closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #frameworks, ngraham, dfaure Cc: dfaure, feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D3835: [Calendar] Populate overview models on-demand

2020-05-30 Thread Méven Car
meven accepted this revision as: meven. meven added a comment. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. @broulik is it still on the table ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D3835 To:

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

2020-05-29 Thread Méven Car
meven added a comment. In D26113#674129 , @dfaure wrote: > Please check that kfileplacesmodeltest and kfileplacesviewtest still pass. Just did, nothing changed, it is expected : only fstab declared filesystem or manually mounted fs

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-29 Thread Méven Car
meven added a comment. ping @pino REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven, #frameworks, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n,

D29806: Thumbnail folders: scale down sub image when their height is too big

2020-05-29 Thread Méven Car
meven abandoned this revision. meven added a comment. Moved to https://invent.kde.org/network/kio-extras/-/merge_requests/2 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29806 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, kfm-devel, waitquietly,

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

2020-05-28 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #frameworks, ngraham Cc: dfaure, feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

2020-05-28 Thread Méven Car
meven added a subscriber: dfaure. meven added a comment. This should be ready to land @dfaure @ngraham (D26114 will land after KF 5.71 release) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #frameworks,

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

2020-05-26 Thread Méven Car
meven updated this revision to Diff 83162. meven added a comment. Update to new Solid::Device::DisplayName REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26113?vs=79277=83162 BRANCH arcpatch-D26113 REVISION DETAIL https://phabricator.kde.org/D26113

D29461: Fix kio-extras build on Windows

2020-05-26 Thread Méven Car
meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH arcpatch-D29461 REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx,

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-25 Thread Méven Car
meven added inline comments. INLINE COMMENTS > ngraham wrote in previewjob.cpp:401 > What about if I'm using a 250% scale factor? Maybe there should be an `@3x` > folder too. or just trunate devicePixelRatio to int REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29397

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-25 Thread Méven Car
meven added a comment. The patch currently does not work. INLINE COMMENTS > ervin wrote in device.h:99 > Why not have a default implementation which returns descriptions()? This > would make for a less intrusive patch (I think it's in part what @bruns > suggested earlier). Well I have to

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

2020-05-25 Thread Méven Car
meven retitled this revision from "Places: For mounted volume display mount points instead of description" to "Places: Use Solid::Device::DisplayName for DisplayRole". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #frameworks, ngraham Cc: feverfew,

D26113: Places: For mounted volume display mount points instead of description

2020-05-25 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #frameworks, ngraham Cc: feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-25 Thread Méven Car
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R245:cdbfb3e799c7: Add a QString Solid::Device::displayName, used in Fstab Device for network… (authored by meven).

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-24 Thread Méven Car
meven marked an inline comment as done. meven added a comment. In D29397#673758 , @ngraham wrote: > Overall seems sane. Two questions though: > Is this @2x suffix standardized? No but it is already being used for icon caching.

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-24 Thread Méven Car
meven updated this revision to Diff 83140. meven added a comment. Rebasing REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29397?vs=83139=83140 BRANCH arcpatch-D29397 REVISION DETAIL https://phabricator.kde.org/D29397 AFFECTED FILES

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-23 Thread Méven Car
meven updated this revision to Diff 83139. meven marked 3 inline comments as done. meven added a comment. Typo, const, doxygen fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29397?vs=82709=83139 BRANCH arcpatch-D29397 REVISION DETAIL

D27731: Improve KDirModel to avoid showing '+' if there are no subdirs

2020-05-23 Thread Méven Car
meven added a comment. I believe this causes https://bugs.kde.org/show_bug.cgi?id=419434 It causes similar issue with dolphin and KFileWidget This is not a correct behavior. It prevents file treeview to show files within folders with no subfolders. The bug has a proposed patch :

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-23 Thread Méven Car
meven added a comment. In D28590#673609 , @dfaure wrote: > @meven you're confusing me with my clone @ervin. lol I thought this was still you when I read the comment. Thanks @ervin REPOSITORY R245 Solid REVISION DETAIL

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-23 Thread Méven Car
meven added a comment. This makes the patch way less intrusive in the process, thanks @dfaure REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter, dfaure Cc: dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack,

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-23 Thread Méven Car
meven updated this revision to Diff 83128. meven added a comment. Remove unneeded change REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28590?vs=83127=83128 BRANCH arcpatch-D28590_1 REVISION DETAIL https://phabricator.kde.org/D28590 AFFECTED FILES

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-23 Thread Méven Car
meven updated this revision to Diff 83127. meven marked 5 inline comments as done. meven added a comment. Use a default implementation for Device::displayName() REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28590?vs=83112=83127 BRANCH arcpatch-D28590_1

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-23 Thread Méven Car
meven added subscribers: broulik, dfaure. meven added a comment. Maybe @dfaure or @broulik would be nice to help the review effort. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter Cc: dfaure, broulik, ervin,

D29281: Deprecate defunct functions

2020-05-23 Thread Méven Car
meven accepted this revision as: meven. meven added a comment. This revision is now accepted and ready to land. Nice REPOSITORY R308 KRunner BRANCH deprecations (branched from master) REVISION DETAIL https://phabricator.kde.org/D29281 To: alex, #plasma, broulik, davidedmundson,

D29281: Deprecate defunct functions

2020-05-22 Thread Méven Car
meven added inline comments. INLINE COMMENTS > querymatch.cpp:338 > { > -return d->runner && d->runner.data()->hasRunOptions(); > } Did you really need to remove this code ? > querymatch.cpp:343 > > +#if KRUNNER_BUILD_DEPRECATED_SINCE(5, 1) > void

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-22 Thread Méven Car
meven added a comment. @pino ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven, #frameworks, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n,

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-22 Thread Méven Car
meven updated this revision to Diff 83112. meven added a comment. Update @since, improve doc REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28590?vs=81061=83112 BRANCH arcpatch-D28590_1 REVISION DETAIL https://phabricator.kde.org/D28590 AFFECTED FILES

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-22 Thread Méven Car
meven added a subscriber: ervin. meven added a comment. @ervin perhaps you might review this as @bruns seems too busy. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter Cc: ervin, kde-frameworks-devel, LeGast00n, cblack,

D29050: KRunner fix prepare/teardown signals

2020-05-20 Thread Méven Car
meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. It is hard to understand why it was wrongly placed here, that makes this hard to review and approve. But you are getting familiar with KRunner internals, so since it does seem benign and

D29232: Introduce the Header color set

2020-05-20 Thread Méven Car
meven added a comment. @mart you have a couple of typos left and recommendation to add some doc. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D29232 To: mart, #vdg, #plasma, cblack, ndavis Cc: meven, davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n,

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-20 Thread Méven Car
meven added a comment. ping dear reviewers REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29397 To: meven, dfaure, broulik, #frameworks, ngraham Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-19 Thread Méven Car
meven added inline comments. INLINE COMMENTS > alex wrote in kpluginselector.cpp:855 > > moduleInfo is part of the ctor here, so the fileName is already available > > indirectly. > > Yes, but the KCModuleProxy is just a wrapper class for the KCModule. > The actual KCModule gets created in

D29381: Thumbnail text: use libmagic to detect encoding

2020-05-19 Thread Méven Car
meven added a comment. I am only half satisfied by the patch. Mostly because of libmagic `magic_load` that loads a 5M file each time which is not needed to detect encoding. I would add some tests before landing anyways. REPOSITORY R320 KIO Extras REVISION DETAIL

D29381: Thumbnail text: use libmagic to detect encoding

2020-05-19 Thread Méven Car
meven updated this revision to Diff 83055. meven marked 5 inline comments as done. meven added a comment. Use QByteArray, find typo, code style and naming REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29381?vs=82252=83055 BRANCH arcpatch-D29381

D29806: Thumbnail folders: scale down sub image when their height is too big

2020-05-18 Thread Méven Car
meven planned changes to this revision. meven added a comment. Will probably send to gitlab ;) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29806 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov,

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-18 Thread Méven Car
meven added a comment. In D29397#672557 , @elvisangelaccio wrote: > Would it make sense to initialize `devicePixelRatio` to `QGuiApplication::devicePixelRatio()` and add an API to change it (if desired) ? It would make KPreviewJob

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-17 Thread Méven Car
meven updated this revision to Diff 83018. meven added a comment. fix indentation REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29805?vs=83014=83018 BRANCH arcpatch-D29805 REVISION DETAIL https://phabricator.kde.org/D29805 AFFECTED FILES

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-17 Thread Méven Car
meven retitled this revision from "Thumbnail djvu: avoid to exit(1) when it should not" to "Thumbnail djvu: Avoid a crash when djvu is not installed". meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven,

D29805: Thumbnail djvu: avoid to exit(1) when it should not

2020-05-17 Thread Méven Car
meven edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven, #frameworks, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice,

D29805: Thumbnail djvu: avoid to exit(1) when it should not

2020-05-17 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven, #frameworks, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n,

D29805: Thumbnail djvu: avoid to exit(1) when it should not

2020-05-17 Thread Méven Car
meven updated this revision to Diff 83014. meven added a comment. Review feedback REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29805?vs=83012=83014 BRANCH arcpatch-D29805 REVISION DETAIL https://phabricator.kde.org/D29805 AFFECTED FILES

D29805: Thumbnail djvu: avoid to exit(1) when it should not

2020-05-17 Thread Méven Car
meven planned changes to this revision. meven added a comment. Thanks @pino REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven, #frameworks, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov,

D29806: Thumbnail folders: scale down sub image when their height is too big

2020-05-17 Thread Méven Car
meven edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29806 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack,

D29806: Thumbnail folders: scale down sub image when their height is too big

2020-05-17 Thread Méven Car
meven created this revision. meven added reviewers: Frameworks, ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY BUG: 419566 FIXED-IN: 20.08 TEST PLAN Before: After

D29805: Thumbnail djvu: avoid to exit(1) when it should not

2020-05-17 Thread Méven Car
meven created this revision. meven added reviewers: Frameworks, broulik, ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY A child process exited with 1 as result but it

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

2020-05-16 Thread Méven Car
meven added inline comments. INLINE COMMENTS > kmountpoint.cpp:444 > +// for /dir/link/dir/test will return result for > /destLink/dir/test > +return findByPath(fileinfo.symLinkTarget() + > path.mid(cursor)); > +} Need to pass the flag here.

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-16 Thread Méven Car
meven added inline comments. INLINE COMMENTS > alex wrote in kpluginselector.cpp:855 > You could add a field to the KCModule class (thats where you ultimately want > to access the fileName). > But then the downside is that you don't have them as a constructor argument. moduleInfo is part of

D29738: Fix service file specifying 'Run in terminal' giving an error code 100

2020-05-16 Thread Méven Car
meven added a comment. It seems it is causing two failures in kiogui_applicationlauncherjobtest : https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/105/testReport/junit/projectroot/autotests/kiogui_applicationlauncherjobtest/ REPOSITORY R241 KIO REVISION DETAIL

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-16 Thread Méven Car
meven added a reviewer: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29397 To: meven, dfaure, broulik, #frameworks, ngraham Cc: kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-16 Thread Méven Car
meven added a comment. ping reviewers INLINE COMMENTS > previewjob.cpp:754 > thumb.setText(QStringLiteral("Thumb::Mimetype"), > currentItem.item.mimetype()); > +thumb.setText(QStringLiteral("Thumb::DevicePixelRatio"), > QString::number(thumb.devicePixelRatio())); >

D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-15 Thread Méven Car
meven removed a dependent revision: D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D29406 To: meven, #frameworks, davidedmundson, apol, bport Cc: kde-frameworks-devel,

D29774: Add X-KDE-DBUS-Restricted-Interfaces to Application desktop entry fields

2020-05-15 Thread Méven Car
meven added a dependent revision: D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D29774 To: meven, davidedmundson, zzag, #frameworks, #kwin Cc: kde-frameworks-devel,

D29774: Add X-KDE-DBUS-Restricted-Interfaces to Application desktop entry fields

2020-05-15 Thread Méven Car
meven created this revision. meven added reviewers: davidedmundson, zzag, Frameworks, KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY This added field to Application desktop entries allows to

D29767: CopyJob: Check if destination dir is a symlink

2020-05-15 Thread Méven Car
meven updated this revision to Diff 82920. meven marked 3 inline comments as done. meven added a comment. review feedback, cleanups REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29767?vs=82902=82920 BRANCH arcpatch-D29767 REVISION DETAIL

D29767: CopyJob: Check if destination dir is a symlink

2020-05-15 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R241:8769b6360d87: CopyJob: Check if destination dir is a symlink (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29767?vs=82920=82921 REVISION DETAIL

D29767: CopyJob: Check if destination dir is a symlink

2020-05-15 Thread Méven Car
meven updated this revision to Diff 82902. meven added a comment. Remove unrelated change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29767?vs=82901=82902 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29767 AFFECTED FILES

D28902: CopyJob: when stat'ing the dest, use StatBasic.

2020-05-15 Thread Méven Car
meven added a comment. Fix at D29767 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28902 To: dfaure, meven Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29767: CopyJob: Check if destination dir is a symlink

2020-05-15 Thread Méven Car
meven created this revision. meven added reviewers: Frameworks, dfaure, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY BUG: 421213 FIXED-IN: 5.71 TEST PLAN ctest REPOSITORY R241 KIO

D28902: CopyJob: when stat'ing the dest, use StatBasic.

2020-05-14 Thread Méven Car
meven added a comment. Fix and test coming REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28902 To: dfaure, meven Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28902: CopyJob: when stat'ing the dest, use StatBasic.

2020-05-14 Thread Méven Car
meven added a comment. In D28902#671260 , @ngraham wrote: > @dfaure git bisect says this caused https://bugs.kde.org/show_bug.cgi?id=421213. > > After fixing, maybe we should get a test for that use case? I see the issue, because we

D29634: sftp: break large writes into multiple requests

2020-05-14 Thread Méven Car
meven added a comment. In D29634#670485 , @feverfew wrote: > In D29634#670419 , @meven wrote: > > > In D29634#670377 , @ngraham wrote: > > > > > Nice

D29634: sftp: break large writes into multiple requests

2020-05-13 Thread Méven Car
meven added a comment. In D29634#670377 , @ngraham wrote: > Nice work. > > In D29634#670159 , @feverfew wrote: > > > I imagine something similar should be done for FileJob::write? > > >

D29526: Thumbnails: make thumbnail generation dpr-aware

2020-05-13 Thread Méven Car
meven added inline comments. INLINE COMMENTS > sitter wrote in thumbnail.cpp:774 > Var naming is a bit inconsistent across the code base now. In the > implementations there are maxWidth/H that are device-adjusted but in here > they are not. Not a huge concern, just noticed. Will take care >

D29634: sftp: break large writes into multiple requests

2020-05-13 Thread Méven Car
meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH release/20.04 REVISION DETAIL https://phabricator.kde.org/D29634 To: sitter, ngraham, meven Cc: meven, feverfew, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik,

D29708: Introduce EXCLUDE_DEPRECATED_BEFORE_AND_AT

2020-05-13 Thread Méven Car
meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Great stuff, this much less cleanup will be needed for KF6 ! INLINE COMMENTS > global.cpp:99 > > +#if KIOCORE_BUILD_DEPRECATED_SINCE(3, 4) > KIOCORE_EXPORT QTime

D29707: Remove deprecation tag from SlaveBase::config() for now

2020-05-13 Thread Méven Car
meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH removedeprecatetagfromslavebaseconfig REVISION DETAIL https://phabricator.kde.org/D29707 To: kossebau, #frameworks, meven, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack,

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

2020-05-13 Thread Méven Car
meven added inline comments. INLINE COMMENTS > kossebau wrote in slavebase.h:355 > Given there are still a few usages of config() left which seem not easily > replaceable, it would be better to remove the deprecation tag for the > compiler, to not have false warnings on those places (see e.g.

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-13 Thread Méven Car
meven added inline comments. INLINE COMMENTS > kpluginselector.cpp:855 > +} > +KCModuleProxy *currentModuleProxy = new > KCModuleProxy(moduleInfo, moduleProxyParentWidget, arguments); > if (currentModuleProxy->realModule()) { Adding a fileName field to

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-13 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29397 To: meven, dfaure, broulik, #frameworks Cc: kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-13 Thread Méven Car
meven updated this revision to Diff 82709. meven added a comment. Ensure to load images with the right devicePixelRatio REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29397?vs=82339=82709 BRANCH preview-dpr REVISION DETAIL

D29634: sftp: break large writes into multiple requests

2020-05-13 Thread Méven Car
meven added a comment. Well apart from the length of data needed to be reduced as we progress, all this makes sense. Btw gvfs uses 32768 as MAX_BUFFER_SIZE for sftp https://gitlab.gnome.org/GNOME/gvfs/-/blob/master/daemon/gvfsbackendsftp.c#L94 REPOSITORY R320 KIO Extras REVISION

D29634: sftp: break large writes into multiple requests

2020-05-12 Thread Méven Car
meven added inline comments. INLINE COMMENTS > feverfew wrote in kio_sftp.cpp:1831-1832 > AFAICT the size of the buffer never changes so this will easily cause a > buffer overrun if I'm not mistaken? > > Say for example you have a buffer with `buffer.size() == MAX_XFER_BUF_SIZE + > 1`. Then

D29634: sftp: break large writes into multiple requests

2020-05-12 Thread Méven Car
meven requested changes to this revision. meven added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kio_sftp.cpp:58 > // you will overflow the 2 byte size variable in a sftp packet. > +// FIXME: this seems too large > +// from the RFC: > +// The maximum

D27203: Don't try to open files we can't figure out where they are

2020-05-11 Thread Méven Car
meven accepted this revision. meven added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:226 > +//passing non-local files as the working directory is not supported. > +//See QFileDialogPrivate::initialSelections > +

D18883: Add PDF thumbnailer

2020-05-11 Thread Méven Car
meven added a comment. In D18883#424888 , @aacid wrote: > Also do we have a way to limit thumbnailers to run say for X seconds? There's some files in which poppler will run "forever" kio-extras thumbnail is a an ioslave so I guess we can

D26066: [KProcessInfo] Add parent PID

2020-05-11 Thread Méven Car
meven added subscribers: dfaure, meven. meven added a comment. In D26066#598036 , @broulik wrote: > Am now using ksysguard.. I think this would makes sense, and is a nice addition to `KProcessInfo`. @dfaure an opinion ? REPOSITORY

D28460: Add KCModuleData as base class for plugin

2020-05-11 Thread Méven Car
meven added inline comments. INLINE COMMENTS > kcmoduledata.h:35 > + * > + * @since 5.70 > + */ @since 5.71 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28460 To: bport, #plasma, ervin Cc: meven, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D28460: Add KCModuleData as base class for plugin

2020-05-11 Thread Méven Car
meven added inline comments. INLINE COMMENTS > kcmoduleloader.h:113 > + * > + * @since 5.69 > + */ @since 5.71 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28460 To: bport, #plasma, ervin Cc: meven, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D28033: Create ExpandableListItem

2020-05-10 Thread Méven Car
meven added a comment. Great consistency work ! CC @niccolove REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma, davidedmundson Cc: meven, dfaure, mart, davidedmundson, bruns, niccolove, cblack, davidre,

D18380: KIO: make file dialog columns resizable again (and movable)

2020-05-10 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18380 To: rjvbb, ngraham, #frameworks, #dolphin, apol, dfaure, ahartmetz, markg Cc: markg, cfeck, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

  1   2   3   4   5   6   7   8   9   10   >