D20766: Use appropriate background color for text previews

2019-11-14 Thread Méven Car
meven added a comment. I believe the issue currently is that for text files or files without associated definition we end up with an invalid definition that prevents SyntaxHighlighter::setDefinition to call rehighlight(). QTextDocument uses then whatever it get from the theme I guess.

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

2019-11-14 Thread Méven Car
meven created this revision. meven added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY This was a unix only function in the shared file protocol cpp This has not

D22801: [KIO] silence a QFileInfo warning

2019-11-14 Thread Méven Car
meven added a subscriber: dfaure. meven added a comment. In D22801#561989 , @rjvbb wrote: > Are you not seeing these for instance when browsing an MSWin share in Dolphin (with the same or newer versions of kio-extras, Samba and MSWin)?ç

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-11-14 Thread Méven Car
meven marked 5 inline comments as done. meven added a comment. friendly ping Is https://phabricator.kde.org/D25010#inline-142132 satisfactory ? I think names are now explicit enough. I still wonder if the granularity level is enough. REPOSITORY R241 KIO REVISION DETAIL

D25117: file ioslave: stop copying as soon as the ioslave is killed

2019-11-14 Thread Méven Car
meven added a comment. Anyone to review this ? 30 lines change + test REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25117 To: meven, #frameworks, dfaure, ngraham, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

2019-11-14 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R241:80d5f52b0675: [DeleteJob] Use a separate worker thread to run actual IO operation (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D22801: [KIO] silence a QFileInfo warning

2019-11-13 Thread Méven Car
meven added a comment. The issue could be as well located in previewjob.cpp. Could you debug why KMountPoint::List::findByPath is called with an empty string or non-existing file. We might want to prevent this to happen instead. REPOSITORY R241 KIO REVISION DETAIL

D10702: Always use a job to delete files to avoid freezing process waiting on IO

2019-11-12 Thread Méven Car
meven abandoned this revision. meven added a comment. Abandoned in favor of D24962 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks, dfaure, ngraham, #dolphin, jtamate Cc: kde-frameworks-devel, jtamate,

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

2019-11-11 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R320:49440c0cbea1: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D24433: Move URL parsing methods from kioslave to query object

2019-11-11 Thread Méven Car
meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me. Tested and works REPOSITORY R293 Baloo BRANCH extend_query_url REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven, ngraham, astippich

D24433: Move URL parsing methods from kioslave to query object

2019-11-11 Thread Méven Car
meven added a reviewer: astippich. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven, ngraham, astippich Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,

D24433: Move URL parsing methods from kioslave to query object

2019-11-11 Thread Méven Car
meven added a reviewer: ngraham. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven, ngraham Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

2019-11-11 Thread Méven Car
meven marked 3 inline comments as done. meven added inline comments. INLINE COMMENTS > file_unix.cpp:266 > #ifdef USE_SENDFILE > -bool use_sendfile = buff_src.st_size < 0x7FFF; > +bool use_sendfile = true; > #endif This prevented using sendfile for file bigger than 2 GB. Our code

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

2019-11-11 Thread Méven Car
meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25117: file ioslave: stop copying as soon as the ioslave is killed

2019-11-09 Thread Méven Car
meven added a reviewer: apol. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25117 To: meven, #frameworks, dfaure, ngraham, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25221: Add OBS to screenrecorders

2019-11-08 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R304:d9258f219328: Add OBS to screenrecorders (authored by meven). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25221?vs=69478=69498#toc REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R304:cdafed6b395f: Fix a couple of broken links, update links to https://kde.org/applications/ (authored by meven). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D25221: Add OBS to screenrecorders

2019-11-08 Thread Méven Car
meven updated this revision to Diff 69478. meven marked an inline comment as done. meven added a comment. Remove translations REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25221?vs=69476=69478 BRANCH obs-branch REVISION DETAIL

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Méven Car
meven added a comment. In D25215#560229 , @ngraham wrote: > In an ideal world the OBS stuff would be in a separate patch. :) Done. I interpreted "While you're touching this stuff" wrongly. REPOSITORY R304 KNewStuff BRANCH

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Méven Car
meven updated this revision to Diff 69477. meven added a comment. Split obs changes to D25221 REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25215?vs=69474=69477 BRANCH arcpatch-D25215 REVISION DETAIL

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R304 KNewStuff BRANCH arcpatch-D25215 REVISION DETAIL https://phabricator.kde.org/D25215 To: meven, leinir, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Méven Car
meven retitled this revision from "Fix a couple of broken links, update links to https://kde.org/applications/, add obs" to "Fix a couple of broken links, update links to https://kde.org/applications/;. REPOSITORY R304 KNewStuff BRANCH arcpatch-D25215 REVISION DETAIL

D25221: Add OBS to screenrecorders

2019-11-08 Thread Méven Car
meven created this revision. meven added reviewers: leinir, ngraham. meven added a project: Frameworks. meven requested review of this revision. REVISION SUMMARY BUG: 412320 FIXED-IN: 5.65 TEST PLAN Spectacle > Tools > More REPOSITORY R304 KNewStuff BRANCH obs-branch REVISION

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

2019-11-08 Thread Méven Car
meven updated this revision to Diff 69474. meven added a comment. rebasing on master REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25215?vs=69473=69474 BRANCH arcpatch-D25215 REVISION DETAIL https://phabricator.kde.org/D25215 AFFECTED FILES

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

2019-11-08 Thread Méven Car
meven updated this revision to Diff 69473. meven added a comment. rebase on master REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25215?vs=69470=69473 BRANCH arcpatch-D25215 REVISION DETAIL https://phabricator.kde.org/D25215 AFFECTED FILES

D25216: Fix translations of $GenericName

2019-11-08 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R304:91f212f983ef: Fix translations of $GenericName (authored by meven). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25216?vs=69461=69472 REVISION DETAIL

D25216: Fix translations of $GenericName

2019-11-08 Thread Méven Car
meven added a comment. In D25216#560212 , @aspotashev wrote: > LGTM since it fixes the issue. > > A next step could be a clearer explaination of what $GenericName will be replaced with. Is it always replaced with Filelight's GenericName

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

2019-11-08 Thread Méven Car
meven updated this revision to Diff 69470. meven added a comment. Reapply some lost changes REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25215?vs=69469=69470 BRANCH arcpatch-D25215_1 REVISION DETAIL https://phabricator.kde.org/D25215 AFFECTED

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

2019-11-08 Thread Méven Car
meven updated this revision to Diff 69469. meven added a comment. Add OBS entry to screenrecorders REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25215?vs=69460=69469 BRANCH arcpatch-D25215_1 REVISION DETAIL https://phabricator.kde.org/D25215

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

2019-11-08 Thread Méven Car
meven retitled this revision from "Fix a couple of broken links, update links to https://kde.org/applications/; to "Fix a couple of broken links, update links to https://kde.org/applications/, add obs". meven edited the summary of this revision. REPOSITORY R304 KNewStuff BRANCH

D25216: Fix translations of $GenericName

2019-11-08 Thread Méven Car
meven added a comment. @aspotashev Is it good for ? REPOSITORY R304 KNewStuff BRANCH arcpatch-D25216 REVISION DETAIL https://phabricator.kde.org/D25216 To: meven, leinir, ngraham, #localization Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

2019-11-08 Thread Méven Car
meven updated this revision to Diff 69461. meven added a comment. Better translator-friendly implementation REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25216?vs=69453=69461 BRANCH arcpatch-D25216 REVISION DETAIL

D25216: Fix translations of $GenericName

2019-11-08 Thread Méven Car
meven added a comment. In D25216#560122 , @aspotashev wrote: > I suggest a more flexible approach which allows translators to more around the "$GenericName" part inside their translation and change the " - " separator to anything more

D25117: file ioslave: stop copying as soon as the ioslave is killed

2019-11-08 Thread Méven Car
meven added a reviewer: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25117 To: meven, #frameworks, dfaure, ngraham Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Méven Car
meven updated this revision to Diff 69460. meven added a comment. Replace remaning kde project links to https://kde.org/applications/ REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25215?vs=69457=69460 BRANCH arcpatch-D25215 REVISION DETAIL

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Méven Car
meven updated this revision to Diff 69457. meven marked an inline comment as done. meven added a comment. amend comment REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25215?vs=69456=69457 BRANCH arcpatch-D25215 REVISION DETAIL

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Méven Car
meven retitled this revision from "Fix a couple of broken links" to "Fix a couple of broken links, update links to https://kde.org/applications/;. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25215 To: meven, leinir, ngraham Cc: ngraham, kde-frameworks-devel,

D25215: Fix a couple of broken links

2019-11-08 Thread Méven Car
meven updated this revision to Diff 69456. meven added a comment. Fix kdf link and update others REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25215?vs=69447=69456 BRANCH arcpatch-D25215 REVISION DETAIL https://phabricator.kde.org/D25215 AFFECTED

D25215: Fix a couple of broken links

2019-11-08 Thread Méven Car
meven added a comment. In D25215#560047 , @ngraham wrote: > We should use the kde.org/applications links, e.g. https://kde.org/applications/system/org.kde.kdf, not https://utils.kde.org/projects/kdf I did not find this url, thanks

D25216: Fix translations of $GenericName

2019-11-08 Thread Méven Car
meven updated this revision to Diff 69453. meven added a comment. Amend comment REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25216?vs=69452=69453 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25216 AFFECTED FILES

D25216: Fix translations of $GenericName

2019-11-08 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25216 To: meven, leinir, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

2019-11-08 Thread Méven Car
meven created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY $GenericName was translated before being passed to KMoreToolsService::formatString, causing translators to process

D25216: Fix translations of $GenericName

2019-11-08 Thread Méven Car
meven added reviewers: leinir, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25216 To: meven, leinir, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25215: Fix a couple of broken links

2019-11-08 Thread Méven Car
meven created this revision. meven added a reviewer: leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D25215 AFFECTED

D25117: file ioslave: stop copying as soon as the ioslave is killed

2019-11-08 Thread Méven Car
meven added a comment. friendly ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25117 To: meven, #frameworks, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-11-07 Thread Méven Car
meven added a comment. I feel the code is ready for review toward merging. INLINE COMMENTS > global.h:321 > +/// Filename, access, type, size, linkdest > +StatBasic = 0x1, > +/// uid, gid Naming should be explicit enough now. I still wonder about granularity if I should expose

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-11-07 Thread Méven Car
meven updated this revision to Diff 69385. meven marked an inline comment as done. meven added a comment. Add Stat prefix to enum values of KIO::StatDetail REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=69261=69385 BRANCH arcpatch-D25010 REVISION

D25164: MobileTextActionsToolBar check if controlRoot is undefined before using it

2019-11-06 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R242:22b66892: MobileTextActionsToolBar check if controlRoot is undefined before using it (authored by meven). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D25164: MobileTextActionsToolBar check if controlRoot is undefined before using it

2019-11-06 Thread Méven Car
meven created this revision. meven added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Prevents warning such as

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

2019-11-06 Thread Méven Car
meven added inline comments. INLINE COMMENTS > deletejob.cpp:130 > +/// Callback of worker rmfile > +void rmFileResult(bool result, bool isLink); > +/// Callback of worker rmdir Now we are at it, isLink could become m_curentURLIsLink, but isLink being a bool, it is much cheaper to

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

2019-11-06 Thread Méven Car
meven updated this revision to Diff 69332. meven marked 4 inline comments as done. meven added a comment. Use m_current instead of passing const QUrl around REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24962?vs=68946=69332 BRANCH arcpatch-D24962

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

2019-11-06 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D24962 REVISION DETAIL https://phabricator.kde.org/D24962 To: meven, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-11-04 Thread Méven Car
meven updated this revision to Diff 69261. meven added a comment. Move KIO::StatJob::StatDetail(s) to KIO::StatDetail(s), wrapped old details metadata code path with KIOCORE_ENABLE_DEPRECATED_SINCE REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25117: file ioslave: stop copying as soon as the ioslave is killed

2019-11-03 Thread Méven Car
meven updated this revision to Diff 69208. meven added a comment. Fix test JobTest::cancelCopyAndCleanDest REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25117?vs=69204=69208 BRANCH better-kill REVISION DETAIL https://phabricator.kde.org/D25117 AFFECTED

D25113: ftp ioslave: remove redundant variable

2019-11-03 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R241:d03551cd0367: ftp ioslave: remove redundant variable (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25113?vs=69180=69205 REVISION DETAIL

D25117: file ioslave: stop copying as soon as the ioslave is killed

2019-11-03 Thread Méven Car
meven updated this revision to Diff 69204. meven marked an inline comment as done. meven added a comment. Better safe than sorry, keep the doKill override REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25117?vs=69187=69204 BRANCH better-kill REVISION

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

2019-11-02 Thread Méven Car
meven added inline comments. INLINE COMMENTS > dfaure wrote in deletejob.cpp:67 > Seems negligible to me. If you remove the argument, you'll have to > "reconstruct" the URL from files.first()/symlinks.first()? Or [ab]use > m_currentURL? > The "no premature optimization" rule says: don't change

D25117: file ioslave: stop copying as soon as the ioslave is killed

2019-11-02 Thread Méven Car
meven created this revision. meven added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Previously when cancelling a copy the ioslave would continue. The file copy

T11627: Improve KIO asynchronicity

2019-11-02 Thread Méven Car
meven added a revision: D24962: [DeleteJob] Use a separate worker thread to run actual IO operation. TASK DETAIL https://phabricator.kde.org/T11627 To: meven Cc: broulik, ognarb, #dolphin, #frameworks, meven, dfaure, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2,

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

2019-11-02 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D24962 REVISION DETAIL https://phabricator.kde.org/D24962 To: meven, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

2019-11-02 Thread Méven Car
meven added a task: T11627: Improve KIO asynchronicity. REPOSITORY R241 KIO BRANCH arcpatch-D24962 REVISION DETAIL https://phabricator.kde.org/D24962 To: meven, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

2019-11-02 Thread Méven Car
meven added a reviewer: Frameworks. REPOSITORY R241 KIO BRANCH arcpatch-D24962 REVISION DETAIL https://phabricator.kde.org/D24962 To: meven, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T11627: Improve KIO asynchronicity

2019-11-02 Thread Méven Car
meven added a revision: D25079: [CopyJob] Increase the amount of data sendfile can copy at once. TASK DETAIL https://phabricator.kde.org/T11627 To: meven Cc: broulik, ognarb, #dolphin, #frameworks, meven, dfaure, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2,

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

2019-11-02 Thread Méven Car
meven added a task: T11627: Improve KIO asynchronicity. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-11-02 Thread Méven Car
meven updated this revision to Diff 69181. meven added a comment. Allow retro-compatibility with old details both ways : old kio or old app, update comments to ready patch for KF 5.65 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=69023=69181 BRANCH

D25113: ftp ioslave: remove redundant variable

2019-11-02 Thread Méven Car
meven created this revision. meven added reviewers: Frameworks, kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. TEST PLAN builds REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D25039: Fix Clazy performance issues, const

2019-11-02 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R241:f2a3a78972b2: Fix Clazy performance issues, const (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25039?vs=69178=69179 REVISION DETAIL

D25039: Fix Clazy performance issues, const

2019-11-02 Thread Méven Car
meven updated this revision to Diff 69178. meven added a comment. Rebasing on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25039?vs=69121=69178 BRANCH arcpatch-D25039 REVISION DETAIL https://phabricator.kde.org/D25039 AFFECTED FILES

D25039: Fix Clazy performance issues, const

2019-11-01 Thread Méven Car
meven added a comment. In D25039#557579 , @kossebau wrote: > Not tested, only read code. Looks good to me. > Please remove the newInstance method in a direct commit before, and drop change from this patch. (If you prefer, can do the remove

D25039: Fix Clazy performance issues, const

2019-10-31 Thread Méven Car
meven updated this revision to Diff 69121. meven marked 7 inline comments as done. meven added a comment. Review feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25039?vs=69083=69121 BRANCH arcpatch-D25039 REVISION DETAIL

D25088: Use X-KDE-NoGlobalShortcut instead of NoDisplay to store that a component is disabled

2019-10-31 Thread Méven Car
meven added inline comments. INLINE COMMENTS > davidedmundson wrote in kserviceactioncomponent.cpp:36 > I don't think I follow. > > We're editing the .desktop file inside > {XDG_DATA_DIRS}/kglobalaccel/someName.desktop > The menu only reads from XDG_DATA_DIRS/applications/someName.desktop > >

D25088: Use X-KDE-NoGlobalShortcut instead of NoDisplay to store that a component is disabled

2019-10-31 Thread Méven Car
meven created this revision. meven added reviewers: Plasma, broulik, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Needed to allow apps to not be visible in menus but have shortcuts (i.e

D25003: [KDesktopFile] Add a property and propertyKde functions to access custom properties

2019-10-31 Thread Méven Car
meven abandoned this revision. meven added a comment. In D25003#557100 , @broulik wrote: > `KDesktopFile::desktopGroup()` just gives you a `KConfigGroup` of the ´[Desktop Entry]` section at which point you can read whatever you want

D25003: [KDesktopFile] Add a property and propertyKde functions to access custom properties

2019-10-31 Thread Méven Car
meven added a comment. In D25003#555366 , @apol wrote: > Hi Meven, I guess I didn't make myself clear, sorry about that. This is not what I meant. > > What I meant was here D24956 you can query the

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

2019-10-31 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-10-31 Thread Méven Car
meven planned changes to this revision. meven added a comment. I don't expect this to make to KF5.64, will update the @since and all. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n,

D25039: Fix Clazy performance issues, const

2019-10-31 Thread Méven Car
meven added a comment. In D25039#557004 , @anthonyfieroni wrote: > Not using references is not a big problem with QString nor QUrl since they are reference counting objects, say if you don't change their content they are immutable, so > >

D25039: Fix Clazy performance issues, const

2019-10-31 Thread Méven Car
meven updated this revision to Diff 69083. meven edited the summary of this revision. meven added a comment. amend commit message REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25039?vs=69082=69083 BRANCH arcpatch-D25039 REVISION DETAIL

D25039: Fix Clazy performance issues, const

2019-10-31 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25039 To: meven, #frameworks, dfaure Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25039: Fix Clazy performance issues, const

2019-10-31 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25039 To: meven, #frameworks, dfaure Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25039: Fix Clazy performance issues, const

2019-10-31 Thread Méven Car
meven updated this revision to Diff 69082. meven edited the summary of this revision. meven added a comment. amend commit message REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25039?vs=69081=69082 BRANCH arcpatch-D25039 REVISION DETAIL

D25039: Fix Clazy performance issues, const

2019-10-31 Thread Méven Car
meven retitled this revision from "Fix Clazy performance issues, const &, noexcept" to "Fix Clazy performance issues, const &". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25039 To: meven, #frameworks, dfaure Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2,

D25039: Fix Clazy performance issues, const &, noexcept

2019-10-31 Thread Méven Car
meven updated this revision to Diff 69081. meven marked 5 inline comments as done. meven added a comment. Remove noexcept changes, avoid touching kpac, some code formatting REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25039?vs=68955=69081 BRANCH

D25039: Fix Clazy performance issues, const &, noexcept

2019-10-30 Thread Méven Car
meven marked 2 inline comments as done. meven added a comment. If somebody could accept this before KF 5.64 tagging, it would to modify `SlaveBase::configValue` signature that were added for the same value. I don't think any of this is subject to much concern. I may commit it without

T11627: Improve KIO asynchronicity

2019-10-30 Thread Méven Car
meven added a comment. @dfaure I think that ioslave suffer from the same kind of issue DeleteJob has : it freezes because of I/O. I believe it is the origin lag in such cases as https://bugs.kde.org/show_bug.cgi?id=342056 especially on slow I/O operation like move/copy. I don't get

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

2019-10-30 Thread Méven Car
meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > file_unix.cpp:58 > +// Defaults to 5MB so the user can follow copy progress > +#define SENDFILE_CHUNK_SIZE (5 * 1024 * 1024) > #endif I have reduced the value to 5 MB so that users can still follow progress,

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

2019-10-30 Thread Méven Car
meven updated this revision to Diff 69075. meven added a comment. Limit sendfile chunk size to 5MB so that users can still follow progress while enjoying faster copy REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25079?vs=69065=69075 BRANCH master

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

2019-10-30 Thread Méven Car
meven added a comment. In D25079#556824 , @ahmadsamir wrote: > Hopefully may fix https://bugs.kde.org/show_bug.cgi?id=402276 The bug scope is rather large. But this will help and I suspect https://phabricator.kde.org/D23523 will too.

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

2019-10-30 Thread Méven Car
meven updated this revision to Diff 69065. meven added a comment. Update quote from man sendfile REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25079?vs=69064=69065 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25079 AFFECTED FILES

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

2019-10-30 Thread Méven Car
meven updated this revision to Diff 69064. meven added a comment. amend commit message REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25079?vs=69063=69064 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25079 AFFECTED FILES

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

2019-10-30 Thread Méven Car
meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

2019-10-30 Thread Méven Car
meven created this revision. meven added reviewers: dfaure, Frameworks, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY We had a bad value of 32,768 bytes to copy at once. But Linux

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-10-30 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-10-30 Thread Méven Car
meven updated this revision to Diff 69023. meven added a comment. Use StatDetail to reduce statx mask, support old details metadata in file ioslave, adding metadata statDetails for the new values REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-10-29 Thread Méven Car
meven planned changes to this revision. meven added a comment. In D25010#556237 , @dfaure wrote: > If you change the actual values being sent to kioslaves, then this breaks the "wire protocol". I.e. after upgrading KF5 on a live system,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-10-29 Thread Méven Car
meven updated this revision to Diff 69021. meven marked 3 inline comments as done. meven added a comment. Avoid using short and testFlag REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=68975=69021 BRANCH arcpatch-D25010 REVISION DETAIL

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

2019-10-29 Thread Méven Car
meven added inline comments. INLINE COMMENTS > dfaure wrote in deletejob.cpp:67 > "const bool" doesn't do anything in a signal, I suggest removing the const. I am hesitant to remove `const QUrl& url` from this signal, it could save some space in message passing. REPOSITORY R241 KIO BRANCH

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

2019-10-29 Thread Méven Car
meven abandoned this revision. meven added a comment. See D25010 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24999 To: meven, #frameworks, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-10-29 Thread Méven Car
meven retitled this revision from "[StatJob] Use A QFlag to specify the details returned by statJob" to "[StatJob] Use A QFlag to specify the details returned by StatJob". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc:

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

2019-10-29 Thread Méven Car
meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

  1   2   3   4   5   6   7   8   9   10   >