meven added a comment.

  In D28745#674827 <https://phabricator.kde.org/D28745#674827>, @bruns wrote:
  
  > In D28745#674711 <https://phabricator.kde.org/D28745#674711>, @meven wrote:
  >
  > >
  >
  >
  >
  >
  > > Solid does not provide straight `folder => StorageVolume` yet, but I 
think Solid could have such a utility feature added.
  > >  Something like `Solid::Device::findByPath()`, it would need to 
canonically and recursively resolves the path parent to pay attention to 
symlinks.
  > >  This would also help D26407 <https://phabricator.kde.org/D26407>
  >
  > No recursion needed, `stat` provides the device.
  
  
  Only when the file is not a symlink, if so we need to check the symlink 
target recursively, that's what I meant.
  
  > And can you please use arc to upload the patch - it is nearly impossible to 
do a review with the missing context
  
  Or pushing it to https://community.kde.org/Infrastructure/GitLab

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

Reply via email to