D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks, broulik
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks, broulik
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Works, thanks!

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks, broulik
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey marked 2 inline comments as done.
sharvey added a comment.


  Merge errors tracked down and eradicated.

INLINE COMMENTS

> ngraham wrote in kdiroperatordetailview.cpp:53
> Uh-oh :)

What is that? (finding it and killing it)

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks, broulik
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey updated this revision to Diff 32002.
sharvey added a comment.


  - Repairing merge error

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11993?vs=31992=32002

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp
  src/filewidgets/kdiroperatordetailview_p.h

To: sharvey, ngraham, dfaure, #frameworks, broulik
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> kdiroperatordetailview.cpp:53
>  
> +<<< HEAD
>  void KDirOperatorDetailView::setModel(QAbstractItemModel *model)

Uh-oh :)

> kdiroperatordetailview.cpp:71
> +===
> +>>> Remove unneeded resize code; ensure other columns fill to contents
>  bool KDirOperatorDetailView::setViewMode(KFile::FileView viewMode)

Uh-oh part II :)

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks, broulik
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey added a comment.


  Rebased (I think). Had to manually resolve a conflict. Hopefully it'll land 
now.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks, broulik
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey updated this revision to Diff 31992.
sharvey marked an inline comment as done.
sharvey added a comment.


  - Remove unneeded resize code; ensure other columns fill to contents
  - Remove leftover commented-out code; restore variable declaration

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11993?vs=31545=31992

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp
  src/filewidgets/kdiroperatordetailview_p.h

To: sharvey, ngraham, dfaure, #frameworks, broulik
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham added a comment.


  @sharvey, can you re-base this onto current master? It doesn't want to land.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks, broulik
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham added a comment.


  In D11993#244077 , @broulik wrote:
  
  > The only downside this has is that you can no longer resize the column 
wider manually but then you might as well resize the window and actually 
//see// more :)
  
  
  Precisely! :)

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks, broulik
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  The only downside this has is that you can longer resize the column wider 
manually but then you might as well resize the window and actually //see// more 
:)

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks, broulik
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham added a comment.


  Any more opinions on this? As you can see from the Summary section, it fixes 
(or obviates) a //ton// of bugs, many of them very old.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham added a reviewer: Frameworks.
ngraham edited subscribers, added: Dolphin; removed: Frameworks.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: cfeck, fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: cfeck, fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: cfeck, fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham added a comment.


  In D11993#241607 , @cfeck wrote:
  
  > I vaguely remember there was some code to delay resizing of the columns 
until all items were loaded for performance reasons. Please check the commit 
history before deleting code.
  
  
  File history during the frameworks era: 
https://cgit.kde.org/kio.git/log/src/filewidgets/kdiroperatordetailview.cpp
  
  File history during the kdelibs era: 
https://cgit.kde.org/kdelibs.git/log/kfile/kdiroperatordetailview.cpp?h=Active/Two
  
  Here's the commit from 2007 that added most of the code we're proposing to 
remove: 
https://cgit.kde.org/kdelibs.git/commit/kfile/kdiroperatordetailview.cpp?h=Active/Two=32af0ab2db10e64933b10c2434727b883441c0cf
  
  Apparently the goal was to allow the columns to remain resizable before all 
the items had loaded. A bit of an odd goal, and I'm not able to reproduce the 
issue in my slow VM. Apparently hardware has become a bit faster in the past 11 
years. :)
  
  Of note: while digging, I found multiple commits that were attempting, 
unsuccessfully, to fix the problem that this patch fixes. It'll be nice to 
finally have it done. Overall, the spelunking expedition has made me more 
confident that this patch is sane.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: cfeck, fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Christoph Feck]

cfeck added a comment.


  I vaguely remember there was some code to delay resizing of the columns until 
all items were loaded for performance reasons. Please check the commit history 
before deleting code.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: cfeck, fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey marked 3 inline comments as done.
sharvey added inline comments.

INLINE COMMENTS

> ngraham wrote in kdiroperatordetailview_p.h:56
> Don't leave code commented out like this; if it's not used anymore, delete it!

Remnants of testing. Won't do that again.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey updated this revision to Diff 31545.
sharvey added a comment.


  - Remove leftover commented-out code; restore variable declaration

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11993?vs=31540=31545

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp
  src/filewidgets/kdiroperatordetailview_p.h

To: sharvey, ngraham, dfaure
Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham added a comment.


  Got a few code niggles, detailed below.
  
  Function-wise, this is a vast usability improvement. And in case you have a 
really excessively long file name, you can just use Tree view (the non-details 
version), which only has one column.

INLINE COMMENTS

> kdiroperatordetailview.cpp:35
>  
>  KDirOperatorDetailView::KDirOperatorDetailView(QWidget *parent) :
> +QTreeView(parent)

Oops, we shouldn't get rid of the initialization for both of these variables, 
just the one for `m_resizeColumns`. Remember to remove its definition in the 
header file, too.

> kdiroperatordetailview_p.h:56
>  void expandNameColumn();
> -
> +**/
>  private:

Don't leave code commented out like this; if it's not used anymore, delete it!

> kdiroperatordetailview_p.h:58
>  private:
>  bool m_resizeColumns;
>  bool m_hideDetailColumns;

We don't need this anymore.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey added a comment.


  Also, yes - Stretch has disabled the ability to manually resize the columns. 
Columns 1 & 2 are set to fit the size of their contents, while column 0 fills 
all the remaining space. Resizing the dialog results in only the Name column 
(column 0) to change size; the others stay fixed to the size of their contents.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey added a comment.


  All seems to be well with the removal of the extraneous resizing code.
  
  Here's the result of a test with a ridiculously long filename:
  F5796698: Screenshot_20180406_195204.png 

  
  I think that looks perfectly reasonable.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey updated this revision to Diff 31540.
sharvey added a comment.


  - Remove unneeded resize code; ensure other columns fill to contents

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11993?vs=31517=31540

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp
  src/filewidgets/kdiroperatordetailview_p.h

To: sharvey, ngraham, dfaure
Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey added a comment.


  I'll give that a test. I'm sure I can find a file (or make one up) with an 
absurdly long filename.
  
  Once I figure out why @ngraham's uploaded diff won't apply... grr.

REPOSITORY
  R241 KIO

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Fabian Kosmale]

fabiank added a comment.


  I'm to tired to test this myself, but could you please test this with the 
edge case where some file names are so long that they don't fit in the view? 
Also, Stretch disables manual resizing, right?' If that is also deemed useful, 
we could adapt the solution from 
https://centaurialpha.github.io/resize-qheaderview-to-contents-and-interactive. 
That's pyqt, but the same idea applies to C++. The resize event handling code 
is even already there, just needs to be adjusted.

REPOSITORY
  R241 KIO

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey added a comment.


  In the works...

REPOSITORY
  R241 KIO

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham added a comment.


  And while we're digging into this code, it would be quite nice to set 
`QHeaderView::ResizeToContents` for the other two columns so they always 
display the correct width and never have to be resized. That even fits under 
the umbrella of the patch's title "tweak column widths..."

REPOSITORY
  R241 KIO

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham added a comment.


  I wasn't able to find any regressions stemming from removing that code, and 
once gone, I was able to hack out even more code that seemed to exist purely in 
support of it. Here's a diff that applies on top of this patch: 
https://paste.kde.org/p9z7riqdo

REPOSITORY
  R241 KIO

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey added a comment.


  Give me a moment to comment it out again and re-check. I thought it was, but 
let me run another test.

REPOSITORY
  R241 KIO

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham added a comment.


  Question: is `expandNameColumn()` even needed anymore with this change?

REPOSITORY
  R241 KIO

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey marked an inline comment as done.
sharvey added a comment.


  In D11993#241387 , @ngraham wrote:
  
  > This patch is a breath of fresh air when using Detailed View or Detailed 
Tree View. You can resize the window and open and close the preview without 
wanting to kill something!
  
  
  Such passion over a file dialog :)

REPOSITORY
  R241 KIO

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  So. Much. Better. Now.
  
  This patch is a breath of fresh air when using Detailed View or Detailed Tree 
View. You can resize the window and open and close the preview without wanting 
to kill something!

REPOSITORY
  R241 KIO

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Kai Uwe Broulik]

broulik added a comment.


  Thanks for updating! I think this patch makes sense (and seems to work well) 
but I'm not too familiar with `QTreeView`, let's wait a bit for further 
feedback and merge it once Frameworks 5.45 has been tagged.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey marked an inline comment as done.
sharvey added inline comments.

INLINE COMMENTS

> broulik wrote in kdiroperatordetailview.cpp:103
> For first colum you want to set it to `0`, here it blew up the "Size" column 
> to full width

I got misled by my manual adjustment of the columns from previous tests. Thanks 
for catching.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey updated this revision to Diff 31517.
sharvey added a comment.


  - Fix incorrect column index

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11993?vs=31516=31517

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp

To: sharvey, ngraham, dfaure
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> kdiroperatordetailview.cpp:103
>  QHeaderView *headerView = header();
> -headerView->setSectionResizeMode(QHeaderView::Interactive);
> +headerView->setSectionResizeMode(1, QHeaderView::Stretch);
>  headerView->setStretchLastSection(false);

For first colum you want to set it to `0`, here it blew up the "Size" column to 
full width

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey added a comment.


  F5795938: Screenshot_20180406_145748.png 

  Before (from user bug report)
  
  F5795942: Screenshot_20180406_145619.png 

  After (mine)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey edited the summary of this revision.
sharvey added reviewers: ngraham, dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
sharvey requested review of this revision.

REVISION SUMMARY
  Adjust column sizing options so that "last" column is no longer the largest.
  First column (folder/file name & icon) will now occupy the majority of the 
space

TEST PLAN
  - Compile KIO with patch
  - Recompile an application (i.e. Kate), ensuring it will include the patched 
version of KIO
  - File -> Open (and/or File -> Save); select Detailed Tree View option
  - Check that Name column is the widest and occupies most of the space

REPOSITORY
  R241 KIO

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp

To: sharvey
Cc: #frameworks, michaelh, ngraham, bruns