D13124: [RFC] Add Share action to Dolphin context menu

[Nicolas Fella]

nicolasfella updated this revision to Diff 37052.
nicolasfella added a comment.


  - Rename to ShareFileItemAction

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13124?vs=36578=37052

BRANCH
  fiap

REVISION DETAIL
  https://phabricator.kde.org/D13124

AFFECTED FILES
  src/CMakeLists.txt
  src/fileitemactionplugin/CMakeLists.txt
  src/fileitemactionplugin/Messages.sh
  src/fileitemactionplugin/sharefileitemaction.cpp
  src/fileitemactionplugin/sharefileitemaction.h
  src/fileitemactionplugin/sharefileitemaction.json

To: nicolasfella, apol
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Aleix Pol Gonzalez]

apol added a comment.


  Looks good to me overall.
  
  Maybe it would make sense to call it ShareFileItemAction everywhere? 
"purpose" is an implementation detail here.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, apol
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Nicolas Fella]

nicolasfella added a comment.


  @apol ping?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, apol
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Elvis Angelaccio]

elvisangelaccio added a comment.


  +1, thanks!

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, apol
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Nicolas Fella]

nicolasfella added a comment.


  @apol As soon as we land this we have two ways of sharing with KDE Connect. 
Should we just remove the FileItemActionPlugin from KDE Connect? Are there more 
applications than Dolphin using FIAPs?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, apol
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Nicolas Fella]

nicolasfella marked 3 inline comments as done.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, apol
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Nicolas Fella]

nicolasfella updated this revision to Diff 36578.
nicolasfella added a comment.


  Use JSON metadata and install in kf5/fileitemaction namespace

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13124?vs=34934=36578

BRANCH
  fiap

REVISION DETAIL
  https://phabricator.kde.org/D13124

AFFECTED FILES
  src/CMakeLists.txt
  src/fileitemactionplugin/CMakeLists.txt
  src/fileitemactionplugin/Messages.sh
  src/fileitemactionplugin/sendfileitemaction.cpp
  src/fileitemactionplugin/sendfileitemaction.h
  src/fileitemactionplugin/sendfileitemaction.json

To: nicolasfella, apol
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> nicolasfella wrote in CMakeLists.txt:12-13
> Sorry, I don't quite understand what I am supposed to do

I recommend to use the `kcoreaddons_add_plugin` cmake macro. Something like 
this:

  kcoreaddons_add_plugin(purposefileitemaction
  SOURCES sendfileitemaction.cpp
  JSON sendfileitemaction.json
  INSTALL_NAMESPACE "kf5/kfileitemaction")

then drop both the `install()` calls. 
Also, the plugin should use `K_PLUGIN_FACTORY_WITH_JSON` rather than 
`K_PLUGIN_FACTORY`.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, apol
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in CMakeLists.txt:12-13
> Please consider using json metadata and installing the plugin into the 
> `kf5/kfileitemaction` namespace.

Sorry, I don't quite understand what I am supposed to do

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, apol
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Elvis Angelaccio]

elvisangelaccio removed a reviewer: Dolphin.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, apol, elvisangelaccio
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Elvis Angelaccio]

elvisangelaccio removed a reviewer: elvisangelaccio.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, apol
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> CMakeLists.txt:12-13
> +)
> +install(TARGETS purposefileitemaction DESTINATION ${PLUGIN_INSTALL_DIR})
> +install(FILES purposesendfile.desktop DESTINATION ${SERVICES_INSTALL_DIR})

Please consider using json metadata and installing the plugin into the 
`kf5/kfileitemaction` namespace.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, #dolphin, apol, elvisangelaccio
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Mark Gaiser]

markg added a comment.


  In D13124#272698 , @nicolasfella 
wrote:
  
  > Friendly ping?
  
  
  ?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, #dolphin, apol, elvisangelaccio
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Nicolas Fella]

nicolasfella added a comment.


  Friendly ping?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, #dolphin, apol, elvisangelaccio
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Nicolas Fella]

nicolasfella added a comment.


  In D13124#269655 , @broulik wrote:
  
  > I like yours better, I can abandon mine if you want to finish this :)
  
  
  I would have abandoned mine because you were first, but fine with me :)

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, #dolphin, apol, elvisangelaccio
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Nicolas Fella]

nicolasfella added a comment.


  In D13124#268906 , @broulik wrote:
  
  > Have you seen D12895 ?
  
  
  I looked for similar patches with the #dolphin 
 tag, but I didn't see yours

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, #dolphin, apol, elvisangelaccio
Cc: broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, 
#dolphin, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, 
bruns, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Kai Uwe Broulik]

broulik added a comment.


  Have you seen D12895 ?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, #dolphin, apol, elvisangelaccio
Cc: broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, 
#dolphin, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, 
bruns, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Nicolas Fella]

nicolasfella updated this revision to Diff 34934.
nicolasfella added a comment.


  - Set mimetype to */* if reported mimetype is empty

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13124?vs=34933=34934

BRANCH
  fiap

REVISION DETAIL
  https://phabricator.kde.org/D13124

AFFECTED FILES
  src/CMakeLists.txt
  src/fileitemactionplugin/CMakeLists.txt
  src/fileitemactionplugin/Messages.sh
  src/fileitemactionplugin/purposesendfile.desktop
  src/fileitemactionplugin/sendfileitemaction.cpp
  src/fileitemactionplugin/sendfileitemaction.h

To: nicolasfella, #dolphin, apol, elvisangelaccio
Cc: kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, 
michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, bruns, 
emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Nicolas Fella]

nicolasfella marked an inline comment as done.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, #dolphin, apol, elvisangelaccio
Cc: kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, 
michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, bruns, 
emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

[Nicolas Fella]

nicolasfella updated this revision to Diff 34933.
nicolasfella added a comment.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.


  Make it a FileItemActionPlugin

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13124?vs=34889=34933

BRANCH
  fiap

REVISION DETAIL
  https://phabricator.kde.org/D13124

AFFECTED FILES
  src/CMakeLists.txt
  src/fileitemactionplugin/CMakeLists.txt
  src/fileitemactionplugin/Messages.sh
  src/fileitemactionplugin/purposesendfile.desktop
  src/fileitemactionplugin/sendfileitemaction.cpp
  src/fileitemactionplugin/sendfileitemaction.h

To: nicolasfella, #dolphin, apol, elvisangelaccio
Cc: kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, 
michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, bruns, 
emmanuelp