D15718: Do not index the path if the path has no execute permissions.

smithjd abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15718 To: smithjd, ngraham, #baloo, ltoscano Cc: ltoscano, marten, bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D15718: Do not index the path if the path has no execute permissions.

smithjd added a comment. xattrs are no good for vaults because the xattr is ignored for the mountpoint, only restored when the volume is unmounted. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15718 To: smithjd, ngraham, #baloo, ltoscano Cc: ltoscano, marten, bruns

D15718: Do not index the path if the path has no execute permissions.

ngraham added a comment. So the goal is to be able to turn off indexing for certain files? Baloo already has a global toggle to stop indexing anything, and you can also add folders to the exclude lists. But stepping back even farther: //why// do we want to turn off indexing for cert

D15718: Do not index the path if the path has no execute permissions.

smithjd added a comment. > No, because even if the default umask is 002, or 022, POSIX says that the default permissions of a file on creation are going to be 0666, not 0777: Trial-and-error proven. :( In D15718#331449 , @ngraham wrote:

D15718: Do not index the path if the path has no execute permissions.

ngraham added a comment. Let's back up a bit. What's the goal here? What are you trying to accomplish? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15718 To: smithjd, ngraham, #baloo, ltoscano Cc: ltoscano, marten, bruns, ngraham, kde-frameworks-devel, #baloo, asha

D15718: Do not index the path if the path has no execute permissions.

smithjd added a comment. https://www.freedesktop.org/wiki/CommonExtendedAttributes suggests xattrs to use to store do-not-index information and also requires each file to be explicitly set to be indexed. > user.xdg.robots.index: On a file: "true" to index, "false" to not index. On a dir

D15718: Do not index the path if the path has no execute permissions.

ltoscano requested changes to this revision. ltoscano added a comment. I agree with all the objections raised so far, and I'm not sure about the rationale of this change. I'd like to add one point: In D15718#330844 , @smithjd wrote: > In D15

D15718: Do not index the path if the path has no execute permissions.

ngraham added a comment. The point is, we don't make changes to our software that break users, and then demand that users alter their own files to keep using the software. It's not an option--especially if the breakage results in the software basically not working at all (i.e. search no long

D15718: Do not index the path if the path has no execute permissions.

smithjd added a comment. In D15718#330864 , @ngraham wrote: > Making files executable that don't need to be executable is a bad security habit. What if the contents get replaced with something malicious? Suddenly that now-malicious file has exec

D15718: Do not index the path if the path has no execute permissions.

ngraham added a comment. Making files executable that don't need to be executable is a bad security habit. What if the contents get replaced with something malicious? Suddenly that now-malicious file has execute permissions. --- Conceptually, you are proposing that the rest of the w

D15718: Do not index the path if the path has no execute permissions.

smithjd added a comment. In D15718#330845 , @ngraham wrote: > In D15718#330844 , @smithjd wrote: > > > In D15718#330836 , @ngraham wrote: > > > > > Wou

D15718: Do not index the path if the path has no execute permissions.

ngraham added a comment. In D15718#330844 , @smithjd wrote: > In D15718#330836 , @ngraham wrote: > > > Wouldn't this have the effect of un-indexing most files? A quick check of my documents (text, w

D15718: Do not index the path if the path has no execute permissions.

smithjd added a comment. In D15718#330836 , @ngraham wrote: > Wouldn't this have the effect of un-indexing most files? A quick check of my documents (text, word processing, excel, etc) reveals that none of them have the execute bit set. As-is, I

D15718: Do not index the path if the path has no execute permissions.

ngraham requested changes to this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15718 To: smithjd, ngraham, #baloo Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D15718: Do not index the path if the path has no execute permissions.

bruns added a comment. This is completely wrong ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15718 To: smithjd, ngraham Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D15718: Do not index the path if the path has no execute permissions.

bruns added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15718 To: smithjd, ngraham, #baloo Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D15718: Do not index the path if the path has no execute permissions.

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Wouldn't this have the effect of un-indexing most files? A quick check of my documents (text, word processing, excel, etc) reveals that none of them have the execute bit set. As

D15718: Do not index the path if the path has no execute permissions.

smithjd added a comment. Files/folders should not be automatically indexed if the execute bit is unset. Downloads from most if not all popular browsers are not executable by default. Setting a file unexecutable would be used to prevent automatic indexing of files and most importantly pr

D15718: Do not index the path if the path has no execute permissions.

smithjd created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REVISION SUMMARY This will prevent automatic indexing of newly downloaded files and can be used to prevent indexing of Pl