/
---
(Updated Sept. 24, 2013, 1:39 p.m.)
Review request for KDE Frameworks.
Description
---
- find kcrash deps in kcrash/CMakeLists.txt
- fix kcrash dir in superbuild/CMakeLists.txt
Diffs
-
superbuild
/
---
(Updated Sept. 24, 2013, 2:19 p.m.)
Review request for KDE Frameworks.
Description
---
- find kcrash deps in kcrash/CMakeLists.txt
- fix kcrash dir in superbuild/CMakeLists.txt
Diffs
-
superbuild/CMakeLists.txt 2abe36a
tier2
.
Changes
---
Bring back kconfigwidgets in superbuild/CMakeLists.txt
Description
---
- find kcrash deps in kcrash/CMakeLists.txt
- fix kcrash dir in superbuild/CMakeLists.txt
Diffs (updated)
-
superbuild/CMakeLists.txt 2abe36a
tier2/kcrash/CMakeLists.txt 62ae2ba
Diff: http
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112495/#review39318
---
Ship it!
KCrash is tested by kde-runtime/drkonqi/tests
to be
changed with removing definitions, one line for find_dependency() etc...).
2) Why did you add Qt5::Gui to the link interface? As far as I can see it
does not need to be.
Because KCrash needs qwindowdefs.h, which is in QtGui and afaiu the link
interface is what sets include paths now, so without
On Sept. 4, 2013, 10:47 a.m., Stephen Kelly wrote:
staging/kcrash/CMakeLists.txt, line 12
http://git.reviewboard.kde.org/r/112495/diff/2/?file=186875#file186875line12
Why was this needed? Widgets already finds Qt5Gui.
Isn't it the other way around (Gui finds Widgets)? It was added
Martin Klapetek wrote:
On Sept. 4, 2013, 10:47 a.m., Stephen Kelly wrote:
staging/kcrash/CMakeLists.txt, line 12
http://git.reviewboard.kde.org/r/112495/diff/2/?file=186875#file186875line12
Why was this needed? Widgets already finds Qt5Gui.
Isn't it the other way around (Gui
the remove_definitions(..) from cmake, no code changes needed. KCrash
however has no tests, I'm not sure how to test it properly (if someone can give
me ideas, I'll try writing such tests).
Diffs
-
staging/CMakeLists.txt 3e4ec3a
staging/kcrash/CMakeLists.txt ce926ec
staging/kcrash
.
Description
---
Removes the remove_definitions(..) from cmake, no code changes needed. KCrash
however has no tests, I'm not sure how to test it properly (if someone can give
me ideas, I'll try writing such tests).
Diffs (updated)
-
staging/CMakeLists.txt 3e4ec3a
staging/kcrash
On Saturday 13 July 2013 13:32:51 Stefanie Dargel wrote:
unfortunally KCrash causes kdelibs-frameworks to fail for me when build from
scratch with kdesrc-build due to a cmake error:
CMake Error at
KDE/KF5/inst/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:10
8 (message): Could
Hi,
unfortunally KCrash causes kdelibs-frameworks to fail for me when build from
scratch with kdesrc-build due to a cmake error:
CMake Error at
KDE/KF5/inst/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:108
(message):
Could NOT find KF5 (missing: KCoreAddons KWindowSystem
marked as submitted.
Review request for KDE Frameworks.
Description
---
Create KCrash framework
Copy/Paste struct from klauncher_cmds to kcrash and rename it to avoid conflict
Diffs
-
kded/CMakeLists.txt 6283135
kdeui/CMakeLists.txt 35b4019
kdeui/util/config-strlcpy.h.cmake
://git.reviewboard.kde.org/r/111456/#comment26567
klauncer - klauncher
staging/kcrash/CMakeLists.txt
http://git.reviewboard.kde.org/r/111456/#comment26568
not set anymore - you can remove this line
- David Faure
On July 10, 2013, 7:02 p.m., Benjamin Port wrote
/
---
(Updated July 8, 2013, 9:32 p.m.)
Review request for KDE Frameworks.
Description
---
Create KCrash framework
Copy/Paste struct from klauncher_cmds to kcrash and rename it to avoid
conflict
Diffs
-
kded/CMakeLists.txt 6283135
kdeui
.
Changes
---
Fix issues
Description
---
Create KCrash framework
Copy/Paste struct from klauncher_cmds to kcrash and rename it to avoid conflict
Diffs (updated)
-
kded/CMakeLists.txt 6283135
kdeui/CMakeLists.txt c7dd8c2
kdeui/util/config-strlcpy.h.cmake
kdeui/util
.
Description
---
Create KCrash framework
Copy/Paste struct from klauncher_cmds to kcrash and rename it to avoid conflict
Diffs (updated)
-
kded/CMakeLists.txt 6283135
kdeui/CMakeLists.txt 35b4019
kdeui/util/config-strlcpy.h.cmake
kdeui/util/kcrash.h f0c92f8
kdeui/util
KCrash Q_COREAPP_STARTUP_FUNCTION porting was done I realized that
there is a method not called or implemented by anyone (it is not even exported)
in KCrash namespace.
Perhaps the intention was to rename kcrashInitialize to KCrash::setup ?
Diffs
-
kdeui/util/kcrash.cpp 0a41ae1
Diff: http
.)
Review request for KDE Frameworks.
Description
---
Checking how KCrash Q_COREAPP_STARTUP_FUNCTION porting was done I realized
that there is a method not called or implemented by anyone (it is not even
exported) in KCrash namespace.
Perhaps the intention was to rename
/
---
(Updated March 16, 2013, 12:54 p.m.)
Review request for KDE Frameworks.
Description
---
Checking how KCrash Q_COREAPP_STARTUP_FUNCTION porting was done I realized
that there is a method not called or implemented by anyone
marked as submitted.
Review request for KDE Frameworks.
Description
---
Checking how KCrash Q_COREAPP_STARTUP_FUNCTION porting was done I realized that
there is a method not called or implemented by anyone (it is not even exported)
in KCrash namespace.
Perhaps the intention was to rename
501 - 520 of 520 matches
Mail list logo
