D25638: autotests: Find perl executable on all platforms

This revision was automatically updated to reflect the committed changes. Closed by commit R172:accdbdd65ee0: autotests: Find perl executable on all platforms (authored by aspotashev). REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25638?vs=70636=70663

D25638: autotests: Find perl executable on all platforms

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I approve, given that I wrote the same in D25643 :-) REPOSITORY R172 KCalendar Core BRANCH perl REVISION DETAIL

D25638: autotests: Find perl executable on all platforms

aspotashev added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:93 > maybe it would make sense to check for BSD instead? > I don't know much about BSD, but I'd expect the shebang to work there as well. I think it's better to minimize platform-specific if-endifs and make CMake

D25638: autotests: Find perl executable on all platforms

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:93 > - set(_runner ${CMAKE_CURRENT_SOURCE_DIR}/runsingletestcase.pl) > - if(WIN32) > -set(_runner ${PERL_EXECUTABLE} ${_runner}) maybe it would make sense to check for BSD instead? I don't know much about BSD, but I'd expect the

D25638: autotests: Find perl executable on all platforms

aspotashev added a reviewer: Frameworks. aspotashev added a project: Frameworks. aspotashev added a subscriber: Frameworks. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D25638 To: aspotashev, #frameworks Cc: #frameworks, kde-pim, bcooksley, LeGast00n,

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

This revision was automatically updated to reflect the committed changes. Closed by commit R241:591cc2a16e3e: Treat application/x-ms-dos-executable as executable on all platforms (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks, ngraham, dfaure Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n,

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe marked an inline comment as done. guoyunhe added inline comments. INLINE COMMENTS > dfaure wrote in krun.cpp:1101 > should this be in ifdef Q_OS_WIN? > > On windows, *.exe is executed, not opened (with e.g. wine) Yes, I updated this part. REPOSITORY R241 KIO REVISION DETAIL

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe updated this revision to Diff 67761. guoyunhe added a comment. *.exe should be normal executable in Windows REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24463?vs=67458=67761 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krun.cpp:1101 > +return ExecutableFileOpenDialog::OpenOrExecute; > +} else if >

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

GB_2 added inline comments. INLINE COMMENTS > ppeter wrote in executablefileopendialog.cpp:58 > if (mode == OnlyExecute) > connect(executeButton, ...) > else if (mode == OpenAsExecute) > ... > > looks better :) That would be against the common KDE coding style:

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

ppeter added inline comments. INLINE COMMENTS > executablefileopendialog.cpp:58 > + > +if (mode == OnlyExecute) { > +connect(executeButton, ::clicked, > [=]{done(ExecuteFile);}); if (mode == OnlyExecute) connect(executeButton, ...) else if (mode == OpenAsExecute) ...

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe edited the summary of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks, ngraham, dfaure Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe retitled this revision from "WIP: Treat "application/x-ms-dos-executable" as executable on all platforms" to "Treat "application/x-ms-dos-executable" as executable on all platforms". guoyunhe edited the summary of this revision. REPOSITORY R2

D24463: WIP: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe added a comment. It is now working. The condition is so complex. Please help test this patch! F7541884: image.png REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks,

D24463: WIP: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe updated this revision to Diff 67458. guoyunhe added a comment. Fix *.exe execution condition REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24463?vs=67444=67458 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463 AFFECTED FILES

D24463: WIP: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe retitled this revision from "Treat "application/x-ms-dos-executable" as executable on all platforms" to "WIP: Treat "application/x-ms-dos-executable" as executable on all platforms". guoyunhe edited the summary of this revision. REPOSITORY R2

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe updated this revision to Diff 67444. guoyunhe added a comment. "openAsExecute" parameter for ExecutableFileOpenDialog REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24463?vs=67424=67444 BRANCH master REVISION DETAIL

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

ahmadsamir added a reviewer: dfaure. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks, ngraham, dfaure Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe added a comment. I just realized that this patch might be unfinished. In the pop up, you usually have "Open", "Execute" and "Cancel". But for *.exe, "Open" is actually to be executed by Wine? "Execute" will do nothing because it isn't a native executable for Linux/BSD. REPOSITORY

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

ngraham accepted this revision. ngraham added a subscriber: dfaure. ngraham added a comment. This revision is now accepted and ready to land. I suppose that's true. Would be nice to also do that as a follow-up patch. Shipit! @dfaure given the security implications here, maybe we

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe added a comment. In D24463#543070 , @ngraham wrote: > Maybe can we check to see if WINE is installed or if there's a handler for `application/x-ms-dos-executable`? Otherwise if you don't have WINE installed, won't you see a dialog that

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

ngraham added a comment. Maybe can we check to see if WINE is installed or if there's a handler for `application/x-ms-dos-executable`? Otherwise if you don't have WINE installed, won't you see a dialog that gives you the option to execute it when that doesn't work? REPOSITORY R241 KIO

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

broulik added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY Because of Wine, *.exe can be executed in almost all desktop platforms. BUG: 412694 REPOSITORY R241 KIO BRANCH

D22755: [platforms/xcb] Use XRES extension to get real window PID

This revision was automatically updated to reflect the committed changes. Closed by commit R278:b485043e5633: [platforms/xcb] Use XRES extension to get real window PID (authored by davidedmundson). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22755?vs

D22755: [platforms/xcb] Use XRES extension to get real window PID

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D22755 To: davidedmundson, zzag Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22755: [platforms/xcb] Use XRES extension to get real window PID

davidedmundson marked 2 inline comments as done. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D22755 To: davidedmundson Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22755: [platforms/xcb] Use XRES extension to get real window PID

=62588 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22755 AFFECTED FILES CMakeLists.txt src/platforms/xcb/CMakeLists.txt src/platforms/xcb/kwindowinfo.cpp src/platforms/xcb/kwindowinfo_p_x11.h To: davidedmundson Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh

D22755: [platforms/xcb] Use XRES extension to get real window PID

zzag added a comment. > Querying the NET_WM_ATOM with the NETWM classes remains unchanged _NET_WM_PID? INLINE COMMENTS > kwindowinfo.cpp:85 > +specs.mask = XCB_RES_CLIENT_ID_MASK_LOCAL_CLIENT_PID; > +auto cookie = xcb_res_query_client_ids(QX11Info::connection(), 1, > );

D22755: [platforms/xcb] Use XRES extension to get real window PID

KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D22755 AFFECTED FILES CMakeLists.txt src/platforms/xcb/CMakeLists.txt src/platforms/xcb/kwindowinfo.cpp src/platforms/xcb/kwindowinfo_p_x11.h To: davidedmundson Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh

D12557: [XCF/GIMP loader] Raise maximimum allowed image size to 32767x32767 on 64 bit platforms

This revision was automatically updated to reflect the committed changes. Closed by commit R287:19f33239e7a7: [XCF/GIMP loader] Raise maximimum allowed image size to 32767x32767 on 64 bit… (authored by cfeck). REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE

D12557: [XCF/GIMP loader] Raise maximimum allowed image size to 32767x32767 on 64 bit platforms

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D12557 To: cfeck, alexmerry, dfaure Cc: #frameworks, michaelh, bruns

D12557: [XCF/GIMP loader] Raise maximimum allowed image size to 32767x32767 on 64 bit platforms

cfeck created this revision. cfeck added a reviewer: alexmerry. cfeck added a project: Frameworks. Restricted Application added a subscriber: Frameworks. cfeck requested review of this revision. REVISION SUMMARY The GIMP image loader had a limit to 16K x 16K pixels, because this would already

[sysadmin/ci-tooling] helpers: Don't allow the dependency diagram data generation process to run on secondary platforms either.

Git commit 15c5d9a75f87ff5ac78fd8aff2824faa6fdaa349 by Ben Cooksley. Committed on 23/01/2018 at 07:41. Pushed by bcooksley into branch 'master'. Don't allow the dependency diagram data generation process to run on secondary platforms either. This runs into the same issue that the cmake

[sysadmin/ci-tooling] helpers: Ensure the cmake dependency metadata extraction process only runs for our primary platforms.

Git commit a603dc47b518eb1f6d94379f19345748ebd7fb3a by Ben Cooksley. Committed on 05/01/2018 at 10:37. Pushed by bcooksley into branch 'master'. Ensure the cmake dependency metadata extraction process only runs for our primary platforms. Frameworks had a slight issue here as it has both Qt 5.10

D9076: Have an application that can cross-check if the promised platforms are correct

This revision was automatically updated to reflect the committed changes. Closed by commit R857:235e202a1374: Have an application that can cross-check if the promised platforms are correct (authored by apol). REPOSITORY R857 CI System Tooling CHANGES SINCE LAST UPDATE https

D9076: Have an application that can cross-check if the promised platforms are correct

bcooksley accepted this revision. bcooksley added a comment. This revision is now accepted and ready to land. Perfect. Lets get this committed. REPOSITORY R857 CI System Tooling BRANCH master REVISION DETAIL https://phabricator.kde.org/D9076 To: apol, #frameworks, bcooksley Cc:

D9076: Have an application that can cross-check if the promised platforms are correct

rameworks metadata.yaml files) See line 29, if 'all' we replace it with the list of all the platforms we know. REPOSITORY R857 CI System Tooling REVISION DETAIL https://phabricator.kde.org/D9076 To: apol, #frameworks Cc: adridg, bcooksley, dfaure

D9076: Have an application that can cross-check if the promised platforms are correct

bcooksley added a comment. This can go in from my perspective, code looks fine from my understanding of it. In terms of 'All' as a platform, how is that handled? (assuming that's a valid specification in the Frameworks metadata.yaml files) REPOSITORY R857 CI System Tooling REVISION

D9076: Have an application that can cross-check if the promised platforms are correct

apol updated this revision to Diff 23784. apol added a comment. Wording, FreeBSDQt5.9 REPOSITORY R857 CI System Tooling CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9076?vs=23189=23784 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9076 AFFECTED FILES

D9076: Have an application that can cross-check if the promised platforms are correct

apol marked an inline comment as done. apol added a comment. In https://phabricator.kde.org/D9076#177399, @adridg wrote: > To understand the expected output better: suppose something says "platforms: All", like kcontacts. If there's no actual build configured in CI for t

D9076: Have an application that can cross-check if the promised platforms are correct

bcooksley added a comment. The FreeBSD platform name was changed this week yes. I can't see any explicit handling for 'All' being specified as a platform in the metainfo file here though, unless one is always required to list the platforms explicitly? REPOSITORY R857 CI System Tooling

D9076: Have an application that can cross-check if the promised platforms are correct

adridg added a comment. To understand the expected output better: suppose something says "platforms: All", like kcontacts. If there's no actual build configured in CI for that something, for FreeBSD, it will say "FreeBS is a disabled platform". The message can

D9076: Have an application that can cross-check if the promised platforms are correct

bcooksley added a comment. In principle I think this code is doing the right thing as it's comparing what's enabled on CI vs. what's enabled in the Framework's own metadata files. Any comments in that regard David? REPOSITORY R857 CI System Tooling REVISION DETAIL

D9076: Have an application that can cross-check if the promised platforms are correct

apol added a comment. > Cool stuff, but who will run this tool and when? `¯\_(ツ)_/¯` Exciting times, isn't it? My plan was to discuss with sysadmin where to deploy it once we agree it's something we want. Here, we basically need to agree that it's the right metric to move

D9076: Have an application that can cross-check if the promised platforms are correct

bcooksley added a comment. Neat. I'm curious as to where it'll be used as well, but otherwise it looks fine to me. REPOSITORY R857 CI System Tooling REVISION DETAIL https://phabricator.kde.org/D9076 To: apol, #frameworks Cc: bcooksley, dfaure

D9076: Have an application that can cross-check if the promised platforms are correct

dfaure added a comment. Cool stuff, but who will run this tool and when? REPOSITORY R857 CI System Tooling REVISION DETAIL https://phabricator.kde.org/D9076 To: apol, #frameworks Cc: dfaure

D9076: Have an application that can cross-check if the promised platforms are correct

apol created this revision. apol added a reviewer: Frameworks. REVISION SUMMARY In KDE Frameworks projects (and some others) we have a metainfo.yaml file that tells us which platforms it's supposed to work on. This is never checked other than by maintainers. This tool notifies us about

[sysadmin/ci-tooling] build-specs/Frameworks: Revoke test execution for extra-cmake-modules across all platforms.

Git commit 45ff1bc4ecb18ad71ad0570f7e838d1ae7cab2e2 by Ben Cooksley. Committed on 27/09/2017 at 09:04. Pushed by bcooksley into branch 'master'. Revoke test execution for extra-cmake-modules across all platforms. The tests in their current condition are incompatible with being run prior

Re: Review Request 128420: Name supported platforms in YAML file.

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit bcf4b0962d984be8720179b37d3c9c8ffaa15e84 by Andreas Cord-Landwehr to branch master. Repository: knotifications Description --- There are ifdefs for the platforms Windows and MacOSX, besides

Re: Review Request 128420: Name supported platforms in YAML file.

Updated July 10, 2016, 10:30 a.m.) > > > Review request for KDE Frameworks. > > > Repository: knotifications > > > Description > --- > > There are ifdefs for the platforms Windows and MacOSX, besides Linux. > Hence, it seems logical

Review Request 128420: Name supported platforms in YAML file.

Description --- There are ifdefs for the platforms Windows and MacOSX, besides Linux. Hence, it seems logical that all these three platforms are supported. Diffs - metainfo.yaml 397b3c168d274c0608efc8ba32409ac86d183472 Diff: https://git.reviewboard.kde.org/r/128420/diff/ Testing

Re: Review Request 128234: Name provided platforms

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 5146e2d0918abd22f3444b00cc88ab63b33e1067 by Andreas Cord-Landwehr to branch master. Repository: kded Description --- Specify provided platforms. This is only a guess, though. Currently

Re: Review Request 128235: Specify supported platforms

that it is a 3rd level tier and I hardly can imaging how it is useful at other platforms. Please correct me if more platforms are supported. Diffs - metainfo.yaml 3fe32b2cf6c258dd72052598bc67b1a53f22689f Diff: https://git.reviewboard.kde.org/r/128235/diff/ Testing --- Thanks, Andreas

Re: Review Request 128234: Name provided platforms

org/r/128234/ > --- > > (Updated June 23, 2016, 9:08 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kded > > > Description > --- > > Specify provided platforms. This is only a guess, though. Currently, wit

Re: Review Request 128235: Specify supported platforms

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128235/#review96848 --- Ship it! There's none now. Adding other platforms

Re: Review Request 128234: Name provided platforms

. Changes --- ping... Repository: kded Description (updated) --- Specify provided platforms. This is only a guess, though. Currently, with the platform value missing, all platforms are marked as supported. Diffs - metainfo.yaml cbc2c3bf2540d1a16ce5bb9b6325614029cbaa82 Diff

Re: Review Request 128235: Specify supported platforms

d Juni 18, 2016, 7:37 vorm.) > > > Review request for KDE Frameworks. > > > Repository: kcmutils > > > Description > --- > > Linux as only supported platform is a guess, coming from the fact that it is > a 3rd level tier and I hardly can imag

kded5 and "other platforms"

MacPorts on OS X. That's more or less a prerequisite if you want cookie support but also support for certificate management in KDE(4) applications. I also see even less reason to run that daemon than to run a DBus daemon on "other platforms". It's a KDE application that provides backg

Review Request 128235: Specify supported platforms

--- Linux as only supported platform is a guess, coming from the fact that it is a 3rd level tier and I hardly can imaging how it is useful at other platforms. Please correct me if more platforms are supported. Diffs - metainfo.yaml 3fe32b2cf6c258dd72052598bc67b1a53f22689f Diff: https

Review Request 128234: Name provided platforms

--- Specify provided platforms Diffs - metainfo.yaml cbc2c3bf2540d1a16ce5bb9b6325614029cbaa82 Diff: https://git.reviewboard.kde.org/r/128234/diff/ Testing --- Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 128196: Add Android to supported platforms

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128196/ --- (Updated June 16, 2016, 10:30 a.m.) Status -- This change has been

Re: Review Request 128196: Add Android to supported platforms

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128196/#review96539 --- Ship it! Ship It! - David Faure On June 15, 2016, 4:22

Review Request 128196: Add Android to supported platforms

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128196/ --- Review request for KDE Frameworks and Olivier Churlaud. Repository:

Spread to more platforms - Randa Meetings 2016 open for registration

Good morning everyone Please excuse this cross-posting but all the above mailing list fit quite well this year's topic of the Randa Meetings: multi-platform end-user application development. This includes stuff like improving KDE Frameworks 5 (KF5) on other platforms like MS Windows, Android

Re: Review Request 125070: Setup and install dbus interfaces for all platforms since dbus is a mandatory component.

gt; > Description > --- > > Setup and install dbus interfaces for all platforms since dbus is a mandatory > component. > > > Diffs > - > > src/api/KWallet/CMakeLists.txt 539b034d20a0e10ef7471bcc515b7b3885d617d6 > > Diff: https://git.reviewboa

Re: Review Request 125070: Setup and install dbus interfaces for all platforms since dbus is a mandatory component.

. Repository: kwallet Description --- Setup and install dbus interfaces for all platforms since dbus is a mandatory component. Diffs (updated) - src/api/KWallet/CMakeLists.txt 539b034d20a0e10ef7471bcc515b7b3885d617d6 Diff: https://git.reviewboard.kde.org/r/125070/diff/ Testing

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG. Diffs - autotests/kdelibs4configmigratortest.cpp 0affd2a6bc86f8e4cad04dd662e1298d34b1e7c1 Diff: https://git.reviewboard.kde.org/r/123588/diff/ Testing --- Still passes on Linux, we'll see

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

request for KDE Frameworks and Laurent Montel. Repository: kcoreaddons Description --- Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG. Diffs - autotests/kdelibs4configmigratortest.cpp

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

/ --- (Updated mai 2, 2015, 8:17 matin) Review request for KDE Frameworks and Laurent Montel. Repository: kcoreaddons Description --- Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG. Diffs - autotests

Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

: kcoreaddons Description --- Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG. Diffs - autotests/kdelibs4configmigratortest.cpp 0affd2a6bc86f8e4cad04dd662e1298d34b1e7c1 Diff: https://git.reviewboard.kde.org/r/123588/diff/ Testing

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

to QStandardPaths, so it works on other platforms than XDG. Diffs - autotests/kdelibs4configmigratortest.cpp 0affd2a6bc86f8e4cad04dd662e1298d34b1e7c1 Diff: https://git.reviewboard.kde.org/r/123588/diff/ Testing --- Still passes on Linux, we'll see if the CI says it fixed

Re: Review Request 122770: Support KWindowSystem::icon with NETWinInfo on all platforms

implementation on all platforms and not just on platform xcb. The NETWinInfo is already so X11 specific that the platform doesn't matter. To solve this the method it delegates to in KWindowSystemPrivateX11 is made static. It only operates through the NETWinInfo and doesn't need anything else from

Review Request 122770: Support KWindowSystem::icon with NETWinInfo on all platforms

Description --- If we compile with X11 support we want this method to use the X11 implementation on all platforms and not just on platform xcb. The NETWinInfo is already so X11 specific that the platform doesn't matter. To solve this the method it delegates to in KWindowSystemPrivateX11 is made static

platforms

Do we support building and using frameworks on Windows CE anymore? I don't see it on http://qt-project.org/doc/qt-4.8/supported-platforms.html so I guess not, is that correct? If not I can clean up some old ifdefs in knewstuff sources. thanks, Jeremy

Re: platforms

It can be cleaned up ... other WinCE specifics had already been cleaned up in frameworks. 2014-10-13 20:59 GMT-03:00 Jeremy Whiting jpwhit...@kde.org: Do we support building and using frameworks on Windows CE anymore? I don't see it on http://qt-project.org/doc/qt-4.8/supported-platforms.html

How to properly encode the supported platforms on api.kde.org?

Hi, I wanted to ask how the platforms on the overview of http://api.kde.org/frameworks-api/frameworks5-apidocs/ are supposed to be read. E.g. for kwindowsystem it looks like: * Linux supported * Windows not supported * MacOS X not supported This is only half of the story, though

Re: How to properly encode the supported platforms on api.kde.org?

On 22/05/14 08:21, Martin Gräßlin wrote: Hi, I wanted to ask how the platforms on the overview of http://api.kde.org/frameworks-api/frameworks5-apidocs/ are supposed to be read. E.g. for kwindowsystem it looks like: * Linux supported * Windows not supported * MacOS X not supported

Re: Allocating kde-runtime/platforms/win

On Thu, Feb 20, 2014 at 6:46 PM, Aleix Pol aleix...@kde.org wrote: Hi! I am going through the list of things where we're moving kde-runtime components to [1] and I see that there's a platform/win directory. Do you agree that having it in a separate repository would be the best? Could

Re: Allocating kde-runtime/platforms/win

On Monday 24 March 2014 19:01:14 Aleix Pol wrote: So if nobody disagrees, we'll split it out into a KWindowsAddons repository and hope somebody will find a use for it some day. No objection to have it as separate repository. Just to clarify though: won't be part of a KF5.0, afaict it's not

Re: Allocating kde-runtime/platforms/win

2014-02-21 1:17 GMT+01:00 Andrius da Costa Ribas andrius...@gmail.com: Afaik only Alexander Richardson is currently working on KF5 on Windows, but I think this kcm module is more related to plasma-workspace destination, given the settings it provides (see attached image) Em 20/02/2014 14:47,

Allocating kde-runtime/platforms/win

Hi! I am going through the list of things where we're moving kde-runtime components to [1] and I see that there's a platform/win directory. Do you agree that having it in a separate repository would be the best? Could anybody with a working KF5 + windows system (if that exists) work on it?

Re: Review Request 115289: Search for LibIntl, not all platforms include it in libc

and Chusslove Illich. Changes --- check whether libintl needs a separate library by using check_symbol_exists Summary (updated) - Search for LibIntl, not all platforms include it in libc Repository: ki18n Description (updated) --- Search for LibIntl, not all platforms

Re: Review Request 115289: Search for LibIntl, not all platforms include it in libc

.) Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- Search for LibIntl, not all platforms include it in libc This is required on e.g. Windows, but also any other system that does not use glibc as the default C library Fix linking

Re: Review Request 115289: Search for LibIntl, not all platforms include it in libc

marked as submitted. Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- Search for LibIntl, not all platforms include it in libc This is required on e.g. Windows, but also any other system that does not use glibc as the default C library Fix