[Diff] D4847: KAuth integration in document saving

2017-03-02 Thread Luigi Toscano
ltoscano added a comment. View Revision In D4847#91810, @martinkostolny wrote: This diff includes preserving owner and group when file is saved with elevated privileges. Actually loosing owner was (and is) already happening before my patch when user has the permission to write the file and is not

[Diff] D4847: KAuth integration in document saving

2017-03-02 Thread Martin Kostolný
martinkostolny updated this revision to Diff 12058.martinkostolny added a comment. View RevisionNext iteration, still without autotests, I need to study them more. This diff includes preserving owner and group when file is saved with elevated privileges. Actually loosing owner was (and is)

[Diff] D4847: KAuth integration in document saving

2017-03-02 Thread Martin Kostolný
martinkostolny marked 2 inline comments as done. View RevisionREPOSITORYR39 KTextEditorREVISION DETAILhttps://phabricator.kde.org/D4847EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: martinkostolny, dhaumann, KTextEditorCc: dhaumann, graesslin, davidedmundson,

[Diff] D4847: KAuth integration in document saving

2017-03-02 Thread Martin Kostolný
martinkostolny updated this revision to Diff 12054.martinkostolny added a comment. View RevisionThanks for all the feedback! I'm updating the diff to reflect most Dominik's points. I'll learn from them next time :). Anyway I was unable to remove the KAuth namespace. It doesn't work without it,