D11820: Handle properties with multiple values

2019-05-03 Thread Alexander Stippich
astippich abandoned this revision. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11820 To: astippich, #baloo, #frameworks, michaelh Cc: bruns, astippich, mgallien, elvisangelaccio, gennad, domson, ashaposhnikov, spoorun, abrahams

D11820: Handle properties with multiple values

2019-05-03 Thread Alexander Stippich
astippich commandeered this revision. astippich added a reviewer: michaelh. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11820 To: astippich, #baloo, #frameworks, michaelh Cc: bruns, astippich, mgallien, elvisangelaccio, gennad, domson, ashaposhnikov, spoorun,

D11820: Handle properties with multiple values

2018-04-15 Thread Michael Heidelbach
michaelh added a comment. Surprising! master F5808891: cur-noidx.png patch F5808893: patch.png REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11820 To: michaelh, #baloo,

D11820: Handle properties with multiple values

2018-04-15 Thread Alexander Stippich
astippich added a comment. Seems to work just fine, see screenshot: F5808864: Screenshot_20180415_181027.png I did a little bit more testing, and in case you didn't already know: It looks like baloo outputs properties with multiple values as a

D11820: Handle properties with multiple values

2018-04-15 Thread Michael Heidelbach
michaelh added a subscriber: bruns. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11820 To: michaelh, #baloo, #frameworks Cc: bruns, astippich, mgallien, elvisangelaccio, ashaposhnikov, spoorun, alexeymin

D11820: Handle properties with multiple values

2018-04-15 Thread Michael Heidelbach
michaelh added a comment. In D11820#246525 , @astippich wrote: > Sorry for the late answer. Isn't this already handled in widgetfactory.cpp toString function (line 87)? During my testing with multiple values I've never had issues with

D11820: Handle properties with multiple values

2018-04-15 Thread Michael Heidelbach
michaelh planned changes to this revision. michaelh added a comment. Due to a bug in calligra `test.odt` file is broken. see D11971 . REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11820 To: michaelh, #baloo, #frameworks

D11820: Handle properties with multiple values

2018-04-15 Thread Alexander Stippich
astippich added a comment. Sorry for the late answer. Isn't this already handled in widgetfactory.cpp toString function (line 87)? During my testing with multiple values I've never had issues with baloo-widgets, only with baloo itself. If there are still changes required in baloo-widgets, I

D11820: Handle properties with multiple values

2018-03-30 Thread Michael Heidelbach
michaelh created this revision. michaelh added reviewers: Baloo, Frameworks. Restricted Application added a project: Baloo. michaelh requested review of this revision. TEST PLAN make test REPOSITORY R824 Baloo Widgets BRANCH string-list (branched from master) REVISION DETAIL

D11820: Handle properties with multiple values

2018-03-30 Thread Michael Heidelbach
michaelh edited the summary of this revision. michaelh added a dependency: D10694: epubextractor: Handle multiple subjects better. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11820 To: michaelh, #baloo, #frameworks Cc: astippich, mgallien, elvisangelaccio,