D15814: show all borders for pop up windows in a dock

kossebau resigned from this revision. kossebau added a comment. This revision is now accepted and ready to land. No time for Plasma in the next months reserved, so withdrawing as reviewer/commenter to clear my todo list REPOSITORY R242 Plasma Framework (Library) BRANCH dockBorders

D15814: show all borders for pop up windows in a dock

filipf added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15814 To: mvourlakos, #plasma, broulik, davidedmundson, kossebau, #vdg Cc: kossebau, abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15814: show all borders for pop up windows in a dock

kossebau requested changes to this revision. kossebau added a comment. This revision now requires changes to proceed. Actually popups from Plasma panels itself, at least with non-full-width-non-hide ones, now & then could use some more borders as well. E.g. when popup is shown next to

D15814: show all borders for pop up windows in a dock

davidedmundson added a comment. > sorry, I dont understand what explicitly means As in "void setAlwaysShowAllBorders(bool)" (or whatever) that a user calls. REPOSITORY R242 Plasma Framework (Library) BRANCH dockBorders REVISION DETAIL https://phabricator.kde.org/D15814 To:

D15814: show all borders for pop up windows in a dock

mvourlakos added a comment. In D15814#343330 , @davidedmundson wrote: > > first introduced at popupPlacement() > > ...by you :P I know :( and this broke plasma popups placement in !compositing mode. This is why I sent

D15814: show all borders for pop up windows in a dock

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > It is based on the assumption that by design plasma panels do not use mask() It's a big assumption. It seems more based on what the two windows happen to currently do

D15814: show all borders for pop up windows in a dock

mvourlakos added inline comments. INLINE COMMENTS > davidedmundson wrote in dialog.cpp:209 > How does parentWindow->mask relate to being a dock or not? > > Also we need to be a bit careful on names. > _NET_WM_WINDOW_TYPE_DOCK is all panels, including the standard plasma one. The idea was first

D15814: show all borders for pop up windows in a dock

davidedmundson added inline comments. INLINE COMMENTS > dialog.cpp:209 > +QWindow *parentWindow = q->transientParent(); > +bool inDock = parentWindow && !parentWindow->mask().isNull() && > KWindowSystem::compositingActive(); > + How does parentWindow->mask relate to being a dock or

D15814: show all borders for pop up windows in a dock

ngraham added a comment. Ok, no problem! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15814 To: mvourlakos, #plasma, broulik, davidedmundson Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15814: show all borders for pop up windows in a dock

mvourlakos added a comment. @ngraham @abetts I searched a bit the "downward-pointing triangle" case but I dont think it can be drawn based on the current plasma theme implementation. Plasma themes are svg(s) so the borders images can also have borders so it isnt just drawing a triangle

D15814: show all borders for pop up windows in a dock

mvourlakos added reviewers: broulik, davidedmundson. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15814 To: mvourlakos, #plasma, broulik, davidedmundson Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15814: show all borders for pop up windows in a dock

abetts added a comment. In D15814#85 , @mvourlakos wrote: > In D15814#10 , @ngraham wrote: > > > A big improvement! Even better would be a little downward-pointing triangle pointing to the

D15814: show all borders for pop up windows in a dock

ngraham added a comment. A downward-pointing triangle doesn't make sense for pop-ups with a standard Plasma panel because pop-ups appear to slide out of panels, and they're always touching one another. So there is never a question about what the parent is. Latte has a different visual style

D15814: show all borders for pop up windows in a dock

mvourlakos added a comment. In D15814#10 , @ngraham wrote: > A big improvement! Even better would be a little downward-pointing triangle pointing to the thing that spawned it. Here's a visual example from macOS with a vertical Dock:

D15814: show all borders for pop up windows in a dock

mvourlakos added a comment. In D15814#13 , @broulik wrote: > The idea is fine in principle but Plasma may also set a mask on its panels, noticeably in non-composited case for rounded corners, so when I disable compositing I get borders on

D15814: show all borders for pop up windows in a dock

mvourlakos updated this revision to Diff 42489. mvourlakos added a comment. - do not consider dock for !compositing REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15814?vs=42480=42489 BRANCH dockBorders REVISION DETAIL

D15814: show all borders for pop up windows in a dock

abetts added a comment. I like both ideas so far. Great improvement! Would it be too hard to create the pointer triangle? I think it make so much sense. That way the poppup doesn't feel like it is floating out of nowhere. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D15814: show all borders for pop up windows in a dock

broulik added a comment. The idea is fine in principle but Plasma may also set a mask on its panels, noticeably in non-composited case for rounded corners, so when I disable compositing I get borders on all side for regular panel popups REPOSITORY R242 Plasma Framework (Library) REVISION

D15814: show all borders for pop up windows in a dock

ngraham added a comment. A big improvement! Even better would be a little downward-pointing triangle pointing to the thing that spawned it. Here's a visual example from macOS with a vertical Dock: F6291932: macOS.png REPOSITORY R242 Plasma Framework

D15814: show all borders for pop up windows in a dock

mvourlakos added a comment. F6291922: εικόνα.png (before) F6291928: εικόνα.png (after) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15814 To: mvourlakos,

D15814: show all borders for pop up windows in a dock

mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mvourlakos requested review of this revision. REVISION SUMMARY --it creates a much better and consistent visual effect when applets pop