D17730: [WIP] Review KateStatusBar (based on D17729)

cullmann added a comment. Ah, you are right :=) Since we handle that differently the status bar has already full length. For the button issue: if you convert it and it looks the same as now with the normal breeze style, one could give it a try, thought I think that the labels are ok,

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. > ..as soon as you split (and as the statusbar dictates the minimum size), you will get in trouble. My first thought was, "Oops, right!" But while I verifying this I notice that the status bar has the full width of the window, not only the split view.

D17730: [WIP] Review KateStatusBar (based on D17729)

cullmann added a comment. > - Most of them have an answer now ;-) Will add more stuff here > - Your comment to @zetazeta request ? I have tried to add a QScrollArea but without success :-/ Ideas? Perhaps is a second level of layout/widget needed(?) > > ``` updateStatus();

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. > For the "should we use buttons": I think I tried that in the past and it did look horrible in many styles, but perhaps I am wrong ;) I see. May it in the meantime not an issue anymore, due to new designs elsewhere? And what's up with the existing buttons, they

D17730: [WIP] Review KateStatusBar (based on D17729)

cullmann added a comment. I am a bit confused which questions still need answers ;=) What I think about the current state of the patch: I am fine with it, beside that I think having the dictionary picker per default there takes to much space and one should have some "show XXX" in

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar updated this revision to Diff 48237. loh.tar edited the test plan for this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - All in one diff - Rebased on master - Removed test plan - Will update Summary/Title before you commit

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar updated this revision to Diff 48236. loh.tar edited the summary of this revision. loh.tar added a comment. - Only show lineColLabel context menu when click on it and not somewhere on the bar As "usual" without all other patches. > No idea how the spell-checking code handles

D17730: [WIP] Review KateStatusBar (based on D17729)

zetazeta added a comment. I don't know if it should be done in this revision but... I find it annoying that the status bar imposes a limit on the minimum width of the window. Let's say that I want a really small (20 chars width) instance of kwrite for note taking always on top - it

D17730: [WIP] Review KateStatusBar (based on D17729)

cullmann added a comment. In D17730#381237 , @loh.tar wrote: > > My main intent is to add somehow a spell check button/hint > > Here a snapshot how it looks currently > F6503235: 1545570321.png >

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. > My main intent is to add somehow a spell check button/hint Here a snapshot how it looks currently F6503235: 1545570321.png Sadly stuck I now, every help is appreciated I like to show on the button the current

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar updated this revision to Diff 48000. loh.tar edited the summary of this revision. loh.tar added a comment. - KateStatusBar: Move the modified-label from far right to far left Once again without all other patches REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. How about to change the "action-labels" to buttons? Thisway would it be less "quirky" and we would have a feedback that there is an action available when hovered by mouse REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To:

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. Oops, have now the first commit omitted in this update. Perhaps not too bad this way(?) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh,

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar updated this revision to Diff 47998. loh.tar edited the summary of this revision. loh.tar added a comment. - KateStatusBar: Don't treat click in empty area as click on mode-label REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - KateStatusBar: Do actions on labels by single click instead