nicolasfella closed this revision.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D29390
To: nicolasfella, #plasma, #frameworks, mart
Cc: mart, kossebau, aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh,
ngraham, bruns
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
go for it :)
REPOSITORY
R302 KIconThemes
BRANCH
fallback
REVISION DETAIL
https://phabricator.kde.org/D29390
To: nicolasfella, #plasma, #frameworks, mart
Cc: mart, kossebau, aacid,
nicolasfella updated this revision to Diff 82600.
nicolasfella added a comment.
- Use array
REPOSITORY
R302 KIconThemes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29390?vs=81821=82600
BRANCH
fallback
REVISION DETAIL
https://phabricator.kde.org/D29390
AFFECTED FILES
nicolasfella added inline comments.
INLINE COMMENTS
> aacid wrote in kiconloader.cpp:1142
> I just realized that function is private, not really easy to use :/
>
> anyhow do you think we should remove svgz?
>
> Also i think using
>
> const QStringList extensions = { QStringLiteral(".png"),
>
kossebau added inline comments.
INLINE COMMENTS
> aacid wrote in kiconloader.cpp:1142
> I just realized that function is private, not really easy to use :/
>
> anyhow do you think we should remove svgz?
>
> Also i think using
>
> const QStringList extensions = { QStringLiteral(".png"),
>
aacid added inline comments.
INLINE COMMENTS
> aacid wrote in kiconloader.cpp:1142
> Would it make sense trying to use QIconLoader::lookupFallbackIcon ? This way
> we "upstream" Qt behaviour? For example you're supporting svgz while Qt
> doesn't. Which would mean different
aacid added inline comments.
INLINE COMMENTS
> kiconloader.cpp:1142
> +for (const QString : fallbackPaths) {
> +const QStringList extensions = QStringList() <<
> QStringLiteral(".png") << QStringLiteral(".svg") << QStringLiteral(".svgz")
> << QStringLiteral(".xpm");
> +
nicolasfella created this revision.
nicolasfella added reviewers: Plasma, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
When an icon isn't found within a theme we are supposed to
