D6053: Use explicit flag values or explicit constructor instead of nullptr

This revision was automatically updated to reflect the committed changes. Closed by commit R236:ff2e1d8e22fe: Use explicit flag values or explicit constructor instead of nullptr (authored by kossebau). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D6053: Use explicit flag values or explicit constructor instead of nullptr

cfeck accepted this revision. REPOSITORY R236 KWidgetsAddons BRANCH nonullptrforflagsplease REVISION DETAIL https://phabricator.kde.org/D6053 To: kossebau, #frameworks, cfeck, kfunk Cc: kfunk

D6053: Use explicit flag values or explicit constructor instead of nullptr

kossebau added inline comments. INLINE COMMENTS > cfeck wrote in kfontrequester.cpp:187 > Does removing the default value mean the flags would be now uninitialized? No, the constructor called would be (as before) `QFlags::QFlags(Zero zero = Q_NULLPTR)`, so still default to 0 internally, so

D6053: Use explicit flag values or explicit constructor instead of nullptr

kfunk accepted this revision. kfunk added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > cfeck wrote in kfontrequester.cpp:187 > Does removing the default value mean the flags would be now uninitialized? No, `QFontDialog::FontDialogOptions` is a `QFlags<>`

D6053: Use explicit flag values or explicit constructor instead of nullptr

kossebau created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY The constructor of QFlags which was intended to handle literal "0" as commonly used indicator of no-flags-set has been done with a trick based on pointer types. Which these days of nullptr