This revision was automatically updated to reflect the committed changes.
Closed by commit R216:b54210c3e238: Rewrite the email syntax definition
(authored by vkrause).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7289?vs=18106&id=18150#toc
REPOSITORY
R216 Syntax Highlighting
CHANGE
dhaumann added a comment.
OK, sounds sane. Please commit, no need for another review round. Thanks!
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7289
To: vkrause, #framework_syntax_hightlighting, kwrite-devel, dhaumann
Cc: dhaumann, #f
vkrause added a comment.
Correct, any highlighting of the body content is gone, intentionally. The
original highlighting was from a time when emails had 4-5 human readable
headers and ASCII bodys. At that time body highlighting made sense, and even
reading emails in kate was feasible. Nowada
dhaumann added a comment.
Ah, one more thing: we probably can add spellChecking="false" for some item
datas...
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7289
To: vkrause, #framework_syntax_hightlighting, kwrite-devel, dhaumann
Cc:
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Please commit - thanks! :)
As I understand, the indent coloring with '>' is gone. There certainly will
be some users who want that, but if requested, we can add it again (I remember
vkrause updated this revision to Diff 18106.
vkrause added a comment.
- improve content boundary regexp
- don't attempt to highlight unknown header content, those can contain
arbitrarily bizarrely encoded stuff (see e.g. X-Face)
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDA
vkrause updated this revision to Diff 18105.
vkrause added a comment.
Add body context, fix some allowed characters for content boundaries and
email addresses.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7289?vs=18088&id=18105
BRANCH
mast
vkrause marked an inline comment as done.
vkrause added inline comments.
INLINE COMMENTS
> dhaumann wrote in email.xml:51
> Not sure, but is underscore '_' also allowed?
Not here, but below indeed.
> dhaumann wrote in email.xml:52
> Search for lineEmptyContext here:
> https://docs.kde.org/trun
dhaumann added a comment.
Looks already good, but maybe we can do better with the lineEmptyContext?
Also, we have things like fallthroughContext, if no rule matches at all in a
context.
I suggest one more review iteration.
INLINE COMMENTS
> email.xml:51
> + String="head
vkrause created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
- no more hardcoded colors, which makes the source view in KMail a lot more
pleasant to look at
- reduced the regexp usage in favor of key
10 matches
Mail list logo
