Re: KTextEditor Frameworks question

2014-01-09 Thread Kevin Ottens
On Wednesday 08 January 2014 23:00:02 Alex Merry wrote: On 08/01/14 22:24, Kevin Ottens wrote: I also modified a bit one of the policies: http://community.kde.org/Frameworks/Policies#Frameworks_buildsystem_is_con sistent (was saying installation rules but it's really more about style of

Re: KTextEditor Frameworks question

2014-01-09 Thread Alex Merry
On 09/01/14 13:11, Kevin Ottens wrote: On Wednesday 08 January 2014 23:00:02 Alex Merry wrote: On 08/01/14 22:24, Kevin Ottens wrote: I also modified a bit one of the policies: http://community.kde.org/Frameworks/Policies#Frameworks_buildsystem_is_con sistent (was saying installation rules

Re: KTextEditor Frameworks question

2014-01-08 Thread Kevin Ottens
On Tuesday 07 January 2014 20:48:39 David Faure wrote: The checklist for new frameworks can be extracted from http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation which gives: * make new repo using script (done, in your case) * run astyle-kdelibs (requires some patching, so I

Re: KTextEditor Frameworks question

2014-01-08 Thread Alex Merry
On 08/01/14 22:24, Kevin Ottens wrote: I also modified a bit one of the policies: http://community.kde.org/Frameworks/Policies#Frameworks_buildsystem_is_consistent (was saying installation rules but it's really more about style of the buildsystem, we might want to reference aurélien's

Re: KTextEditor Frameworks question

2014-01-07 Thread Christoph Cullmann
On Tuesday 07 January 2014 07:12:40 Christoph Cullmann wrote: I tried my luck with splitting/grafting/kdeexamples template. Could somebody take a look what ended up in the master branch of g...@git.kde.org:scratch/cullmann/ktexteditor.git Any feedback welcome, if I

Re: KTextEditor Frameworks question

2014-01-07 Thread Martin Klapetek
On Tue, Jan 7, 2014 at 9:37 AM, Christoph Cullmann cullm...@absint.comwrote: Should the heuristic be: If there is a K in front, remove it and do stuff like KFooBar leads to KF5FooBar, else keep the complete FooBar name and do KF5FooBar. Yes, pretty much that. Cheers -- Martin Klapetek |

Re: KTextEditor Frameworks question

2014-01-07 Thread Christoph Cullmann
Hi, I just tried to fix the naming issues. Does that try here look better http://quickgit.kde.org/?p=scratch%2Fcullmann%2Fktexteditor.git If yes, I would ask sysadmin to move to framworks, if that is ok and remove the stuff in frameworks branch of kate.git. Greetings Christoph -

Re: KTextEditor Frameworks question

2014-01-07 Thread David Faure
On Tuesday 07 January 2014 19:57:56 Christoph Cullmann wrote: Hi, I just tried to fix the naming issues. Does that try here look better http://quickgit.kde.org/?p=scratch%2Fcullmann%2Fktexteditor.git I see a ${FooBar_HEADERS} in src/CMakeLists.txt which is used but not set, should be

Re: KTextEditor Frameworks question

2014-01-07 Thread Christoph Cullmann
On Tuesday 07 January 2014 19:57:56 Christoph Cullmann wrote: Hi, I just tried to fix the naming issues. Does that try here look better http://quickgit.kde.org/?p=scratch%2Fcullmann%2Fktexteditor.git I see a ${FooBar_HEADERS} in src/CMakeLists.txt which is used but not set,

Re: KTextEditor Frameworks question

2014-01-07 Thread David Faure
add_library (KF5TextEditor ${ktexteditor_LIB_SRCS} ${KTEXTEDITOR_PUBLIC_HEADERS}) Why pass headers to add_library? Just for automoc, without that, I get stuff like: Linking CXX shared library libKF5TextEditor.so CMakeFiles/KF5TextEditor.dir/view/kateviewinternal.cpp.o: In

Re: KTextEditor Frameworks question

2014-01-07 Thread Christoph Cullmann
add_library (KF5TextEditor ${ktexteditor_LIB_SRCS} ${KTEXTEDITOR_PUBLIC_HEADERS}) Why pass headers to add_library? Just for automoc, without that, I get stuff like: Linking CXX shared library libKF5TextEditor.so

Re: KTextEditor Frameworks question

2014-01-07 Thread Christoph Cullmann
On Tuesday 07 January 2014 20:55:19 Christoph Cullmann wrote: * run astyle-kdelibs (requires some patching, so I can do it if you want) Sure, that would be nice. OK. Can you give a quick look at http://www.davidfaure.fr/2014/ktexteditor-astyled.diff and give me a green light? No

Re: KTextEditor Frameworks question

2014-01-07 Thread David Faure
On Tuesday 07 January 2014 21:12:39 Christoph Cullmann wrote: Yeah, 2 = 4, all right, wanted that anyway since long. Only the autotests/input stuff should be best left untouched. That is no source in that case only input for tests, and yeah, I guess they won't like that. OK, reverted that

Re: KTextEditor Frameworks question

2014-01-07 Thread Kevin Funk
Am Dienstag, 7. Januar 2014, 19:57:56 schrieb Christoph Cullmann: Hi, I just tried to fix the naming issues. Does that try here look better http://quickgit.kde.org/?p=scratch%2Fcullmann%2Fktexteditor.git If yes, I would ask sysadmin to move to framworks, if that is ok and remove the

Re: KTextEditor Frameworks question

2014-01-07 Thread Kevin Funk
Am Dienstag, 7. Januar 2014, 21:20:40 schrieb Kevin Funk: Am Dienstag, 7. Januar 2014, 19:57:56 schrieb Christoph Cullmann: Hi, I just tried to fix the naming issues. Does that try here look better http://quickgit.kde.org/?p=scratch%2Fcullmann%2Fktexteditor.git If yes, I

Re: KTextEditor Frameworks question

2014-01-07 Thread Christoph Cullmann
Fixed :P - Ursprüngliche Mail - Am Dienstag, 7. Januar 2014, 19:57:56 schrieb Christoph Cullmann: Hi, I just tried to fix the naming issues. Does that try here look better http://quickgit.kde.org/?p=scratch%2Fcullmann%2Fktexteditor.git If yes, I would ask sysadmin

Re: KTextEditor Frameworks question

2014-01-06 Thread David Faure
On Monday 06 January 2014 08:36:14 Christoph Cullmann wrote: Is it really enough to init a new repository and have that one initial commit + add (and then move the files around inside the new git) to have history via grafting available? There is no other trick behind I just don't see ATM?

Re: KTextEditor Frameworks question

2014-01-06 Thread Christoph Cullmann
I see, yeah, thats KatePart it seems to me. Anyway, I am all for going to have a KF5 KTextEditor framework, will make it more approachable for other projects to use it. And unlike in 4.x, KTextEditor would always provide the implementation directly (KatePart merged in, internally) and

Re: KTextEditor Frameworks question

2014-01-06 Thread Kevin Funk
Am Montag, 6. Januar 2014, 21:44:46 schrieb Christoph Cullmann: I see, yeah, thats KatePart it seems to me. Anyway, I am all for going to have a KF5 KTextEditor framework, will make it more approachable for other projects to use it. And unlike in 4.x, KTextEditor would always provide

Re: KTextEditor Frameworks question

2014-01-06 Thread Aleix Pol
On Tue, Jan 7, 2014 at 3:03 AM, Kevin Funk k...@gmx.de wrote: Am Montag, 6. Januar 2014, 21:44:46 schrieb Christoph Cullmann: I see, yeah, thats KatePart it seems to me. Anyway, I am all for going to have a KF5 KTextEditor framework, will make it more approachable for other

Re: KTextEditor Frameworks question

2014-01-05 Thread Martin Graesslin
On Saturday 04 January 2014 19:40:46 Christoph Cullmann wrote: On Saturday 04 January 2014 19:18:56 Christoph Cullmann wrote: Hi, I cleanup the frameworks branch in kate.git to only have libktexteditor lib and the KTextEditor/ktexteditor includes to be installed as public API.

Re: KTextEditor Frameworks question

2014-01-05 Thread Christoph Cullmann
On Saturday 04 January 2014 19:40:46 Christoph Cullmann wrote: On Saturday 04 January 2014 19:18:56 Christoph Cullmann wrote: Hi, I cleanup the frameworks branch in kate.git to only have libktexteditor lib and the KTextEditor/ktexteditor includes to be installed as public

KTextEditor Frameworks question

2014-01-04 Thread Christoph Cullmann
Hi, I cleanup the frameworks branch in kate.git to only have libktexteditor lib and the KTextEditor/ktexteditor includes to be installed as public API. Now, for 5.x, if others port over, like KDevelop, is it a good idea to keep the ktexteditor parts in kate.git, together with the applications,

Re: KTextEditor Frameworks question

2014-01-04 Thread Christoph Cullmann
On Saturday 04 January 2014 19:18:56 Christoph Cullmann wrote: Hi, I cleanup the frameworks branch in kate.git to only have libktexteditor lib and the KTextEditor/ktexteditor includes to be installed as public API. Now, for 5.x, if others port over, like KDevelop, is it a good idea

Re: KTextEditor Frameworks question

2014-01-04 Thread David Faure
On Saturday 04 January 2014 19:40:46 Christoph Cullmann wrote: What would be required to have the ktexteditor stuff be frameworks ready? Using all the cmake stuff from other frameworks ;) I just updated and moved the framework template we had in kdelibs to kdeexamples/framework-template. You

Re: KTextEditor Frameworks question

2014-01-04 Thread Christoph Cullmann
On Saturday 04 January 2014 19:40:46 Christoph Cullmann wrote: What would be required to have the ktexteditor stuff be frameworks ready? Using all the cmake stuff from other frameworks ;) I just updated and moved the framework template we had in kdelibs to kdeexamples/framework-template.

Re: KTextEditor Frameworks question

2014-01-04 Thread David Faure
On Saturday 04 January 2014 22:40:13 Christoph Cullmann wrote: On Saturday 04 January 2014 19:40:46 Christoph Cullmann wrote: What would be required to have the ktexteditor stuff be frameworks ready? Using all the cmake stuff from other frameworks ;) I just updated and moved the

Re: KTextEditor Frameworks question

2014-01-04 Thread Christoph Cullmann
On Saturday 04 January 2014 22:40:13 Christoph Cullmann wrote: On Saturday 04 January 2014 19:40:46 Christoph Cullmann wrote: What would be required to have the ktexteditor stuff be frameworks ready? Using all the cmake stuff from other frameworks ;) I just updated and