Re: Making polkit-qt-1 a tier1 framework

[David Faure]

Talking about polkit-qt-1, your last commit there broke compilation in CI:

https://build.kde.org/job/polkit-qt-1%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/5/console

kf5-qt5/core/polkitqt1-subject.cpp:186:111: error: 
‘polkit_system_bus_name_get_user_sync’ was not declared in this scope

Same in the other CI, 
http://ci-logs.kde.flaska.net/45/4528ea9f808f7f9de56dee70626040bed2b4b67c/rebuilddep/rebuilddep-kf5-qt55-clang-el7/5477297/shell_output.log

Thanks for taking a look.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Making polkit-qt-1 a tier1 framework

[David Faure]

On Monday 25 January 2016 09:12:50 Martin Graesslin wrote:
> On Saturday, January 23, 2016 11:59:28 AM CET David Faure wrote:
> > On Thursday 14 January 2016 13:20:01 Martin Gräßlin wrote:
> > > Hi all,
> > > 
> > > I want to suggest to move polkit-qt-1 [1] from kdesupport to frameworks.
> > > Reasons are:
> > > 
> > > * kdesupport is basically what became tier1 in frameworks
> > > * it's used by other frameworks, e.g. KAuth (tier 2) and in
> > > kde/workspace
> > > * polkit-qt-1 is currently in a not really released state (last release
> > > in 2014, quite a few bugfixes around)
> > > 
> > > By moving it to frameworks we get closer to getting rid of kdesupport
> > > and get the making releases problem solved once and for all: bug fixes
> > > will get to users in a timely manner.
> > > 
> > > Opinions?
> > 
> > Sounds good. A few questions come to mind:
> > 
> > - Will you be the official maintainer? (Otherwise who will?)
> 
> eh no, my domain knowledge is not enough and I already maintain too much.
> 
> My suggestion for maintainer is shared responsibility of Plasma team. Not 
> optimal, but still better than the unmaintained state it's currently in. And 
> Plasma needs polkit.

Yes that is suboptimal, but OK, it's the case for some of the existing 
frameworks too.
I just wanted to raise the opportunity to actually find/define a maintainer for 
polkit-qt-1.

> > - Is this an opportunity for a better name? I keep wondering why this lib
> > targets Qt 1 :-)
> 
> The name makes kind of sense. It's a Qt wrapper for polkit-1. If you have a 
> better name suggestion: sure, but it shouldn't cause breakage for existing 
> code.

Well, since it's moving to be a frameworks, it could be called kpolkit-1
or polkit-1-qt, if it has to be renamed anyway.
I mean I wonder if "breakage for existing code" can be avoided anyway,
when making this a proper framework.
find_package(PolkitQt5-1) will have to become find_package(KF5PolkitQt1), no?
And linking to KF5::PolkitQt1Core instead of linking to .. 
${POLKITQT-1_CORE_LIBRARY} apparently
(although we could just set that var for compatibility).
Overall, there is some work to be done on making this in line with KF5 naming 
conventions,
and I don't think it will "cause breakage" because the unported apps will keep 
finding the
current polkit-qt-1 package/library. So this is an opportunity for renaming 
IMHO. But if I'm
the only one who is bothered by the name, I'm happy to shut up of course.

My confusion also comes from: what's the difference between 
kauth/cmake/FindPolkitQt.cmake
and kauth/cmake/FindPolkitQt-1.cmake? There is polkit-qt-1 and polkit-qt?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Making polkit-qt-1 a tier1 framework

[Martin Graesslin]

On Saturday, January 23, 2016 11:59:28 AM CET David Faure wrote:
> On Thursday 14 January 2016 13:20:01 Martin Gräßlin wrote:
> > Hi all,
> > 
> > I want to suggest to move polkit-qt-1 [1] from kdesupport to frameworks.
> > Reasons are:
> > 
> > * kdesupport is basically what became tier1 in frameworks
> > * it's used by other frameworks, e.g. KAuth (tier 2) and in
> > kde/workspace
> > * polkit-qt-1 is currently in a not really released state (last release
> > in 2014, quite a few bugfixes around)
> > 
> > By moving it to frameworks we get closer to getting rid of kdesupport
> > and get the making releases problem solved once and for all: bug fixes
> > will get to users in a timely manner.
> > 
> > Opinions?
> 
> Sounds good. A few questions come to mind:
> 
> - Will you be the official maintainer? (Otherwise who will?)

eh no, my domain knowledge is not enough and I already maintain too much.

My suggestion for maintainer is shared responsibility of Plasma team. Not 
optimal, but still better than the unmaintained state it's currently in. And 
Plasma needs polkit.

> 
> - Is this an opportunity for a better name? I keep wondering why this lib
> targets Qt 1 :-)

The name makes kind of sense. It's a Qt wrapper for polkit-1. If you have a 
better name suggestion: sure, but it shouldn't cause breakage for existing 
code.

Cheers
Martin


signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Making polkit-qt-1 a tier1 framework

[David Faure]

On Thursday 14 January 2016 13:20:01 Martin Gräßlin wrote:
> Hi all,
> 
> I want to suggest to move polkit-qt-1 [1] from kdesupport to frameworks. 
> Reasons are:
> 
> * kdesupport is basically what became tier1 in frameworks
> * it's used by other frameworks, e.g. KAuth (tier 2) and in 
> kde/workspace
> * polkit-qt-1 is currently in a not really released state (last release 
> in 2014, quite a few bugfixes around)
> 
> By moving it to frameworks we get closer to getting rid of kdesupport 
> and get the making releases problem solved once and for all: bug fixes 
> will get to users in a timely manner.
> 
> Opinions?

Sounds good. A few questions come to mind:

- Will you be the official maintainer? (Otherwise who will?)

- Is this an opportunity for a better name? I keep wondering why this lib 
targets Qt 1 :-)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Making polkit-qt-1 a tier1 framework

[Martin Gräßlin]

Hi all,

I want to suggest to move polkit-qt-1 [1] from kdesupport to frameworks. 
Reasons are:


* kdesupport is basically what became tier1 in frameworks
* it's used by other frameworks, e.g. KAuth (tier 2) and in 
kde/workspace
* polkit-qt-1 is currently in a not really released state (last release 
in 2014, quite a few bugfixes around)


By moving it to frameworks we get closer to getting rid of kdesupport 
and get the making releases problem solved once and for all: bug fixes 
will get to users in a timely manner.


Opinions?

Cheers,
Martin

[1] git://anongit.kde.org/polkit-qt-1
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Making polkit-qt-1 a tier1 framework

[Aleix Pol]

On Thu, Jan 14, 2016 at 1:20 PM, Martin Gräßlin  wrote:
> Hi all,
>
> I want to suggest to move polkit-qt-1 [1] from kdesupport to frameworks.
> Reasons are:
>
> * kdesupport is basically what became tier1 in frameworks
> * it's used by other frameworks, e.g. KAuth (tier 2) and in kde/workspace
> * polkit-qt-1 is currently in a not really released state (last release in
> 2014, quite a few bugfixes around)
>
> By moving it to frameworks we get closer to getting rid of kdesupport and
> get the making releases problem solved once and for all: bug fixes will get
> to users in a timely manner.
>
> Opinions?
>
> Cheers,
> Martin
>
> [1] git://anongit.kde.org/polkit-qt-1

+1

Have you checked it passes the KDE Frameworks checklist?
https://community.kde.org/Frameworks/Policies
https://community.kde.org/Frameworks/CreationGuidelines

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Making polkit-qt-1 a tier1 framework

[Kevin Ottens]

Hello,

On Thursday, 14 January 2016 13:20:01 CET Martin Gräßlin wrote:
> By moving it to frameworks we get closer to getting rid of kdesupport
> and get the making releases problem solved once and for all: bug fixes
> will get to users in a timely manner.
> 
> Opinions?

Personally I like it. Similar options for the rest of kdesupport should likely 
be considered as well.

Cheers.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Making polkit-qt-1 a tier1 framework

[Martin Bříza]

On Thu, 14 Jan 2016 13:20:01 +0100, Martin Gräßlin   
wrote:



Hi all,

I want to suggest to move polkit-qt-1 [1] from kdesupport to frameworks.  
Reasons are:


* kdesupport is basically what became tier1 in frameworks
* it's used by other frameworks, e.g. KAuth (tier 2) and in kde/workspace
* polkit-qt-1 is currently in a not really released state (last release  
in 2014, quite a few bugfixes around)


By moving it to frameworks we get closer to getting rid of kdesupport  
and get the making releases problem solved once and for all: bug fixes  
will get to users in a timely manner.


Opinions?

Cheers,
Martin

[1] git://anongit.kde.org/polkit-qt-1


Hi,

I think the move is a good decision, especially considering the release  
cycle.


Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Making polkit-qt-1 a tier1 framework

[Martin Gräßlin]

Am 2016-01-14 18:40, schrieb David Edmundson:

On Thu, Jan 14, 2016 at 12:20 PM, Martin Gräßlin
 wrote:


Hi all,

I want to suggest to move polkit-qt-1 [1] from kdesupport to
frameworks. Reasons are:

* kdesupport is basically what became tier1 in frameworks
* it's used by other frameworks, e.g. KAuth (tier 2) and in
kde/workspace
* polkit-qt-1 is currently in a not really released state (last
release in 2014, quite a few bugfixes around)

By moving it to frameworks we get closer to getting rid of
kdesupport and get the making releases problem solved once and for
all: bug fixes will get to users in a timely manner.



Opinions?


Not whilst it does the weird "I can build Qt4 and 5 at the same time"
mess.


sure, that can (and should) be cleaned up. It's part of "need to get the 
CMake for frameworks" adjustment.


Cheers
Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel