Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-22 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/ --- (Updated Oct. 22, 2013, 9:51 p.m.) Status -- This change has been mar

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review42187 --- This review has been submitted with commit 9d0d6b4b5fef67b2154

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-21 Thread David Gil Oliva
> On Oct. 11, 2013, 4:28 p.m., Kevin Ottens wrote: > > Ship It! > > Kevin Ottens wrote: > Any reason why this patch isn't pushed yet? Yes. There are some personal reasons and, besides, I've been trying for days to compile Qt5.2 with no luck till today. I think I'll have both patches pushed

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-21 Thread Kevin Ottens
> On Oct. 11, 2013, 4:28 p.m., Kevin Ottens wrote: > > Ship It! Any reason why this patch isn't pushed yet? - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review41566 ---

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-11 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review41566 --- Ship it! Ship It! - Kevin Ottens On Oct. 7, 2013, 10:08 p.m

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-08 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review41393 --- Ship it! Ship It! - Aurélien Gâteau On Oct. 8, 2013, 12:08

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-07 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/ --- (Updated Oct. 7, 2013, 10:08 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-07 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review41326 --- Looks good to me. One last thing: you need to document the save

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-06 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/ --- (Updated Oct. 6, 2013, 8:56 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-03 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review41164 --- staging/kemoticons/src/core/kemoticonsprovider.h

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-01 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/ --- (Updated Oct. 1, 2013, 8:45 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-09-30 Thread David Gil Oliva
> On Sept. 30, 2013, 10:48 a.m., Aleix Pol Gonzalez wrote: > > staging/kemoticons/src/core/kemoticonsprovider.h, line 95 > > > > > > Use KEMOTICONS_DEPRECATED What a stupid mistake!!! Sorry :-/ On Sept. 30, 2013

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-09-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review41018 --- staging/kemoticons/src/core/kemoticonsprovider.h

Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-09-28 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/ --- Review request for KDE Frameworks. Description --- Adjust API in KEmo