Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-02-05 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/ --- (Updated Feb. 5, 2014, 8:10 p.m.) Status -- This change has been

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/#review48693 --- If this review is obsolete, can you discard it, please? -

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-31 Thread David Narváez
On Jan. 31, 2014, 6:21 p.m., Alex Merry wrote: If this review is obsolete, can you discard it, please? I'm waiting for an answer to my question above. - David --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-31 Thread Alex Merry
On Jan. 31, 2014, 6:21 p.m., Alex Merry wrote: If this review is obsolete, can you discard it, please? David Narváez wrote: I'm waiting for an answer to my question above. I would go with Luigi's suggestion. If we determine later that it might be useful beyond KDocTools, we can

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-21 Thread David Narváez
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: KF5DocToolsMacros.cmake, lines 166-172 https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166 These should *not* be renamed, as they are compatibility macros. However, they should probably be moved to

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-21 Thread David Narváez
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: KF5DocToolsMacros.cmake, lines 166-172 https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166 These should *not* be renamed, as they are compatibility macros. However, they should probably be moved to

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-19 Thread Alex Merry
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: KF5DocToolsMacros.cmake, lines 166-172 https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166 These should *not* be renamed, as they are compatibility macros. However, they should probably be moved to

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-19 Thread Luigi Toscano
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: KF5DocToolsMacros.cmake, lines 166-172 https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166 These should *not* be renamed, as they are compatibility macros. However, they should probably be moved to

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-18 Thread Aleix Pol Gonzalez
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: KF5DocToolsMacros.cmake, lines 166-172 https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166 These should *not* be renamed, as they are compatibility macros. However, they should probably be moved to

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-18 Thread David Narváez
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: KF5DocToolsMacros.cmake, lines 166-172 https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166 These should *not* be renamed, as they are compatibility macros. However, they should probably be moved to

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-18 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/ --- (Updated Jan. 18, 2014, 1:16 p.m.) Review request for Documentation, KDE

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-18 Thread Alex Merry
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: KF5DocToolsMacros.cmake, lines 166-172 https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166 These should *not* be renamed, as they are compatibility macros. However, they should probably be moved to

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-18 Thread Luigi Toscano
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: KF5DocToolsMacros.cmake, lines 166-172 https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166 These should *not* be renamed, as they are compatibility macros. However, they should probably be moved to

Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-17 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/ --- Review request for Documentation and KDE Frameworks. Repository:

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-17 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/#review47592 --- KF5DocToolsMacros.cmake