Re: Review Request 115344: With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/#review48852 --- This review has been submitted with commit 3278a78a4a7af534e40be6c5311e2a2e8a22f00f by Alex Richardson to branch master. - Commit Hook On Jan. 27, 2014, 10:22 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/ --- (Updated Jan. 27, 2014, 10:22 p.m.) Review request for KDE Frameworks. Repository: kunitconversion Description --- With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined Is it okay to put the define in the source file, or should I rather put it in the CMake code? Diffs - src/CMakeLists.txt aefd6abe964d19177a3514f9c01022141af0425b Diff: https://git.reviewboard.kde.org/r/115344/diff/ Testing --- didn't compile before, does now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115344: With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/ --- (Updated Feb. 3, 2014, 7:46 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kunitconversion Description --- With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined Is it okay to put the define in the source file, or should I rather put it in the CMake code? Diffs - src/CMakeLists.txt aefd6abe964d19177a3514f9c01022141af0425b Diff: https://git.reviewboard.kde.org/r/115344/diff/ Testing --- didn't compile before, does now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115344: With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/#review48707 --- Ship it! Can you include a link to http://msdn.microsoft.com/en-us/library/4hwaceh6.aspx in the comment? - Alex Merry On Jan. 27, 2014, 10:22 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/ --- (Updated Jan. 27, 2014, 10:22 p.m.) Review request for KDE Frameworks. Repository: kunitconversion Description --- With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined Is it okay to put the define in the source file, or should I rather put it in the CMake code? Diffs - src/CMakeLists.txt aefd6abe964d19177a3514f9c01022141af0425b Diff: https://git.reviewboard.kde.org/r/115344/diff/ Testing --- didn't compile before, does now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115344: With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/ --- Review request for KDE Frameworks and kdewin. Repository: kunitconversion Description --- With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined Is it okay to put the define in the source file, or should I rather put it in the CMake code? Diffs - src/angle.cpp 4df1981930e6459a7d2486caffaee6fd439976d0 Diff: https://git.reviewboard.kde.org/r/115344/diff/ Testing --- didn't compile before, does now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115344: With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/#review48418 --- We use to do so in the CMake files (as more than one source file may use it). - Andrius da Costa Ribas On Jan. 27, 2014, 9:32 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/ --- (Updated Jan. 27, 2014, 9:32 p.m.) Review request for KDE Frameworks and kdewin. Repository: kunitconversion Description --- With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined Is it okay to put the define in the source file, or should I rather put it in the CMake code? Diffs - src/angle.cpp 4df1981930e6459a7d2486caffaee6fd439976d0 Diff: https://git.reviewboard.kde.org/r/115344/diff/ Testing --- didn't compile before, does now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115344: With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/ --- (Updated Jan. 27, 2014, 11:22 p.m.) Review request for KDE Frameworks. Changes --- Do the check in CMakeLists.txt instead of the source file Repository: kunitconversion Description --- With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined Is it okay to put the define in the source file, or should I rather put it in the CMake code? Diffs (updated) - src/CMakeLists.txt aefd6abe964d19177a3514f9c01022141af0425b Diff: https://git.reviewboard.kde.org/r/115344/diff/ Testing --- didn't compile before, does now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
