D25638: autotests: Find perl executable on all platforms

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R172:accdbdd65ee0: autotests: Find perl executable on all 
platforms (authored by aspotashev).

REPOSITORY
  R172 KCalendar Core

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25638?vs=70636=70663

REVISION DETAIL
  https://phabricator.kde.org/D25638

AFFECTED FILES
  autotests/CMakeLists.txt

To: aspotashev, #frameworks, dfaure
Cc: dfaure, apol, #frameworks, kde-pim, bcooksley, LeGast00n, fbampaloukas, 
GB_2, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D25638: autotests: Find perl executable on all platforms

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  I approve, given that I wrote the same in D25643 
 :-)

REPOSITORY
  R172 KCalendar Core

BRANCH
  perl

REVISION DETAIL
  https://phabricator.kde.org/D25638

To: aspotashev, #frameworks, dfaure
Cc: dfaure, apol, #frameworks, kde-pim, bcooksley, LeGast00n, fbampaloukas, 
GB_2, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D25638: autotests: Find perl executable on all platforms

[Alexander Potashev]

aspotashev added inline comments.

INLINE COMMENTS

> apol wrote in CMakeLists.txt:93
> maybe it would make sense to check for BSD instead?
> I don't know much about BSD, but I'd expect the shebang to work there as well.

I think it's better to minimize platform-specific if-endifs and make CMake code 
clean rather  than micro-optimize per platform.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D25638

To: aspotashev, #frameworks
Cc: apol, #frameworks, kde-pim, bcooksley, LeGast00n, fbampaloukas, GB_2, 
dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D25638: autotests: Find perl executable on all platforms

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> CMakeLists.txt:93
> -  set(_runner ${CMAKE_CURRENT_SOURCE_DIR}/runsingletestcase.pl)
> -  if(WIN32)
> -set(_runner ${PERL_EXECUTABLE} ${_runner})

maybe it would make sense to check for BSD instead?
I don't know much about BSD, but I'd expect the shebang to work there as well.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D25638

To: aspotashev, #frameworks
Cc: apol, #frameworks, kde-pim, bcooksley, LeGast00n, fbampaloukas, GB_2, 
dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D25638: autotests: Find perl executable on all platforms

[Alexander Potashev]

aspotashev added a reviewer: Frameworks.
aspotashev added a project: Frameworks.
aspotashev added a subscriber: Frameworks.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D25638

To: aspotashev, #frameworks
Cc: #frameworks, kde-pim, bcooksley, LeGast00n, fbampaloukas, GB_2, dcaliste, 
michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, mlaurent, 
knauss, dvratil

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:591cc2a16e3e: Treat 
application/x-ms-dos-executable as executable on all platforms 
(authored by Guo Yunhe i...@guoyunhe.me).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24463?vs=67761=68027

REVISION DETAIL
  https://phabricator.kde.org/D24463

AFFECTED FILES
  src/widgets/executablefileopendialog.cpp
  src/widgets/executablefileopendialog_p.h
  src/widgets/krun.cpp
  src/widgets/krun_p.h

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe marked an inline comment as done.
guoyunhe added inline comments.

INLINE COMMENTS

> dfaure wrote in krun.cpp:1101
> should this be in ifdef Q_OS_WIN?
> 
> On windows, *.exe is executed, not opened (with e.g. wine)

Yes, I updated this part.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe updated this revision to Diff 67761.
guoyunhe added a comment.


  *.exe should be normal executable in Windows

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24463?vs=67458=67761

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

AFFECTED FILES
  src/widgets/executablefileopendialog.cpp
  src/widgets/executablefileopendialog_p.h
  src/widgets/krun.cpp
  src/widgets/krun_p.h

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> krun.cpp:1101
> +return ExecutableFileOpenDialog::OpenOrExecute;
> +} else if 
> (mime.inherits(QStringLiteral("application/x-ms-dos-executable"))) {
> +return ExecutableFileOpenDialog::OpenAsExecute;

should this be in ifdef Q_OS_WIN?

On windows, *.exe is executed, not opened (with e.g. wine)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> ppeter wrote in executablefileopendialog.cpp:58
>   if (mode == OnlyExecute)
> connect(executeButton, ...)
>   else if (mode == OpenAsExecute)
> ...
> 
> looks better :)

That would be against the common KDE coding style: 
https://community.kde.org/Policies/Kdelibs_Coding_Style#Braces

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yi-Jyun Pan]

ppeter added inline comments.

INLINE COMMENTS

> executablefileopendialog.cpp:58
> +
> +if (mode == OnlyExecute) {
> +connect(executeButton, ::clicked, 
> [=]{done(ExecuteFile);});

if (mode == OnlyExecute)
connect(executeButton, ...)
  else if (mode == OpenAsExecute)
...

looks better :)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe retitled this revision from "WIP: Treat 
"application/x-ms-dos-executable" as executable on all platforms" to "Treat 
"application/x-ms-dos-executable" as executable on all platforms".
guoyunhe edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: WIP: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe added a comment.


  It is now working. The condition is so complex. Please help test this patch!
  
  F7541884: image.png 

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: WIP: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe updated this revision to Diff 67458.
guoyunhe added a comment.


  Fix *.exe execution condition

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24463?vs=67444=67458

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

AFFECTED FILES
  src/widgets/executablefileopendialog.cpp
  src/widgets/executablefileopendialog_p.h
  src/widgets/krun.cpp
  src/widgets/krun_p.h

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: WIP: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe retitled this revision from "Treat "application/x-ms-dos-executable" 
as executable on all platforms" to "WIP: Treat 
"application/x-ms-dos-executable" as executable on all platforms".
guoyunhe edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe updated this revision to Diff 67444.
guoyunhe added a comment.


  "openAsExecute" parameter for ExecutableFileOpenDialog

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24463?vs=67424=67444

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

AFFECTED FILES
  src/widgets/executablefileopendialog.cpp
  src/widgets/executablefileopendialog_p.h
  src/widgets/krun.cpp
  src/widgets/krun_p.h

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Ahmad Samir]

ahmadsamir added a reviewer: dfaure.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe added a comment.


  I just realized that this patch might be unfinished. In the pop up, you 
usually have "Open", "Execute" and "Cancel". But for *.exe, "Open" is actually 
to be executed by Wine? "Execute" will do nothing because it isn't a native 
executable for Linux/BSD.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a subscriber: dfaure.
ngraham added a comment.
This revision is now accepted and ready to land.


  I suppose that's true. Would be nice to also do that as a follow-up patch.
  
  Shipit!
  
  @dfaure given the security implications here, maybe we should get this into 
5.63. What do you think?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe added a comment.


  In D24463#543070 , @ngraham wrote:
  
  > Maybe can we check to see if WINE is installed or if there's a handler for 
`application/x-ms-dos-executable`? Otherwise if you don't have WINE installed, 
won't you see a dialog that gives you the option to execute it when that 
doesn't work?
  
  
  It is another feature. We also need to check if PHP/Python/Perl/Ruby/Node.js 
is installed for other script types. It is not Wine specific problem but a 
general issue for all executable that requires an interpreter.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks
Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Nathaniel Graham]

ngraham added a comment.


  Maybe can we check to see if WINE is installed or if there's a handler for 
`application/x-ms-dos-executable`? Otherwise if you don't have WINE installed, 
won't you see a dialog that gives you the option to execute it when that 
doesn't work?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks
Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Kai Uwe Broulik]

broulik added a comment.


  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Because of Wine, *.exe can be executed in almost all desktop platforms. BUG: 
412694

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

AFFECTED FILES
  src/widgets/krun.cpp

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22755: [platforms/xcb] Use XRES extension to get real window PID

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R278:b485043e5633: [platforms/xcb] Use XRES extension to get 
real window PID (authored by davidedmundson).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22755?vs=62588=62589

REVISION DETAIL
  https://phabricator.kde.org/D22755

AFFECTED FILES
  CMakeLists.txt
  src/platforms/xcb/CMakeLists.txt
  src/platforms/xcb/kwindowinfo.cpp
  src/platforms/xcb/kwindowinfo_p_x11.h

To: davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22755: [platforms/xcb] Use XRES extension to get real window PID

[Vlad Zagorodniy]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22755

To: davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22755: [platforms/xcb] Use XRES extension to get real window PID

[David Edmundson]

davidedmundson marked 2 inline comments as done.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D22755

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22755: [platforms/xcb] Use XRES extension to get real window PID

[David Edmundson]

davidedmundson updated this revision to Diff 62588.
davidedmundson edited the summary of this revision.
davidedmundson removed a subscriber: zzag.
davidedmundson added a comment.


  update

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22755?vs=62578=62588

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22755

AFFECTED FILES
  CMakeLists.txt
  src/platforms/xcb/CMakeLists.txt
  src/platforms/xcb/kwindowinfo.cpp
  src/platforms/xcb/kwindowinfo_p_x11.h

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns, zzag

D22755: [platforms/xcb] Use XRES extension to get real window PID

[Vlad Zagorodniy]

zzag added a comment.


  > Querying the NET_WM_ATOM with the NETWM classes remains unchanged
  
  _NET_WM_PID?

INLINE COMMENTS

> kwindowinfo.cpp:85
> +specs.mask = XCB_RES_CLIENT_ID_MASK_LOCAL_CLIENT_PID;
> +auto cookie = xcb_res_query_client_ids(QX11Info::connection(), 1, 
> );
> +

I don't like `auto` here, but on the other hand we don't have yet any policy on 
whether auto is allowed to be used in this case.

> kwindowinfo.cpp:449
>  {
> +if (m_pid > 0) {
> +return m_pid;

Leave a comment that explains why m_pid is preferred.

> kwindowinfo.cpp:462
> +
> +bool KWindowInfoPrivateX11::haveXres()
> +{

Make it a static function instead.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D22755

To: davidedmundson
Cc: zzag, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22755: [platforms/xcb] Use XRES extension to get real window PID

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  It's increasingly common for apps to be in their own PID namespace. If
  this is the case, they report a buggy NET_WM_PID on their windows as
  obviously they don't know their own PID.
  
  This patch uses the XResources extension to query the real PID instead
  of asking the window.
  
  This allows the task manager to know the real PID when doing lookups for
  matching services or showing pulseaudio badges.
  
  Querying the NET_WM_ATOM with the NETWM classes remains unchanged, so we
  still have access to all information should a system need it.
  
  BUG: 384837

TEST PLAN
  The relevant unit test KWindowInfo::testPid() still passes whilst using
  this new extension.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22755

AFFECTED FILES
  CMakeLists.txt
  src/platforms/xcb/CMakeLists.txt
  src/platforms/xcb/kwindowinfo.cpp
  src/platforms/xcb/kwindowinfo_p_x11.h

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D12557: [XCF/GIMP loader] Raise maximimum allowed image size to 32767x32767 on 64 bit platforms

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R287:19f33239e7a7: [XCF/GIMP loader] Raise maximimum allowed 
image size to 32767x32767 on 64 bit… (authored by cfeck).

REPOSITORY
  R287 KImageFormats

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12557?vs=33184=33467

REVISION DETAIL
  https://phabricator.kde.org/D12557

AFFECTED FILES
  src/imageformats/xcf.cpp

To: cfeck, alexmerry, dfaure
Cc: #frameworks, michaelh, bruns

D12557: [XCF/GIMP loader] Raise maximimum allowed image size to 32767x32767 on 64 bit platforms

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D12557

To: cfeck, alexmerry, dfaure
Cc: #frameworks, michaelh, bruns

D12557: [XCF/GIMP loader] Raise maximimum allowed image size to 32767x32767 on 64 bit platforms

[Christoph Feck]

cfeck created this revision.
cfeck added a reviewer: alexmerry.
cfeck added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
cfeck requested review of this revision.

REVISION SUMMARY
  The GIMP image loader had a limit to 16K x 16K pixels, because this would 
already exhaust the 2 GByte address space limit of 32 bit systems.
  
  Remove this limit on 64 bit systems to allow the full 32K x 32K size.
  
  BUG: 391970

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D12557

AFFECTED FILES
  src/imageformats/xcf.cpp

To: cfeck, alexmerry
Cc: #frameworks, michaelh, bruns

[sysadmin/ci-tooling] helpers: Don't allow the dependency diagram data generation process to run on secondary platforms either.

[Ben Cooksley]

Git commit 15c5d9a75f87ff5ac78fd8aff2824faa6fdaa349 by Ben Cooksley.
Committed on 23/01/2018 at 07:41.
Pushed by bcooksley into branch 'master'.

Don't allow the dependency diagram data generation process to run on secondary 
platforms either.
This runs into the same issue that the cmake dependency metadata extraction 
process did, which I fixed in a603dc47b518eb1f6d94379f19345748ebd7fb3a

CCMAIL: kde-frameworks-devel@kde.org

M  +6-0helpers/generate-dependency-diagram-data.py

https://commits.kde.org/sysadmin/ci-tooling/15c5d9a75f87ff5ac78fd8aff2824faa6fdaa349

diff --git a/helpers/generate-dependency-diagram-data.py 
b/helpers/generate-dependency-diagram-data.py
index be5f549..e527151 100755
--- a/helpers/generate-dependency-diagram-data.py
+++ b/helpers/generate-dependency-diagram-data.py
@@ -20,6 +20,12 @@ buildEnvironment = EnvironmentHandler.generateFor( 
installPrefix=arguments.using
 # We'll assume that the directory we're running from is where the sources are 
located
 sourcesLocation = os.getcwd()
 
+# Are we allowed to run?
+# We only gather this metadata from the principal Linux platform, which at the 
moment is SUSEQt5.7 for Frameworks and SUSEQt5.9 for everyone else
+if arguments.platform != 'SUSEQt5.7' and arguments.platform != 'SUSEQt5.9':
+   # Then there is nothing for us to do
+   sys.exit(0)
+
 # First determine where we the data will be stored, both temporarily and on 
the server
 # As the API documentation can only be generated once, and we have the 
greatest capacity available for Linux we will use Linux dependency diagrams on 
api.kde.org.
 outputDirectory = os.path.join( sourcesLocation, 'dotdata' )

[sysadmin/ci-tooling] helpers: Ensure the cmake dependency metadata extraction process only runs for our primary platforms.

[Ben Cooksley]

Git commit a603dc47b518eb1f6d94379f19345748ebd7fb3a by Ben Cooksley.
Committed on 05/01/2018 at 10:37.
Pushed by bcooksley into branch 'master'.

Ensure the cmake dependency metadata extraction process only runs for our 
primary platforms.
Frameworks had a slight issue here as it has both Qt 5.10 and Qt 5.7 builds on 
Linux at the moment.
Depending on the assigned builders it is quite possible both builds when 
triggered will reach this script at essentially the same time, creating a race 
condition when it comes to updating the destination server (api.kde.org)
To ensure we don't fail, ensure we only run on the primary platforms.

CCMAIL: kde-frameworks-devel@kde.org

M  +6-0helpers/extract-cmake-dependency-metadata.py

https://commits.kde.org/sysadmin/ci-tooling/a603dc47b518eb1f6d94379f19345748ebd7fb3a

diff --git a/helpers/extract-cmake-dependency-metadata.py 
b/helpers/extract-cmake-dependency-metadata.py
index 96f8428..2e39612 100755
--- a/helpers/extract-cmake-dependency-metadata.py
+++ b/helpers/extract-cmake-dependency-metadata.py
@@ -25,6 +25,12 @@ buildEnvironment = EnvironmentHandler.generateFor( 
installPrefix=arguments.using
 sourcesLocation = os.getcwd()
 buildLocation = CommonUtils.buildDirectoryForSources( sources=sourcesLocation, 
inSourceBuild=buildSpecification['in-source-build'] )
 
+# Are we allowed to run?
+# We only gather this metadata from the principal Linux platform, which at the 
moment is SUSEQt5.7 for Frameworks and SUSEQt5.9 for everyone else
+if arguments.platform != 'SUSEQt5.7' and arguments.platform != 'SUSEQt5.9':
+   # Then there is nothing for us to do
+   sys.exit(0)
+
 # Determine the name we'll use to store the results, as well as the local and 
remote paths it will be stored at
 # We use the package name as it's pretty much guaranteed to be unique among 
all the builds we will be running
 # As the CMake dependency metadata is only used by Linux packagers, we don't 
need to take platform into account here

D9076: Have an application that can cross-check if the promised platforms are correct

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R857:235e202a1374: Have an application that can cross-check if 
the promised platforms are correct (authored by apol).

REPOSITORY
  R857 CI System Tooling

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9076?vs=23784=23829

REVISION DETAIL
  https://phabricator.kde.org/D9076

AFFECTED FILES
  helpers/check-platform.py

To: apol, #frameworks, bcooksley
Cc: adridg, bcooksley, dfaure

D9076: Have an application that can cross-check if the promised platforms are correct

[Ben Cooksley]

bcooksley accepted this revision.
bcooksley added a comment.
This revision is now accepted and ready to land.


  Perfect. Lets get this committed.

REPOSITORY
  R857 CI System Tooling

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9076

To: apol, #frameworks, bcooksley
Cc: adridg, bcooksley, dfaure

D9076: Have an application that can cross-check if the promised platforms are correct

[Aleix Pol Gonzalez]

apol added a comment.


  In https://phabricator.kde.org/D9076#178587, @bcooksley wrote:
  
  > This can go in from my perspective, code looks fine from my understanding 
of it.
  >
  > In terms of 'All' as a platform, how is that handled? (assuming that's a 
valid specification in the Frameworks metadata.yaml files)
  
  
  See line 29, if 'all' we replace it with the list of all the platforms we 
know.

REPOSITORY
  R857 CI System Tooling

REVISION DETAIL
  https://phabricator.kde.org/D9076

To: apol, #frameworks
Cc: adridg, bcooksley, dfaure

D9076: Have an application that can cross-check if the promised platforms are correct

[Ben Cooksley]

bcooksley added a comment.


  This can go in from my perspective, code looks fine from my understanding of 
it.
  
  In terms of 'All' as a platform, how is that handled? (assuming that's a 
valid specification in the Frameworks metadata.yaml files)

REPOSITORY
  R857 CI System Tooling

REVISION DETAIL
  https://phabricator.kde.org/D9076

To: apol, #frameworks
Cc: adridg, bcooksley, dfaure

D9076: Have an application that can cross-check if the promised platforms are correct

[Aleix Pol Gonzalez]

apol updated this revision to Diff 23784.
apol added a comment.


  Wording, FreeBSDQt5.9

REPOSITORY
  R857 CI System Tooling

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9076?vs=23189=23784

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9076

AFFECTED FILES
  helpers/check-platform.py

To: apol, #frameworks
Cc: adridg, bcooksley, dfaure

D9076: Have an application that can cross-check if the promised platforms are correct

[Aleix Pol Gonzalez]

apol marked an inline comment as done.
apol added a comment.


  In https://phabricator.kde.org/D9076#177399, @adridg wrote:
  
  > To understand the expected output better: suppose something says 
"platforms: All", like kcontacts. If there's no actual build configured in CI 
for that something, for FreeBSD, it will say "FreeBS is a disabled platform". 
The message can probably be improved, then.
  
  
  See new version of the patch, should be better.
  
  > And how about checking the reverse, too? CI builds that are not listed in 
the metainfo? (if that can even happen)
  
  Sure, can be a v2 of the script ;)

REPOSITORY
  R857 CI System Tooling

REVISION DETAIL
  https://phabricator.kde.org/D9076

To: apol, #frameworks
Cc: adridg, bcooksley, dfaure

D9076: Have an application that can cross-check if the promised platforms are correct

[Ben Cooksley]

bcooksley added a comment.


  The FreeBSD platform name was changed this week yes. I can't see any explicit 
handling for 'All' being specified as a platform in the metainfo file here 
though, unless one is always required to list the platforms explicitly?

REPOSITORY
  R857 CI System Tooling

REVISION DETAIL
  https://phabricator.kde.org/D9076

To: apol, #frameworks
Cc: adridg, bcooksley, dfaure

D9076: Have an application that can cross-check if the promised platforms are correct

[Adriaan de Groot]

adridg added a comment.


  To understand the expected output better: suppose something says "platforms: 
All", like kcontacts. If there's no actual build configured in CI for that 
something, for FreeBSD, it will say "FreeBS is a disabled platform". The 
message can probably be improved, then. And how about checking the reverse, 
too? CI builds that are not listed in the metainfo? (if that can even happen)

INLINE COMMENTS

> check-platform.py:15
> +'SUSEQt5.7': 'Linux',
> +'FreeBSDQt5.7': 'FreeBSD',
> +'WindowsMSVCQt5.9': 'Windows',

I think this was just renamed ,  to Qt5.9 (check with Ben though)

REPOSITORY
  R857 CI System Tooling

REVISION DETAIL
  https://phabricator.kde.org/D9076

To: apol, #frameworks
Cc: adridg, bcooksley, dfaure

D9076: Have an application that can cross-check if the promised platforms are correct

[Ben Cooksley]

bcooksley added a comment.


  In principle I think this code is doing the right thing as it's comparing 
what's enabled on CI vs. what's enabled in the Framework's own metadata files.
  Any comments in that regard David?

REPOSITORY
  R857 CI System Tooling

REVISION DETAIL
  https://phabricator.kde.org/D9076

To: apol, #frameworks
Cc: bcooksley, dfaure

D9076: Have an application that can cross-check if the promised platforms are correct

[Aleix Pol Gonzalez]

apol added a comment.


  > Cool stuff, but who will run this tool and when?
  
  `¯\_(ツ)_/¯`
  
  Exciting times, isn't it?
  
  My plan was to discuss with sysadmin where to deploy it once we agree it's 
something we want.
  Here, we basically need to agree that it's the right metric to move forward.

REPOSITORY
  R857 CI System Tooling

REVISION DETAIL
  https://phabricator.kde.org/D9076

To: apol, #frameworks
Cc: bcooksley, dfaure

D9076: Have an application that can cross-check if the promised platforms are correct

[Ben Cooksley]

bcooksley added a comment.


  Neat. I'm curious as to where it'll be used as well, but otherwise it looks 
fine to me.

REPOSITORY
  R857 CI System Tooling

REVISION DETAIL
  https://phabricator.kde.org/D9076

To: apol, #frameworks
Cc: bcooksley, dfaure

D9076: Have an application that can cross-check if the promised platforms are correct

[David Faure]

dfaure added a comment.


  Cool stuff, but who will run this tool and when?

REPOSITORY
  R857 CI System Tooling

REVISION DETAIL
  https://phabricator.kde.org/D9076

To: apol, #frameworks
Cc: dfaure

D9076: Have an application that can cross-check if the promised platforms are correct

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.

REVISION SUMMARY
  In KDE Frameworks projects (and some others) we have a metainfo.yaml file
  that tells us which platforms it's supposed to work on. This is never
  checked other than by maintainers.
  This tool notifies us about a framework saying that a platform is available
  when it's not even part of our CI.

TEST PLAN
kcompletion: Android is a disabled platform
kcontacts: FreeBSD is a disabled platform
kdewebkit: Linux is a disabled platform
kidentitymanagement: FreeBSD is a disabled platform
syntax-highlighting: Android is a disabled platform

REPOSITORY
  R857 CI System Tooling

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9076

AFFECTED FILES
  helpers/check-platform.py

To: apol, #frameworks

[sysadmin/ci-tooling] build-specs/Frameworks: Revoke test execution for extra-cmake-modules across all platforms.

[Ben Cooksley]

Git commit 45ff1bc4ecb18ad71ad0570f7e838d1ae7cab2e2 by Ben Cooksley.
Committed on 27/09/2017 at 09:04.
Pushed by bcooksley into branch 'master'.

Revoke test execution for extra-cmake-modules across all platforms.
The tests in their current condition are incompatible with being run prior to 
installation, and leave the build directory unusable following their execution.
This means that brokeness in ECM won't be seen anywhere in the CI system until 
it is picked up the Dependency Rebuild jobs, after which point the impact will 
be KDE wide.
To ensure that the rest of Frameworks is built using the most recent version of 
ECM - and thus ensure any brokeness in ECM is detected early - we skip running 
tests, which allows installation to succeed.

CCMAIL: kde-frameworks-devel@kde.org
CCMAIL: release-t...@kde.org

A  +5-0build-specs/Frameworks/extra-cmake-modules.yaml

https://commits.kde.org/sysadmin/ci-tooling/45ff1bc4ecb18ad71ad0570f7e838d1ae7cab2e2

diff --git a/build-specs/Frameworks/extra-cmake-modules.yaml 
b/build-specs/Frameworks/extra-cmake-modules.yaml
new file mode 100644
index 000..b235a3b
--- /dev/null
+++ b/build-specs/Frameworks/extra-cmake-modules.yaml
@@ -0,0 +1,5 @@
+kf5-qt5:
+  run-tests: False
+
+stable-kf5-qt5:
+  run-tests: False

Re: Review Request 128420: Name supported platforms in YAML file.

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128420/
---

(Updated July 10, 2016, 5:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit bcf4b0962d984be8720179b37d3c9c8ffaa15e84 by Andreas 
Cord-Landwehr to branch master.


Repository: knotifications


Description
---

There are ifdefs for the platforms Windows and MacOSX, besides Linux.
Hence, it seems logical that all these three platforms are supported.


Diffs
-

  metainfo.yaml 397b3c168d274c0608efc8ba32409ac86d183472 

Diff: https://git.reviewboard.kde.org/r/128420/diff/


Testing
---


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128420: Name supported platforms in YAML file.

[Sune Vuorela]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128420/#review97259
---


Ship it!




Ship It!

- Sune Vuorela


On July 10, 2016, 10:30 a.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128420/
> ---
> 
> (Updated July 10, 2016, 10:30 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> There are ifdefs for the platforms Windows and MacOSX, besides Linux.
> Hence, it seems logical that all these three platforms are supported.
> 
> 
> Diffs
> -
> 
>   metainfo.yaml 397b3c168d274c0608efc8ba32409ac86d183472 
> 
> Diff: https://git.reviewboard.kde.org/r/128420/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128420: Name supported platforms in YAML file.

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128420/
---

Review request for KDE Frameworks.


Repository: knotifications


Description
---

There are ifdefs for the platforms Windows and MacOSX, besides Linux.
Hence, it seems logical that all these three platforms are supported.


Diffs
-

  metainfo.yaml 397b3c168d274c0608efc8ba32409ac86d183472 

Diff: https://git.reviewboard.kde.org/r/128420/diff/


Testing
---


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128234: Name provided platforms

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128234/
---

(Updated June 25, 2016, 5:40 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 5146e2d0918abd22f3444b00cc88ab63b33e1067 by Andreas 
Cord-Landwehr to branch master.


Repository: kded


Description
---

Specify provided platforms. This is only a guess, though. Currently, with the 
platform value missing, all platforms are marked as supported.


Diffs
-

  metainfo.yaml cbc2c3bf2540d1a16ce5bb9b6325614029cbaa82 

Diff: https://git.reviewboard.kde.org/r/128234/diff/


Testing
---


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128235: Specify supported platforms

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128235/
---

(Updated June 25, 2016, 5:39 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit d42402a0b5581707d019bb9db0b074b1775083a1 by Andreas 
Cord-Landwehr to branch master.


Repository: kcmutils


Description
---

Linux as only supported platform is a guess, coming from the fact that it is a 
3rd level tier and I hardly can imaging how it is useful at other platforms.
Please correct me if more platforms are supported.


Diffs
-

  metainfo.yaml 3fe32b2cf6c258dd72052598bc67b1a53f22689f 

Diff: https://git.reviewboard.kde.org/r/128235/diff/


Testing
---


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128234: Name provided platforms

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128234/#review96849
---


Ship it!




There was none, there's one now. We can always add more.

- Aleix Pol Gonzalez


On June 23, 2016, 9:08 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128234/
> ---
> 
> (Updated June 23, 2016, 9:08 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kded
> 
> 
> Description
> ---
> 
> Specify provided platforms. This is only a guess, though. Currently, with the 
> platform value missing, all platforms are marked as supported.
> 
> 
> Diffs
> -
> 
>   metainfo.yaml cbc2c3bf2540d1a16ce5bb9b6325614029cbaa82 
> 
> Diff: https://git.reviewboard.kde.org/r/128234/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128235: Specify supported platforms

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128235/#review96848
---


Ship it!




There's none now. Adding other platforms is always possible.

- Aleix Pol Gonzalez


On June 18, 2016, 9:37 a.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128235/
> ---
> 
> (Updated June 18, 2016, 9:37 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> Linux as only supported platform is a guess, coming from the fact that it is 
> a 3rd level tier and I hardly can imaging how it is useful at other platforms.
> Please correct me if more platforms are supported.
> 
> 
> Diffs
> -
> 
>   metainfo.yaml 3fe32b2cf6c258dd72052598bc67b1a53f22689f 
> 
> Diff: https://git.reviewboard.kde.org/r/128235/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128234: Name provided platforms

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128234/
---

(Updated Juni 23, 2016, 7:08 nachm.)


Review request for KDE Frameworks.


Changes
---

ping...


Repository: kded


Description (updated)
---

Specify provided platforms. This is only a guess, though. Currently, with the 
platform value missing, all platforms are marked as supported.


Diffs
-

  metainfo.yaml cbc2c3bf2540d1a16ce5bb9b6325614029cbaa82 

Diff: https://git.reviewboard.kde.org/r/128234/diff/


Testing
---


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128235: Specify supported platforms

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128235/#review96823
---



ping...

- Andreas Cord-Landwehr


On Juni 18, 2016, 7:37 vorm., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128235/
> ---
> 
> (Updated Juni 18, 2016, 7:37 vorm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> Linux as only supported platform is a guess, coming from the fact that it is 
> a 3rd level tier and I hardly can imaging how it is useful at other platforms.
> Please correct me if more platforms are supported.
> 
> 
> Diffs
> -
> 
>   metainfo.yaml 3fe32b2cf6c258dd72052598bc67b1a53f22689f 
> 
> Diff: https://git.reviewboard.kde.org/r/128235/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

kded5 and "other platforms"

[René J . V . Bertin]

Hi,

David (Faure) mentioned he's been working to port the kcookiejar away from 
kded5 (maybe that has advantages on *n*x too?). Idem for the automatic sycoca 
regeneration, IIRC.

I've been running kded4 and now kded5 as part of a "fullest possible" build & 
install principle under MacPorts on OS X. That's more or less a prerequisite if 
you want cookie support but also support for certificate management in KDE(4) 
applications. I also see even less reason to run that daemon than to run a DBus 
daemon on "other platforms". It's a KDE application that provides background 
services to other KDE apps, and any platform specificity resides in the 
services it runs, not the daemon itself. It probably wouldn't even be very hard 
to think of other-platform-specific services that it might run, a bit like how 
the Baloo framework might provide an interface to Spotlight on OS X (or KWallet 
to the keychain).

Anyway, taking stock of what else I have running I saw the "Network Status" 
service as probably the only other potentially relevant service.
Is this what allows akonadi/KDE PIM to detect when network goes off and on 
line? Because that's a feature that does seem to work in KMail4 c.s. on OS X, 
and it's something I definitely wouldn't want to lose if and when I move to KF5 
PIM.

R.


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128235: Specify supported platforms

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128235/
---

Review request for KDE Frameworks.


Repository: kcmutils


Description
---

Linux as only supported platform is a guess, coming from the fact that it is a 
3rd level tier and I hardly can imaging how it is useful at other platforms.
Please correct me if more platforms are supported.


Diffs
-

  metainfo.yaml 3fe32b2cf6c258dd72052598bc67b1a53f22689f 

Diff: https://git.reviewboard.kde.org/r/128235/diff/


Testing
---


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128234: Name provided platforms

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128234/
---

Review request for KDE Frameworks.


Repository: kded


Description
---

Specify provided platforms


Diffs
-

  metainfo.yaml cbc2c3bf2540d1a16ce5bb9b6325614029cbaa82 

Diff: https://git.reviewboard.kde.org/r/128234/diff/


Testing
---


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128196: Add Android to supported platforms

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128196/
---

(Updated June 16, 2016, 10:30 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Olivier Churlaud.


Changes
---

Submitted with commit f72884d9f031e2239004e6df0ba2569b33b86b14 by Andreas 
Cord-Landwehr to branch master.


Repository: kapidox


Description
---

The individual frameworks will pick that platform up once the platform
is specified in their metainfo files.


Diffs
-

  metainfo.yaml 16811ca 

Diff: https://git.reviewboard.kde.org/r/128196/diff/


Testing
---


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128196: Add Android to supported platforms

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128196/#review96539
---


Ship it!




Ship It!

- David Faure


On June 15, 2016, 4:22 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128196/
> ---
> 
> (Updated June 15, 2016, 4:22 p.m.)
> 
> 
> Review request for KDE Frameworks and Olivier Churlaud.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> The individual frameworks will pick that platform up once the platform
> is specified in their metainfo files.
> 
> 
> Diffs
> -
> 
>   metainfo.yaml 16811ca 
> 
> Diff: https://git.reviewboard.kde.org/r/128196/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128196: Add Android to supported platforms

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128196/
---

Review request for KDE Frameworks and Olivier Churlaud.


Repository: kapidox


Description
---

The individual frameworks will pick that platform up once the platform
is specified in their metainfo files.


Diffs
-

  metainfo.yaml 16811ca 

Diff: https://git.reviewboard.kde.org/r/128196/diff/


Testing
---


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Spread to more platforms - Randa Meetings 2016 open for registration

[Mario Fux]

Good morning everyone

Please excuse this cross-posting but all the above mailing list fit quite well 
this year's topic of the Randa Meetings:

multi-platform end-user application development. This includes stuff like 
improving KDE Frameworks 5 (KF5) on other platforms like MS Windows, Android 
or Apple’s MacOSX, presenting and discussing how software distribution works 
on other systems than GNU/Linux (Windows installers, app stores and 
application bundles) and learning from the experience projects like Krita, 
digiKam, Rkward, Kdenlive & Co collected. We’d like to bring this information 
to more KDE Applications and work on this during a full week.

So if you're interested and can help please go to:
https://sprints.kde.org/sprint/301
and add yourself.

And spread this information and tell people that could be of great help.

This email though is just an informational email and thus not to start a 
discussion.

Thanks and cu soon
Mario
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125070: Setup and install dbus interfaces for all platforms since dbus is a mandatory component.

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125070/#review84890
---



src/api/KWallet/CMakeLists.txt (line 81)
<https://git.reviewboard.kde.org/r/125070/#comment58733>

this line should be removed, too, since KF5Wallet already links to 
Qt5::DBus on line 69.


- David Faure


On Sept. 6, 2015, 8:06 a.m., Samuel Gaist wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125070/
> ---
> 
> (Updated Sept. 6, 2015, 8:06 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> Setup and install dbus interfaces for all platforms since dbus is a mandatory 
> component.
> 
> 
> Diffs
> -
> 
>   src/api/KWallet/CMakeLists.txt 539b034d20a0e10ef7471bcc515b7b3885d617d6 
> 
> Diff: https://git.reviewboard.kde.org/r/125070/diff/
> 
> 
> Testing
> ---
> 
> Build on OS X 10.8
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125070: Setup and install dbus interfaces for all platforms since dbus is a mandatory component.

[Samuel Gaist]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125070/
---

(Updated Sept. 6, 2015, 8:37 a.m.)


Review request for KDE Frameworks.


Repository: kwallet


Description
---

Setup and install dbus interfaces for all platforms since dbus is a mandatory 
component.


Diffs (updated)
-

  src/api/KWallet/CMakeLists.txt 539b034d20a0e10ef7471bcc515b7b3885d617d6 

Diff: https://git.reviewboard.kde.org/r/125070/diff/


Testing
---

Build on OS X 10.8


Thanks,

Samuel Gaist

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

[Laurent Montel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123588/#review79775
---



autotests/kdelibs4configmigratortest.cpp (line 85)
https://git.reviewboard.kde.org/r/123588/#comment54638

You test after copy file ?
It's perhaps more logical to test before no ?


- Laurent Montel


On mai 2, 2015, 8:17 matin, David Faure wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123588/
 ---
 
 (Updated mai 2, 2015, 8:17 matin)
 
 
 Review request for KDE Frameworks and Laurent Montel.
 
 
 Repository: kcoreaddons
 
 
 Description
 ---
 
 Port kdelibs4configmigratortest to QStandardPaths, so it works on other 
 platforms than XDG.
 
 
 Diffs
 -
 
   autotests/kdelibs4configmigratortest.cpp 
 0affd2a6bc86f8e4cad04dd662e1298d34b1e7c1 
 
 Diff: https://git.reviewboard.kde.org/r/123588/diff/
 
 
 Testing
 ---
 
 Still passes on Linux, we'll see if the CI says it fixed it for Mac.
 
 Failure before the fix:
 https://build.kde.org/view/Frameworks%20kf5-qt5/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/17/testReport/junit/%28root%29/TestSuite/kdelibs4configmigratortest/
 
 
 Thanks,
 
 David Faure
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

[Laurent Montel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123588/#review79780
---

Ship it!


Ship it

- Laurent Montel


On mai 2, 2015, 8:17 matin, David Faure wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123588/
 ---
 
 (Updated mai 2, 2015, 8:17 matin)
 
 
 Review request for KDE Frameworks and Laurent Montel.
 
 
 Repository: kcoreaddons
 
 
 Description
 ---
 
 Port kdelibs4configmigratortest to QStandardPaths, so it works on other 
 platforms than XDG.
 
 
 Diffs
 -
 
   autotests/kdelibs4configmigratortest.cpp 
 0affd2a6bc86f8e4cad04dd662e1298d34b1e7c1 
 
 Diff: https://git.reviewboard.kde.org/r/123588/diff/
 
 
 Testing
 ---
 
 Still passes on Linux, we'll see if the CI says it fixed it for Mac.
 
 Failure before the fix:
 https://build.kde.org/view/Frameworks%20kf5-qt5/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/17/testReport/junit/%28root%29/TestSuite/kdelibs4configmigratortest/
 
 
 Thanks,
 
 David Faure
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

[Laurent Montel]

 On mai 2, 2015, 8:50 matin, David Faure wrote:
  autotests/kdelibs4configmigratortest.cpp, line 85
  https://git.reviewboard.kde.org/r/123588/diff/1/?file=365397#file365397line85
 
  The copy that happens above is for creating the KDE4 test files, right?
  
  My QCOMPARE is to ensure that the KF5 file doesn't exist yet. I'm just 
  reusing that foreach loop, really.
  
  The point is to then check the same after migrate() and see that the 
  KF5 file was created.
  
  I can repeat the foreach() if you think it's more readable.

Oh you're right.
Ok I didn't see that it was the code which created kde4 file .
So all is good indeed.


- Laurent


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123588/#review79776
---


On mai 2, 2015, 8:17 matin, David Faure wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123588/
 ---
 
 (Updated mai 2, 2015, 8:17 matin)
 
 
 Review request for KDE Frameworks and Laurent Montel.
 
 
 Repository: kcoreaddons
 
 
 Description
 ---
 
 Port kdelibs4configmigratortest to QStandardPaths, so it works on other 
 platforms than XDG.
 
 
 Diffs
 -
 
   autotests/kdelibs4configmigratortest.cpp 
 0affd2a6bc86f8e4cad04dd662e1298d34b1e7c1 
 
 Diff: https://git.reviewboard.kde.org/r/123588/diff/
 
 
 Testing
 ---
 
 Still passes on Linux, we'll see if the CI says it fixed it for Mac.
 
 Failure before the fix:
 https://build.kde.org/view/Frameworks%20kf5-qt5/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/17/testReport/junit/%28root%29/TestSuite/kdelibs4configmigratortest/
 
 
 Thanks,
 
 David Faure
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123588/
---

Review request for KDE Frameworks and Laurent Montel.


Repository: kcoreaddons


Description
---

Port kdelibs4configmigratortest to QStandardPaths, so it works on other 
platforms than XDG.


Diffs
-

  autotests/kdelibs4configmigratortest.cpp 
0affd2a6bc86f8e4cad04dd662e1298d34b1e7c1 

Diff: https://git.reviewboard.kde.org/r/123588/diff/


Testing
---

Still passes on Linux, we'll see if the CI says it fixed it for Mac.

Failure before the fix:
https://build.kde.org/view/Frameworks%20kf5-qt5/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/17/testReport/junit/%28root%29/TestSuite/kdelibs4configmigratortest/


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123588/#review79776
---



autotests/kdelibs4configmigratortest.cpp (line 85)
https://git.reviewboard.kde.org/r/123588/#comment54639

The copy that happens above is for creating the KDE4 test files, right?

My QCOMPARE is to ensure that the KF5 file doesn't exist yet. I'm just 
reusing that foreach loop, really.

The point is to then check the same after migrate() and see that the KF5 
file was created.

I can repeat the foreach() if you think it's more readable.


- David Faure


On May 2, 2015, 8:17 a.m., David Faure wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123588/
 ---
 
 (Updated May 2, 2015, 8:17 a.m.)
 
 
 Review request for KDE Frameworks and Laurent Montel.
 
 
 Repository: kcoreaddons
 
 
 Description
 ---
 
 Port kdelibs4configmigratortest to QStandardPaths, so it works on other 
 platforms than XDG.
 
 
 Diffs
 -
 
   autotests/kdelibs4configmigratortest.cpp 
 0affd2a6bc86f8e4cad04dd662e1298d34b1e7c1 
 
 Diff: https://git.reviewboard.kde.org/r/123588/diff/
 
 
 Testing
 ---
 
 Still passes on Linux, we'll see if the CI says it fixed it for Mac.
 
 Failure before the fix:
 https://build.kde.org/view/Frameworks%20kf5-qt5/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/17/testReport/junit/%28root%29/TestSuite/kdelibs4configmigratortest/
 
 
 Thanks,
 
 David Faure
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122770: Support KWindowSystem::icon with NETWinInfo on all platforms

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122770/
---

(Updated March 16, 2015, 9:42 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 3306777fe098720238c2e28992b4b21bdea25511 by Martin 
Gräßlin to branch master.


Repository: kwindowsystem


Description
---

If we compile with X11 support we want this method to use the X11
implementation on all platforms and not just on platform xcb. The
NETWinInfo is already so X11 specific that the platform doesn't
matter.

To solve this the method it delegates to in KWindowSystemPrivateX11
is made static. It only operates through the NETWinInfo and doesn't
need anything else from KWindowSystemPrivateX11.


Diffs
-

  src/kwindowsystem.h 21b254b246753d6ee7805864e28284dfa169855e 
  src/kwindowsystem.cpp 97dd6072a77f864b1e08287e8546cc29c24474c6 
  src/kwindowsystem_p_x11.h a507922ba632eb54e9121a1420d83c26d3676c66 

Diff: https://git.reviewboard.kde.org/r/122770/diff/


Testing
---

kwin_wayland (Martin dev branch) shows icons for X11 applications again.


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122770: Support KWindowSystem::icon with NETWinInfo on all platforms

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122770/
---

Review request for KDE Frameworks.


Repository: kwindowsystem


Description
---

If we compile with X11 support we want this method to use the X11
implementation on all platforms and not just on platform xcb. The
NETWinInfo is already so X11 specific that the platform doesn't
matter.

To solve this the method it delegates to in KWindowSystemPrivateX11
is made static. It only operates through the NETWinInfo and doesn't
need anything else from KWindowSystemPrivateX11.


Diffs
-

  src/kwindowsystem.h 21b254b246753d6ee7805864e28284dfa169855e 
  src/kwindowsystem.cpp 97dd6072a77f864b1e08287e8546cc29c24474c6 
  src/kwindowsystem_p_x11.h a507922ba632eb54e9121a1420d83c26d3676c66 

Diff: https://git.reviewboard.kde.org/r/122770/diff/


Testing
---

kwin_wayland (Martin dev branch) shows icons for X11 applications again.


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

platforms

[Jeremy Whiting]

Do we support building and using frameworks on Windows CE anymore? I
don't see it on
http://qt-project.org/doc/qt-4.8/supported-platforms.html so I guess
not, is that correct? If not I can clean up some old ifdefs in
knewstuff sources.

thanks,
Jeremy
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: platforms

[Andrius da Costa Ribas]

It can be cleaned up ... other WinCE specifics had already been cleaned up
in frameworks.

2014-10-13 20:59 GMT-03:00 Jeremy Whiting jpwhit...@kde.org:

 Do we support building and using frameworks on Windows CE anymore? I
 don't see it on
 http://qt-project.org/doc/qt-4.8/supported-platforms.html so I guess
 not, is that correct? If not I can clean up some old ifdefs in
 knewstuff sources.

 thanks,
 Jeremy
 ___
 Kde-frameworks-devel mailing list
 Kde-frameworks-devel@kde.org
 https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

How to properly encode the supported platforms on api.kde.org?

[Martin Gräßlin]

Hi,

I wanted to ask how the platforms on the overview of 
http://api.kde.org/frameworks-api/frameworks5-apidocs/ are supposed to be 
read.

E.g. for kwindowsystem it looks like:
* Linux supported
* Windows not supported
* MacOS X not supported

This is only half of the story, though. The framework can be compiled and used 
on all platforms. It just uses a fallback on Windows and MacOS. The same is 
also the case for Linux on non-X11. Even with a working backend on non-X11 
some parts of the API will only be available on X11.

What should I use in the metadata file to encode this correctly? I would 
prefer to have Windows and MacOS X not being crossed out, as that could be 
read like cannot use and would limit the possible usage of the framework.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: How to properly encode the supported platforms on api.kde.org?

[Alex Merry]

On 22/05/14 08:21, Martin Gräßlin wrote:
 Hi,
 
 I wanted to ask how the platforms on the overview of 
 http://api.kde.org/frameworks-api/frameworks5-apidocs/ are supposed to be 
 read.
 
 E.g. for kwindowsystem it looks like:
 * Linux supported
 * Windows not supported
 * MacOS X not supported
 
 This is only half of the story, though. The framework can be compiled and 
 used 
 on all platforms. It just uses a fallback on Windows and MacOS. The same is 
 also the case for Linux on non-X11. Even with a working backend on non-X11 
 some parts of the API will only be available on X11.
 
 What should I use in the metadata file to encode this correctly? I would 
 prefer to have Windows and MacOS X not being crossed out, as that could be 
 read like cannot use and would limit the possible usage of the framework.

Something like:

platforms:
- name: Linux
- name: MacOSX
  note: Not all features supported
- name: Windows
  note: Not all features supported

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Allocating kde-runtime/platforms/win

[Aleix Pol]

On Thu, Feb 20, 2014 at 6:46 PM, Aleix Pol aleix...@kde.org wrote:

 Hi!
 I am going through the list of things where we're moving kde-runtime
 components to [1] and I see that there's a platform/win directory.

 Do you agree that having it in a separate repository would be the best?
 Could anybody with a working KF5 + windows system (if that exists) work on
 it?

 Thanks
 Aleix

 [1] http://community.kde.org/Frameworks/Epics/New_Runtime_Organization


So if nobody disagrees, we'll split it out into a KWindowsAddons repository
and hope somebody will find a use for it some day.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Allocating kde-runtime/platforms/win

[Kevin Ottens]

On Monday 24 March 2014 19:01:14 Aleix Pol wrote:
 So if nobody disagrees, we'll split it out into a KWindowsAddons repository
 and hope somebody will find a use for it some day.

No objection to have it as separate repository. Just to clarify though: won't 
be part of a KF5.0, afaict it's not something with API.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Allocating kde-runtime/platforms/win

[Alexander Richardson]

2014-02-21 1:17 GMT+01:00 Andrius da Costa Ribas andrius...@gmail.com:
 Afaik only Alexander Richardson is currently working on KF5 on Windows, but
 I think this kcm module is more related to plasma-workspace destination,
 given the settings it provides (see attached image)

 Em 20/02/2014 14:47, Aleix Pol aleix...@kde.org escreveu:

 Hi!
 I am going through the list of things where we're moving kde-runtime
 components to [1] and I see that there's a platform/win directory.

 Do you agree that having it in a separate repository would be the best?
 Could anybody with a working KF5 + windows system (if that exists) work on
 it?

 Thanks
 Aleix

 [1] http://community.kde.org/Frameworks/Epics/New_Runtime_Organization



Hi,

I won't try to get this working, my only goal with the Windows effort
is to be able to run Kate and Okteta on Windows so I can use them at
work.
This seems to be more about platform integration which I'm not
interested in. Hopefully someone from the kde-windows team can pick
this up.
Developing on Windows is such a pain, I don't want to spend more time
than necessary there.
Once I have managed to get all frameworks (except kdesupport, since
that has so many compile errors that I won't even try) to compile and
pass the tests I will be back to Linux-only work. I will still run the
tests every few days/weeks to make sure no regressions are introduced,
but I don't feel like doing any more Windows work.

Regards
Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Allocating kde-runtime/platforms/win

[Aleix Pol]

Hi!
I am going through the list of things where we're moving kde-runtime
components to [1] and I see that there's a platform/win directory.

Do you agree that having it in a separate repository would be the best?
Could anybody with a working KF5 + windows system (if that exists) work on
it?

Thanks
Aleix

[1] http://community.kde.org/Frameworks/Epics/New_Runtime_Organization
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115289: Search for LibIntl, not all platforms include it in libc

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115289/
---

(Updated Jan. 26, 2014, 4:54 p.m.)


Review request for KDE Frameworks and Chusslove Illich.


Changes
---

check whether libintl needs a separate library by using check_symbol_exists


Summary (updated)
-

Search for LibIntl, not all platforms include it in libc


Repository: ki18n


Description (updated)
---

Search for LibIntl, not all platforms include it in libc

This is required on e.g. Windows, but also any other system that does
not use glibc as the default C library


Fix linking on MSVC by using KTRANSCRIPT_EXPORT


Diffs (updated)
-

  cmake/FindLibIntl.cmake PRE-CREATION 
  src/CMakeLists.txt bfb7d793a8cea883378555368eeec7582e8f88b1 
  src/gettext.h 3d3c2733576b5d2b977c3360519636662caf18c5 
  src/kcatalog.cpp d337a50fb973e810e549671b60b2227db78d0628 
  src/ktranscript.cpp e0570f1cccabb8e3a59ff952eac2817081ec4e9e 
  CMakeLists.txt 165f8c84156ebdb5034424752cc5f80a5d70319c 

Diff: https://git.reviewboard.kde.org/r/115289/diff/


Testing
---

Compiles on Windows, no change to Linux


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115289: Search for LibIntl, not all platforms include it in libc

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115289/#review48298
---

Ship it!


Looks good!

- Alex Merry


On Jan. 26, 2014, 3:54 p.m., Alexander Richardson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115289/
 ---
 
 (Updated Jan. 26, 2014, 3:54 p.m.)
 
 
 Review request for KDE Frameworks and Chusslove Illich.
 
 
 Repository: ki18n
 
 
 Description
 ---
 
 Search for LibIntl, not all platforms include it in libc
 
 This is required on e.g. Windows, but also any other system that does
 not use glibc as the default C library
 
 
 Fix linking on MSVC by using KTRANSCRIPT_EXPORT
 
 
 Diffs
 -
 
   cmake/FindLibIntl.cmake PRE-CREATION 
   src/CMakeLists.txt bfb7d793a8cea883378555368eeec7582e8f88b1 
   src/gettext.h 3d3c2733576b5d2b977c3360519636662caf18c5 
   src/kcatalog.cpp d337a50fb973e810e549671b60b2227db78d0628 
   src/ktranscript.cpp e0570f1cccabb8e3a59ff952eac2817081ec4e9e 
   CMakeLists.txt 165f8c84156ebdb5034424752cc5f80a5d70319c 
 
 Diff: https://git.reviewboard.kde.org/r/115289/diff/
 
 
 Testing
 ---
 
 Compiles on Windows, no change to Linux
 
 
 Thanks,
 
 Alexander Richardson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115289: Search for LibIntl, not all platforms include it in libc

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115289/
---

(Updated Jan. 26, 2014, 5:33 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Chusslove Illich.


Repository: ki18n


Description
---

Search for LibIntl, not all platforms include it in libc

This is required on e.g. Windows, but also any other system that does
not use glibc as the default C library


Fix linking on MSVC by using KTRANSCRIPT_EXPORT


Diffs
-

  cmake/FindLibIntl.cmake PRE-CREATION 
  src/CMakeLists.txt bfb7d793a8cea883378555368eeec7582e8f88b1 
  src/gettext.h 3d3c2733576b5d2b977c3360519636662caf18c5 
  src/kcatalog.cpp d337a50fb973e810e549671b60b2227db78d0628 
  src/ktranscript.cpp e0570f1cccabb8e3a59ff952eac2817081ec4e9e 
  CMakeLists.txt 165f8c84156ebdb5034424752cc5f80a5d70319c 

Diff: https://git.reviewboard.kde.org/r/115289/diff/


Testing
---

Compiles on Windows, no change to Linux


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel