Re: Review Request 126113: make event filters static to decrease installed filters on qApp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/#review88649 --- src/plasma/svg.cpp (line 581)

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/ --- (Updated Nov. 20, 2015, 1:27 p.m.) Status -- This change has been

Re: Review Request 126087: Move the i18n context from KDeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126087/ --- (Updated Nov. 20, 2015, 3:03 p.m.) Review request for KDE Frameworks,

Re: Review Request 126123: [Linux/Kubuntu] find udev when installing to a parallel prefix

> On Nov. 20, 2015, 1:44 p.m., Martin Gräßlin wrote: > > The need for the change surprises me. I have been using a /opt setup for > > years and udev was always found. Can you show the error you hit? > > René J.V. Bertin wrote: > Have you been using a Linux distro like Ubuntu that has

Re: Review Request 126087: Move the i18n context from KDeclarative

> On Nov. 20, 2015, 2:33 p.m., Chusslove Illich wrote: > > src/klocalizedcontext.cpp, line 87 > > > > > > How are numbers converted to strings, before being passed here? Because > > when it receives actual

Re: Review Request 126087: Move the i18n context from KDeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126087/#review88648 --- src/klocalizedcontext.h (line 28)

Re: Review Request 126123: [Linux/Kubuntu] find udev when installing to a parallel prefix

> On Nov. 20, 2015, 1:44 p.m., Martin Gräßlin wrote: > > The need for the change surprises me. I have been using a /opt setup for > > years and udev was always found. Can you show the error you hit? > > René J.V. Bertin wrote: > Have you been using a Linux distro like Ubuntu that has

Re: Review Request 126123: [Linux/Kubuntu] find udev when installing to a parallel prefix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126123/#review88645 --- The need for the change surprises me. I have been using a

Re: Review Request 126123: [Linux/Kubuntu] find udev when installing to a parallel prefix

> On Nov. 20, 2015, 1:44 p.m., Martin Gräßlin wrote: > > The need for the change surprises me. I have been using a /opt setup for > > years and udev was always found. Can you show the error you hit? Have you been using a Linux distro like Ubuntu that has multi-arch, with the actual libraries

Re: KGlobalAccel on ~Linux?

David Faure wrote: > On Friday 13 November 2015 22:04:35 René J. V. Bertin wrote: >> I can imagine that the session dbus doesn't look in /opt/local by default on >> Linux (guess I'll have to look into that) > > Right. Add /opt/local/share to XDG_DATA_DIRS before starting the DBus daemon, >

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/ --- (Updated Nov. 20, 2015, 11:18 a.m.) Review request for KDE Frameworks

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

> On Nov. 19, 2015, 5:38 p.m., David Edmundson wrote: > > src/plasma/svg.cpp, line 47 > > > > > > An SVG with colours will have a Theme object (via > > SvgPrivate::cacheAndColorsTheme()) > > > >

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/ --- (Updated Nov. 20, 2015, 12:19 p.m.) Review request for KDE Frameworks

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

> On Nov. 20, 2015, 12:35 p.m., David Edmundson wrote: > > src/plasma/svg.cpp, line 590 > > > > > > we may as well remove this method then? Edit. obviously we can't. Ignore me. - David

Review Request 126123: [Linux/Kubuntu] find udev when installing to a parallel prefix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126123/ --- Review request for KDE Frameworks. Repository: solid Description

Re: Review Request 126119: remove unused platformstatus kded

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126119/ --- (Updated Nov. 20, 2015, 10:19 a.m.) Status -- This change has been

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/#review88643 --- Ship it! src/plasma/svg.cpp (line 590)

Re: Review Request 126087: Move the i18n context from KDeclarative

> On Nov. 19, 2015, 5:21 p.m., Marco Martin wrote: > > so let's go for that and then add the import with the singleton as well, if > > is okay for framework maintainer are fine with the qtqml dependency.. but > > they should be as the "everything in kdeclarative" situation has to be > >

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

On Thursday November 19 2015 19:15:39 René J.V. Bertin wrote: > ... Grand Central Dispatch ... https://github.com/RJVB/KIdleTiming/commit/9514bf13b1d921e481fa6074d08fef58139dd986 Deliciously imprecise for the amateurs: almost 10% late almost systematically for the first 5000ms timeout of the

Re: Review Request 126123: [Linux/Kubuntu] find udev when installing to a parallel prefix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126123/ --- (Updated Nov. 20, 2015, 5:13 p.m.) Status -- This change has been

Re: Review Request 126123: [Linux/Kubuntu] find udev when installing to a parallel prefix

> On Nov. 20, 2015, 1:44 p.m., Martin Gräßlin wrote: > > The need for the change surprises me. I have been using a /opt setup for > > years and udev was always found. Can you show the error you hit? > > René J.V. Bertin wrote: > Have you been using a Linux distro like Ubuntu that has

Review Request 126125: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126125/ --- Review request for KDE Software on Mac OS X, KDE Frameworks and David

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126125/#review88662 --- src/ioslaves/trash/trashimpl.cpp (line 941)

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126125/ --- (Updated Nov. 20, 2015, 10:09 p.m.) Review request for KDE Software on

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

> On Nov. 20, 2015, 10:06 p.m., René J.V. Bertin wrote: > > src/ioslaves/trash/trashimpl.cpp, line 947 > > > > > > These were `kDebug()` statements; I guess they should become > > `qWarning()` now that `kDebug`

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126125/#review88664 --- src/ioslaves/trash/trashimpl.cpp (line 129)