D11414: [xcb] Fix implementation of _NET_WM_FULLSCREEN_MONITORS

kossebau added inline comments. INLINE COMMENTS > netwm.cpp:2845-2847 > +const uint32_t data[5] = { > +topology.top, topology.bottom, topology.left, topology.right, 1 > +}; Seems clang (at least as of FreeBSD with -Wc++11-narrowing) does not like this narrowing from

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 30271. Kanedias added a comment. - Implement releasing of client-freed output - Review fixes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=25976=30271 BRANCH gbm-vnc REVISION DETAIL

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 30273. Kanedias marked an inline comment as done. Kanedias added a comment. - Merge branch 'master' into gbm-vnc REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=30272=30273 BRANCH gbm-vnc REVISION DETAIL

D1231: Add Remote Access interface to KWayland

Kanedias marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson, romangg Cc: jtamate, jgrulich, romangg, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, schernikov, michaelh,

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.9 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/15/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 23 Mar 2018 07:56:17 + Build duration: 5 min 15 sec and counting JUnit Tests

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/23/ Project: Frameworks krunner kf5-qt5 SUSEQt5.10 Date of build: Fri, 23 Mar 2018 07:56:16 + Build duration: 4 min 2 sec and counting JUnit Tests

D11570: Introduce GamingInputBattery type

broulik added a dependent revision: D11571: [Battery Monitor] Support "Gaming Input Battery type". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11570 To: broulik, #frameworks, apol, dollinger, lbeltrame Cc: michaelh, ngraham

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.9 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.9/6/ Project: Frameworks krunner kf5-qt5 SUSEQt5.9 Date of build: Fri, 23 Mar 2018 07:56:17 + Build duration: 16 min and counting JUnit Tests Name:

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 30272. Kanedias added a comment. Remove already merged changes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=30271=30272 BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1231 AFFECTED FILES

D11487: optimization of TextLineData::attribute

mwolff added a comment. In D11487#231656 , @jtamate wrote: > In D11487#231522 , @mwolff wrote: > > > @jtamate looking at your screenshots, it represents closely what I see locally. Most notably,

D11487: optimization of TextLineData::attribute

mwolff added a comment. Also, what is "@mwolf solution" - I didn't provide any code, until now: diff --git a/src/spellcheck/spellcheck.cpp b/src/spellcheck/spellcheck.cpp index 9e04d788..3a97e5c5 100644 --- a/src/spellcheck/spellcheck.cpp +++ b/src/spellcheck/spellcheck.cpp

D11602: Fix build on Android

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. apol requested review of this revision. REVISION SUMMARY fstab backend didn't build and probavbly wouldn't work anyway. TEST PLAN Built REPOSITORY R245 Solid BRANCH master

D11605: Fix look-up of KF5::Auth

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. apol requested review of this revision. REVISION SUMMARY It wasn't being searched, I'm guessing it's working on some systems because it's a dependency of a dependency. TEST PLAN

D11604: kdirlistertest doesn't fail at random

apol added inline comments. INLINE COMMENTS > kdirlistertest.cpp:194 > +for (int i = 0; i < 1000 ; i++) { > +createSimpleFile(path + QString("toplevelfile_new_%1").arg(i)); > +} Should be QStringLiteral("") instead of QString(""). REPOSITORY R241 KIO REVISION DETAIL

D11604: kdirlistertest doesn't fail at random

jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY - Instead of testing the creation and deletion of one file, do it with 1000 files. - test the mime type

D11605: Fix look-up of KF5::Auth

apol updated this revision to Diff 30289. apol added a comment. small changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11605?vs=30288=30289 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11605 AFFECTED FILES CMakeLists.txt To: apol,

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 180 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/180/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 23 Mar 2018 17:31:25 + Build duration: 37 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 85 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/85/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 23 Mar 2018 19:02:41 + Build duration: 5 min 11 sec and counting

D10820: Send slave's polkit authorization status to the host

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH D10820 REVISION DETAIL https://phabricator.kde.org/D10820 To: chinmoyr, dfaure Cc: anthonyfieroni, #frameworks, michaelh, ngraham

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 110 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/110/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 23 Mar 2018 19:02:41 + Build duration: 7 min 7 sec and counting

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/13/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Fri, 23 Mar 2018 17:53:21 + Build duration: 1 min 36 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/36/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Fri, 23 Mar 2018 17:53:21 + Build duration: 1 min 45 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/30/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 23 Mar 2018 17:53:21 + Build duration: 1 min 55 sec and counting JUnit Tests

D11619: Add entities for Elisa, Markdown, KParts, DOT, SVG

lueck created this revision. lueck added a reviewer: Documentation. Restricted Application added projects: Frameworks, Documentation. Restricted Application added a subscriber: Frameworks. lueck requested review of this revision. REPOSITORY R238 KDocTools REVISION DETAIL

D11552: [WIP] Handle CJK characters

michaelh added a comment. @cfeck: Thanks a lot for your help. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11552 To: michaelh, hein Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham

D11487: optimization of TextLineData::attribute

jtamate added a comment. In D11487#232497 , @mwolff wrote: > @jtamate I just checked, the function is called with the same parameters for me locally. What output do you get for this: > > For me this is the interesting bit: > > 15.097

D11610: clang-tidy: modernize-use-default-member-init run

dhaumann added a comment. I like this a lot, but have not done a review yet. Will do later. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11610 To: kfunk Cc: dhaumann, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars

D11552: [WIP] Handle CJK characters

cfeck resigned from this revision. This revision now requires review to proceed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11552 To: michaelh, hein Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella,

D11552: [WIP] Handle CJK characters

cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. The Unicode handling looks correct. REPOSITORY R293 Baloo BRANCH cjk (branched from master) REVISION DETAIL https://phabricator.kde.org/D11552 To: michaelh, hein, cfeck Cc: bruns,

D11487: optimization of TextLineData::attribute

mwolff added a comment. WTF :D Your desktop CPU has clearly a better performance than my mobile CPU, no? Is AMD really so much worse here? How can that be - I don't get it :D Anyhow, I give up trying to understand this now - thanks a lot for your repeated input Jaime! REPOSITORY R39

D11569: Improve consistency of "Open With" UI by always showing top app inline

abetts added a comment. This may be different than this patch is intending to address. Let me know if that's the case. Another thing that adds more characters to the menus are the long names that our applications have. Firefox Web Browser Gwenview Image Editor GIMP Image Editor

D11487: optimization of TextLineData::attribute

mwolff added a comment. @jtamate I just checked, the function is called with the same parameters for me locally. What output do you get for this: diff --git a/src/spellcheck/spellcheck.cpp b/src/spellcheck/spellcheck.cpp index 9e04d788..50e92885 100644 ---

D11569: Improve consistency of "Open With" UI by always showing top app inline

rkflx added a comment. Looked at this now: The first iterations with the long list of apps and the header were not all that great (in particular for folders the list got much too long), but after @anthonyfieroni's idea I guess the current version is quite good. Showing the default app again

D11569: Improve consistency of "Open With" UI by always showing top app inline

rkflx added a comment. In D11569#232567 , @abetts wrote: > the long names that our applications have. @ngraham I don't see that on my system. Is this a custom Kubuntu patch changing some default again in your screenshot? For Open With

D11610: clang-tidy: modernize-use-default-member-init run

kfunk created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. kfunk requested review of this revision. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D11610 AFFECTED FILES

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/24/ Project: Frameworks krunner kf5-qt5 SUSEQt5.10 Date of build: Fri, 23 Mar 2018 12:45:08 + Build duration: 9 min 6 sec and counting JUnit Tests

D11204: Support NTFS hidden files

markg added a comment. Ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks, markg, dfaure Cc: dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks, #dolphin, michaelh, ngraham

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.9 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.9/7/ Project: Frameworks krunner kf5-qt5 SUSEQt5.9 Date of build: Fri, 23 Mar 2018 12:45:08 + Build duration: 9 min 28 sec and counting JUnit Tests Name:

D11610: clang-tidy: modernize-use-default-member-init run

kfunk edited the summary of this revision. kfunk edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11610 To: kfunk Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/16/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 23 Mar 2018 12:45:08 + Build duration: 4 min 31 sec and counting JUnit Tests

D11570: Introduce GamingInputBattery type

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11570 To: broulik, #frameworks, apol, dollinger, lbeltrame, davidedmundson Cc: michaelh, ngraham

D11204: Support NTFS hidden files

markg added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks, markg, dfaure Cc: dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks, #dolphin, michaelh, ngraham

D11487: optimization of TextLineData::attribute

jtamate added a comment. > One question to that though: Why do you sort/lookup by `x.offset + x.length <= p`? Note how lower_bound returns the first iterator that is _not_ going to return true. Assuming there are neither overlaps nor unsorted entries. Lets call X the iterator returned

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D10304 REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility, mart Cc: cfeck, #frameworks, ngraham,

D11604: kdirlistertest doesn't fail at random

jtamate updated this revision to Diff 30323. jtamate added a comment. QStringLiteral instead of QString. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11604?vs=30285=30323 REVISION DETAIL https://phabricator.kde.org/D11604 AFFECTED FILES

D10381: [ToolTipArea] Add "aboutToShow" signal

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10381 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, lesliezhai, ali-mohamed,

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

ngraham added a comment. FYI Linus doesn't have a developer account, so someone will need to commit this for him. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D10304 REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility, mart

D11487: optimization of TextLineData::attribute

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Yep, makes sense. Thanks for the improvement. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11487 To: jtamate, #frameworks, #kate, cullmann Cc:

D10824: Delete IdleSlave having temporary authorization

chinmoyr added a comment. David, what about this patch? It seems to me deleting the IdleSlave object is the only way to kill the ioslave from here. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D10824 To: chinmoyr, dfaure, #frameworks Cc: #frameworks, michaelh,

D11487: optimization of TextLineData::attribute

This revision was automatically updated to reflect the committed changes. jtamate marked 2 inline comments as done. Closed by commit R39:787318967fce: optimization of TextLineData::attribute (authored by jtamate). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D11617: Fix rcc packages generation

This revision was automatically updated to reflect the committed changes. Closed by commit R290:b2e112960457: Fix rcc packages generation (authored by apol). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11617?vs=30330=30335 REVISION DETAIL

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/29/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 23 Mar 2018 16:49:30 + Build duration: 1 min 58 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/35/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Fri, 23 Mar 2018 16:49:30 + Build duration: 1 min 36 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/12/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Fri, 23 Mar 2018 16:49:30 + Build duration: 4 min 37 sec and counting JUnit Tests

D11587: [WIP] autotests: Introduce TermGeneratorTestUTF

michaelh updated this revision to Diff 30336. michaelh edited the summary of this revision. michaelh added a comment. - termgeneratortestutf: Add Korean - termgeneratortestutf: Add Chinese+Latin mix - Reenable ligature test REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D10824: Delete IdleSlave having temporary authorization

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK. If the slave indeed gets killed then this is what we want, indeed. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D10824 To: chinmoyr, dfaure,

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 111 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/111/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 23 Mar 2018 23:45:08 + Build duration: 4 min 39 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 86 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/86/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 23 Mar 2018 23:45:09 + Build duration: 6 min 1 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 87 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/87/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 00:06:23 + Build duration: 5 min 17 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 112 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/112/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Mar 2018 00:06:23 + Build duration: 20 min and counting JUnit

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a comment. The names are determined entirely by the distro packaging. Ubuntu tends to lengthen the names, e.g. "Firefox Web Browser" instead of just "Firefox". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks,

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 181 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/181/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 23 Mar 2018 22:20:53 + Build duration: 6 min 58 sec and counting JUnit Tests Name:

D11628: Fix remotedirnotify service file

valeriymalov created this revision. valeriymalov added a reviewer: Frameworks. Restricted Application added a project: Frameworks. valeriymalov requested review of this revision. REVISION SUMMARY kded plugin is actually named "remotenotifier", update .desktop file accordingly This should fix

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 160 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/160/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 23 Mar 2018 22:20:53 + Build duration: 15 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/31/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 23 Mar 2018 22:20:53 + Build duration: 27 min and counting JUnit Tests Name: (root)

D11487: optimization of TextLineData::attribute

jtamate updated this revision to Diff 30331. jtamate edited the summary of this revision. jtamate added a comment. Using upper_bound with < Changed the name of the iterator Using -> instead of (*x) These are the calls I get since I open the document: doc=

D7563: Add privilegeExecution field to file protocol description

chinmoyr added a comment. In D7563#23 , @ngraham wrote: > What's the status of this patch? I will push this patch after fixing all security issues with kauth support in KIO. (T8075 ) BRANCH master

D11617: Fix rcc packages generation

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D11617 To: apol, #frameworks, mart Cc: michaelh, ngraham

D10820: Send slave's polkit authorization status to the host

chinmoyr updated this revision to Diff 30332. chinmoyr marked 2 inline comments as done. chinmoyr added a comment. 1. Made method const. 2. Increment iterator only if erasing failed. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10820?vs=28541=30332 BRANCH

D10820: Send slave's polkit authorization status to the host

dfaure added inline comments. INLINE COMMENTS > anthonyfieroni wrote in slavebase.cpp:154 > it = m_tempAuths.erase(it); > } else { > ++it; > } You forgot the `it =` in front. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10820 To: chinmoyr, dfaure Cc:

D11487: optimization of TextLineData::attribute

mwolff added a comment. +1 from my side, @cullmann, @dhaumann ? I'll continue to figure out why I don't see the performance issue here REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11487 To: jtamate, #frameworks, #kate Cc: anthonyfieroni, dhaumann, mwolff,

D10820: Send slave's polkit authorization status to the host

chinmoyr updated this revision to Diff 30333. chinmoyr added a comment. Added the missing assignment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10820?vs=30332=30333 BRANCH D10820 REVISION DETAIL https://phabricator.kde.org/D10820 AFFECTED FILES

D11568: cleanup test files

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH master REVISION DETAIL https://phabricator.kde.org/D11568 To: davidedmundson, #plasma, broulik Cc: #frameworks, michaelh, ngraham

D11568: cleanup test files

This revision was automatically updated to reflect the committed changes. Closed by commit R308:02d0123776c2: cleanup test files (authored by davidedmundson). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11568?vs=30180=30303 REVISION DETAIL

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.9 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.9/8/ Project: Frameworks krunner kf5-qt5 SUSEQt5.9 Date of build: Fri, 23 Mar 2018 12:54:58 + Build duration: 4 min 4 sec and counting JUnit Tests Name:

D11487: optimization of TextLineData::attribute

mwolff added a comment. In D11487#232258 , @jtamate wrote: > > One question to that though: Why do you sort/lookup by `x.offset + x.length <= p`? Note how lower_bound returns the first iterator that is _not_ going to return true. > >

D11617: Fix rcc packages generation

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. apol requested review of this revision. REVISION SUMMARY Show an error when it doesn't succeed. Don't use a generator expression for the rcc file, cmake isn't smart enough to

D11617: Fix rcc packages generation

apol updated this revision to Diff 30330. apol added a comment. Allow to configure the used rcc file, use a better variable name REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11617?vs=30328=30330 BRANCH master REVISION DETAIL

D11552: [WIP] Handle CJK characters

michaelh updated this revision to Diff 30337. michaelh added a comment. - Correct surrogate pair handling REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11552?vs=30257=30337 BRANCH cjk (branched from master) REVISION DETAIL

D11602: Fix build on Android

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D11602 To: apol, #frameworks, vkrause Cc: michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/30/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 23 Mar 2018 17:31:25 + Build duration: 7 min 52 sec and counting JUnit Tests Name: (root)

D11583: Add platform detection and adjustment to kded

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED BRANCH platform-detection REVISION DETAIL https://phabricator.kde.org/D11583 To: graesslin, #frameworks, #plasma, apol, romangg Cc: michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 159 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/159/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 23 Mar 2018 17:31:25 + Build duration: 13 min and counting JUnit Tests Name: