D11685: Implement single click on line number to select line of text

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I have no strong opinions on that, as I am not really using the line numbers in such a way. But I think it can't hurt to have this in. REPOSITORY R39 KTextEditor BRANCH

D12513: CVE-2018-10361: privilege escalation

cullmann added a comment. > Any reason you guys decided to not involve secur...@kde.org ? I think we all forgot to do that, without any real reason, I drop that address a mail now, thanks for the hint! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513

D12341: fix detection of taglib when compiling for Android

This revision was automatically updated to reflect the committed changes. Closed by commit R286:d497ffebe202: fix detection of taglib when compiling for Android (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12341?vs=32543=33035

D12508: Make KMessageWidget match Kirigami inlineMessage's style

elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:20 > > +find_package(KF5ConfigWidgets ${KF5_VERSION} REQUIRED) > Unfortunately we can't do this, kwidgetsaddons is tier1

D12371: fix always reproducible crash

jtamate updated this revision to Diff 33045. jtamate edited the test plan for this revision. jtamate added a comment. Just to know if I'm in the correct path, because I'm getting out of ideas. Use in the hash table, and probably in other parts, always the url with at most one trailing /.

D12511: optimization of KTextEditor::DocumentPrivate::views()

jtamate created this revision. jtamate added a reviewer: Kate. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. jtamate requested review of this revision. REVISION SUMMARY Calculate the list of keys of a hash table is quite

D11511: [KPropertiesDialog] Support X-KDE-Protocols

broulik updated this revision to Diff 33053. broulik edited the test plan for this revision. broulik added a comment. - Fix query to check for both being empty REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11511?vs=30001=33053 REVISION DETAIL

D12513: CVE-2018-10361: privelege escalation

maximilianocuria created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. maximilianocuria requested review of this revision. REVISION SUMMARY See http://www.openwall.com/lists/oss-security/2018/04/24/1 REPOSITORY

D12512: ScrollViewKCM

hein added a comment. Does the magic pixel size number for the padding get scaled correctly on hidpi? And where does System Settings have the magic pixel number from - is it hardcoded there as well or is it a QStyle thing that could change with the style engine? Could System

D12513: CVE-2018-10361: privelege escalation

cullmann updated this revision to Diff 33057. cullmann added a comment. Should solve all reported issues. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12513?vs=33054=33057 REVISION DETAIL https://phabricator.kde.org/D12513 AFFECTED FILES

D12512: ScrollViewKCM

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mart requested review of this revision. REVISION SUMMARY ScrollViewKCM component to be used when a kcm has a main component which

D12513: CVE-2018-10361: privelege escalation

cullmann added a comment. > Why dropping syncToDisk? Why is that related to the current issue? Because it always just worked on a invalid file handle. QFile(targetFile).handle() That is just wrong. One can add it to an other place fixed later if one really needs it. REPOSITORY

D12371: fix always reproducible crash

anthonyfieroni added a comment. Can you verify who calls lister with file:///kk -> this is not correct it should be file://kk (2 slashes) then Cache will start to work again. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12371 To: jtamate, dfaure, #frameworks, apol

D12513: CVE-2018-10361: privelege escalation

maximilianocuria added a comment. Why dropping syncToDisk? Why is that related to the current issue? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: cullmann, maximilianocuria, dfaure Cc: cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns,

D12513: CVE-2018-10361: privelege escalation

cullmann commandeered this revision. cullmann added a reviewer: maximilianocuria. cullmann added a comment. Hi, I propose this variant, that should remove all issues report. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: cullmann, maximilianocuria Cc:

D12513: CVE-2018-10361: privelege escalation

maximilianocuria edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: maximilianocuria Cc: #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D12513: CVE-2018-10361: privelege escalation

cullmann added a reviewer: dfaure. cullmann added a comment. The only thing that is unclear: Shall we use the target dir for the tempfile with QTemporaryFile tempFile(targetFileInfo.absolutePath() + QStringLiteral("/secureXX")); or shall we keep in in the normal tempdir?

D12513: CVE-2018-10361: privelege escalation

fvogt added a comment. There's a typo in the title, it should be "privilege escalation". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: cullmann, maximilianocuria, dfaure Cc: fvogt, cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns,

D12513: CVE-2018-10361: privilege escalation

maximilianocuria retitled this revision from "CVE-2018-10361: privelege escalation" to "CVE-2018-10361: privilege escalation". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: cullmann, maximilianocuria, dfaure Cc: fvogt, cullmann, #frameworks, michaelh,

D12513: CVE-2018-10361: privilege escalation

maximilianocuria added a comment. In D12513#253537 , @fvogt wrote: > There's a typo in the title, it should be "privilege escalation". Done REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: cullmann,

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ngraham wrote in jobuidelegate.cpp:229 > Couldn't get `` working, so I hope `` tags are okay. Nope, see the following warnings: "Tag 'p'

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 211 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/211/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 25 Apr 2018 11:56:25 + Build duration: 9 min 25 sec and counting JUnit Tests Name:

D12513: CVE-2018-10361: privilege escalation

maximilianocuria resigned from this revision. This revision now requires review to proceed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: cullmann, dfaure Cc: fvogt, cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, sars, dhaumann

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/45/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 25 Apr 2018 11:50:44 + Build duration: 1 min 4 sec and counting JUnit Tests

D12513: CVE-2018-10361: privilege escalation

maximilianocuria added a comment. Mmh, the accept revision doesn't work as a +1, does it? I was intending to say +1/thumbs up, but I would still prefer somebody else to review this. After all, I sent forwarded the original patch, clearly I want this to land, but it's up the

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 233 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/233/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 25 Apr 2018 11:56:25 + Build duration: 4 min 47 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 82 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/82/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 25 Apr 2018 11:56:25 + Build duration: 15 min and counting JUnit Tests Name: (root)

D12513: CVE-2018-10361: privilege escalation

maximilianocuria accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: cullmann, maximilianocuria, dfaure Cc: fvogt, cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking,

D12513: CVE-2018-10361: privilege escalation

cullmann added a comment. I will ask the openSUSE engineer Matthias Gerstner for feedback before landing this. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: cullmann, dfaure Cc: fvogt, cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns,

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham updated this revision to Diff 33063. ngraham added a comment. Remove KConfigWdgets dependency and revert to hardcoded background colors REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12508?vs=33028=33063 BRANCH arcpatch-D12508 REVISION

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, elvisangelaccio Cc: fabianr, elvisangelaccio, jnoack, #frameworks, michaelh, bruns

D10078: Add separate lib KF5::DBusRunner

kossebau added a comment. API dox still needs overhaul, just concentrated on code for now to keep feedback loop rolling REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D10078 To: kossebau, broulik, davidedmundson Cc: bruns, michaelh, ngraham, #frameworks

D10078: Add separate lib KF5::DBusRunner

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > abstractrunner_p.cpp:141 > +MatchReplyPrivate *p = new MatchReplyPrivate(this, message(), queryTerm); > +

D12247: Use "Do x" action texts for drop menu entries

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH containmentdropmenudoactions REVISION DETAIL https://phabricator.kde.org/D12247 To: kossebau, #vdg, #plasma, davidedmundson Cc: ngraham, #frameworks,

D12512: ScrollViewKCM

hein added a comment. It looks good otherwise and I really want to accept this so I can progress on the Language KCM, but this magic value thing gives me a headache. It's going to break with other QStyles with a different value. We need some sort of fix for that ... REPOSITORY R296

D12247: Use "Do x" action texts for drop menu entries

This revision was automatically updated to reflect the committed changes. Closed by commit R242:de1fde829870: Use Do x action texts for drop menu entries (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

kfilemetadata compile failure

kfilemetadata does not compile in KDE neon from git master currently /workspace/build/src/extractors/ffmpegextractor.cpp:97:15: error: ‘AVCodecParameters’ does not name a type 12:27:35 const AVCodecParameters* codec = stream->codecpar;

D12512: ScrollViewKCM

mart added a comment. In D12512#253498 , @hein wrote: > Does the magic pixel size number for the padding get scaled correctly on hidpi? on the current way we have to scale in the kcm yes, it will be scaled > And where does System

D12512: ScrollViewKCM

mart added a comment. to be used with https://phabricator.kde.org/D12515 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D12512 To: mart, #plasma Cc: hein, #frameworks, michaelh, bruns

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham added a comment. What a shame; this means that it won't inherit background colors from the active theme. I guess that's why it was implemented this way before. I've reverted that part and added a comment into the code so future folks aren't tripped up as I was. Still more red

D10078: Add separate lib KF5::DBusRunner

kossebau added inline comments. INLINE COMMENTS > davidedmundson wrote in abstractrunner_p.cpp:141 > you can't (and don't need to) keep a list here. > > It will break the MatchReply destructor calling submit working How would you think it does break? submit() tests if the reply is still

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham marked an inline comment as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, elvisangelaccio Cc: fabianr, elvisangelaccio, jnoack, #frameworks, michaelh, bruns

D10078: Add separate lib KF5::DBusRunner

kossebau updated this revision to Diff 33064. kossebau added a comment. also cancel any still running reply on deleting the runner instance REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10078?vs=33026=33064 BRANCH kdbusrunnerlib2 REVISION DETAIL

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 117 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/117/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 25 Apr 2018 13:36:36 + Build duration: 2 min 43 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 142 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/142/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 25 Apr 2018 13:36:35 + Build duration: 3 min 40 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 118 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/118/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 25 Apr 2018 13:39:23 + Build duration: 3 min 28 sec and counting

D10078: Add separate lib KF5::DBusRunner

davidedmundson added a comment. > How would you think it does break? If the runner has a reference to a sharedpointer then that object will never be deleted and we'll never hit the auto submit in the runner destructor. REPOSITORY R308 KRunner REVISION DETAIL

D12518: [Button Styles] Fill height and vertical align

broulik updated this revision to Diff 33073. broulik added a comment. - Also unsed `Label` default height to avoid binding loops REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12518?vs=33070=33073 REVISION DETAIL

D10078: Add separate lib KF5::DBusRunner

kossebau added a comment. In D10078#253627 , @davidedmundson wrote: > > How would you think it does break? > > If the runner has a reference to a sharedpointer then that object will never be deleted and we'll never hit the auto submit in

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 143 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/143/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 25 Apr 2018 13:40:18 + Build duration: 3 min 39 sec and counting

D11732: Improve protocols documentation

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH improveOutputManagementDoc REVISION DETAIL https://phabricator.kde.org/D11732 To: romangg, #frameworks, davidedmundson Cc: davidedmundson, michaelh, bruns

D12518: [Button Styles] Fill height and vertical align

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. broulik requested review of this revision. REVISION SUMMARY Otherwise the `Text` will never grow below its preferred height

D12379: [Containment Interface] Don't enter edit mode when immutable

broulik updated this revision to Diff 33071. broulik added a comment. - Also unset stupid `Label` height to avoid binding loops REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12379?vs=32785=33071 REVISION DETAIL

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham updated this revision to Diff 33074. ngraham marked an inline comment as done. ngraham added a comment. Do this correctly REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12420?vs=32885=33074 BRANCH more-serious-delete-text (branched from master)

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham marked 2 inline comments as done. ngraham added a comment. Thanks for your patience, Elvis. Your experience and guidance is much appreciated. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: michaelh,

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

broulik added a comment. -1 What about "permanently" do you not understand. Also -1000 for bold text. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: broulik, michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham added a comment. Besides, people like you (and me) who find this kind of hand-holding annoying can (and likely do) just check the checkbox for "Do not ask again". Problem solved. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks,

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham added a comment. 1. We already have the sentence "This action cannot be undone" in the empty trash dialog alongside the word "permanently". This patch just makes the similarly destructive delete action say the same thing. 2. It's well known the users barely read this kind of

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12422 To: ngraham, #frameworks, #dolphin Cc: michaelh, bruns

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

ngraham updated this revision to Diff 33075. ngraham added a comment. Use correct formatting REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12422?vs=32747=33075 BRANCH prettier-trach-and-delete-dialogs-for-single-items (branched from master) REVISION

D7534: [KUrlNavigator] Emit tabRequested when path in path selector menu is middle-clicked

broulik updated this revision to Diff 33076. broulik added a comment. - Split event filter into its own class REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7534?vs=18730=33076 REVISION DETAIL https://phabricator.kde.org/D7534 AFFECTED FILES

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

broulik added a comment. How about adding "Permanently" to the action button? And no I don't want to turn off confirmation for deleting files. > makes the similarly destructive delete action say the same thing. I see. It's not bold, though. REPOSITORY R241 KIO REVISION

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

broulik added a comment. Looking at it again, I think you convinved me. Just mind the string freeze (two weeks before tag), push it only after the upcoming Frameworks tag. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin,

D10078: Add separate lib KF5::DBusRunner

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH kdbusrunnerlib2 REVISION DETAIL https://phabricator.kde.org/D10078 To: kossebau, broulik, davidedmundson Cc: bruns, michaelh, ngraham, #frameworks

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham added a subscriber: anemeth. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, elvisangelaccio, cfeck Cc: anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, #frameworks, michaelh, bruns

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham marked an inline comment as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, elvisangelaccio, cfeck Cc: anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, #frameworks, michaelh, bruns

D12508: Make KMessageWidget match Kirigami inlineMessage's style

broulik added a comment. Can we maybe do something in Breeze widget style to override the colors with theme colors? Breeze does some special behavior for other widgets as well like `KTitleWidget`. Might be worth looking into? REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham edited the summary of this revision. ngraham added a dependency: D12523: Fix overlapping warning widget. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, elvisangelaccio, cfeck Cc: broulik, anemeth, abetts, cfeck,

D10078: Add separate lib KF5::DBusRunner

davidedmundson added a comment. > What do you think? Would give this a separate try tonight, to get some idea. Forwarding AbstractRunner::teardown is something I'd fully support. At which point you don't need a signal in the context. IMO that's making things overly complex. Note

D12521: KFileWidget fix hidpi icons

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH qt_scaling (branched from master) REVISION DETAIL

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham added a comment. In D12508#253724 , @cfeck wrote: > The gradient was a remnant from the Oxygen days. Glad that it's gone. > > ~~Could you please restore the comments that state where the colors were taken from?~~ > > EDIT: Ah,

D12508: Make KMessageWidget match Kirigami inlineMessage's style

broulik added a comment. Sure! It has to work without Breeze and on other platforms anyway but for a unified look we could add some special Breeze code on top maybe :) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg,

D12521: KFileWidget fix hidpi icons

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12521 To: anemeth, #frameworks, #vdg Cc: ngraham,

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham added a comment. Thanks Kai! I'll wait until after tagging to land it, assuming @elvisangelaccio is satisfied by that point. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: broulik, michaelh, bruns

D12508: Make KMessageWidget match Kirigami inlineMessage's style

cfeck requested changes to this revision. cfeck added a comment. This revision now requires changes to proceed. The gradient was a remnant from the Oxygen days. Glad that it's gone. Could you please restore the comments that state where the colors were taken from? INLINE COMMENTS >

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham updated this revision to Diff 33089. ngraham added a comment. Address @cfeck's review comments REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12508?vs=33063=33089 BRANCH arcpatch-D12508 REVISION DETAIL

D12508: Make KMessageWidget match Kirigami inlineMessage's style

mart added inline comments. INLINE COMMENTS > elvisangelaccio wrote in CMakeLists.txt:20 > Unfortunately we can't do this, kwidgetsaddons is tier1 and it cannot depend > on another framework. > > We'll need to duplicate the relevant code from kconfigwidgets here. if one doesn't fear horrible

D10078: Add separate lib KF5::DBusRunner

kossebau added a comment. Good, seems we found agreed-on codebase :) Will brush over the API dox/code comments some more for a final thumb-up. Though after yesterday's prototyping of further dbusrunner plugins there is another thing where I might want to suggest some API change to be

D12521: KFileWidget use hidpi icons

anemeth added a comment. In D12521#253761 , @broulik wrote: > A widget setting an attribute on the application is bad Where should I set it? I can't find a mainwindow class in kio REPOSITORY R241 KIO BRANCH qt_scaling (branched

D12521: KFileWidget use hidpi icons

ngraham added a comment. Only for the purpose of showing this dialog though, right? REPOSITORY R241 KIO BRANCH qt_scaling (branched from master) REVISION DETAIL https://phabricator.kde.org/D12521 To: anemeth, #frameworks, #vdg, ngraham Cc: broulik, ngraham, #frameworks, michaelh,

D12520: [PasteJob] Emit KDirWatch on paste

broulik created this revision. broulik added a reviewer: Frameworks. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY `storedPut` isn't particularly smart and so after pasting the file tell everyone about it TEST PLAN Copied

D12520: [PasteJob] Emit KDirNotify on paste

broulik retitled this revision from "[PasteJob] Emit KDirWatch on paste" to "[PasteJob] Emit KDirNotify on paste". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12520 To: broulik, #frameworks Cc: michaelh, bruns

D12508: Make KMessageWidget match Kirigami inlineMessage's style

abetts added a comment. +1, looking good. Keep up the work! REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, elvisangelaccio, cfeck Cc: abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, #frameworks, michaelh, bruns

D12521: KFileWidget use hidpi icons

anemeth retitled this revision from "KFileWidget fix hidpi icons" to "KFileWidget use hidpi icons". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12521 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12521: KFileWidget use hidpi icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Well that was easy, lol. REPOSITORY R241 KIO BRANCH qt_scaling (branched from master) REVISION DETAIL https://phabricator.kde.org/D12521 To: anemeth, #frameworks, #vdg, ngraham

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham added a comment. In D12508#253782 , @broulik wrote: > Can we maybe do something in Breeze widget style to override the colors with theme colors? Breeze does some special behavior for other widgets as well like `KTitleWidget`. Might be

D12521: KFileWidget use hidpi icons

broulik added a comment. -1 A widget setting an attribute on the application is bad REPOSITORY R241 KIO BRANCH qt_scaling (branched from master) REVISION DETAIL https://phabricator.kde.org/D12521 To: anemeth, #frameworks, #vdg, ngraham Cc: broulik, ngraham, #frameworks,

D12321: Hide file preview when icon is too small

anemeth marked 8 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, markg Cc: markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

rkflx added a comment. Thanks for the update, but please make sure not to lose the `kconf_update` changes… INLINE COMMENTS > kdiroperator.cpp:2163 > +d->showPreviews = configGroup.readEntry(QStringLiteral("Show Inline > Previews"), true); > +d->showPreviewsConfigEntry =

D12306: Improve grid icon layout in filepicker dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bbc262674a56: Improve grid icon layout in filepicker dialog (authored by anemeth, committed by rkflx). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D12328: Enable preview by default in the filepicker dialog

anemeth updated this revision to Diff 33099. anemeth added a comment. Rebase on D12321 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12328?vs=32611=33099 BRANCH preview_default (branched from master) REVISION DETAIL

D12521: KFileWidget use hidpi icons

elvisangelaccio added a comment. In D12521#253764 , @anemeth wrote: > In D12521#253761 , @broulik wrote: > > > A widget setting an attribute on the application is bad > > > Where should I set

D12508: Make KMessageWidget match Kirigami inlineMessage's style

cfeck accepted this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, elvisangelaccio, cfeck Cc: broulik, anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, #frameworks, michaelh, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 119 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/119/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 25 Apr 2018 20:36:13 + Build duration: 2 min 36 sec and counting

D12521: KFileWidget use hidpi icons

anemeth abandoned this revision. anemeth added a comment. In D12521#253806 , @elvisangelaccio wrote: > Every application that opens a file dialog is supposed to do this in their own startup code (usually in `main()`). Looks like this is

D12321: Hide file preview when icon is too small

ngraham added a comment. Mark, how can we move forward here? We'd like to address your concerns if we can. The underlying goal here is to turn on previews by default so that the large icons view gets them, but we don't irritate people using very small icon sizes who generally don't

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 234 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/234/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 25 Apr 2018 18:58:03 + Build duration: 4 min 37 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 212 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/212/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 25 Apr 2018 18:58:03 + Build duration: 5 min 19 sec and counting JUnit Tests Name:

D12321: Hide file preview when icon is too small

anemeth marked an inline comment as done. anemeth added inline comments. INLINE COMMENTS > rkflx wrote in kdiroperator.cpp:2589-2591 > Could you explain why you need to change `showPreviewsEnabledBeforeZoom` > here? As far as I can see this variable just caches the config value, and > thus

  1   2   >