D11880: Add firewall-config and firewall-applet icons

svenmauch added a comment. In D11880#330810 , @ndavis wrote: > While orange may mean "warning", it could mean any kind of warning. In this case, it's a warning that an extreme setting is being used, but there is a lock in the corner to show

D15687: [Device Notifier] Avoid accessing attributes of stale UDIs

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15687 To: bruns, #frameworks, broulik Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D15685: Fix Android builds using cmake 3.12.1

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH wop REVISION DETAIL https://phabricator.kde.org/D15685 To: apol, #frameworks, vkrause Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14528: Android: Make sure we're looking for .mo files in the right path

This revision was automatically updated to reflect the committed changes. Closed by commit R249:65fe7009ae9e: Android: Make sure were looking for .mo files in the right path (authored by apol). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14528?vs=38987=42226

D14529: Android: Make sure Qm translations get loaded

This revision was automatically updated to reflect the committed changes. Closed by commit R240:0d961ecbdf17: Android: Make sure Qm translations get loaded (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14529?vs=38883=42225

D15685: Fix Android builds using cmake 3.12.1

This revision was automatically updated to reflect the committed changes. Closed by commit R240:20e619af331f: Fix Android builds using cmake 3.12.1 (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15685?vs=42117=42224 REVISION

D11880: Add firewall-config and firewall-applet icons

ndavis updated this revision to Diff 42257. ndavis added a comment. Remove 48px firewall-applet icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11880?vs=42212=42257 BRANCH firewalld-icons (branched from master) REVISION DETAIL

D15687: [Device Notifier] Avoid accessing attributes of stale UDIs

This revision was automatically updated to reflect the committed changes. bruns marked an inline comment as done. Closed by commit R120:61b2b173e8d6: [Device Notifier] Avoid accessing attributes of stale UDIs (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D15675: [sftp] Reformat sftpProtocol::GetRequest::GetRequest()

asn updated this revision to Diff 42243. asn added a comment. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. Remove former revision REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 228 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/228/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 24 Sep 2018 15:59:39 + Build duration: 7 min 51 sec and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 153 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/153/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 24 Sep 2018 15:59:38 + Build duration: 18 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 229 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/229/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 24 Sep 2018 16:14:28 + Build duration: 6 min 30 sec and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 154 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/154/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 24 Sep 2018 16:17:53 + Build duration: 15 min and counting JUnit Tests Name: (root)

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich updated this revision to Diff 42264. astippich added a comment. - implement feedback REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15714?vs=42197=42264 BRANCH taglib_write_unicode REVISION DETAIL https://phabricator.kde.org/D15714

D15721: Make lock on plasmavault icon visible with breeze-dark

abetts added a comment. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15721 To: ndavis, #vdg Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D11880: Add firewall-config and firewall-applet icons

ndavis added a comment. In D11880#330909 , @svenmauch wrote: > In D11880#330788 , @ngraham wrote: > > > I think that `firewall-applet` looks maybe a bit too plain at its 22px size. The wall seems

D15704: increase test coverage of taglibwriter

astippich added inline comments. INLINE COMMENTS > svuorela wrote in taglibwriter.cpp:22 > Unrelated. but consider making this static ? Never really though about that, but should be static, yes. None of the writers and extractors I looked at currently do this, so if I find time I will do that

D15635: Use String to store UDS_USER and UDS_GROUP of String type.

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Code looks better and I can verify that it fixes the bug. Feels a bit faster, too. Maybe wait for a final review from @broulik or someone in #frameworks

D15718: Do not index the path if the path has no execute permissions.

smithjd added a comment. > No, because even if the default umask is 002, or 022, POSIX says that the default permissions of a file on creation are going to be 0666, not 0777: Trial-and-error proven. :( In D15718#331449 , @ngraham wrote:

D15721: Make lock on plasmavault icon visible with breeze-dark

ngraham added a comment. Can you provide steps to reproduce the problem so I can test it? In my naive testing, the `plasmavault` icon looks like a lock and shows up fine on both Breeze Light and Breeze Dark. I'm also confused by the images you posted (which should be in the Test Plan{

D7446: [Places panel] Add a Recently Used item by default

ngraham edited reviewers, added: VDG, Frameworks; removed: KDE Applications, dfaure, emmanuelp. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, #kde_applications Cc: kde-frameworks-devel,

D15583: [Balooctl] remove directory parent check

smithjd added a comment. What was wrong with https://phabricator.kde.org/D15583?id=42018 ? > I could see the case for allowing this behavior to be explicitly overridden by an advanced user who marks ~/foo/ as excluded and then later marks ~foo/bar/ as included, but that would be

D15718: Do not index the path if the path has no execute permissions.

smithjd added a comment. https://www.freedesktop.org/wiki/CommonExtendedAttributes suggests xattrs to use to store do-not-index information and also requires each file to be explicitly set to be indexed. > user.xdg.robots.index: On a file: "true" to index, "false" to not index. On a

D15739: [Places panel] Don't show Root by default

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11880: Add firewall-config and firewall-applet icons

ngraham added a comment. In D11880#330865 , @ndavis wrote: > In D11880#330861 , @ngraham wrote: > > > For the panic mode icon, how about leaving the wall itself black, and only the lock is orange?

D11880: Add firewall-config and firewall-applet icons

ndavis added a comment. In D11880#331450 , @ngraham wrote: > FWIW, I'm okay with the existing `firewall-applet`. So here's what we've got now, as viewed with `cuttlefish`: > F6283724: Screenshot_20180924_215450.png

D7446: [Places panel] Add a Recently Used item by default

ngraham added a comment. I'd like to re-submit this patch (now re-based on master) for consideration. I put some work into improving the `recentdocuments:/` ioslave in D14893 so it's useful now. User requests for this feature to be added by default still

D15739: [Places panel] Don't show Root by default

acrouthamel added a comment. +1 Seeing "Root" written as such, also makes me think of `/root`, which makes no sense to have there. The odds of needing quick access to `/` via Dolphin are extremely rare, and there is already a link anyway. People are used to clicking the primary drive

D7446: [Places panel] Add a Recently Used item by default

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, emmanuelp, markg Cc: kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, gregormi, markg,

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

ngraham added a task: T8349: Improve Places panel usability and presentation. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11767 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson Cc: kde-frameworks-devel,

D15583: [Balooctl] remove directory parent check

ngraham added a comment. https://phabricator.kde.org/D15583?id=42018 didn't let you add `~/foo/bar` to the list of includes or excludes if `~/foo` was already present. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15583 To: ngraham, #baloo, #dolphin, bruns,

D15739: [Places panel] Don't show Root by default

ngraham added a task: T8349: Improve Places panel usability and presentation. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D7446: [Places panel] Add a Recently Used item by default

ngraham added a task: T8349: Improve Places panel usability and presentation. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, emmanuelp, markg Cc: kde-frameworks-devel, spoorun,

D15739: [Places panel] Don't show Root by default

ngraham created this revision. ngraham added reviewers: Dolphin, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This patch removes Root from the default Places panel for new installations,

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

ngraham updated this revision to Diff 42277. ngraham added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Re-base on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=18867=42277 REVISION DETAIL

D7446: [Places panel] Add a Recently Used item by default

ngraham retitled this revision from "Add a Recent Documents places item to Dolphin and file pickers by default" to "[Places panel] Add a Recently Used item by default". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

ngraham added a task: T8349: Improve Places panel usability and presentation. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14893 To: ngraham, broulik, #dolphin,

D15739: [Places panel] Don't show Root by default

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg Cc: acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D11880: Add firewall-config and firewall-applet icons

ngraham added a comment. FWIW, I'm okay with the existing `firewall-applet`. So here's what we've got now, as viewed with `cuttlefish`: F6283724: Screenshot_20180924_215450.png I say +1! However, there seems to be a problem for the breeze

D15739: [Places panel] Don't show Root by default

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg Cc: acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15718: Do not index the path if the path has no execute permissions.

ngraham added a comment. Let's back up a bit. What's the goal here? What are you trying to accomplish? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15718 To: smithjd, ngraham, #baloo, ltoscano Cc: ltoscano, marten, bruns, ngraham, kde-frameworks-devel, #baloo,

D15718: Do not index the path if the path has no execute permissions.

ngraham added a comment. The point is, we don't make changes to our software that break users, and then demand that users alter their own files to keep using the software. It's not an option--especially if the breakage results in the software basically not working at all (i.e. search no

D15718: Do not index the path if the path has no execute permissions.

ltoscano requested changes to this revision. ltoscano added a comment. I agree with all the objections raised so far, and I'm not sure about the rationale of this change. I'd like to add one point: In D15718#330844 , @smithjd wrote: > In

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich updated this revision to Diff 42270. astippich added a comment. - actually use temporary string variable for unicode REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15714?vs=42264=42270 BRANCH taglib_write_unicode REVISION DETAIL

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich added inline comments. INLINE COMMENTS > smithjd wrote in taglibwritertest.cpp:60 > Is wrapping in a QString necessary? It does not compile otherwise. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15714 To: astippich, mgallien, bruns Cc: smithjd,