D16137: Add an option to KConfigDialog to fit page contents horizontally

aacid added a comment. Yep, this looks more like it :) You're missing @since markers (in the documentation of the new functions) for the KF5 version this will be introduced, but i'd say let's wait for someone to give the final approval and then you remember to commit the correct version

D11869: epubextractor: Add property ReleaseYear

This revision was automatically updated to reflect the committed changes. Closed by commit R286:15adb113399e: epubextractor: Add property ReleaseYear (authored by michaelh, committed by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D16165: Don't crash on invalid exiv2 data

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH dont-crash-invalid-exiv (branched from master) REVISION DETAIL https://phabricator.kde.org/D16165 To: poboiko, #baloo, #frameworks, astippich Cc: bruns, astippich,

D15867: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. Looks OK to me. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15867 To: bruns, #frameworks, apol, lbeltrame Cc: lbeltrame,

D16197: provide a list of supported mimetypes for embeddedimagedata

astippich added inline comments. INLINE COMMENTS > mgallien wrote in embeddedimagedata.h:62 > You can make it static because you are returning a static member. It means > that you should probably return by const reference (even if I do not remember > if it is always the best answer). I had it

D16154: fix Service(Type)Browser documentation

This revision was automatically updated to reflect the committed changes. Closed by commit R272:d99ca8a15458: fix Service(Type)Browser documentation (authored by sitter). REPOSITORY R272 KDNSSD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16154?vs=43468=43634 REVISION DETAIL

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 82 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/82/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Oct 2018 06:52:18 + Build duration: 1 min 39 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/60/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 15 Oct 2018 06:52:18 + Build duration: 3 min 22 sec and counting JUnit Tests Name: (root)

D16235: [Extractor] Exclude Postscript from being indexed

bruns abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16235 To: bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16235: [Extractor] Exclude Postscript from being indexed

ngraham added a comment. What? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16235 To: bruns Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D15867: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding

This revision was automatically updated to reflect the committed changes. Closed by commit R240:c2639d5698dc: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding (authored by bruns). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D16236: [Extractor] Handle documents correctly where mimetype should not be indexed

bruns created this revision. bruns added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The BasicIndexingJob started from the UnindexedFileIndexer only has the

D16237: [Scheduler] Reuse mimetype from UnindexedFileIterator in indexer

bruns created this revision. bruns added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The mimetype is already determined in the iterator, no need to do it

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.10 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.10/57/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Oct 2018 08:21:19 + Build duration: 23 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 165 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/165/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 15 Oct 2018 08:24:14 + Build duration: 1 hr 42 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 70 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/70/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Oct 2018 08:20:57 + Build duration: 29 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 437 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/437/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Oct 2018 08:22:04 + Build duration: 42 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 83 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/83/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Oct 2018 08:22:50 + Build duration: 42 min and counting JUnit Tests Name: (root) Failed: 4

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/62/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 15 Oct 2018 08:19:34 + Build duration: 1 hr 8 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/64/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 15 Oct 2018 08:20:37 + Build duration: 1 hr 21 min and counting JUnit Tests Name: (root)

D15814: show all borders for pop up windows in a dock

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > It is based on the assumption that by design plasma panels do not use mask() It's a big assumption. It seems more based on what the two windows happen to currently do

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/34/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 15 Oct 2018 08:23:48 + Build duration: 1 hr 38 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 120 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/120/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Oct 2018 08:20:37 + Build duration: 21 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/44/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 15 Oct 2018 08:20:57 + Build duration: 1 hr 18 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 7 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/7/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 15 Oct 2018 08:22:44 + Build duration: 1 hr 56 min and counting JUnit Tests

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 118 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/118/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Oct 2018 08:19:35 + Build duration: 13 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 240 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/240/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Oct 2018 08:24:14 + Build duration: 53 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/46/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Oct 2018 08:23:48 + Build duration: 53 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/61/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 15 Oct 2018 08:22:50 + Build duration: 1 hr 31 min and counting JUnit Tests Name: (root)

D15510: Introduce HKDF

volkov closed this revision. REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D15510 To: volkov, iromanov, sitter, #frameworks, dfaure Cc: dfaure

D15814: show all borders for pop up windows in a dock

mvourlakos added a comment. In D15814#343330 , @davidedmundson wrote: > > first introduced at popupPlacement() > > ...by you :P I know :( and this broke plasma popups placement in !compositing mode. This is why I sent

D15814: show all borders for pop up windows in a dock

davidedmundson added a comment. > sorry, I dont understand what explicitly means As in "void setAlwaysShowAllBorders(bool)" (or whatever) that a user calls. REPOSITORY R242 Plasma Framework (Library) BRANCH dockBorders REVISION DETAIL https://phabricator.kde.org/D15814 To:

D16221: style++

sitter created this revision. sitter added a reviewer: apol. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY easier to read with spaces SCM_SILENT REPOSITORY R240

D16221: style++

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D16221 To: sitter, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D16221: style++

This revision was automatically updated to reflect the committed changes. Closed by commit R240:72aa6e1bf19c: style++ (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16221?vs=43649=43650 REVISION DETAIL

Re: Password field security and information leaking

> It seems to me that a notional end-user application is the one that > actually needs to *use* the password though, which might imply that the > U/I for entering the password needs to be in a different process? Depends. I investigated all of this primarily for Plasma Vaults. The

D15842: Lower log level for X-KDE-DBus-ServiceName missing message

ngraham added a reviewer: davidedmundson. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D15842 To: bruns, #frameworks, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15867: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding

bruns added a comment. This is a trivial cleanup - can I push it? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15867 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D16226: Reformat library code using kde-dev-scripts/astyle-kdelibs

volkov added a reviewer: Frameworks. REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D16226 To: volkov, #frameworks

D16166: Pass the FileIndexerConfig as const to the individual indexers

bruns added a reviewer: ngraham. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16166 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15842: Lower log level for X-KDE-DBus-ServiceName missing message

bruns added a comment. The current state causes unnecessary log spam, would be good to have this in. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D15842 To: bruns, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 121 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/121/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 16 Oct 2018 05:15:44 + Build duration: 5 min 28 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/65/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 16 Oct 2018 05:15:44 + Build duration: 6 min 26 sec and counting JUnit Tests Name: (root)