D17021: [ioslaves/trash] Handle broken symlinks in deleted subdirectories

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17021 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 328 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/328/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 19 Nov 2018 21:47:26 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 1

D16984: [RenameDialog] Fix layout when using the NoRename flag

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bb00649dc6e0: [RenameDialog] Fix layout when using the NoRename flag (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16984?vs=45740=45843

D17033: Change primary monochrome icon colors to match new HIG colors

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17033 To: ndavis, #vdg, #breeze Cc: andreask, kde-frameworks-devel, #breeze, #vdg, michaelh, ngraham, bruns

D17000: Make sure there is only one MTime per document in the MTimeDB

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5b24bd42e4b6: Make sure there is only one MTime per document in the MTimeDB (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17000?vs=45773=45857

D17028: Loader: Avoid Q_FOREACH

loh.tar created this revision. Herald added a project: Frameworks. loh.tar requested review of this revision. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17028 AFFECTED FILES src/core/loader.cpp To: loh.tar Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16983: Add 48px firewall-applet* icons

ndavis added a comment. In D16983#362552 , @aacid wrote: > These symlinks as they stand are not poinless, they are wrong. > > Icon sets are not "targeting a particular piece of software", icon sets are system wide and any software can ask

D16985: Fix apidox of RenameDialog_Option

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d9e33ad398b0: Fix apidox of RenameDialog_Option (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16985?vs=45742=45840 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 327 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/327/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 19 Nov 2018 21:35:16 + Build duration: 12 min and counting JUnit Tests Name: (root) Failed: 0

D17021: [ioslaves/trash] Handle broken symlinks in deleted subdirectories

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4f5b4fd218ca: [ioslaves/trash] Handle broken symlinks in deleted subdirectories (authored by davidedmundson). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D17033: Change primary monochrome icon colors to match new HIG colors

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17033 To: ndavis, #vdg, #breeze Cc: kde-frameworks-devel, #breeze, #vdg, michaelh, ngraham, bruns

D17001: Add unittest for document replacement

This revision was automatically updated to reflect the committed changes. Closed by commit R293:40ef654f7857: Add unittest for document replacement (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17001?vs=45774=45858 REVISION DETAIL

D16999: Extend diagnostic output for DB autotests

This revision was automatically updated to reflect the committed changes. Closed by commit R293:933db065c975: Extend diagnostic output for DB autotests (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16999?vs=45772=45856 REVISION DETAIL

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

loh.tar created this revision. Herald added a project: Frameworks. loh.tar requested review of this revision. REVISION SUMMARY ...to ease the switch between dictionaries you usually need REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 AFFECTED FILES

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

ngraham accepted this revision. ngraham added reviewers: Kate, KTextEditor. ngraham added a comment. This revision is now accepted and ready to land. Looks good from my perspective! Let's see what the #kate folks think. INLINE COMMENTS > slenz wrote

D17033: Change primary monochrome icon colors to match new HIG colors

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The old colors were Icon Grey (#4d4d4d) and an undocument white color (#f2f2f2).

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

slenz updated this revision to Diff 45841. slenz added a comment. Increment menubar file version number REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17008?vs=45788=45841 BRANCH arcpatch-D17008_1 REVISION DETAIL https://phabricator.kde.org/D17008

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

loh.tar added a comment. The added stuff at the ConfigWidget looks to me not perfect but OK. Suggestions are welcome. Some thoughts/questions - Most UI member are named m_foo but some without the m_ prefix. I can't recognize a rule why and chose for my new stuff a name without the

D17028: Loader: Avoid Q_FOREACH

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17028 To: loh.tar, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17033: Change primary monochrome icon colors to match new HIG colors

andreask added a comment. Thanks for the update, I will work with the new colors also in LibO. We have there an issue on OS-X cause the contrast was not good enough and the new darker color will give an better contrast. REPOSITORY R266 Breeze Icons REVISION DETAIL

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

slenz marked an inline comment as done. slenz added inline comments. INLINE COMMENTS > ngraham wrote in katepart5ui.rc:2 > You need to bump the version to 79 or else the changes won't take effect. That might explain why the changes only sometimes appeared. Fixed :) > ngraham wrote in

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 329 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/329/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 19 Nov 2018 21:58:35 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed: 0

D17031: Fix a few memory leaksASAN: Fix leak in AppletQuickItem

kfunk created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kfunk requested review of this revision. REVISION SUMMARY Direct leak of 3960 byte(s) in 15 object(s) allocated from: #0 0x544cc0 in operator new(unsigned long)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 113 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/113/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 20 Nov 2018 07:14:22 + Build duration: 4 min 10 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 87 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/87/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 20 Nov 2018 07:14:22 + Build duration: 18 min and counting JUnit Tests Name: (root) Failed: 1

D17028: Loader: Avoid Q_FOREACH

loh.tar added a comment. @davidedmundson Wow, that was fast :-) I have now done a search for more Q_FOREACH/foreach. Please let me know if you want each as own diff or all in once. data/parsetrigrams.cpp src/core/guesslanguage.cpp src/plugins/hspell/hspelldict.cpp

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 112 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/112/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 20 Nov 2018 07:06:27 + Build duration: 5 min 11 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 265 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/265/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 20 Nov 2018 04:36:50 + Build duration: 10 min and counting JUnit Tests Name: (root)

D16946: Port more search providers to HTTPS

vkrause added a comment. In D16946#361950 , @apol wrote: > About the rest, probably not, do you think that there's any that would be a big loss? I would assume by now that if they don't work with https it's probably because it's abandoned.

D17021: [ioslaves/trash] Handle broken symlinks in deleted subdirectories

davidedmundson edited the summary of this revision. davidedmundson added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17021 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17021: [ioslaves/trash] Handle broken symlinks in deleted subdirectories

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY The trash ioslave currently handles: - working symlinks at the toplevel - broken symlinks at the

D16983: Add 48px firewall-applet* icons

ndavis added a subscriber: sitter. ndavis added a comment. @sitter sent me an email saying that it would be better to put the firewall-applet icons into `status/`. He's probably right and it would mean I don't need to make a bunch of pointless symlinks. REPOSITORY R266 Breeze Icons

Re: firewall-applet icons break breeze auto tests

On Monday, November 19, 2018 6:53:28 AM EST Harald Sitter wrote: > I am CCing Andreas Kainz on this as he may have input on where the > firewall-* icons should go. > From a quick look though I am convinced the majority/all of these > icons should be in status/ not apps/. They are used in the

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Lovely, this is just what I wanted. It's cool that the feature was already there. :) I like how you preserve the old shortcuts for compatibility. Just a few changes needed from

D16985: Fix apidox of RenameDialog_Option

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH fix-renameflags-apidox REVISION DETAIL https://phabricator.kde.org/D16985 To: elvisangelaccio, #frameworks, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb updated this revision to Diff 45782. rjvbb added a comment. Another fix: use the active MainWindow as the parent of the contextMenuData instance and do NOT delete it in the `TextDocumentPrivate` dtor. Also, do not assume there will ever only be a single MainWindow in a KDevelop

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb set the repository for this revision to R32 KDevelop. REPOSITORY R32 KDevelop REVISION DETAIL https://phabricator.kde.org/D16882 To: rjvbb, #kdevelop, kossebau Cc: egospodinova, kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf,

D16108: When re-using runners when reloading, reload their configuration

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D16108 To: broulik, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16108: When re-using runners when reloading, reload their configuration

This revision was automatically updated to reflect the committed changes. Closed by commit R308:770f8d64a495: When re-using runners when reloading, reload their configuration (authored by broulik). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb added a comment. > E.g. I would have expected before looking at things that each view has their own separate context menu instance, possibly even created on the fly per display :) I think that is what I would have expected too (maybe not per display :)), and that's one reason I

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb updated this revision to Diff 45786. rjvbb added a comment. This implements and uses my idea of an `ecm_add__compiler_flags_if_supported` function set for C and C++. It uses compiler ID+version conditions to determine if flag(s) are supported when those conditions are known and

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb set the repository for this revision to R240 Extra CMake Modules. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D16894 To: rjvbb, #build_system, kfunk Cc: kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, michaelh, ngraham, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

thsurrel added a comment. Simply calling setFocus() was not working (I used this in D16914 ). My understanding is that the widget containing this has to be completely built before trying to set the focus, adding the timer ensures that. Correct me if this

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

slenz created this revision. slenz added a reviewer: VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. slenz requested review of this revision. REVISION SUMMARY Adds a menu item to toggle comments and adds CTRL + / as a shortcut. Also

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

slenz edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17008 To: slenz, #vdg Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D16250: Use lambdas instead of std::bind()

volkov added a comment. https://clang.llvm.org/extra/clang-tidy/checks/modernize-avoid-bind.html > std::bind can be hard to read and can result in larger object files and binaries due to type information that will not be produced by equivalent lambdas. REPOSITORY R127 KWayland

D16250: Use lambdas instead of std::bind()

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16250 To: volkov, #kwin, davidedmundson Cc: bruns, davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham

D16301: Remove ComponentInstaller

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16301 To: broulik, #plasma, mart Cc: apol, bruns, kde-frameworks-devel, michaelh, ngraham

D16250: Use lambdas instead of std::bind()

volkov closed this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16250 To: volkov, #kwin, davidedmundson Cc: bruns, davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham

Re: firewall-applet icons break breeze auto tests

On Sun, Nov 18, 2018 at 6:33 PM Noah Davis wrote: > > My *guess* is that whoever decided 16, 22 and 32 are "fixed" even if they > > are SVG while 48 is not, is that sometimes in the 16, 22, 32 sizes you have > > to "sacrifice" some details because since you know it'll be shown in small > > sizes

D16301: Remove ComponentInstaller

This revision was automatically updated to reflect the committed changes. Closed by commit R242:38098e96e3d8: Remove ComponentInstaller (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16301?vs=43874=45796 REVISION

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 111 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/111/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 19 Nov 2018 11:47:45 + Build duration: 7 min 33 sec and counting JUnit Tests Name: (root)

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb updated this revision to Diff 45797. rjvbb added a comment. Well, apparently the contextmenu CAN change during a session (at least on Mac and when I open it in different opened-at-session-load documents when the initial project load and parsing activity is still in progress).

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb set the repository for this revision to R32 KDevelop. REPOSITORY R32 KDevelop REVISION DETAIL https://phabricator.kde.org/D16882 To: rjvbb, #kdevelop, kossebau Cc: egospodinova, kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf,

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 264 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/264/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 19 Nov 2018 11:54:20 + Build duration: 3 min 14 sec and counting JUnit Tests Name:

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli created this revision. lsartorelli added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. lsartorelli requested review of this revision. REVISION SUMMARY Provide a common message ,encapsulated into the ShowMenuBarAction, with

D17014: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli added a dependency: D17013: Show menu bar, how to re-enable, common shortcut dialog. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D17014 To: lsartorelli, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli added a dependent revision: D17014: Show menu bar, how to re-enable, common shortcut dialog. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17014: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli created this revision. lsartorelli added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. lsartorelli requested review of this revision. REVISION SUMMARY Provide a common message ,encapsulated into the ShowMenuBarAction, with

D17013: Show menu bar, how to re-enable, common shortcut dialog

broulik added inline comments. INLINE COMMENTS > ktoggleshowmenubaraction.cpp:26 > + > +#define i18n QString::fromLatin1 > + What's this for? > ktoggleshowmenubaraction.h:49 > + */ > +KToggleShowMenuBarAction(QWidget *window, QObject *parent); > + I know we typically use `window` here

D17015: Fix the Qt doc creation with Qt 5.12.

cgiboudeaux created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. cgiboudeaux requested review of this revision. REVISION SUMMARY In Qt >= 5.12, the qhelpgenerator and qcollectiongenerator tools were fused, only

D17015: Fix the Qt doc creation with Qt 5.12.

cgiboudeaux added a comment. If anyone wonders: - These are 2 different commits for the same - Using find-modules/FindQHelpGenerator.cmake is not an option. Same reason as the one that made using query_qmake impossible. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli updated this revision to Diff 45807. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45798=45807 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt src/ktoggleshowmenubaraction.cpp

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli marked 2 inline comments as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D16852: Add Documents to the default list of Places

acrouthamel added a comment. I had submitted this with the intention of being a follow-up to D15739 , as that would clear a slot for this. I think right now, T9795 is outside my skill set. I'd be glad to make D15739

D17014: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli added a dependent revision: D17016: Show menu bar, how to re-enable, common shortcut dialog. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D17014 To: lsartorelli, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli added a dependent revision: D17016: Show menu bar, how to re-enable, common shortcut dialog. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

cfeck added inline comments. INLINE COMMENTS > ktoggleshowmenubaraction.cpp:21 > + > +#include "ktoggleshowmenubaraction.h" > + Do we still follow the rule "include own headers first"? > ktoggleshowmenubaraction.h:28 > + * An action to hide or show the menubar of a window. > + * The action by

D17017: Fix assert when cleaning up symlinks in PreviewJob

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY When previewing files in a KIOslave KIO will copy the file out to a temporary directory and then run

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli updated this revision to Diff 45811. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45807=45811 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt src/ktoggleshowmenubaraction.cpp

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli updated this revision to Diff 45812. lsartorelli marked 2 inline comments as done. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45811=45812 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli added inline comments. INLINE COMMENTS > cfeck wrote in ktoggleshowmenubaraction.h:28 > reminds > > Additionally, "show back" does not sound like proper english, but I am not a > native english speaker. Unfortunately, me too, ... any suggestion is appreciated REPOSITORY R236

D16852: Add Documents to the default list of Places

ngraham added a comment. Well, the extra space gained from D15739 would also be taken up by D7446 . :) I wasn't suggesting that you fix T9795 (it's beyond me too!), but rather

D16852: Add Documents to the default list of Places

acrouthamel added a comment. In D16852#362344 , @ngraham wrote: > you could tackle the patch to make Dolphin's default window size a tad taller. I'll poke around. REPOSITORY R241 KIO BRANCH add-documents (branched from master)

D16930: Android: improve clang support

This revision was automatically updated to reflect the committed changes. Closed by commit R240:06061b0e3ce4: Android: improve clang support (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16930?vs=45606=45816 REVISION DETAIL

D16913: Add the possibility to give focus to the KPluginSelector search field

ngraham added subscribers: broulik, cfeck. ngraham added a comment. Sounds like you know more than I do at this point. :) Let's see if this approach makes sense to @cfeck or @broulik. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks

D17013: Show menu bar, how to re-enable, common shortcut dialog

ngraham added reviewers: Frameworks, KDE Applications. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham, #frameworks, #kde_applications Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

ngraham added inline comments. INLINE COMMENTS > ktoggleshowmenubaraction.h:57 > +/** > + * Sets the parent window for message box with the user remainder. > + * @param window the window that will be parent for the message box remainder -> reminder > ktoggleshowmenubaraction.h:64

D17019: actually initialize kcrash properly

sitter created this revision. sitter added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY to successfully use kcrash when linking with as-needed (which is a

D17019: actually initialize kcrash properly

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D17019 To: sitter, #baloo, #frameworks, apol Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D17013: Show menu bar, how to re-enable, common shortcut dialog

aacid added inline comments. INLINE COMMENTS > ktoggleshowmenubaraction.cpp:77 > +KMessageBox::information(d->window, tr("This will hide the menu bar > completely." > +" You can show it again by > typing

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli marked 3 inline comments as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham, #frameworks, #kde_applications Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli updated this revision to Diff 45821. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45812=45821 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt src/ktoggleshowmenubaraction.cpp

D16983: Add 48px firewall-applet* icons

aacid added a comment. These symlinks as they stand are not poinless, they are wrong. Icon sets are not "targeting a particular piece of software", icon sets are system wide and any software can ask for a given icon, so firewall-applet-shields_up symlinking to firewall-config in size 48

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

loh.tar created this revision. Herald added a project: Frameworks. loh.tar requested review of this revision. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17026 AFFECTED FILES examples/dictionarycombobox.cpp To: loh.tar Cc: kde-frameworks-devel, michaelh, ngraham,