D17243: Only cal updateView() in visibleRange() when endPos() is invalid.

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Then lets try that. REPOSITORY R39 KTextEditor BRANCH lessUpdateView REVISION DETAIL https://phabricator.kde.org/D17243 To: sars, cullmann, #kate, dhaumann Cc: kwrite-devel,

D17342: team-port setting

jgrulich added a comment. Submit full patch, not only recent changes. REVISION DETAIL https://phabricator.kde.org/D17342 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17342: team-port setting

This revision was automatically updated to reflect the committed changes. Closed by commit R282:d3ca739a37ab: team-port setting (authored by pranavgade, committed by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17342?vs=46946=46949#toc REPOSITORY R282 NetworkManagerQt

D17342: team-port setting

pranavgade updated this revision to Diff 46940. pranavgade marked 2 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17342?vs=46905=46940 REVISION DETAIL https://phabricator.kde.org/D17342 AFFECTED FILES autotests/settings/CMakeLists.txt

D17378: Change title of the message box to something which conveys message

shubham created this revision. shubham added a reviewer: ngraham. shubham added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY The warning message box which appears on applying shift + delete (permanent

D17342: team-port setting

jgrulich added inline comments. INLINE COMMENTS > teamportsettingtest.cpp:103 > +if (it.key() == QLatin1String(NM_SETTING_TEAM_PORT_LINK_WATCHERS)) { > +NMVariantMapList list = it_1.value().value(); > +NMVariantMapList list1 = > map1.value(it_1.key()).value();

D17342: team-port setting

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. I lived in assumption that "link-watchers" is NMVariantMapMap and not NMVariantMapList, that's why I suggested those changes. I'm sorry for that. I'll fix it locally here, you were

D17342: team-port setting

pranavgade updated this revision to Diff 46946. pranavgade marked an inline comment as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17342?vs=46940=46946 REVISION DETAIL https://phabricator.kde.org/D17342 AFFECTED FILES autotests/settings/CMakeLists.txt

D17392: Fix checkDesktopFile function

ngraham added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17392 To: i.Dark_Templar, davidedmundson, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17378: Change title of the message box to something which conveys message

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17378 To: shubham, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17310: Improve Kile icon with LaTeX font

ndavis added a comment. In D17310#371697 , @trickyricky26 wrote: > With a small "k" in the equation: > F6457785: kile-alternative.svg.png > > With a capital "K": > F6457787:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 364 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/364/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 06 Dec 2018 20:04:43 + Build duration: 9 min 3 sec and counting JUnit Tests Name: (root) Failed: 2

D16716: fail writing test if mime type is not supported by the extractor

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH skip_missing REVISION DETAIL https://phabricator.kde.org/D16716 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16716: fail writing test if mime type is not supported by the extractor

astippich retitled this revision from "skip writing test if mime type is not supported by the extractor" to "fail writing test if mime type is not supported by the extractor". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16716 To: astippich, mgallien, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/3/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 06 Dec 2018 20:04:43 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed: 2

D17281: Add icon to KBuildSycocaProgressDialog cancel button

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3b320f7a32f3: Add icon to KBuildSycocaProgressDialog cancel button (authored by GB_2, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D17392: Fix checkDesktopFile function

i.Dark_Templar added a commit: R241:16edef0dca46: Remove unused variable. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17392 To: i.Dark_Templar, davidedmundson, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17015: Fix the Qt doc creation with Qt 5.12.

tcberner added inline comments. INLINE COMMENTS > ECMQueryQmake.cmake:9 > +# We need to look for the executable directly. > +find_program(_qmake_executable_default NAMES qmake-qt5) > endif() ^ on FreeBSD qmake-qt5 is just called qmake (which is in fact qtchooser). REPOSITORY R240

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

probono added a comment. Thank you @kossebau, really nice to see this. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham, TheAssassin Cc: probono, TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17392: Fix checkDesktopFile function

i.Dark_Templar created this revision. i.Dark_Templar added a reviewer: davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. i.Dark_Templar requested review of this revision. REVISION SUMMARY Variable isLocal is no longer initialized anywhere.

D14998: Add AppImage thumbnailer

ltoscano added a comment. In D14998#372293 , @probono wrote: > Can it be included/installed in KDE neon? You should ask on Neon request channels. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14998 To:

D17301: add documentation to result class

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH result_documentation REVISION DETAIL https://phabricator.kde.org/D17301 To: astippich, #baloo, bruns Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D17381: macsec setting

jgrulich added inline comments. INLINE COMMENTS > macsecsettingtest.cpp:29 > + > +#if !NM_CHECK_VERSION(1, 12, 0) > +#define NM_SETTING_MACSEC_PARENT "parent" This required version is not true, please verify it properly, I'm not going to do it every time :). >

D16694: Improve visibility for Konsole icon when using Breeze Dark

anishgiri edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16694 To: anishgiri, ngraham, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17381: macsec setting

jgrulich added a comment. Rebase this change on top of your previous change, this will not apply. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17381 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17241: WIP:Disable highlighting for lines longer than 1024 characters.

sars updated this revision to Diff 46957. sars edited the summary of this revision. sars added a comment. Add a message to inform about why the lines are not highlighted. Add a note about disabled highlighting to the wrapped lines warning. Increase the default line length limit to 100 000

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

loh.tar added a comment. Without any special "Oh, that would be nice", I will stop now with further S - I have tried to clean up a little bit the two header files, but that's more difficult than thought - m_cursor => cursorPosition() is also not so easy - There was no comment

D17395: add attributes `shared` and `__gshared`

aG0aep6G set the repository for this revision to R216 Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17395 To: aG0aep6G Cc:

D17241: WIP:Disable highlighting for lines longer than 1024 characters.

sars added a comment. The highlighting limit is now returned in a function in KateRenderer as it is used also in katedocument.cpp for the warning/information message. INLINE COMMENTS > mwolff wrote in katerenderer.cpp:400 > this style-change should be submitted independently of this code

D17243: Only cal updateView() in visibleRange() when endPos() is invalid.

This revision was automatically updated to reflect the committed changes. Closed by commit R39:cb63ec1ee30a: Only cal updateView() in visibleRange() when endPos() is invalid. (authored by sars). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/2/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 06 Dec 2018 13:18:01 + Build duration: 6 min 27 sec and counting BUILD ARTIFACTS

D17381: macsec setting

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Added macsec setting according to:

D17378: Change title of the message box to something which conveys message

This revision was automatically updated to reflect the committed changes. Closed by commit R241:13092bd64615: Change title of the message box to something which conveys message (authored by shubham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 365 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/365/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 07 Dec 2018 04:07:50 + Build duration: 7 min 33 sec and counting JUnit Tests Name: (root) Failed: 2

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/4/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 07 Dec 2018 04:07:50 + Build duration: 7 min 47 sec and counting JUnit Tests Name: (root) Failed: 2

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 366 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/366/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 07 Dec 2018 04:26:25 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed: 2

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.11 - Build # 3 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.11/3/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 07 Dec 2018 04:26:45 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/5/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 07 Dec 2018 04:26:25 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 2

D17381: macsec setting

pranavgade added inline comments. INLINE COMMENTS > jgrulich wrote in macsecsettingtest.cpp:29 > This required version is not true, please verify it properly, I'm not going > to do it every time :). I tried to get the version from here: F6459587: Screenshot from 2018-12-06 22-13-34.png

D15829: make units and prefixes of formatValue translatable

This revision was automatically updated to reflect the committed changes. Closed by commit R244:0b58dc656d1a: make units and prefixes of formatValue translatable (authored by astippich). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15829?vs=43038=46981

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 79 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/79/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 06 Dec 2018 17:47:32 + Build duration: 4 min 5 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.11 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.11/2/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 06 Dec 2018 17:47:32 + Build duration: 4 min 4 sec and counting JUnit Tests Name: (root)

D17357: extend list of supported mimetypes for embedded image extractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH image_extend REVISION DETAIL https://phabricator.kde.org/D17357 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16671: Refactor embedded image extractor for greater extensibility

This revision was automatically updated to reflect the committed changes. Closed by commit R286:7929a896b5e1: Refactor embedded image extractor for greater extensibility (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16671?vs=46880=46982#toc REPOSITORY R286

D17357: extend list of supported mimetypes for embedded image extractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:9f67b436f851: extend list of supported mimetypes for embedded image extractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D17358: implement cover extraction for asf files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:2a41e4b45262: implement cover extraction for asf files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17358?vs=46868=46985 REVISION

D17381: macsec setting

pranavgade updated this revision to Diff 46975. pranavgade marked 3 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17381?vs=46958=46975 REVISION DETAIL https://phabricator.kde.org/D17381 AFFECTED FILES autotests/settings/CMakeLists.txt

D17381: macsec setting

pranavgade added inline comments. INLINE COMMENTS > pranavgade wrote in macsecsetting.h:58 > From where can I get the possible values? Because I cannot find them here: > https://developer.gnome.org/NetworkManager/stable/settings-macsec.html (I mean the default values to use in the defines)

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL

D17381: macsec setting

pranavgade updated this revision to Diff 46958. pranavgade added a comment. rebased on master CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17381?vs=46953=46958 REVISION DETAIL https://phabricator.kde.org/D17381 AFFECTED FILES autotests/settings/CMakeLists.txt

D16694: Improve visibility for Konsole icon when using Breeze Dark

anishgiri updated this revision to Diff 46959. anishgiri edited the summary of this revision. anishgiri added a comment. Corrected the bright corner issue REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16694?vs=44931=46959 BRANCH utilities-terminal

D17301: add documentation to result class

astippich updated this revision to Diff 46987. astippich added a comment. - rephase description of TermGenerator REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17301?vs=46864=46987 BRANCH result_documentation REVISION DETAIL

D17301: add documentation to result class

astippich marked 2 inline comments as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in result.h:79 > The TermGenerator's do not contain any data themselves, but > > - keep/update the position state when adding data > - add the data to the referenced Baloo::Document when

D16716: skip writing test if mime type is not supported by the extractor

astippich added a comment. Well, if it is not even signaled via ctest, that's pretty bad, I agree REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16716 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16716: skip writing test if mime type is not supported by the extractor

astippich updated this revision to Diff 46990. astippich added a comment. - use QFAIL REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16716?vs=44983=46990 BRANCH skip_missing REVISION DETAIL https://phabricator.kde.org/D16716 AFFECTED FILES

D17391: add support for more mimetypes to taglibwriter

astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY adds support for basic tag writing to aiff, wav, wavpack,

D14998: Add AppImage thumbnailer

probono added a comment. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. Can it be included/installed in KDE neon? F6459777: ss.png REPOSITORY R320 KIO Extras REVISION DETAIL