D18379: Add tools icon

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Adds a `tools` icon for menus that show a list of tools/programs (e.g., the "Tools" menus

D18379: Add tools icon

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18379 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18379: Add tools icon

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18379 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18379: Add tools icon

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18379 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18379: Add tools icon

ndavis updated this revision to Diff 49862. ndavis added a comment. Fix messed up breeze-dark 32px version REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18379?vs=49861=49862 BRANCH tools-icon (branched from master) REVISION DETAIL

D18380: KIO: make file dialog columns resizable again

rjvbb created this revision. rjvbb added a reviewer: ngraham. rjvbb added a project: Frameworks. rjvbb requested review of this revision. REVISION SUMMARY File dialog detailed view columns were made fixed-size in commit #e504bc1fd56412ee7e9748a0dfafa537977ec1b5, leading to bug 401506.

D18379: Add tools icon

rooty added a comment. nice, +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18379 To: ndavis, #vdg Cc: rooty, kde-frameworks-devel, michaelh, ngraham, bruns

D18380: KIO: make file dialog columns resizable again

rjvbb updated this revision to Diff 49864. rjvbb added a comment. I realised the 1st version introduced a regression. This update restores automatic sizing when the dialog is resized. The fix currently has the effect of undoing any column sizing the user may have done before resizing the

D18380: KIO: make file dialog columns resizable again

rjvbb set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18380 To: rjvbb, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18379: Add tools icon

GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. Very nice! REPOSITORY R266 Breeze Icons BRANCH tools-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18379 To: ndavis, #vdg, GB_2 Cc: GB_2, rooty,

D18302: Add Android notification channel support

This revision was automatically updated to reflect the committed changes. Closed by commit R289:1c3c1dd70980: Add Android notification channel support (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18302?vs=49661=49865 REVISION

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.11 - Build # 13 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.11/13/ Project: kf5-qt5 AndroidQt5.11 Date of build: Sat, 19 Jan 2019 10:29:22 + Build duration: 2 min 55 sec and counting CONSOLE OUTPUT

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R240:7d73c6744f64: Move -Wsuggest-override -Wlogical-op to regular compiler settings (authored by aacid). REPOSITORY

Re: Power Management and Inhibition by Applications

On 16/01/19 22:07, Matthieu Gallien wrote: > Hello, > > I am trying to work on a feature request to add the ability to suppress > laptop > sleep when playing music. > > Currently, Juk is doing it via dbus calls to "org.kde.Solid.PowerManagement". > > I also had a look to Solid frameworks

D13316: manually set format in jpeg thumbnail creator

elvisangelaccio accepted this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13316 To: miklosm, dfaure, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, kfm-devel, ngraham, alexde, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros,

D18380: KIO: make file dialog columns resizable again (and movable)

ngraham added a comment. This version works pretty well! I'm not sure I like the bit where you make the Size column 20% smaller under certain circumstances though. Since the Size column was previously sized perfectly, making it 20% smaller makes all of its items get elided and become

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/4/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 20 Jan 2019 04:44:13 + Build duration: 6 min 26 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/6/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 20 Jan 2019 04:44:15 + Build duration: 7 min 45 sec and counting JUnit Tests

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.11 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.11/8/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 20 Jan 2019 04:44:14 + Build duration: 18 min and counting BUILD ARTIFACTS

D18384: Throw warning before creating directory named '~'

shubham updated this revision to Diff 49914. shubham added a comment. Use error string message as per recommendation. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18384?vs=49888=49914 BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18384

D18384: Throw warning before creating directory named '~'

shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18277: Add a new preferences-desktop-theme-global icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land.  REPOSITORY R266 Breeze Icons BRANCH new-pref-theme-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18277 To: trickyricky26, #vdg, ngraham Cc: ngraham,

D18277: Add a new preferences-desktop-theme-global icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:8523d32b1411: Add a new preferences-desktop-theme-global icon (authored by trickyricky26, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D17545: Do not stat move/copy job if the destination file system does not support writing

shubham abandoned this revision. shubham added a comment. Abandoned in favor of D17632 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17545 To: shubham, #frameworks, dfaure Cc: davidedmundson, ngraham, broulik, kde-frameworks-devel,

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 36 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/36/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 19 Jan 2019 15:23:55 + Build duration: 15 hr and counting

D18384: Throw warning before creating directory named '~'

shubham retitled this revision from "Throw warning before creating directory named '~' escaped by '\'" to "Throw warning before creating directory named '~' ". shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To:

D18384: Throw warning before creating directory named '~' escaped by '\'

shubham updated this revision to Diff 49883. shubham added a comment. - a REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18384?vs=49882=49883 BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18384 AFFECTED FILES src/filewidgets/knewfilemenu.cpp

D18387: Build without D-Bus on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY There is no D-Bus on Android. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/13/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 19 Jan 2019 15:39:10 + Build duration: 3 min 29 sec and counting JUnit Tests

D18329: Remove the AndroidX support library dependency

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D18329 To: vkrause, nicolasfella Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D18379: Add tools icon

ngraham added a comment. Very nice! Just what I had in mind. Do we really need a 32px version though? I thought we were trying to move towards all ≥ 32px icons being colorful, and not using the 32px size for action icons? REPOSITORY R266 Breeze Icons BRANCH tools-icon (branched from

D18384: Throw warning before creating directory named '~'

shubham updated this revision to Diff 49885. shubham retitled this revision from "Throw warning before creating directory named '~' " to "Throw warning before creating directory named '~'". shubham added a comment. 1. Better error message string. 2. Change name of the function. REPOSITORY

D18384: Throw warning before creating directory named '~'

shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18385: Build without KAuth and D-Bus on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY D-Bus isn't available on Android, and KAuth makes no sense either as the concept of executing things with elevated

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/19/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sat, 19 Jan 2019 15:39:10 + Build duration: 9 min 52 sec and counting BUILD ARTIFACTS

D18317: Don't fail if defaultLanguage dictionary can't be loaded

ahmadsamir added a comment. In D18317#395928 , @loh.tar wrote: > Just my thoughts: > > - I think there shouldn't be the (default) dictionary changed by some smart logic. Just hint the user that the setting is not applicable. The user

D18384: Give warning before creating directory named '~' escaped by '\'

shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18384: Give warning before creating directory named '~' escaped by '\'

shubham created this revision. shubham added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY BUG: 377978 TEST PLAN 1. Create a directory named "\~". 2. Warning dialog

D18379: Add tools icon

ngraham accepted this revision. ngraham added a comment. In D18379#396445 , @ndavis wrote: > In D18379#396432 , @ngraham wrote: > > > Very nice! Just what I had in mind. Do we really need a 32px

D18384: Throw warning before creating directory named '~' escaped by '\'

shubham retitled this revision from "Give warning before creating directory named '~' escaped by '\'" to "Throw warning before creating directory named '~' escaped by '\'". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc:

D18384: Throw warning before creating directory named '~' escaped by '\'

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Neat idea. INLINE COMMENTS > knewfilemenu.cpp:440 > +} else if (name.operator==(QLatin1String("\\~"))) { > +confirmDialog->setWindowTitle(i18n("Create directory

D18384: Throw warning before creating directory named '~'

ngraham added inline comments. INLINE COMMENTS > ngraham wrote in knewfilemenu.cpp:440 > That's not accurate; the dir just //begins with// `~`. Oops, never mind, ignore this. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc:

D18317: Don't fail if defaultLanguage dictionary can't be loaded

loh.tar added a comment. Well, I'm not a Sonnet Guru, more a normal user. Sorry if it sounds so. I can't give a detailed point how to solve some particular issue. My comment is more about what I would expect or what I would try to achieve. I didn't investigate from where is

D18386: Build without D-Bus on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY There is no D-Bus on Android. REPOSITORY R309 KService BRANCH master REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/9/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 19 Jan 2019 15:39:10 + Build duration: 6 min 1 sec and counting BUILD ARTIFACTS

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb retitled this revision from "KIO: make file dialog columns resizable again" to "KIO: make file dialog columns resizable again (and movable)". rjvbb set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18380 To: rjvbb,

D18380: KIO: make file dialog columns resizable again

rjvbb updated this revision to Diff 49869. rjvbb added a comment. Setting explicit sizes is best done in a mode that supports doing so... =/ Also, sections can be movable (again) now (I often like to see dates first, sizes 2nd). CHANGES SINCE LAST UPDATE

D18379: Add tools icon

ndavis added a comment. In D18379#396432 , @ngraham wrote: > Very nice! Just what I had in mind. Do we really need a 32px version though? A number of icons start with `tools-`, which means that this icon is the last fallback option. It

D18384: Throw warning before creating directory named '~'

shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18379: Add tools icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:1000c8b4884e: Add tools icon (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18379?vs=49862=49884 REVISION DETAIL

D18384: Throw warning before creating directory named '~'

ngraham added inline comments. INLINE COMMENTS > ngraham wrote in knewfilemenu.cpp:442 > Hmm, that might be too technical an explanation. How about this instead? > > `Beginning a file name with a tilde character ("~") is not recommended > because it may be confusing or dangerous if files are

D18384: Throw warning before creating directory named '~'

shubham added a comment. @ngraham There do exist a bug for inability to create directory named '~' without escaping, but I don't know it's bugzilla number. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: kde-frameworks-devel, michaelh,

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.11 - Build # 14 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.11/14/ Project: kf5-qt5 AndroidQt5.11 Date of build: Sat, 19 Jan 2019 15:23:55 + Build duration: 43 sec and counting CONSOLE OUTPUT

D18384: Throw warning before creating directory named '~'

shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18329: Remove the AndroidX support library dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R289:8536ef7e67a5: Remove the AndroidX support library dependency (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18329?vs=49737=49887

D18384: Throw warning before creating directory named '~'

shubham updated this revision to Diff 49888. shubham added a comment. 1. Change error string. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18384?vs=49885=49888 BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18384 AFFECTED FILES

D18380: KIO: make file dialog columns resizable again (and movable)

ngraham added a comment. This does indeed make the Name column resizable again (+1) but when the view is very narrow, it still starts out with a poor size by default. Maybe we can incorporate some more intelligence here and set a sensible default width for the Name column when the height of

D18277: Add a new preferences-desktop-theme-global icon

trickyricky26 updated this revision to Diff 49907. trickyricky26 added a comment. - Use a design with a rainbow background and color-split panel REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18277?vs=49573=49907 BRANCH new-pref-theme-icon

D18277: Add a new preferences-desktop-theme-global icon

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18277 To: trickyricky26, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb updated this revision to Diff 49908. rjvbb added a comment. tentative fix for "very narrow views". This imposes a simple minimum width on the name column. The value is taken from (33% wider than) the date column which has a useful width (which is already based on the current

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18380 To: rjvbb, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a comment. > If there's still enough room to show everything without a horizontal scrollbar, then we're still good. No, resizing a view so that it becomes taller than wide shouldn't make it behave as if it's become very narrow all of a sudden. Similarly, a very narrow

D18380: KIO: make file dialog columns resizable again (and movable)

ngraham added a comment. In D18380#396578 , @rjvbb wrote: > > Maybe we can incorporate some more intelligence here > > Same commit? It is a separate issue in a sense, no - you say "it *still* starts" so not a regression I introduced?

D13316: manually set format in jpeg thumbnail creator

This revision was automatically updated to reflect the committed changes. Closed by commit R320:880a09adae2a: manually set format in jpeg thumbnail creator (authored by miklosm, committed by ngraham). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D18388: Build without D-Bus on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D18388 AFFECTED FILES CMakeLists.txt

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a comment. > Maybe we can incorporate some more intelligence here Same commit? It is a separate issue in a sense, no - you say "it *still* starts" so not a regression I introduced? > and set a sensible default width for the Name column when the height of the view is

D18390: Build without D-Bus on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R294 KBookmarks BRANCH master REVISION DETAIL https://phabricator.kde.org/D18390 AFFECTED FILES CMakeLists.txt

D18389: Build without D-Bus on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D18389 AFFECTED FILES CMakeLists.txt

D18317: Don't fail if defaultLanguage dictionary can't be loaded

ahmadsamir added a comment. In D18317#396483 , @loh.tar wrote: > Well, I'm not a Sonnet Guru, more a normal user. Me too; your views are appreciated all the same. REPOSITORY R246 Sonnet REVISION DETAIL

D18384: Throw warning before creating directory named '~'

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. My string change request isn't addressed, and the string still doesn't end with a period. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: