D20752: Add missing properties in kpackage-generic.desktop

dfaure created this revision. dfaure added reviewers: mart, apol, sitter. dfaure requested review of this revision. REVISION SUMMARY Before: Unknown property type for key "Keywords" -> falling back to string Unknown property type for key "X-KDE-ParentApp" -> falling back to string

D20748: Fix wrong "Unable to find service type" warnings

aacid added a comment. Is this autotestable? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20748 To: dfaure, mart, arichardson, davidedmundson, mpyne Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20758: kpackagetool: read kpackage-generic.desktop from qrc

apol accepted this revision. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D20758 To: dfaure, sitter, apol Cc: #frameworks

D20748: Fix wrong "Unable to find service type" warnings

dfaure created this revision. dfaure added reviewers: mart, arichardson, davidedmundson, mpyne. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY If we parsed the service type from a qrc file (like

D20758: kpackagetool: read kpackage-generic.desktop from qrc

dfaure created this revision. dfaure added reviewers: sitter, apol. dfaure requested review of this revision. TEST PLAN (to mimick CI) : make uninstall in kpackage and then QT_LOGGING_RULES='*=true' XDG_DATA_DIRS=$KDEDIR/share /d/kde/build/5/frameworks/kpackage/bin/kpackagetool5

D20749: autotests: don't fail appstream test because of anything on stderr

dfaure created this revision. dfaure added reviewers: sitter, apol. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY ERROR_VARIABLE simply means where stderr goes, this

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Thanks! INLINE COMMENTS > kbookmarkmenu.cpp:150 > +d->numberOfOpenTabs = numberOfOpenTabs; > +m_bDirty = true; > +} Technically this is only needed if the number of open

D20749: autotests: don't fail appstream test because of anything on stderr

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D20749 To: dfaure, sitter, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20700: Add "edit-remove" icon symlink

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I'll accept this if you also make 22px versions. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis,

D20264: Add test for "Auto Reload Document" option

dhaumann added a comment. Yes, that's exactly what I meant. But if it's not stable, then it does not help. Maybe in that case keep it as is for now? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20264 To: loh.tar, dhaumann, cullmann Cc: cullmann, kwrite-devel,

D20169: Add profile support interface for TerminalInterface

dhaumann added a comment. Please fix the API getters: in the KDE/Qt world, getters never start with 'get': just use availableProdiles() etc. Similarly, I suggest to rename changeCurrentProfile() to setCurrentProfile(). Could you provide an updated patch? REPOSITORY R306 KParts

D20697: Review IconBorder

loh.tar added a comment. In D20697#453841 , @dhaumann wrote: > Did you test that the annotation border still works? You can do so in KDevelop by invoking git blame. :-/ ...OK, thanks > Besides I still gave no issues with this patch,

D20608: Declare properties as meta type

This revision was automatically updated to reflect the committed changes. Closed by commit R286:e869bac59302: Declare properties as meta type (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20608?vs=56387=56722 REVISION DETAIL

D20700: Add "edit-remove" icon symlink

GB_2 updated this revision to Diff 56707. GB_2 added a comment. Add 22px version of `paint-none` and add symlink for it REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20700?vs=56651=56707 BRANCH add-edit-remove-icon (branched from master) REVISION

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

GB_2 retitled this revision from "Add "edit-remove" icon symlink" to "Add "edit-remove" icon symlink and add 22px version of "paint-none"". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis, kde-frameworks-devel,

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/23/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 22 Apr 2019 09:41:39 + Build duration: 1 min 59 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/20/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 22 Apr 2019 09:41:39 + Build duration: 2 min 4 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/22/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 22 Apr 2019 09:41:39 + Build duration: 1 min 3 sec and counting JUnit Tests Name:

D20697: Review IconBorder

dhaumann added a comment. Did you test that the annotation border still works? You can do so in KDevelop by invoking git blame. Besides I still gave no issues with this patch, except that I did not test myself. If you say there are mouse move issues, then these issues should be fixed

D20169: Add profile support interface for TerminalInterface

mschiller updated this revision to Diff 56696. mschiller added a comment. Remove getProfilePath and remove get prefixes REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20169?vs=56672=56696 BRANCH terminal-interface-profiles (branched from master)

D20169: Add profile support interface for TerminalInterface

mschiller marked 3 inline comments as done. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

mschiller updated this revision to Diff 56697. mschiller added a comment. change KDEPARTS to KPARTS REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20169?vs=56696=56697 BRANCH terminal-interface-profiles (branched from master) REVISION DETAIL

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 85 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/85/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 22 Apr 2019 10:47:46 + Build duration: 1 min 9 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/80/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 22 Apr 2019 10:47:46 + Build duration: 2 min 2 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 86 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/86/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 22 Apr 2019 10:47:46 + Build duration: 2 min 12 sec and counting BUILD ARTIFACTS

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

This revision was automatically updated to reflect the committed changes. Closed by commit R824:c36d6b26eb3f: [FileMetaDataWidget] Allow inline configuration of visible properties (authored by bruns). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE

D20742: Paint the folding marker in propper color and make it more visible

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Both diff + output change in the screenshot look reasonable for me. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20742 To: loh.tar, #ktexteditor,

D20735: [KPropertiesDialog] Add octal permissions

ngraham added a comment. I think it makes sense to show octal permissions somewhere in the GUI. Power users use the GUI, too. :) But yeah, where exactly to put it needs some thought. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20735 To: shubham, ngraham, pino Cc:

D20525: [InformationPanel] Use the new inline configuration mode

bruns added inline comments. INLINE COMMENTS > elvisangelaccio wrote in informationpanelcontent.cpp:122-124 > These 3 lines could go in a dedicated function which we could call from both > lambdas, to avoid code duplication. Or it could even be a private slot > connected to

D20735: [KPropertiesDialog] Add octal permissions

shubham created this revision. shubham added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY This patch adds file permissions shown in octal format to the KPropertiesDialog

D20695: Add more icon sizes for audio, configure, distribute

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b5ec56091ed3: Add more icon sizes for audio, configure, distribute (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 83 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/83/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 22 Apr 2019 12:42:42 + Build duration: 5 min 3 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 86 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/86/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 22 Apr 2019 12:42:42 + Build duration: 5 min 3 sec and counting JUnit Tests

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

hallas updated this revision to Diff 56744. hallas added a comment. Reworked the patch to avoid any ABI breakage. Now the new functionality is in KBookmarkMenu instead. REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20209?vs=55300=56744 BRANCH

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

hallas added a comment. In D20209#450100 , @dfaure wrote: > Urgh. Indeed. And looking around I find many inline virtuals in apparently public headers... http://www.davidfaure.fr/2019/inline_virtual_dtors.diff (though maybe some of these don't

D20693: Remove pixelated border

ngraham added a comment. This patch doesn't apply: INFO Base commit is not in local repository; trying to fetch. Created and checked out branch arcpatch-D20693. Checking patch src/ui/imagepreviewwidget_p.h... Checking patch src/ui/imagepreviewwidget.cpp... Checking

D20668: [InformationPanel] Remove obsolete intermediate wrapper widget/layoutThe Baloo::MetaDataWidget is now able to stretch in a meaningful wayby itself, remove the wrapper.

This revision was automatically updated to reflect the committed changes. Closed by commit R318:832fd0965594: [InformationPanel] Remove obsolete intermediate wrapper widget/layout (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20668?vs=56538=56730#toc REPOSITORY

D17302: Add test for adding properties to result

astippich updated this revision to Diff 56729. astippich added a comment. - Test result document REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17302?vs=52894=56729 BRANCH test_result REVISION DETAIL https://phabricator.kde.org/D17302 AFFECTED FILES

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

ndavis added a comment. The 22px version needs to have 1px thick lines and 3px margins on each side. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D20667: Make the FileMetadataWidget stretch vertically in a sensible way

This revision was automatically updated to reflect the committed changes. Closed by commit R824:380dc4037c10: Make the FileMetadataWidget stretch vertically in a sensible way (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20667?vs=56537=56726#toc REPOSITORY R824

D20525: [InformationPanel] Use the new inline configuration mode

bruns updated this revision to Diff 56732. bruns marked 3 inline comments as done. bruns added a comment. coding style, rebase REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20525?vs=56405=56732 BRANCH cleanup REVISION DETAIL

D20735: [KPropertiesDialog] Add octal permissions

shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20735 To: shubham, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/76/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 22 Apr 2019 12:42:42 + Build duration: 18 min and counting BUILD ARTIFACTS

D20735: [KPropertiesDialog] Add octal permissions

ngraham requested changes to this revision. ngraham added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1869 > +lbl = new QLabel(i18n("Octal: %1", perm2), gb); > +gl = new QGridLayout(gb); > +gl->addWidget(lbl, 7, 0, Qt::AlignRight); You don't

D20708: Change input-* device icon styles, add 16px icons

ngraham added a comment. Even if only Inkscape currently uses the icon, as a rule we ignore that kind of information for code/content in Frameworks, because //in principle// any app could use it. It's more important for the icon to be semantically correct for any app that wants to use it

D20735: [KPropertiesDialog] Add octal permissions

pino added a comment. Also: what is the use case of this feature? For casual users the octal permissions make no sense, they are mostly useful for power users (if they don't even just use the terminal for these things). At most, this would fit in the "advanced permissions" dialog.

D20697: Review IconBorder

dhaumann added a comment. Well, issues that were already there before should not hinder this patch of course! If you think this is good enough, please go on. REVISION DETAIL https://phabricator.kde.org/D20697 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel,

D20742: Paint the folding marker in propper color and make it more visible

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Prior to this patch was the line in a color of the word wrap

D20735: [KPropertiesDialog] Add octal permissions

pino added a comment. In D20735#454260 , @shubham wrote: > I had used permission() to get the mode_t variable, which I later type casted to qint64, still the permissions resulted were completed wrong. Tried to print it as octal-based

D20735: [KPropertiesDialog] Add octal permissions

shubham added a comment. In D20735#454263 , @pino wrote: > Tried to print it as octal-based value? No, now I get that those permissions were base 10. How to print it as octal? REPOSITORY R241 KIO REVISION DETAIL

D20735: [KPropertiesDialog] Add octal permissions

pino added a comment. In D20735#454271 , @shubham wrote: > How to print it as octal? http://lmgtfy.com/?q=QString+arg REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20735 To: shubham, ngraham, pino Cc: pino,

D17442: KTextEditor: Tweak keyboard shortcuts to free F keys

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. We go with the minimal invasive effort ATM: just remove F6. As discussed in D17443 . We can introduce the CTRL-E... stuff later. REPOSITORY R39

D17442: KTextEditor: Tweak keyboard shortcuts to free F keys

This revision was automatically updated to reflect the committed changes. Closed by commit R39:8193e735bca2: remove default shortcut F6 to show icon border (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17442?vs=47152=56754#toc REPOSITORY R39 KTextEditor

D20735: [KPropertiesDialog] Add octal permissions

shubham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20735 To: shubham, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20525: [InformationPanel] Use the new inline configuration mode

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R318 Dolphin BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D20525 To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, elvisangelaccio Cc: elvisangelaccio,

D20735: [KPropertiesDialog] Add octal permissions

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. Parsing the result of KFileItem::permissionsString() is a rather bad idea, especially considering that KFileItem already provides mode() and permissions(). Also, the placing of

D20735: [KPropertiesDialog] Add octal permissions

shubham added a comment. I had used permission() to get the mode_t variable, which I later type casted to qint64, still the permissions resulted were completed wrong. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20735 To: shubham, ngraham, pino Cc: pino,

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

GB_2 updated this revision to Diff 56747. GB_2 added a comment. Fix icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20700?vs=56707=56747 BRANCH add-edit-remove-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D20700

D20742: Paint the folding marker in propper color and make it more visible

This revision was automatically updated to reflect the committed changes. Closed by commit R39:d9171c391267: Paint the folding marker in proper color and make it more visible (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE