D24770: KLocale api docs: make it easier to find how to port code away from it

This revision was automatically updated to reflect the committed changes. Closed by commit R239:556f102af097: KLocale api docs: make it easier to find how to port code away from it (authored by ahmadsamir). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/36/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 19 Oct 2019 13:15:06 + Build duration: 4 min 2 sec and counting JUnit Tests

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

kmaterka updated this revision to Diff 68292. kmaterka added a comment. Wrap menu in QPointer REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24755?vs=68229=68292 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24755 AFFECTED FILES

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

kmaterka marked 5 inline comments as done. kmaterka added a comment. In D24755#550140 , @davidedmundson wrote: > I don't exactly like it, but I don't have anything better. +1 Me neither. Probably the best would be to use shared pointer,

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven created this revision. meven added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY BUG: 413091 REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

davidedmundson added a comment. I don't exactly like it, but I don't have anything better. +1 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D24755 To: kmaterka, #frameworks, davidedmundson, broulik, nicolasfella Cc: anthonyfieroni, kde-frameworks-devel,

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

davidedmundson added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kstatusnotifieritemprivate_p.h:158 > It's related and you don't need to any hacks here. QPointer takes care of > ownership. QPointer here won't solve the other hacks needed. We have MenuSource, Menu and KSNI

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

kmaterka added inline comments. INLINE COMMENTS > davidedmundson wrote in kstatusnotifieritemprivate_p.h:158 > QPointer here won't solve the other hacks needed. > > We have MenuSource, Menu and KSNI > > QPointer would fix the case of MenuSource still owning the Menu and KSNI > lasting longer

D24762: Remove two unused member variables using KSslError

This revision was automatically updated to reflect the committed changes. Closed by commit R241:0bf73b6eebd7: Remove two unused member variables using KSslError (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24762?vs=68249=68287 REVISION

D24742: Make non-ignorable SSL errors explicit

vkrause updated this revision to Diff 68289. vkrause added a comment. Rebase on recent changes. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24742?vs=68248=68289 BRANCH next REVISION DETAIL https://phabricator.kde.org/D24742 AFFECTED FILES

D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket

dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. Looks good to me, thanks! REPOSITORY R7 Konversation BRANCH ahmad/ktcpsocket-qsslsocket (branched from master) REVISION DETAIL https://phabricator.kde.org/D24597 To: ahmadsamir,

D24770: KLocale api docs: make it easier to find how to port code away from it

ahmadsamir created this revision. ahmadsamir added a reviewer: Frameworks. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REPOSITORY R239 KDELibs4Support BRANCH ahmad/klocale-notes (branched from master) REVISION DETAIL https://phabricator.kde.org/D24770

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven added a reviewer: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24754: Fix KNSCore::Cache fetching when initialising Engine

leinir updated this revision to Diff 68284. leinir added a comment. - Ensure that the config filename only has the base name REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24754?vs=68227=68284 BRANCH fix-knscore-cache (branched from master) REVISION

D24770: KLocale api docs: make it easier to find how to port code away from it

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R239 KDELibs4Support BRANCH ahmad/klocale-notes (branched from master) REVISION DETAIL https://phabricator.kde.org/D24770 To: ahmadsamir, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 147 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/147/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 19 Oct 2019 10:47:16 + Build duration: 9 min 24 sec and counting JUnit Tests Name:

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

kmaterka added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kstatusnotifieritem.cpp:790 > That's easy checkable > > if (!qApp->closingDown() && (!d->menu->parent() || d->menu->parent() == > d->associatedWidget) { > delete d->menu; > } > > We should not own the menu,

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

anthonyfieroni added inline comments. INLINE COMMENTS > kmaterka wrote in kstatusnotifieritem.cpp:790 > This check is not reliable, assosiatedWidget can change. Anyway, this doesn't > matter here. > Did you read whole comment? Probably KSNI should not own the menu but it is > doing that for 10

D24753: Add edit-opacity icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:36993fdded88: Add edit-opacity icons (authored by Rafael Brandmaier rafael.brandma...@kdemail.net). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket

This revision was automatically updated to reflect the committed changes. Closed by commit R7:458822190452: [Konversation] Port from deprecated KTcpSocket to QSslSocket (authored by ahmadsamir). REPOSITORY R7 Konversation CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/72/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 20 Oct 2019 01:25:30 + Build duration: 20 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/18/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 20 Oct 2019 01:31:21 + Build duration: 25 min and counting JUnit Tests Name:

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.13 - Build # 15 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.13/15/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 20 Oct 2019 01:30:55 + Build duration: 24 min and counting JUnit Tests Name:

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/42/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 20 Oct 2019 01:41:33 + Build duration: 38 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/21/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 20 Oct 2019 01:05:33 + Build duration: 9 min 6 sec and counting JUnit Tests Name:

D24663: Use ECMGenerateExportHeader to manage deprecated API better

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:1fb1906ac5c2: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO

D24663: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. Reviewed myself once more and will be pushing now, given this is fairly straightforward after all, so the KF_* flags can be enabled next. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D24663 To: kossebau, #kwin Cc: zzag,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/48/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 20 Oct 2019 01:34:26 + Build duration: 27 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/15/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 20 Oct 2019 01:35:26 + Build duration: 27 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.13 - Build # 40 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.13/40/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 20 Oct 2019 03:10:36 + Build duration: 1 hr 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/37/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 20 Oct 2019 03:10:36 + Build duration: 1 hr 40 min and counting JUnit Tests

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 149 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/149/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 20 Oct 2019 03:11:21 + Build duration: 1 hr 49 min and counting JUnit Tests Name:

D24671: Use ECMGenerateExportHeader to manage deprecated API better

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R290:d03f2d7114c4: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R290

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/47/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 20 Oct 2019 00:44:41 + Build duration: 20 min and counting JUnit Tests Name:

D24671: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. Reviewed myself once more and will be pushing now, given this is fairly straightforward after all, so the KF_* flags can be enabled next. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D24671 To: kossebau, #frameworks, #plasma, mart, apol

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/26/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 20 Oct 2019 01:25:30 + Build duration: 15 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 148 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/148/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 20 Oct 2019 01:38:38 + Build duration: 38 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/22/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 20 Oct 2019 01:40:42 + Build duration: 34 min and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/29/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 20 Oct 2019 01:47:39 + Build duration: 44 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 68 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/68/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 20 Oct 2019 03:12:46 + Build duration: 1 hr 20 min and counting BUILD ARTIFACTS

D24793: [Konqueror] Remove KonqView::setActiveComponent()

ahmadsamir created this revision. ahmadsamir added reviewers: dfaure, stefanocrocco. ahmadsamir requested review of this revision. REVISION SUMMARY It's mostly redundant since KF5 port; the remaining bit m_activityResourceInstance->notifyFocusedIn() call can be moved to

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

anthonyfieroni added a comment. F7633806: p.patch That should be fine, in QPA we have a tray icon per sni, update menu should be on same object which will not be a problem, check it. REPOSITORY R289 KNotifications REVISION DETAIL

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

anthonyfieroni added inline comments. INLINE COMMENTS > kmaterka wrote in kstatusnotifieritemprivate_p.h:158 > Sure, but this is not my code and this is not related. What I want to do here > is more like hack/workaround, so it is better to keep it as simple as > possible. It's related and you

D24773: kio_trash: Add size, modification, access and create date for trash:/

ngraham added a dependent revision: D24774: Allow non-local directories to provide UDS_SIZE. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

anthonyfieroni added inline comments. INLINE COMMENTS > kstatusnotifieritem.cpp:454 > Qt::WindowFlags oldFlags = d->menu->windowFlags(); > d->menu->setParent(nullptr); > d->menu->setWindowFlags(oldFlags); Do not take ownership of the menu and delete it when it does not have a

D24593: Modified breeze shadows

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

kmaterka added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kstatusnotifieritem.cpp:454 > Do not take ownership of the menu and delete it when it does not have a > parent. takeOwnership is wrong approach, you can remove it. In theory that should be the correct approach, the "Qt

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

This revision was automatically updated to reflect the committed changes. Closed by commit R276:974a3ad18c05: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer (authored by davidre). REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

anthonyfieroni added inline comments. INLINE COMMENTS > kmaterka wrote in kstatusnotifieritem.cpp:790 > "associatedWidget" is a KSNI parent (line 780). It might be or might not be > set. If parent is not set, then "associatedWidget" is null and QMenu does not > have parent. This is fine, we

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann added a comment. Has somebody tested the current state? I really would like to get this going as in my eyes this will finally put a working solution in place for the coding style enforcing on at least frameworks. One can later still improve stuff like "shall the gitlab

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann added inline comments. INLINE COMMENTS > zzag wrote in clang-format.cmake:75 > I've been always wondering how one should break long ternary operators when > writing KF code. There are several ways to do it > > (a) w/o breaking (BreakBeforeTernaryOperators: false) > > const FooBar