D27133: kconfig_compiler : generate kconfig settings with subgroup

2020-02-25 Thread David Faure
dfaure added a comment. OK. `man ascii` says 0x1d is "GS (group separator)", not completely bogus :) I wonder how/why it becomes in XML, but quick googling says that entity seems to be '␝' which indeed reads GS :) At the KConfig level, this is good for catching people who don't use

D27502: Create ConfigView an unmanaged ConfigWidget

2020-02-25 Thread Kevin Ottens
ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > settings.cpp:62 > > -bool Settings::setCheckUppercase(bool check) > +void Settings::setCheckUppercase(bool check) > { Please rename it to "skip

D27637: kill twitter support

2020-02-25 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R495:13f9f45f2cce: kill twitter support (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27637?vs=76334=76399 REVISION DETAIL

D27616: [UrlHandler] optimise the code and less if nesting

2020-02-25 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > ahmadsamir wrote in urlhandler.cpp:55 > I could be wrong, but this is exactly equivalent to the original code, i.e. > it won't reach this unless helpcenter is empty and it's not a kde app... and > I actually wanted to ask about this bit from the

D27038: [KMessageWidget] Allow the style to change our palette

2020-02-25 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R236:d946fb71ea22: [KMessageWidget] Allow the style to change our palette (authored by davidre). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

2020-02-25 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R252:d3a1b5148008: [KStyle] Set the color of KMessageWidgets to the correct one from the current… (authored by davidre). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE

D27296: [PlasmaComponents]Clean up ListItem code

2020-02-25 Thread George Vogiatzis
This revision was automatically updated to reflect the committed changes. Closed by commit R242:10c112fccda8: [PlasmaComponents]Clean up ListItem code (authored by gvgeo). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27296?vs=75391=76411

D27601: KConfig: Convert to SPDX license statements

2020-02-25 Thread Carl Schwan
ognarb added inline comments. INLINE COMMENTS > cordlandwehr wrote in kcfg.xsd:20 > Actually, I though quite a time about this and at the end did a comparison of > the permissions specifically provided by this statement: use, copy and modify > (yet there is no explicit statement of

D27644: do not hide enum warnings via switch default label

2020-02-25 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH nodefault REVISION DETAIL https://phabricator.kde.org/D27644 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack,

D27654: [kio] Fix running konsole on Wayland

2020-02-25 Thread Wolfgang Bauer
wbauer updated this revision to Diff 76387. wbauer added a comment. Use `KShell::quoteArg()` in case the icon name contains spaces or other special chars. No idea if that's possible/allowed, but better be safe than sorry I suppose. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D27586: templates: Convert license statements to SPDX headers

2020-02-25 Thread Andreas Cord-Landwehr
cordlandwehr accepted this revision. cordlandwehr added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kossebau wrote in main.cpp:31 > Hmpf, that slipped me. The regular expression overdoing its job :) > I guess that will be hit in more KAboutData instances.

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-02-25 Thread Méven Car
meven added inline comments. INLINE COMMENTS > kcoreconfigskeleton.h:764 > QString whatsThis; > +QString val; > + Something I have noticed while testing this. Since it changes the memory of a very common data struct in a very common lib, it creates a lot of crashes if

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.13 - Build # 72 - Unstable!

2020-02-25 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.13/72/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 25 Feb 2020 18:59:03 + Build duration: 4 min 0 sec and counting JUnit Tests Name:

D27647: throw out the windows variant of the smb slave

2020-02-25 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R320 KIO Extras BRANCH smb-no-win REVISION DETAIL https://phabricator.kde.org/D27647 To: sitter, ngraham, #windows, vonreth Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2,

D27097: Port from QRegExp to QRegularExpression

2020-02-25 Thread Ahmad Samir
ahmadsamir added a comment. Looking at the incremental stuff some more, there are no public methods that mention incremental; the only way is to set the KFind::FindIncremental flag; the only method I could find is in the private API (find_p.h) startNewIncrementalSearch(). So technically

D27660: Add Inno Setup syntax, including embedded Pascal scripting

2020-02-25 Thread Michael Hansen
zrax created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. zrax requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH innosetup (branched from master) REVISION DETAIL

D27637: kill twitter support

2020-02-25 Thread Aleix Pol Gonzalez
apol accepted this revision. REPOSITORY R495 Purpose Library BRANCH killtwitter REVISION DETAIL https://phabricator.kde.org/D27637 To: nicolasfella, #frameworks, apol, bshah Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27601: KConfig: Convert to SPDX license statements

2020-02-25 Thread Andreas Cord-Landwehr
cordlandwehr marked 3 inline comments as done. cordlandwehr added inline comments. INLINE COMMENTS > cgiboudeaux wrote in kcfg.xsd:20 > What makes you think it's BSD? Actually, I though quite a time about this and at the end did a comparison of the permissions specifically provided by this

D27601: KConfig: Convert to SPDX license statements

2020-02-25 Thread Andreas Cord-Landwehr
cordlandwehr updated this revision to Diff 76403. cordlandwehr added a comment. Better handling of explenatory texts REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27601?vs=76224=76403 BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27601

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-02-25 Thread Méven Car
meven updated this revision to Diff 76405. meven marked 6 inline comments as done. meven added a comment. Move KCoreConfigSkeleton::ItemEnum::Choice::value to cpp file, use a regex to filter valid choice name REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D27654: [kio] Fix running konsole on Wayland

2020-02-25 Thread Wolfgang Bauer
wbauer edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27654 To: wbauer, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-25 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76382. niccolove added a comment. re-tweaked commits REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=76381=76382 BRANCH contrast_effect_background_color (branched from master) REVISION

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-25 Thread Nathaniel Graham
ngraham added a comment. In D27122#617594 , @niccolove wrote: > F8131397: image.png Now that //is// relaxing :) I like it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D27603: KDNSSD: Convert license headers to SPDX statements

2020-02-25 Thread Andreas Cord-Landwehr
This revision was automatically updated to reflect the committed changes. Closed by commit R272:563fc1416d90: KDNSSD: Convert license headers to SPDX statements (authored by cordlandwehr). REPOSITORY R272 KDNSSD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27603?vs=76226=76400

D27602: KDbusAddons: Convert license statement to SPDX

2020-02-25 Thread Andreas Cord-Landwehr
This revision was automatically updated to reflect the committed changes. Closed by commit R271:a222808f86cd: KDbusAddons: Convert license statement to SPDX (authored by cordlandwehr). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27602?vs=76225=76401

D27502: Create ConfigView an unmanaged ConfigWidget

2020-02-25 Thread Benjamin Port
bport updated this revision to Diff 76384. bport added a comment. Rework, not expose anymore settings and loader but expose a new settings class REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27502?vs=75997=76384 REVISION DETAIL

D27646: smb: apply a whole bunch of static analyzer improvements

2020-02-25 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH tidy REVISION DETAIL https://phabricator.kde.org/D27646 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe,

D27038: [KMessageWidget] Allow the style to change our palette

2020-02-25 Thread David Redondo
davidre updated this revision to Diff 76408. davidre added a comment. Rebase REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27038?vs=74701=76408 BRANCH polish REVISION DETAIL https://phabricator.kde.org/D27038 AFFECTED FILES

D27635: Restore kio-webdav plugin

2020-02-25 Thread Nicolas Fella
nicolasfella updated this revision to Diff 76413. nicolasfella added a comment. - Adapt path REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27635?vs=76328=76413 BRANCH restore REVISION DETAIL https://phabricator.kde.org/D27635 AFFECTED

D27662: Rewrite nextcloud plugin

2020-02-25 Thread Nicolas Fella
nicolasfella updated this revision to Diff 76421. nicolasfella added a comment. - Remove debug REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27662?vs=76420=76421 BRANCH nextcloud REVISION DETAIL https://phabricator.kde.org/D27662 AFFECTED

D27635: Restore kio-webdav plugin

2020-02-25 Thread Nicolas Fella
nicolasfella edited the summary of this revision. REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27635 To: nicolasfella, bshah, leinir, #frameworks

D27363: KHolidays: Convert license statements to SPDX expressions

2020-02-25 Thread Allen Winter
winterz accepted this revision. This revision is now accepted and ready to land. REPOSITORY R175 KHolidays BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27363 To: cordlandwehr, winterz Cc: cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27635: Restore kio-webdav plugin

2020-02-25 Thread Nicolas Fella
nicolasfella updated this revision to Diff 76416. nicolasfella added a comment. - Simplify REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27635?vs=76413=76416 BRANCH restore REVISION DETAIL https://phabricator.kde.org/D27635 AFFECTED

D21795: [KAuth] Add support for action details in Polkit1 backend.

2020-02-25 Thread Alexander Saoutkin
feverfew updated this revision to Diff 76419. feverfew added a comment. - Fix the diff REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21795?vs=76073=76419 BRANCH arcpatch-D21795_1 REVISION DETAIL https://phabricator.kde.org/D21795 AFFECTED FILES

D27665: Support SAE in securityTypeFromConnectionSetting

2020-02-25 Thread hexchain
hexchain added a dependent revision: D27666: Support WPA3-SAE in the applet popup. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D27665 To: hexchain, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27662: Rewrite nextcloud plugin

2020-02-25 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, apol, bshah. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Let CopyJob and the webdav KIO slave do the hard work.

D27665: Support SAE in securityTypeFromConnectionSetting

2020-02-25 Thread hexchain
hexchain created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Herald added a reviewer: jgrulich. hexchain requested review of this revision. REVISION SUMMARY Allow SAE to be returned from securityTypeFromConnectionSetting. TEST PLAN Not

D27097: Port from QRegExp to QRegularExpression

2020-02-25 Thread David Faure
dfaure added a comment. Deprecate the attribute, keep the code. There is more KF5-based code out there than the one visible by lxr.kde.org. Some of it not even public. We make the same promise as Qt, preserving SC and BC in major versions. OK for "Invalid PCRE pattern syntax"

D27654: [kio] Fix running konsole on Wayland

2020-02-25 Thread David Faure
dfaure added a comment. Since this is konsole specific, it's fine to use a Qt-specific argument. But IMHO you could also just remove the %i altogether. I never understood the idea of "take the icon from the desktop file, not the one the application would use by default". I mean, with

D27662: Rewrite nextcloud plugin

2020-02-25 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH nextcloud REVISION DETAIL https://phabricator.kde.org/D27662 To: nicolasfella, #frameworks, apol, bshah Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D23339: Fix memory leak in ConfigView and Dialog

2020-02-25 Thread Nicolas Fella
nicolasfella added a comment. This makes plasmashell crash for me as soon as a notification appears. https://invent.kde.org/snippets/730 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23339 To: dvratil, #plasma, #frameworks, apol,

D27586: templates: Convert license statements to SPDX headers

2020-02-25 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R306:c10ca8623903: templates: Convert license statements to SPDX headers (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27586?vs=76236=76437#toc REPOSITORY R306 KParts

D27557: Auto-generate 24px monochrome icons

2020-02-25 Thread Ömer Fadıl Usta
usta added a comment. Freebsd side broken again : 00:31:45 ./build/icons-dark/generated/devices/24/network-wired-activated.svg:14: parser error : Opening and ending tag mismatch: g line 8 and svg 00:31:45 00:31:45^ 00:31:45

D27665: Support SAE in securityTypeFromConnectionSetting

2020-02-25 Thread Jan Grulich
jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH securityTypeFromConnectionSetting-support-SAE (branched from master) REVISION DETAIL https://phabricator.kde.org/D27665 To: hexchain, jgrulich Cc:

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-25 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76373. niccolove added a comment. Tweaked values REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75787=76373 BRANCH contrast_effect_background_color (branched from master) REVISION

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-02-25 Thread Alex Debus
alexde added a comment. Does this patch also fix indirectly #274629? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-25 Thread Niccolò Venerandi
niccolove added a comment. I felt that the transparency was not working very well with the headerbar on some wallpapers, so I toned down the transparency a bit, going from F8131395: image.png to F8131397: image.png

D27097: Port from QRegExp to QRegularExpression

2020-02-25 Thread Ahmad Samir
ahmadsamir marked an inline comment as done. ahmadsamir added a comment. In D27097#615648 , @dfaure wrote: > OK for deprecating Incremental. A full revert (at KF6 time) of commit 9ac82e27ad0322e444c16

D27647: throw out the windows variant of the smb slave

2020-02-25 Thread Hannah von Reth
vonreth accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH smb-no-win REVISION DETAIL https://phabricator.kde.org/D27647 To: sitter, ngraham, #windows, vonreth Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice,

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-02-25 Thread Kevin Ottens
ervin added a comment. In D27540#617589 , @alexde wrote: > Does this patch also fix indirectly #274629? I doubt it, this bug report seems confused BTW... it was never broken on the kdelibs side but *some* dialogs have bugs which break

D27444: Added top area

2020-02-25 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76376. niccolove added a comment. Added toparea margins REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=75824=76376 BRANCH top_area (branched from master) REVISION DETAIL

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-25 Thread Tranter Madi
trmdi added a comment. Hmm, I think you need to rebase to remove unrelated files in this patch e.g. `dropjob.cpp` ... ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: trmdi, cblack, ndavis,

D27654: [kio] Fix running konsole on Wayland

2020-02-25 Thread Wolfgang Bauer
wbauer created this revision. wbauer added a reviewer: dfaure. wbauer added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. wbauer requested review of this revision. REVISION SUMMARY %i expands to "--icon someicon", but Qt recognizes this option only on X11/xcb. So

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-25 Thread Niccolò Venerandi
niccolove added a comment. In D27122#617614 , @trmdi wrote: > Hmm, I think you need to rebase to remove unrelated files in this patch e.g. `dropjob.cpp` ... ? Definitively. *sigh* REPOSITORY R242 Plasma Framework (Library) REVISION

D27444: Added top area

2020-02-25 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76378. niccolove added a comment. Rebase REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=76376=76378 BRANCH top_area (branched from master) REVISION DETAIL

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-25 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76381. niccolove added a comment. Rebase REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=76373=76381 BRANCH contrast_effect_background_color (branched from master) REVISION DETAIL

D27642: RFC WIP support OSX style device icons system for dns-sd discoveries

2020-02-25 Thread Harald Sitter
sitter created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY looking for some general thoughts on the concept osx and newer sambas send model data in the dnssd

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 356 - Still Unstable!

2020-02-25 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/356/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 25 Feb 2020 10:23:34 + Build duration: 3 min 48 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 209 - Still Unstable!

2020-02-25 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/209/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 25 Feb 2020 10:23:34 + Build duration: 3 min 50 sec and counting BUILD ARTIFACTS

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-25 Thread Cyril Rossi
crossi added a dependent revision: D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27059 To: crossi, ervin, dfaure, #frameworks, mdawson Cc: kde-frameworks-devel, LeGast00n, cblack,

D27133: kconfig_compiler : generate kconfig settings with subgroup

2020-02-25 Thread Cyril Rossi
crossi added a dependent revision: D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27133 To: crossi, ervin, dfaure, #frameworks Cc: meven, kde-frameworks-devel, LeGast00n, cblack,

D27502: Create ConfigView an unmanaged ConfigWidget

2020-02-25 Thread Benjamin Port
bport added inline comments. INLINE COMMENTS > ervin wrote in settings.cpp:109 > This is an odd bit of logic, isn't it? Yes indeed, but what we want is to save false if checked and true if not checked. I moved the logic there in order to work with kconfigxt and with current implementation >

D27644: do not hide enum warnings via switch default label

2020-02-25 Thread Harald Sitter
sitter created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY should we ever extend the url types the compiler will not warn us that the new type may need

D27644: do not hide enum warnings via switch default label

2020-02-25 Thread Harald Sitter
sitter added a reviewer: ngraham. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27644 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh,

D27540: Status indicator for individual widgets in KCModule

2020-02-25 Thread Kevin Ottens
ervin added a comment. In D27540#615091 , @davidre wrote: > The editmarks should probably respect the visibility of the associated widget. In this picture I use a invisble lineedit to manage the settings of the QButtonGroup beneath

D27540: Status indicator for individual widgets in KCModule

2020-02-25 Thread Kevin Ottens
ervin updated this revision to Diff 76362. ervin added a comment. Handle visibility of the tracked widget, setters become slots, and add plural to "indicatorWidgets". REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27540?vs=76089=76362 REVISION

D27540: Status indicator for individual widgets in KCModule

2020-02-25 Thread Kevin Ottens
ervin edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg Cc: iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

2020-02-25 Thread Daniel Vrátil
dvratil added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21902 To: dvratil, mart, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27633: Port to KPluginLoader

2020-02-25 Thread Dan Leinir Turthra Jensen
leinir added inline comments. INLINE COMMENTS > kaccountsdplugin.cpp:24 > > -KAccountsDPlugin::KAccountsDPlugin(QObject *parent) > +KAccountsDPlugin::KAccountsDPlugin(QObject *parent, const QVariantList& args) > : QObject(parent) This caused a compiler warning to show up - pushed a quick

D23339: Fix memory leak in ConfigView and Dialog

2020-02-25 Thread Daniel Vrátil
This revision was automatically updated to reflect the committed changes. Closed by commit R242:4b93b71a4924: Fix memory leak in ConfigView and Dialog (authored by dvratil). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D27627: Fix initialization order

2020-02-25 Thread Daniel Vrátil
This revision was automatically updated to reflect the committed changes. Closed by commit R242:1e11099c1616: Fix initialization order (authored by dvratil). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27627?vs=76306=76361 REVISION

D27540: Status indicator for individual widgets in KCModule

2020-02-25 Thread Kevin Ottens
ervin added a comment. In D27540#615160 , @ervin wrote: > In D27540#615156 , @ngraham wrote: > > > Please add screenshots to the Test Plan section for patches that change the UI. :) Also it would

D21902: Calendar: add method to show event details

2020-02-25 Thread Daniel Vrátil
dvratil updated this revision to Diff 76365. dvratil added a comment. - Rebase to master REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21902?vs=60891=76365 BRANCH arcpatch-D21902 REVISION DETAIL https://phabricator.kde.org/D21902

D27647: throw out the windows variant of the smb slave

2020-02-25 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY it hasn't been built in ages because the top level cmakelists

D27647: throw out the windows variant of the smb slave

2020-02-25 Thread Harald Sitter
sitter added a reviewer: Windows. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27647 To: sitter, ngraham, #windows Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D27616: [UrlHandler] optimise the code and less if nesting

2020-02-25 Thread Ahmad Samir
ahmadsamir added a comment. I created D27615 first; then this one on top of it (optimising the code in a separate commit). INLINE COMMENTS > apol wrote in urlhandler.cpp:55 > won't this recurse forever? I could be wrong, but this is exactly equivalent

D27646: smb: apply a whole bunch of static analyzer improvements

2020-02-25 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY among other things: - {} initialize the posix structs -

D27497: Fix code generation for entries with min/max

2020-02-25 Thread Kevin Ottens
ervin edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27497 To: hchain, meven, crossi, ervin, bport, tcanabrava Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-02-25 Thread Noah Davis
ndavis added a comment. I can see the utility in indicating non-default values in some cases, particularly with software that has a lot of necessary complexity in the settings or where non-default values can cause problems (see SVG Cleaner GUI for an example of both). However, I don't think

D27133: kconfig_compiler : generate kconfig settings with subgroup

2020-02-25 Thread David Faure
dfaure added a comment. I really have zero experience with this stuff, but you're asking for my opinion nonetheless, so you'll get it, as crappy as it might be :-) Your comment refers to "group separator" as if it was an existing notion in KConfig. Can you point me where? Grepping for

D27133: kconfig_compiler : generate kconfig settings with subgroup

2020-02-25 Thread Kevin Ottens
ervin added a comment. In D27133#617577 , @dfaure wrote: > I really have zero experience with this stuff, but you're asking for my opinion nonetheless, so you'll get it, as crappy as it might be :-) > > Your comment refers to "group

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.12 - Build # 123 - Unstable!

2020-02-25 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.12/123/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 25 Feb 2020 14:58:30 + Build duration: 4 min 54 sec and counting BUILD ARTIFACTS

D27540: KCModule: Indicate when a setting has been changed from the default value

2020-02-25 Thread Nathaniel Graham
ngraham retitled this revision from "Status indicator for individual widgets in KCModule" to "KCModule: Indicate when a setting has been changed from the default value". REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson,

D27540: KCModule: Indicate when a setting has been changed from the default value

2020-02-25 Thread David Redondo
davidre added a comment. That title is now not optimal isn't it? 1. It's not only in KCModule 2. It also shows unsaved settings REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg Cc: iasensio,

D27497: Fix code generation for entries with min/max

2020-02-25 Thread Kevin Ottens
ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27497 To: hchain, meven, crossi, ervin, bport, tcanabrava Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-02-25 Thread Nathaniel Graham
ngraham retitled this revision from "KCModule: Indicate when a setting has been changed from the default value" to "KCModule: Indicate when a setting has been changed from the default or previous value". REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To:

D27497: Fix code generation for entries with min/max

2020-02-25 Thread Henri Chain
hchain updated this revision to Diff 76368. hchain added a comment. add bugzilla REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=76317=76368 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED FILES

D27497: Fix code generation for entries with min/max

2020-02-25 Thread Henri Chain
This revision was automatically updated to reflect the committed changes. Closed by commit R237:d218b93a5350: Fix code generation for entries with min/max (authored by hchain). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=76368=76371 REVISION

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.13 - Build # 91 - Unstable!

2020-02-25 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.13/91/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 25 Feb 2020 14:58:30 + Build duration: 2 min 16 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.13 - Build # 85 - Unstable!

2020-02-25 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.13/85/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 25 Feb 2020 14:58:30 + Build duration: 1 min 6 sec and counting JUnit Tests Name: