D29138: [Solid] Replace foreach (deprecated) with range/index for

This revision was automatically updated to reflect the committed changes. Closed by commit R245:b9abef40855e: [Solid] Replace foreach (deprecated) with range/index for (authored by ahmadsamir). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29138?vs=81131=81314

D29197: filenamesearch: Implement stat to display metainfo

meven added a reviewer: elvisangelaccio. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29197 To: meven, #dolphin, #frameworks, ngraham, elvisangelaccio Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack,

D29170: Detect executables without +x permission in $PATH to improve error message

ahmadsamir accepted this revision. ahmadsamir added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kprocessrunner.cpp:65 > +const QStringList searchPaths = > QString::fromLocal8Bit(qgetenv("PATH")).split(QDir::listSeparator(), > skipEmptyParts); > +

D29170: Detect executables without +x permission in $PATH to improve error message

meven added a comment. Is it not sufficient to fix bug 415567 ? In which case replace in commit comment CCBUG by BUG INLINE COMMENTS > desktopexecparser.cpp:40 > #include > +#include > Not needed. REPOSITORY R241 KIO BRANCH 2020_04_findExecutable REVISION DETAIL

D29221: [FakeCdrom] Add a new UnknownMediumType enumerator to MediumType

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven, bruns. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY As was discussed in https://phabricator.kde.org/D29138 and on IRC (with frinring and vkrause), add

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/12/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 27 Apr 2020 09:25:56 + Build duration: 1 min 17 sec and counting JUnit Tests Name:

D29198: filenamesearch:/ define a title for the query

meven updated this revision to Diff 81330. meven marked an inline comment as done. meven added a comment. Rename DolphinSearchBox::getQueryTitle to DolphinSearchBox::queryTitle REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29198?vs=81246=81330 BRANCH

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 11:12 PM Olivier Churlaud wrote: > > Hi, > > Le lundi 27 avril 2020, 12:38:42 CEST Aleix Pol a écrit : > > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > > replies] > > > > > > Hello

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 7:26 PM Ilya Bizyaev wrote: > > Hello Bhushan! > > Thank you for you work on the Gitlab migration! > > The lists look good! Here are some ideas that I have, in case you think they > can be considered before we transition: > • The "applications" category is somewhat

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > replies] > > Hello Community members, > > In view of upcoming Gitlab migration, we sysadmin team wants to share > the recommended structuring for the repositories on Gitlab.

D29138: [Solid] Replace foreach (deprecated) with range/index for

ahmadsamir added inline comments. INLINE COMMENTS > bruns wrote in fakeopticaldisc.cpp:43 > Thats not a cast but a constructor, see QFlags documentation From opticaldrive.h: Q_DECLARE_FLAGS(MediumTypes, MediumType) AFAIU, MediumTypes is the QFlags, MediumType is the enum. So

D29219: [KFontChooser] Remove NoFixedCheckBox DisplayFlag, redundant

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH l-remove-redundant-displayflag (branched from master) REVISION DETAIL https://phabricator.kde.org/D29219 To: ahmadsamir, #frameworks, dfaure, cfeck, bport Cc:

D29219: [KFontChooser] Remove NoFixedCheckBox DisplayFlag, redundant

This revision was automatically updated to reflect the committed changes. Closed by commit R236:5d803a237955: [KFontChooser] Remove NoFixedCheckBox DisplayFlag, redundant (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 10:50 PM Piyush Aggarwal wrote: > > > > On Mon, 27 Apr, 2020, 4:09 pm Aleix Pol, wrote: >> >> On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: >> > >> > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for >> > replies] >> > >> > Hello Community members,

D29222: Fix update auto selection

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY The new autoselection for updating installed entries would firstly not be looking at the right amount of download

D29222: Fix update auto selection

leinir edited the summary of this revision. leinir added reviewers: Frameworks, Plasma, bugseforuns, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29222 To: leinir, #frameworks, #plasma, bugseforuns, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack,

Re: changing icon sizes no longer emits signal

Hi, A patch like the one attached seems to help, but someone who knows the KCM better (or has time to dig) should make this conditional on the user actually changing icon sizes, and only emit for the groups that have changed. Patch makes sense, though I wonder why we do both emitChange and a

D27859: [server] Expose SurfaceRole class

zzag abandoned this revision. zzag added a comment. Given our planned kwaylandserver changes, we don't need this patch. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27859 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure added a comment. In D29170#658058 , @meven wrote: > Is it not sufficient to fix bug 415567 ? In which case replace in commit comment CCBUG by BUG No, that bug has two issues. "Program not found" and "Missing lib" -- which is

D29223: Update Taiwanese holidays

nhiga created this revision. nhiga added reviewers: winterz, cgiboudeaux. nhiga added projects: KDE PIM, Frameworks. nhiga requested review of this revision. REVISION SUMMARY This patch improves upon @shrapnel 's work on the accuracy of the Taiwanese

Re: changing icon sizes no longer emits signal

(That's why confirmation prompts are pointless, one gets so used to just acknowledge them all that that I sent this mail mid-sentece :) ...so perhaps we should just change it to always emit the dbus signal manually when something changed, rather than it being nested inside exportToKDE4().

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 10:39 PM Aleix Pol wrote: > > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > replies] > > > > Hello Community members, > > > > In view of upcoming Gitlab migration, we sysadmin team wants

D29223: Update Taiwanese holidays

nhiga added a comment. Notes: 1. Holidays for indigenous peoples have not been included. Some of them seem to have a fixed date, but for other festivals we know the range but not the exact dates. For example, it is known that 豐年祭(收穫祭) is celebrated between July 1 and September 30

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 12:55 PM Ben Cooksley wrote: > > On Mon, Apr 27, 2020 at 10:39 PM Aleix Pol wrote: > > > > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > > replies] > > > > > > Hello Community

Re: KF 5 & C++14?

Am Montag, 27. April 2020, 00:45:41 CEST schrieb David Faure: > On Sunday, April 26, 2020 5:30:37 PM CEST Friedrich W. H. Kossebau wrote: > > Hi, > > > > I just saw that at least kimageformats, knewstuff & kquickcharts all set > > this: set(CMAKE_CXX_STANDARD 14) > > > >

D29228: [KProcessRunner] Use only executable name for scope

broulik created this revision. broulik added reviewers: Frameworks, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Slashes aren't allowed in scope names, so when a full executable path is

Re: Splitting KWayland

On Mon, Apr 27, 2020 at 1:58 PM Aleix Pol wrote: > Hi, > As discussed in the meeting last week, I've been looking into the split. > > Here's what I was thinking of, please tell me if there's something > massively important I'm missing. > > The idea would be to start working on it after kwayland

D29223: Update Taiwanese holidays

nhiga added a comment. In D29223#658229 , @cgiboudeaux wrote: > I suppose you rename the file for a good reason. Are there different "official" languages for Taiwan? The new file name follows the same naming scheme used by the PRC

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 81341. apol added a comment. Address review comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=81113=81341 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED FILES

D29095: Change mouse icon to have better dark theme contrast

ngraham added a comment. +1, very nice. `icons/preferences/32/preferences-desktop-mouse.svg` still shows the old one from an earlier version of this patch. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: ndavis, #vdg, saligari Cc: bruns,

D29188: [FileWatch] Remove redundant watchIndexedFolders() slot

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D29188 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov,

D29223: Update Taiwanese holidays

cgiboudeaux added a reviewer: shrapnel. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin,

D29199: honor the extractMetaData flag

ngraham accepted this revision. REPOSITORY R286 KFileMetaData BRANCH honorFlag REVISION DETAIL https://phabricator.kde.org/D29199 To: astippich, #baloo, bruns, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh,

D29200: test the extractNothing flag

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH testNoExtraction REVISION DETAIL https://phabricator.kde.org/D29200 To: astippich, #baloo, bruns, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n,

Re: Splitting KWayland

On Mon, Apr 27, 2020 at 2:12 PM David Edmundson wrote: > > > On Mon, Apr 27, 2020 at 1:58 PM Aleix Pol wrote: > >> Hi, >> As discussed in the meeting last week, I've been looking into the split. >> >> Here's what I was thinking of, please tell me if there's something >> massively important I'm

D29188: [FileWatch] Remove redundant watchIndexedFolders() slot

This revision was automatically updated to reflect the committed changes. Closed by commit R293:1793785420b7: [FileWatch] Remove redundant watchIndexedFolders() slot (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29188?vs=81201=81347

D29229: [KPlotting] Port foreach (deprecated) to range for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R277 KPlotting BRANCH l-foreach (branched from master) REVISION DETAIL

D28882: Create protocol to manage video feeds

davidedmundson added inline comments. INLINE COMMENTS > screencast.xml:46 > + > + > + add type = "destructor" so that clients calling this release the resource REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich,

Splitting KWayland

Hi, As discussed in the meeting last week, I've been looking into the split. Here's what I was thinking of, please tell me if there's something massively important I'm missing. The idea would be to start working on it after kwayland and other kf5 have been tagged next week (?). Something I was

D28882: Create protocol to manage video feeds

meven added inline comments. INLINE COMMENTS > screencasting.cpp:141 > +} > +void zkde_screencast_unstable_v1_removeSource(uint32_t sourceId) > override { > +auto it = std::find_if(m_sources.begin(), m_sources.end(), > [sourceId] (const ScreencastingSource ) { Missing blank

D28882: Create protocol to manage video feeds

apol marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich, davidedmundson Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham added a comment. This version looks great to me! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

Re: Information regarding upcoming Gitlab Migration

In part I am mostly re-iterating what Ben already mentioned in different messages. On Mon, Apr 27, 2020 at 12:38:42PM +0200, Aleix Pol wrote: > Does this mean that to clone it we'll have to go "git clone > kde:games/knetwalk" or something along the lines? Yes [Rest of message is with sysadmin

D29223: Update Taiwanese holidays

cgiboudeaux added a comment. I suppose you rename the file for a good reason. Are there different "official" languages for Taiwan? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: #kde_pim, kde-frameworks-devel,

Re: Having $(framework)_global.h headers (was: Re: building KF5 projects against a different Qt5 version [...])

Am Sonntag, 26. April 2020, 16:12:31 CEST schrieb Friedrich W. H. Kossebau: > Am Sonntag, 26. April 2020, 15:46:35 CEST schrieb David Faure: > > On Sunday, April 26, 2020 3:21:34 PM CEST René J.V. Bertin wrote: > > > Talking about version test hacks (or not-so-hacks): why is it that > > >

D29084: Make the HTML file template more useful

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:5adaa7cba102: Make the HTML file template more useful (authored by gszymaszek). REPOSITORY R241 KIO CHANGES SINCE

Re: Information regarding upcoming Gitlab Migration

Hello Bhushan! Thank you for you work on the Gitlab migration! The lists look good! Here are some ideas that I have, in case you think they can be considered before we transition: • The "applications" category is somewhat misleading to me: it does not include all KDE applications, and not

D29095: Change mouse icon to have better dark theme contrast

ndavis updated this revision to Diff 81374. ndavis added a comment. - Change kmousetool and preferences-desktop-mouse to symlinks REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29095?vs=81211=81374 BRANCH arcpatch-D29095 REVISION DETAIL

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

bport added a dependent revision: D29231: [WIP] Add keyboard_shortcuts_inhibit protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29054 To: bport, zzag, davidedmundson Cc: meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport created this revision. bport added reviewers: zzag, davidedmundson, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY Depends on D29054 . REPOSITORY

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

romangg added inline comments. INLINE COMMENTS > zzag wrote in keyboard_shortcuts_inhibit_interface.cpp:129 > We probably need to ask folks in `#wayland` whether inhibitors outlive the > manager object. In general objects created through some interface can outlive the interface bind if not

D29206: Move check for invalid service from KDesktopFileActions to ApplicationLauncherJob

ahmadsamir added a comment. Otherwise makes sense. INLINE COMMENTS > kprocessrunner.cpp:55 > +if (!service->isValid()) { > +emitDelayedError(i18n("The desktop entry file\n%1\nis not valid.", > service->entryPath())); > +return; IMHO, the word "entry" here is confusing,

D29222: Fix update auto selection

ngraham added a comment. Are you on a case-insensitive filesystem? :p /home/nate/kde/src/knewstuff/src/core/engine.cpp: In member function ‘void KNSCore::Engine::downloadLinkLoaded(const KNSCore::EntryInternal&)’: /home/nate/kde/src/knewstuff/src/core/engine.cpp:650:91: error:

D29232: [WIP][RFC]Introduce the Tools color set

mart retitled this revision from "Introduce the Tools color set" to "[WIP][RFC]Introduce the Tools color set". REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D29232 To: mart, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29232: Introduce the Tools color set

mart created this revision. mart added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY This introduces two concepts: a new color set for Tools (or: titlebar? open question)

D29233: [Solid] Port foreach to range/index for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, bruns, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R245 Solid BRANCH l-foreach-3 (branched from master) REVISION DETAIL

D29232: [WIP][RFC]Introduce the Header color set

mart retitled this revision from "[WIP][RFC]Introduce the Tools color set" to "[WIP][RFC]Introduce the Header color set". mart edited the summary of this revision. mart edited the test plan for this revision. REPOSITORY R265 KConfigWidgets BRANCH phab/toolsSet REVISION DETAIL

D29101: KNewStuff: Fix file path and process call

ngraham added a reviewer: leinir. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent, leinir Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29095: Change mouse icon to have better dark theme contrast

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: ndavis, #vdg, saligari Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29232: [WIP][RFC]Introduce the Header color set

cblack added inline comments. INLINE COMMENTS > ndavis wrote in kcolorscheme.h:133 > I think it would be good to explain the issue about enums being converted > into plain integers here so that people know why they shouldn't depend on it. > Also, is there a way to hide this from the

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport updated this revision to Diff 81361. bport added a comment. Use client not display for KeyboardShortcutsInhibitorInterface REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29231?vs=81358=81361 REVISION DETAIL https://phabricator.kde.org/D29231

D28882: Create protocol to manage video feeds

zzag requested changes to this revision. zzag added a comment. This revision now requires changes to proceed. > In future, it might be faster to put up just the interface xml for review first. ++ --- What about using existing `wl_output` objects? The `add_source` event can be

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport updated this revision to Diff 81358. bport marked an inline comment as done. bport added a comment. added const to wrong line REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29231?vs=81355=81358 REVISION DETAIL https://phabricator.kde.org/D29231

Re: Information regarding upcoming Gitlab Migration

Hi, Le lundi 27 avril 2020, 12:38:42 CEST Aleix Pol a écrit : > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > replies] > > > > Hello Community members, > > > > In view of upcoming Gitlab migration, we sysadmin

Re: Information regarding upcoming Gitlab Migration

On Montag, 27. April 2020 14:10:55 CEST Bhushan Shah wrote: > [adding sysad...@kde.org in CC, please make sure you keep it in CC] > > On Mon, Apr 27, 2020 at 02:03:48PM +0200, Ingo Klöcker wrote: > > On Montag, 27. April 2020 13:19:07 CEST Ben Cooksley wrote: > > > That requires that you know it

Re: Information regarding upcoming Gitlab Migration

Le lundi 27 avril 2020, 13:19:07 CEST Ben Cooksley a écrit : > On Mon, Apr 27, 2020 at 11:12 PM Olivier Churlaud > wrote: > > > > Hi, > > > > Le lundi 27 avril 2020, 12:38:42 CEST Aleix Pol a écrit : > > > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > > > > > [Please keep

Re: Information regarding upcoming Gitlab Migration

On 4/27/20 7:52 AM, Nate Graham wrote: On 4/27/20 7:46 AM, Ingo Klöcker wrote: On Montag, 27. April 2020 14:10:55 CEST Bhushan Shah wrote: This is something which can be easily solved by Gitlab, Gitlab offers a solution where project can be shared with another group. So e.g. sharing

Re: Information regarding upcoming Gitlab Migration

On Mon, 27 Apr, 2020, 4:09 pm Aleix Pol, wrote: > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > replies] > > > > Hello Community members, > > > > In view of upcoming Gitlab migration, we sysadmin team wants to

Re: Information regarding upcoming Gitlab Migration

On 4/27/20 4:38 AM, Aleix Pol wrote: Does this mean that to clone it we'll have to go "git clone kde:games/knetwalk" or something along the lines? If that's the case I'd much prefer if we didn't do this, at the moment it's already uncomfortable for me to remember the URL for some of the

Re: Information regarding upcoming Gitlab Migration

On 4/27/20 7:46 AM, Ingo Klöcker wrote: On Montag, 27. April 2020 14:10:55 CEST Bhushan Shah wrote: This is something which can be easily solved by Gitlab, Gitlab offers a solution where project can be shared with another group. So e.g. sharing kcontacts with kdepim should be possible, then

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 66 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/66/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 27 Apr 2020 16:04:46 + Build duration: 5 min 19 sec and counting BUILD ARTIFACTS

D29232: [WIP][RFC]Introduce the Tools color set

mart updated this revision to Diff 81363. mart added a comment. call it Header REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29232?vs=81352=81363 BRANCH phab/toolsSet REVISION DETAIL https://phabricator.kde.org/D29232 AFFECTED FILES

D29232: [WIP][RFC]Introduce the Tools color set

ndavis added a comment. I personally think it should be Header since Tools sound ambiguous and oddly limited to anyone unfamiliar with the context behind this patch REPOSITORY R265 KConfigWidgets BRANCH phab/toolsSet REVISION DETAIL https://phabricator.kde.org/D29232 To: mart, #vdg,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 565 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/565/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 27 Apr 2020 16:04:46 + Build duration: 12 min and counting BUILD ARTIFACTS

D29232: [WIP][RFC]Introduce the Header color set

mart requested review of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D29232 To: mart, #vdg, #plasma, cblack Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29231 To: bport, zzag, davidedmundson, apol Cc: crossi, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

This revision was automatically updated to reflect the committed changes. Closed by commit R127:185f40195dc0: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order (authored by bport). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport updated this revision to Diff 81355. bport added a comment. Cyril feedback REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29231?vs=81351=81355 REVISION DETAIL https://phabricator.kde.org/D29231 AFFECTED FILES autotests/server/CMakeLists.txt

D29232: [WIP][RFC]Introduce the Tools color set

ngraham added a task: T10201: Window titlebars. REPOSITORY R265 KConfigWidgets BRANCH phab/toolsSet REVISION DETAIL https://phabricator.kde.org/D29232 To: mart, #vdg, #plasma, cblack Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 74 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/74/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 27 Apr 2020 16:04:46 + Build duration: 8 min 11 sec and counting JUnit Tests Name:

D29232: [WIP][RFC]Introduce the Tools color set

ndavis added inline comments. INLINE COMMENTS > kcolorscheme.h:127 > +/** > + * Colors for header areas that thould be used both by the top > toolbar and the titlebar titlebar. > + * @since 5.69 - `thould` - `titlebar titlebar` REPOSITORY R265 KConfigWidgets BRANCH

D29232: [WIP][RFC]Introduce the Tools color set

ndavis added inline comments. INLINE COMMENTS > kcolorscheme.h:133 > * Number of color sets. > + * Note: don't use this > * @since 5.65 I think it would be good to explain the issue about enums being converted into plain integers here so that people know why they

D29095: Change mouse icon to have better dark theme contrast

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: ndavis, #vdg, saligari Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/13/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 27 Apr 2020 15:22:51 + Build duration: 5 min 17 sec and counting JUnit Tests Name:

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

crossi added inline comments. INLINE COMMENTS > keyboard_shortcuts_inhibit_interface.cpp:92 > +{ > +return d->m_surface; > +} indentation is missing > keyboard_shortcuts_inhibit_interface.h:39 > +void setActive(bool active); > +bool isActive(); > +private: Should be const REPOSITORY

D29232: [WIP][RFC]Introduce the Tools color set

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. +1 to the approach here. I assume this would probably replace the `WM` set in kdeglobals for all practical usage? REPOSITORY R265 KConfigWidgets BRANCH phab/toolsSet REVISION DETAIL

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

apol added a comment. Code looks good overall, I'd say you'll get to polish the weird bits when developing the kwin side. In fact, this probably could be implemented within kwin considering what we discussed last week. We could remove the weirdness we have to keep its ABI. INLINE

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

zzag requested changes to this revision. zzag added a comment. This revision now requires changes to proceed. I don't want to be selfish, but I'm not really used to the coding style in this patch. Could you please move method definitions outside class declarations? INLINE COMMENTS >

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure added inline comments. INLINE COMMENTS > ahmadsamir wrote in kprocessrunner.cpp:65 > I guess there is no need to use QDir::current() any more. Good point, removing. REPOSITORY R241 KIO BRANCH 2020_04_findExecutable REVISION DETAIL https://phabricator.kde.org/D29170 To: dfaure,

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure updated this revision to Diff 81376. dfaure added a comment. Remove QDir::current REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29170?vs=81275=81376 BRANCH 2020_04_findExecutable REVISION DETAIL https://phabricator.kde.org/D29170 AFFECTED FILES

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 68 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/68/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 27 Apr 2020 19:45:51 + Build duration: 6 min 23 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 76 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/76/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 27 Apr 2020 19:45:51 + Build duration: 6 min 49 sec and counting JUnit Tests Name:

D29232: [WIP][RFC]Introduce the Header color set

ndavis added inline comments. INLINE COMMENTS > davidre wrote in kcolorscheme.cpp:271 > I would have expected at least of one the new colors to have the same value > as this one. Why is that? The only one that might is Active, but that's not really used much right now. REPOSITORY R265

D29206: Move check for invalid service from KDesktopFileActions to ApplicationLauncherJob

ahmadsamir accepted this revision. ahmadsamir added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > dfaure wrote in kprocessrunner.cpp:55 > I see what you're saying. > > It's the name of the spec, though. >

D29206: Move check for invalid service from KDesktopFileActions to ApplicationLauncherJob

dfaure added inline comments. INLINE COMMENTS > ahmadsamir wrote in kprocessrunner.cpp:55 > IMHO, the word "entry" here is confusing, the first thing that comes to mind > is that an entry (i.e. a line) in the file is invalid. I see what you're saying. It's the name of the spec, though.

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure updated this revision to Diff 81377. dfaure added a comment. Remove unused QFileInfo include REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29170?vs=81376=81377 BRANCH 2020_04_findExecutable REVISION DETAIL https://phabricator.kde.org/D29170

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/75/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 27 Apr 2020 19:25:36 + Build duration: 8 min 22 sec and counting JUnit Tests Name:

D29229: [KPlotting] Port foreach (deprecated) to range for

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R277 KPlotting BRANCH l-foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D29229 To: ahmadsamir, #frameworks, dfaure, apol, meven Cc: kde-frameworks-devel, LeGast00n,

D29239: [KPlotting] foreach is gone, build with -DQT_NO_FOREACH

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R277 KPlotting BRANCH l-no-foreach (branched from master) REVISION DETAIL

D29216: Remove dead code since KF5.0: mount/umount devices in their contextmenu

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29216 To: dfaure, apol, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

  1   2   >