D29201: KCMUtils: Add option to append service file to list of arguments

meven added inline comments. INLINE COMMENTS > kpluginselector.cpp:855 > +} > +KCModuleProxy *currentModuleProxy = new > KCModuleProxy(moduleInfo, moduleProxyParentWidget, arguments); > if (currentModuleProxy->realModule()) { Adding a fileName field to

D29634: sftp: break large writes into multiple requests

meven added a comment. Well apart from the length of data needed to be reduced as we progress, all this makes sense. Btw gvfs uses 32768 as MAX_BUFFER_SIZE for sftp https://gitlab.gnome.org/GNOME/gvfs/-/blob/master/daemon/gvfsbackendsftp.c#L94 REPOSITORY R320 KIO Extras REVISION

D29397: KPreviewJob : Support for DeviceRatioPixel

meven updated this revision to Diff 82709. meven added a comment. Ensure to load images with the right devicePixelRatio REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29397?vs=82339=82709 BRANCH preview-dpr REVISION DETAIL

D29397: KPreviewJob : Support for DeviceRatioPixel

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29397 To: meven, dfaure, broulik, #frameworks Cc: kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29201: KCMUtils: Add option to append service file to list of arguments

alex added inline comments. INLINE COMMENTS > meven wrote in kpluginselector.cpp:855 > Adding a fileName field to KCModuleProxy would make more sense to me, and do > it by default. > Plus KCModuleProxy has already access to the fileName since it receives > moduleInfo. > But I am not a

D29634: sftp: break large writes into multiple requests

sitter edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29634 To: sitter, ngraham, meven Cc: meven, feverfew, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n,

D29634: sftp: break large writes into multiple requests

sitter updated this revision to Diff 82723. sitter added a comment. - rejigger write segmentation into new sftpWrite function used by both the put() and write() - fix length calculation - refine buf size comment REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 106 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/106/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 13 May 2020 11:48:37 + Build duration: 7 min 9 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 597 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/597/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 13 May 2020 12:52:18 + Build duration: 6 min 19 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 99 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/99/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 13 May 2020 12:52:17 + Build duration: 6 min 19 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 98 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/98/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 13 May 2020 11:48:37 + Build duration: 8 min 31 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 596 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/596/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 13 May 2020 11:48:37 + Build duration: 14 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 107 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/107/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 13 May 2020 12:52:18 + Build duration: 4 min 38 sec and counting JUnit Tests Name:

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

ngraham added a comment. In D29711#670458 , @cfeck wrote: > Sorry if I don't understand the scope, but does this mean I am forced to install systemsettings to be able to use KCMs? Why, is the "I'm using Plasma but I don't have System

D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED()

This revision was automatically updated to reflect the committed changes. Closed by commit R240:cc8bccadcdb9: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED() (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D27989: Add a new set of barcode size functions

kossebau added a comment. > minimumSize() becomes deprecated by this, the deprecation macros will > follow once the current users have been adjusted. IMHO you should add the macros from the start, otherwise it will be only forgotten later, as there is no mechanism to remind you. And

D29678: Fix incorrect colours in the KNS Quick messagebox

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH fix-colour-issue-for-messagebox (branched from master) REVISION DETAIL https://phabricator.kde.org/D29678 To: leinir, #frameworks, #knewstuff, #plasma, bugseforuns, ngraham

D29678: Fix incorrect colours in the KNS Quick messagebox

This revision was automatically updated to reflect the committed changes. Closed by commit R304:5ce4d1a29b96: Fix incorrect colours in the KNS Quick messagebox (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29678?vs=82744=82791

D29634: sftp: break large writes into multiple requests

meven added a comment. In D29634#670377 , @ngraham wrote: > Nice work. > > In D29634#670159 , @feverfew wrote: > > > I imagine something similar should be done for FileJob::write? > > >

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

cfeck added a comment. Sorry if I don't understand the scope, but does this mean I am forced to install systemsettings to be able to use KCMs? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: cfeck, kde-frameworks-devel,

D29634: sftp: break large writes into multiple requests

feverfew added a comment. In D29634#670419 , @meven wrote: > In D29634#670377 , @ngraham wrote: > > > Nice work. > > > > In D29634#670159 , @feverfew

D29534: Implement scroll and drag adjustment of values for SpinBox control

ngraham updated this revision to Diff 82786. ngraham marked an inline comment as done. ngraham added a comment. Address review comment REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29534?vs=82311=82786 BRANCH

D29634: sftp: break large writes into multiple requests

ngraham accepted this revision. ngraham added a comment. Nice work. In D29634#670159 , @feverfew wrote: > I imagine something similar should be done for FileJob::write? Yeah. REPOSITORY R320 KIO Extras BRANCH release/20.04

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

ltoscano added a comment. In D29711#670470 , @ngraham wrote: > In D29711#670458 , @cfeck wrote: > > > Sorry if I don't understand the scope, but does this mean I am forced to install systemsettings

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 598 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/598/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 13 May 2020 22:26:02 + Build duration: 6 min 20 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 101 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/101/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 13 May 2020 22:41:37 + Build duration: 8 min 52 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 601 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/601/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 14 May 2020 00:06:42 + Build duration: 5 min 32 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 103 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/103/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 14 May 2020 00:08:15 + Build duration: 5 min 52 sec and counting BUILD ARTIFACTS

D29708: Introduce EXCLUDE_DEPRECATED_BEFORE_AND_AT

dfaure added a comment. > there are lots of KRun::run* usages in non-deprecated API sadly in KIO :( OK, I'll fix that. REPOSITORY R241 KIO BRANCH excludedeprecated REVISION DETAIL https://phabricator.kde.org/D29708 To: kossebau, #frameworks, dfaure, meven, ahmadsamir Cc:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 100 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/100/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 13 May 2020 22:26:02 + Build duration: 9 min 52 sec and counting BUILD ARTIFACTS

D29707: Remove deprecation tag from SlaveBase::config() for now

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c7b164496354: Remove deprecation tag from SlaveBase::config() for now (authored by kossebau). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29707?vs=82729=82799

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 111 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/111/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 14 May 2020 00:04:39 + Build duration: 5 min 3 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 108 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/108/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 13 May 2020 22:26:02 + Build duration: 5 min 2 sec and counting JUnit Tests Name:

D29223: Update Taiwanese holidays

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R175:b1291acbfc09: Update Taiwanese holidays (authored by nhiga, committed by winterz). REPOSITORY R175 KHolidays

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 599 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/599/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 13 May 2020 22:41:37 + Build duration: 6 min 31 sec and counting BUILD ARTIFACTS

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

dfaure added inline comments. INLINE COMMENTS > ahmadsamir wrote in copyjob.cpp:1965 > Good point, I missed that the original code was checking the file names and > the paths with the same compare() call. > > About /dir/file and /DIR/FILE, the parent dirs is actually one dir since > "dir" and

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 109 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/109/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 13 May 2020 22:41:37 + Build duration: 5 min 21 sec and counting JUnit Tests Name:

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

dfaure requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29610 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 102 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/102/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 13 May 2020 23:59:36 + Build duration: 8 min 37 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 600 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/600/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 13 May 2020 23:59:36 + Build duration: 7 min 3 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 110 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/110/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 13 May 2020 23:59:36 + Build duration: 4 min 59 sec and counting JUnit Tests Name:

D29708: Introduce EXCLUDE_DEPRECATED_BEFORE_AND_AT

This revision was automatically updated to reflect the committed changes. Closed by commit R241:391351a6be0e: Introduce EXCLUDE_DEPRECATED_BEFORE_AND_AT (authored by kossebau). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29708?vs=82730=82806 REVISION DETAIL

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

bewuethr created this revision. bewuethr added a reviewer: Framework: Syntax Highlighting. bewuethr added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. bewuethr requested review of this revision.

D29680: Fix modified line marker in kate minimap

This revision was automatically updated to reflect the committed changes. Closed by commit R39:f2b0dcdefea7: Fix modified line marker in kate minimap (authored by davidedmundson). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29680?vs=82663=82717

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/14/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 13 May 2020 10:03:09 + Build duration: 5 min 22 sec and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/13/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 13 May 2020 10:03:09 + Build duration: 8 min 33 sec and counting BUILD ARTIFACTS

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

tcanabrava added a comment. +1. @cfeck do you think this can land now? REPOSITORY R236 KWidgetsAddons BRANCH named_color_support REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: cblack, broulik, cfeck,

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

kossebau added inline comments. INLINE COMMENTS > slavebase.h:355 > */ > -KConfigGroup *config(); > +KIOCORE_DEPRECATED KConfigGroup *config(); > Given there are still a few usages of config() left which seem not easily replaceable, it would be better to remove the deprecation

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

ngraham created this revision. ngraham added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Many Plasma applets use `kcmshell.open` to open the appropriate KCM. However

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

ngraham added a dependent revision: D29712: [applets] Show KCMs in System Settings or Info Center, as appropriate. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

ngraham added a dependent revision: D29713: [applets] Show KCMs in System Settings. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

ngraham added a dependent revision: D29714: [applets] Show KCMs in System Settings. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

ngraham added a dependent revision: D29715: [applet] Show KCM in System Settings. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

ngraham added a dependent revision: D29716: [applet] Show KCM in System Settings. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29634: sftp: break large writes into multiple requests

feverfew accepted this revision. feverfew added a comment. I imagine something similar should be done for FileJob::write? REPOSITORY R320 KIO Extras BRANCH release/20.04 REVISION DETAIL https://phabricator.kde.org/D29634 To: sitter, ngraham, meven, feverfew Cc: meven, feverfew,

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

ahmadsamir updated this revision to Diff 82750. ahmadsamir retitled this revision from "[CopyJob] Use stricter conditions when using QFile::rename in slotResultRenaming" to "[kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems". ahmadsamir edited the summary of this revision.

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

ahmadsamir added a comment. In D29610#667858 , @dfaure wrote: > OK for now, to fix the unittests. The *real* fix however is to use QFile::rename in kio_file so that this failure to rename doesn't even happen in the first place. > > In this

D29526: Thumbnails: make thumbnail generation dpr-aware

meven added inline comments. INLINE COMMENTS > sitter wrote in thumbnail.cpp:774 > Var naming is a bit inconsistent across the code base now. In the > implementations there are maxWidth/H that are device-adjusted but in here > they are not. Not a huge concern, just noticed. Will take care >

D29707: Remove deprecation tag from SlaveBase::config() for now

kossebau created this revision. kossebau added reviewers: Frameworks, meven, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY There is no migration path for all current usages of config()

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven added inline comments. INLINE COMMENTS > kossebau wrote in slavebase.h:355 > Given there are still a few usages of config() left which seem not easily > replaceable, it would be better to remove the deprecation tag for the > compiler, to not have false warnings on those places (see e.g.

D29634: sftp: break large writes into multiple requests

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH release/20.04 REVISION DETAIL https://phabricator.kde.org/D29634 To: sitter, ngraham, meven Cc: meven, feverfew, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik,

D29678: Fix incorrect colours in the KNS Quick messagebox

leinir updated this revision to Diff 82744. leinir added a comment. Address comment by @ngraham - Add a comment for the purpose of the control being a TextEdit REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29678?vs=82659=82744 BRANCH

D29708: Introduce EXCLUDE_DEPRECATED_BEFORE_AND_AT

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure, meven, ahmadsamir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Not all versions of the past will work as value,

D29708: Introduce EXCLUDE_DEPRECATED_BEFORE_AND_AT

kossebau added a comment. @dfaure So far I had no idea how to introduce a simple variant of the deprecation macros to support just disabling latest. For one would this make things more complex as there would be yet another approach. And things would be also become a bit unreliable on the

D29526: Thumbnails: make thumbnail generation dpr-aware

sitter added a comment. You do seem to calculate the deviceWidth and height an awful lot, it makes reading a bit clunky. I'd much rather have the multiplication done once and then always use the var instead. In fact, perhaps it'd make sense to have createV3 feed the values into the

D29707: Remove deprecation tag from SlaveBase::config() for now

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH removedeprecatetagfromslavebaseconfig REVISION DETAIL https://phabricator.kde.org/D29707 To: kossebau, #frameworks, meven, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack,

D29708: Introduce EXCLUDE_DEPRECATED_BEFORE_AND_AT

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Great stuff, this much less cleanup will be needed for KF6 ! INLINE COMMENTS > global.cpp:99 > > +#if KIOCORE_BUILD_DEPRECATED_SINCE(3, 4) > KIOCORE_EXPORT QTime

D29678: Fix incorrect colours in the KNS Quick messagebox

ngraham added a comment. Does this even need to be a TextEdit? Or is that to get mouse-selectability for the error text? If so, +1 but please add comments indicating this reason. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29678 To: leinir, #frameworks,

D29678: Fix incorrect colours in the KNS Quick messagebox

leinir added a comment. In D29678#670125 , @ngraham wrote: > Does this even need to be a TextEdit? Or is that to get mouse-selectability for the error text? If so, +1 but please add comments indicating this reason. That is precisely what