and test passes
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Hi!
Today I couldn't compile KF5 with the following message from cmake:
--
CMake Warning at staging/kdoctools/src/CMakeLists.txt:27 (find_package):
By not providing FindDocBookXML.cmake in CMAKE_MODULE_PATH this project
has asked CMake to find a
I answer myself (thanks to the info given by sebas through irc):
If it happens to you, please delete the build dir (at least the e-c-m one)
update e-c-m and rebuild.
Cheers!
David Gil
2013/9/5 David Gil Oliva davidgilol...@gmail.com
Hi!
Today I couldn't compile KF5 with the following
f46265e97243aa776f901120d832368154c5c2ed
Diff: http://git.reviewboard.kde.org/r/112527/diff/
Testing
---
It compiles and test passes
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
/xmpp_emoticons.cpp
2535b71263f468dacc830e7cf92fead5e61528e8
staging/kemoticons/tests/main.cpp f46265e97243aa776f901120d832368154c5c2ed
Diff: http://git.reviewboard.kde.org/r/112527/diff/
Testing
---
It compiles and test passes
Thanks,
David Gil Oliva
---
On Sept. 8, 2013, 12:58 a.m., David Gil Oliva wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112527
2535b71263f468dacc830e7cf92fead5e61528e8
staging/kemoticons/tests/main.cpp f46265e97243aa776f901120d832368154c5c2ed
Diff: http://git.reviewboard.kde.org/r/112527/diff/
Testing
---
It compiles and test passes
Thanks,
David Gil Oliva
___
Kde-frameworks
, but
m_variable.
Nevertheless, members of a private class don't usually have any underscore
or m_, because when accessing them as d-name makes it clear that they are
private. Probably you have a reason, though :-) .
- David Gil Oliva
On Sept. 10, 2013, 11:32 p.m., Sebastian Kügler wrote
On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote:
staging/kservice/src/services/kplugininfo.cpp, line 61
http://git.reviewboard.kde.org/r/112660/diff/1/?file=188728#file188728line61
I think that two variables (hidden and _hidden) so similar are
confusing.
Sebastian Kügler
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112662/
Review request for Aleix Pol Gonzalez.
By David Gil Oliva.
*Updated Sept. 14, 2013, 10 p.m.*
Changes
This patch has been reviewed by Aleix Pol and at least partially by
David Faure, but I
staging/kemoticons/src/providers/xmpp/CMakeLists.txt
6615cf59a987389606243715ad89283a887329da
staging/kemoticons/tests/CMakeLists.txt
5e0d46ed03e23ea31dc6c1b9a74b69ec601ebbc3
Diff: http://git.reviewboard.kde.org/r/112662/diff/
Testing
---
It builds.
Thanks,
David Gil Oliva
---
It builds and installs correctly.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
-CREATION
tier3/kemoticons/tests/main.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/112907/diff/
Testing
---
It compiles, tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
---
On Sept. 23, 2013, 5:42 p.m., David Gil Oliva wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112907
fb4de8f
Diff: http://git.reviewboard.kde.org/r/112907/diff/
Testing
---
It compiles, tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/main.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/112907/diff/
Testing
---
It compiles, tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
/main.cpp
tier3/CMakeLists.txt fb4de8f
Diff: http://git.reviewboard.kde.org/r/112907/diff/
Testing
---
It compiles, tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
. I tested moving the framework to tier3 without any
compile erors.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
://git.reviewboard.kde.org/r/112984/diff/
Testing
---
It builds. It installs. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/xmpp_emoticons.cpp 0dc92ed
Diff: http://git.reviewboard.kde.org/r/112984/diff/
Testing
---
It builds. It installs. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
/xmpp_emoticons.cpp
0dc92ed092d87a559fe7fa1a40e804843ab73d59
Diff: http://git.reviewboard.kde.org/r/112985/diff/
Testing
---
It builds. It installs. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
---
It builds. It installs. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
0dc92ed092d87a559fe7fa1a40e804843ab73d59
Diff: http://git.reviewboard.kde.org/r/112985/diff/
Testing
---
It builds. It installs. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
://git.reviewboard.kde.org/r/112984/diff/
Testing
---
It builds. It installs. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
://git.reviewboard.kde.org/r/112985/#review41450
---
On Oct. 6, 2013, 9:02 p.m., David Gil Oliva wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r
Hi!
I'm getting this error from CMake while building KF5:
-- Found KF5:
/home/david/devel/kf5-development/share/ECM/find-modules/FindKF5.cmake
(found suitable version 5.0.0, minimum required is 5.0.0) found
components: CMake Compiler InstallDirs
CMake Error at
this week.
- David
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112984/#review41566
---
On Oct. 7, 2013, 10:08 p.m., David Gil Oliva
/112984/diff/
Testing
---
It builds. It installs. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
0dc92ed092d87a559fe7fa1a40e804843ab73d59
Diff: http://git.reviewboard.kde.org/r/112985/diff/
Testing
---
It builds. It installs. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
afb07b207407b00bbe0d38e0ca6d9e2bf2ccd809
Diff: http://git.reviewboard.kde.org/r/113426/diff/
Testing
---
Builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
afb07b207407b00bbe0d38e0ca6d9e2bf2ccd809
Diff: http://git.reviewboard.kde.org/r/113426/diff/
Testing
---
Builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
afb07b207407b00bbe0d38e0ca6d9e2bf2ccd809
Diff: http://git.reviewboard.kde.org/r/113426/diff/
Testing
---
Builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
/kemoticonstheme.h
25fc29453535d7e73f4e2d0752ce3f989c83fa96
Diff: http://git.reviewboard.kde.org/r/113436/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp
afb07b207407b00bbe0d38e0ca6d9e2bf2ccd809
Diff: http://git.reviewboard.kde.org/r/113426/diff/
Testing
---
Builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing
/core/kemoticons.cpp
43dac6517b77a0d0040912958fe76687b475d85c
staging/kemoticons/src/core/kemoticonstheme.h
25fc29453535d7e73f4e2d0752ce3f989c83fa96
Diff: http://git.reviewboard.kde.org/r/113436/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
://git.reviewboard.kde.org/r/114716/diff/
Testing
---
It builds.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
On Dec. 29, 2013, 12:55 a.m., David Gil Oliva wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114716/
---
(Updated
aa...@kde.org
Diffs (updated)
-
src/lib/kaboutdata.cpp 3f08f25
Diff: https://git.reviewboard.kde.org/r/114716/diff/
Testing
---
It builds.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
Hi!
I'm porting KGeography to KF5, and I found some issues.
*KConfigDialog::setHelp()*
KConfigDialog* dialog = new KConfigDialog(this, settings,
kgeographySettings::self());
dialog-setHelp(configuration, kgeography);
It gives me the following error:
aa...@kde.org
Diffs
-
src/lib/kaboutdata.cpp 3f08f25
Diff: https://git.reviewboard.kde.org/r/114716/diff/
Testing
---
It builds.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
Hi!
I have tried to build KF5 from scratch. When running ./kdesrc-build, I get
the following:
david@nimfa:~/devel/kf5-development$ ./kdesrc-build
Script started processing at Mon Jan 6 11:53:41 2014
* Downloading projects.kde.org project database...
Updating kde-build-metadata (to branch
Yes, it works.
Thanks!
David Gil
El 06/01/2014 13:49, David Faure fa...@kde.org va escriure:
On Monday 06 January 2014 12:03:26 David Gil Oliva wrote:
I have checked that
/home/david/devel/kf5-development/kde-build-metadata/dependency-data-common
doesn't exist.
Indeed; chicken and egg
---
Correct spelling, grammar and style of kcompletion.h docs
Diffs
-
src/kcompletion.h 46b63a4
Diff: https://git.reviewboard.kde.org/r/115206/diff/
Testing
---
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde
, 2014, 11:12 p.m., David Gil Oliva wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115206/
---
(Updated Jan. 21, 2014, 11:12
://git.reviewboard.kde.org/r/115206/diff/
Testing
---
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote:
src/kcompletion.h, line 501
https://git.reviewboard.kde.org/r/115206/diff/1/?file=235092#file235092line501
One sentence: This signal is emitted by makeCompletion() when a match
is found.
David Gil Oliva wrote:
Since more
marked as submitted.
Review request for KDE Frameworks.
Repository: kcompletion
Description
---
Correct spelling, grammar and style of kcompletion.h docs
Diffs
-
src/kcompletion.h 46b63a4
Diff: https://git.reviewboard.kde.org/r/115206/diff/
Testing
---
Thanks,
David Gil
generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115206/#review48374
---
On Jan. 26, 2014, 10:46 p.m., David Gil Oliva wrote:
---
This is an automatically generated e
---
Fix apidox, fix code style and delete useless includes.
Diffs
-
src/kcombobox.h f34d259
src/kcombobox.cpp 2cfe6e7
Diff: https://git.reviewboard.kde.org/r/115370/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
Hi,
Let's be pragmatic, how many times it happened to you that you actually
responded to the author alone while you actually intended to respond to the
list? It's just super annoying if you're communicating with lists like
plasma-devel which has reply-to-list and dozen more KDE MLs which also
f34d259
Diff: https://git.reviewboard.kde.org/r/115394/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/kcompletionbase.cpp 252b613
src/kcompletion.h fa0731e
src/kcombobox.h f34d259
src/CMakeLists.txt 05452ab
Diff: https://git.reviewboard.kde.org/r/115394/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel
src/kcompletion.h fa0731e
Diff: https://git.reviewboard.kde.org/r/115418/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
/kcompletionbase.cpp 252b613
src/kcompletion.h fa0731e
src/kcombobox.h f34d259
src/CMakeLists.txt 05452ab
Diff: https://git.reviewboard.kde.org/r/115394/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/115419/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
/kcompletionmatches.h PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/115419/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KCompletionPrivate declaration to kcompletion_p.h
Diffs
-
src/kcompletion.cpp 9d727f8
src/kcompletion.h fa0731e
Diff: https://git.reviewboard.kde.org/r/115418/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
ae4a656
src/kcompletion.h f197fc3
src/kcompletion.cpp c684727
src/kcompletion_p.h a8dedae
src/kcompletionmatches.h PRE-CREATION
src/kcompletionmatches.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/115419/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil
---
On Jan. 28, 2014, 10:44 p.m., David Gil Oliva wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115370
/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115419/#review48988
---
On Feb. 4, 2014, 11:08 p.m., David Gil Oliva wrote
/kcompletionmatches.h PRE-CREATION
src/kcompletionmatches.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/115419/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks
/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
src/kcombobox.cpp 2cfe6e7
Diff: https://git.reviewboard.kde.org/r/115524/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
---
Deprecate three slots (slotFoo()) that the only thing they do is call another
method (foo())
Diffs
-
src/kcompletion.h 2104f1b
Diff: https://git.reviewboard.kde.org/r/115525/diff/
Testing
---
It builds and tests pass.
Thanks,
David Gil Oliva
---
Refactor private class member variables of KCompletionBase for readability
Diffs
-
src/kcompletionbase.h 1c1f23f
src/kcompletionbase.cpp 44d05cb
Diff: https://git.reviewboard.kde.org/r/115526/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
/kcombobox.h e59d72b
src/kcombobox.cpp 2cfe6e7
Diff: https://git.reviewboard.kde.org/r/115524/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
and private slots
Diffs
-
src/klineedit.h bea787a
src/klineedit.cpp 73e91df
src/klineedit_p.h 333135c
Diff: https://git.reviewboard.kde.org/r/115610/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde
El 12/02/2014 09:46, Kevin Ottens er...@kde.org escribió:
On Tuesday 11 February 2014 23:19:39 David Faure wrote:
On Thursday 06 February 2014 23:30:25 David Faure wrote:
I have packaged up KF5 alpha 1 and uploaded it for packagers.
And alpha1 is now public !
(tarballs published,
.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
?
- David Gil Oliva
On Feb. 9, 2014, 11:07 p.m., David Gil Oliva wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115610
/#review49623
---
On Feb. 7, 2014, 12:08 a.m., David Gil Oliva wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115526
://git.reviewboard.kde.org/r/115526/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
Hide private methods and private slots behind the d-pointer in KLineEdit
Diffs
-
src/klineedit.h b9457c1
src/klineedit.cpp 24b3bf0
src/klineedit_p.h 778e43a
Diff: https://git.reviewboard.kde.org/r/115901/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil
Hi!
I've removed the build and install folders of KF5. When running
kdesrc-build, I get the following error in kde-runtime:
# kdesrc-build running: 'cmake'
'/home/david/devel/kf5-development/kde-runtime'
'-DCMAKE_CXX_FLAGS:STRING=-pipe -DQT_STRICT_ITERATORS
-DQURL_NO_CAST_FROM_STRING
---
On Feb. 12, 2014, 11:28 p.m., David Gil Oliva wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115710
Diff: https://git.reviewboard.kde.org/r/115710/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
://git.reviewboard.kde.org/r/115984/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Diff: https://git.reviewboard.kde.org/r/116062/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/khistorycombobox.cpp 6f81dda
Diff: https://git.reviewboard.kde.org/r/115710/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115984/#review50892
---
Ping?
- David Gil Oliva
On Feb. 24, 2014, 12:06 a.m
/#comment35726
I would say:
@deprecated since 5.0, use Foo instead.
- David Gil Oliva
On Feb. 25, 2014, 11:03 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
-
src/kcompletionbase.h 105a6d0
src/kcompletionbase.cpp 66f9398
Diff: https://git.reviewboard.kde.org/r/115984/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks
/kcompletionbox.cpp 571b02f
src/kcompletionmatches.h 481a4b9
src/kcompletionmatches.cpp bc381b1
Diff: https://git.reviewboard.kde.org/r/116062/diff/
Testing
---
It builds. Tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115710/#review51125
---
On Feb. 25, 2014, 10:50 p.m., David Gil Oliva wrote
: https://git.reviewboard.kde.org/r/116684/diff/
Testing
---
It compiles and (auto)tests pass without the conflicting part (to be
uncommented).
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
Hi!
2014-03-11 16:33 GMT+01:00 Kevin Ottens er...@kde.org:
Hello everyone,
This is the minutes of the Week 10 KF5 meeting. As usual it has been held
on
#kde-devel at 4pm Paris time.
Were present: afiestas, agateau, alexmerry, dfaure, mgraesslin, notmart,
sebas, teo, tosky and myself.
/kcompletionbox.h 09b7527
src/kcompletionbox.cpp 92e87b3
Diff: https://git.reviewboard.kde.org/r/116747/diff/
Testing
---
It builds and tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
El 11/03/2014 22:58, Martin Klapetek martin.klape...@gmail.com escribió:
On Tue, Mar 11, 2014 at 10:19 PM, David Gil Oliva davidgilol...@gmail.com
wrote:
Announcement:
* Beta 1 will be tagged on March 28 instead of April 1st as planned
earlier;
Why is that? Are we in a hurry? Is the work
, if it's required for some reason.
Also there's a typo in the method name.
Alex Merry inlined deprecated methods in
https://git.reviewboard.kde.org/r/116012 , so I thought that it was the way to
go...
On March 11, 2014, 11:17 p.m., David Gil Oliva wrote:
Have you looked through
, if it's required for some reason.
Also there's a typo in the method name.
David Gil Oliva wrote:
Alex Merry inlined deprecated methods in
https://git.reviewboard.kde.org/r/116012 , so I thought that it was the way
to go...
Alex Merry wrote:
Well, there's a balance
methods, since they don't seem to be able to
work as slots.
Diffs (updated)
-
src/kcompletionbox.h 09b7527
src/kcompletionbox.cpp 92e87b3
Diff: https://git.reviewboard.kde.org/r/116747/diff/
Testing
---
It builds and tests pass.
Thanks,
David Gil Oliva
, since they don't seem to be able to
work as slots.
Diffs (updated)
-
src/kcompletionbox.h 09b7527
src/kcompletionbox.cpp 92e87b3
Diff: https://git.reviewboard.kde.org/r/116747/diff/
Testing
---
It builds and tests pass.
Thanks,
David Gil Oliva
(updated)
-
src/kcompletionbase.h 1dedd2d
src/kcompletionbase.cpp 1e251d1
src/klineedit.cpp ae15093
Diff: https://git.reviewboard.kde.org/r/116684/diff/
Testing
---
It compiles and (auto)tests pass without the conflicting part (to be
uncommented).
Thanks,
David Gil Oliva
.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Diff: https://git.reviewboard.kde.org/r/116792/diff/
Testing
---
It builds and tests pass.
Thanks,
David Gil Oliva
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
1 - 100 of 243 matches
Mail list logo
