Hi David,
Am Samstag, 9. November 2013, 00:39:27 schrieb David Faure:
Hi Friedrich,
I'm looking at interfaces/khexedit in kdelibs-frameworks, and wondering what
to do with it.
Are you still happy with it? Should we bring it into the KF5 world?
If so, we need to find a place for it.
Am Samstag, 28. Dezember 2013, 12:32:43 schrieb Kevin Ottens:
On Saturday 28 December 2013 11:55:56 David Faure wrote:
On Friday 27 December 2013 19:01:09 Friedrich W. H. Kossebau wrote:
So existing code ported from kdelibs would have to explicitely prefix
the
includes, e.g. be changed
Am Sonntag, 29. Dezember 2013, 17:39:47 schrieb Kevin Ottens:
On Sunday 29 December 2013 17:11:36 Friedrich W. H. Kossebau wrote:
So possibly something more that needs to be decided on: where should
plain headers end up?
Consensus was: same place. The camel cased includes and the .h ones
Hi,
I am currently struggling to have the KF5 port of Okteta not only build
locally (what it does fine), but also on KDE's build server:
could anybody hint to me why on the build server the file KLocalizedString is
not found for include on building of the static lib kastencoretestio:
From
Am Samstag, 4. Januar 2014, 15:39:52 schrieb Martin Graesslin:
On Saturday 04 January 2014 15:04:58 Friedrich W. H. Kossebau wrote:
Hi,
I am currently struggling to have the KF5 port of Okteta not only build
locally (what it does fine), but also on KDE's build server:
could anybody
Am Donnerstag, 2. Januar 2014, 15:30:20 schrieb David Faure:
On Thursday 02 January 2014 14:06:47 Kevin Ottens wrote:
On Thursday 02 January 2014 12:25:47 David Faure wrote:
On Thursday 02 January 2014 11:35:43 David Faure wrote:
See attached patch.
I forgot to attach the
: https://git.reviewboard.kde.org/r/114988/diff/
Testing
---
Applied and run make install: CamelCase includes are installed in
[...]/include/KF5/KNewStuff3/KNS3 directory, code which #includes KNS3/*
without KDE4Support builds.
Thanks,
Friedrich W. H. Kossebau
Am Montag, 13. Januar 2014, 09:40:57 schrieb David Faure:
On Saturday 11 January 2014 02:42:20 Friedrich W. H. Kossebau wrote:
There the used namespace does not match the module name:
namespace is KNS3, the module name KNewStuff3.
That's not a problem, the KIOCore module uses namespace
/knewstuff3/knewstuffbutton.h PRE-CREATION
src/knewstuff3/uploaddialog.h PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/115005/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
#includes KNS3/*
without KDE4Support builds.
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115005/#review47371
---
On Jan. 13, 2014, 11:39 p.m., Friedrich W. H. Kossebau wrote
src/knewstuff3/entry.h PRE-CREATION
src/knewstuff3/knewstuffaction.h PRE-CREATION
src/knewstuff3/knewstuffbutton.h PRE-CREATION
src/knewstuff3/uploaddialog.h PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/115005/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics
Diffs (updated)
-
src/kuitmarkup.cpp fa76e5f
Diff: https://git.reviewboard.kde.org/r/115047/diff/
Testing
---
DrKonqi dialogs get proper links with the patch used.
Thanks,
Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/115047/diff/
Testing
---
DrKonqi dialogs get proper links with the patch used.
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
Am Mittwoch, 15. Januar 2014, 12:14:59 schrieb David Faure:
On Wednesday 15 January 2014 11:01:55 Friedrich W. H. Kossebau wrote:
Guess you already started to tackle that? :) Or should I give it a try
tonight?
Go ahead :)
Some questions while I go ahead:
1. How should own headers
autotests pass as expected.
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
dialogs get proper links with the patch used.
And all existing and new autotests pass as expected.
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
links with the patch used.
And all existing and new autotests pass as expected.
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
-include builds fine for me with all the patches.
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/includes/KParts/ListingExtension 38598f9
src/includes/KParts/LiveConnectExtension c3e9e59
src/includes/KParts/MainWindow 452e115
Diff: https://git.reviewboard.kde.org/r/115098/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
___
Kde
.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115098/#review47627
---
On Jan. 18, 2014, 3:48 a.m., Friedrich W. H. Kossebau wrote
On Jan. 18, 2014, 8:58 a.m., David Faure wrote:
Why does this remove some forwarding headers?
Friedrich W. H. Kossebau wrote:
Because they are installed from the KParts module itself already, with
the same forwarding include path. So no need to duplicate them in
KDE4Support
dabdd2f
src/includes/KParts/PartBase bcb6c5e
src/includes/KParts/PartSelectEvent dabdd2f
src/includes/KParts/ReadOnlyPart bcb6c5e
src/includes/KParts/ReadWritePart bcb6c5e
Diff: https://git.reviewboard.kde.org/r/115098/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
/includes/KParts/PartSelectEvent dabdd2f
src/includes/KParts/ReadOnlyPart bcb6c5e
src/includes/KParts/ReadWritePart bcb6c5e
Diff: https://git.reviewboard.kde.org/r/115098/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks
Hi,
I see a few overlappings between methods in KFormat (KCoreAddons) and KIO
(KIOCore), mainly this pair:
namespace KIO
{
typedef qulonglong filesize_t;
KIOCORE_EXPORT QString convertSize(KIO::filesize_t size);
}
[[Takes the binary unit dialect to use from a config file given by
Hi David, Michael, everyone,
Am Freitag, 24. Januar 2014, 09:40:00 schrieb David Faure:
On Thursday 23 January 2014 23:43:36 Friedrich W. H. Kossebau wrote:
Hi,
I see a few overlappings between methods in KFormat (KCoreAddons) and KIO
(KIOCore), mainly this pair:
namespace KIO
Am Samstag, 25. Januar 2014, 21:20:25 schrieb Michael Pyne:
On Sun, January 26, 2014 00:20:02 Friedrich W. H. Kossebau wrote:
In a Plasma Workspace I expect the bytesize parameter defaults to be
configurable, like it used to be. And any program which wants to properly
integrate
Am Freitag, 17. Februar 2012, 19:48:33 schrieb Alexander Neundorf:
Hi,
right now the common version number for libraries in kdelibs/KDE is defined
in KDE4Defaults.cmake:
# define the generic version of the libraries here
# this makes it easy to advance it when the next KDE release comes
: https://git.reviewboard.kde.org/r/120024/diff/
Testing
---
With this and the other patches, I can see no more of those warnings for
standard actions, both KWrite and Okteta.
Also all unit tests still work.
Thanks,
Friedrich W. H. Kossebau
___
Kde
::setDefaultShortcuts() invokable.
Diffs
-
src/kstandardaction.cpp a18527b
Diff: https://git.reviewboard.kde.org/r/120025/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
---
See https://git.reviewboard.kde.org/r/120024/, to be committed after that one.
Diffs
-
src/mainwindow.cpp 7e2ad9c
Diff: https://git.reviewboard.kde.org/r/120026/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks
.
Repository: kparts
Description
---
See https://git.reviewboard.kde.org/r/120024/, to be committed after that one.
Diffs
-
src/mainwindow.cpp 7e2ad9c
Diff: https://git.reviewboard.kde.org/r/120026/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/120024/ to make
KActionCollection::setDefaultShortcuts() invokable.
Diffs
-
src/kstandardaction.cpp a18527b
Diff: https://git.reviewboard.kde.org/r/120025/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks
action into
one, same branch
Needs https://git.reviewboard.kde.org/r/120024/ to make
KActionCollection::setDefaultShortcuts() invokable.
Diffs
-
src/kstandardaction.cpp a18527b
Diff: https://git.reviewboard.kde.org/r/120025/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/120025/#review65624
---
On Aug. 31, 2014, 4:40 nachm., Friedrich W. H. Kossebau wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
.
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Hi,
are there any plans to document which external resources like icons are
exactly needed by the individual framework modules?
Problem:
Imagine a developer planning to use KDE frameworks to write a program for a
platform with no proper package system, so all deps of the program need to be
://git.reviewboard.kde.org/r/121265/diff/
Testing
---
Modified is now properly marked to Off or On in the window title, when
'KMainWindow::setCaption(QString,bool)' is used. Tested with Okteta.
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122495/#review75704
---
Ship it!
Ship It!
- Friedrich W. H. Kossebau
On Feb. 9
Diff: https://git.reviewboard.kde.org/r/122579/diff/
Testing
---
All KArchive tests pass, Calligra can load the ODT files created by DokuWiki
and still other ODT files.
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122579/#review76084
---
On Feb. 16, 2015, Mitternacht, Friedrich W. H. Kossebau wrote
marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
---
Submitted with commit 9175940dc2e85f53621923a0fff253ec6f68e498 by Friedrich W.
H. Kossebau to branch master.
Repository: karchive
Description
---
Currently KZip when writing the central headers
on the current unit tests not failing and having read the code changes 4x.
Diffs
-
src/kzip.cpp 73121f3
Diff: https://git.reviewboard.kde.org/r/122682/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/
Testing
---
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit bcad4105178086b09c6b80014377fc79fdf558b2 by Friedrich W.
H. Kossebau to branch master.
Repository: kdelibs4support
Description
---
When porting code to KF5 while using kdelibs4support
Hi Volker and all,
Am Montag, 10. August 2015, 11:47:43 schrieb Volker Krause:
it turns out KF5 (and PIM, which is where I started looking into this) have
quite some unintentionally exported private symbols (2000+ for PIM and the
KF5 subset used by it, I'd not entirely trust the tool yet
Hi Alexander & all,
thanks for pushing this further.
Am Samstag, 26. September 2015, 18:41:01 schrieb Alexander Potashev:
> Hi everyone,
>
> We had a little discussion on how to name shared libraries in
> kde-core-devel@ thread "Porting to frameworks 2: libkcompactdisc" [1],
> but we did not
Hi Boudhayan,
Am Sonntag, 27. September 2015, 04:01:26 schrieb Boudhayan Gupta:
> We could kill two birds with one stone here, creating a new KDE module
> just for libraries (say, KDE Companion Libraries or something) and put
> everything in the KC5 (or whatever we decide) namespace.
>
> I'm all
Am Sonntag, 6. Dezember 2015, 23:39:13 schrieb Albert Astals Cid:
> El Sunday 06 December 2015, a les 13:56:19, Thorsten Zachmann va escriure:
> > Hello all,
> >
> > I use a separate user for running calligra. I use ssh -X to login from my
> > normal desktop user to my kde running user. However
Hi,
Am Montag, 30. Mai 2016, 19:42:38 CEST schrieb Ben Cooksley:
> As you may recall, some time ago the CI scripts were adapted to
> forcibly inject ASAN into all test processes launched on the CI system
> to fix Marble's tests, as Marble does not use ECM and thus does not
> enable ASAN as a
isit:
https://git.reviewboard.kde.org/r/128243/#review96702
---
On June 18, 2016, 8:36 p.m., Friedrich W. H. Kossebau wrote:
>
> ---
> This is an automatically generated e-mail.
uot;LC_MESSAGES=". Or is that on purpose?
Diffs
-
src/klocalizedstring.cpp fc80135
Diff: https://git.reviewboard.kde.org/r/128243/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
hout the
> > system trying to be smart.
>
> Friedrich W. H. Kossebau wrote:
> a) possibly stayed undetected as there might be no locales in real world
> which have both modifier and charset set. Still is better to have the code
> straight, less confusing for anyone who might c
Am Mittwoch, 13. Januar 2016, 00:33:36 schrieb David Faure:
> I'm about to write a class to handle favicons in a KIO library, rather than
> using DBus communication to a (currently kded, could be kiod otherwise)
> module.
>
> I think there just isn't any point in using a central DBus module to
Hi,
please remember to add some info about for which version of KF5 or ECM a new
cmake macro or argument was added (or changed behaviour).
So people with a newer version of ECM/KF5 installed on their system, but
working on a software using ECM/KF5 with lower minimal version requirements
can
Am Donnerstag, 14. Januar 2016, 09:50:05 schrieb Friedrich W. H. Kossebau:
> I am happy to fix at least KF5CoreAddonsMacros.cmake now that I came across
> it, appending the Since behind the example, if that is the current syntax?
>
> # Example:
> # kcoreaddons_add_plugin(kdecon
hout the
> > system trying to be smart.
>
> Friedrich W. H. Kossebau wrote:
> a) possibly stayed undetected as there might be no locales in real world
> which have both modifier and charset set. Still is better to have the code
> straight, less confusing for anyone who might c
hout the
> > system trying to be smart.
>
> Friedrich W. H. Kossebau wrote:
> a) possibly stayed undetected as there might be no locales in real world
> which have both modifier and charset set. Still is better to have the code
> straight, less confusing for anyone who might c
marked as submitted.
Review request for KDE Frameworks and Chusslove Illich.
Changes
---
Submitted with commit be4f8d73c3090bbb5cad8d7e590f54b7068bf6a7 by Friedrich W.
H. Kossebau to branch master.
Repository: ki18n
Description
---
This patch fixes two things:
a) `splitLocale
marked as submitted.
Review request for KDE Frameworks and Chusslove Illich.
Changes
---
Submitted with commit be4f8d73c3090bbb5cad8d7e590f54b7068bf6a7 by Friedrich W.
H. Kossebau to branch master.
Repository: ki18n
Description
---
This patch fixes two things:
a) `splitLocale
Hi,
please do not forget to also add versions to KF5 products on bugs.kde.org on
new releases.
Was there not a script provided by some good developers meanwhile to help with
that?
Right now it seems at least the 5.21.0 version misses with all KF5 products,
though some also seem to miss the
Am Samstag, 9. April 2016, 18:33:33 CEST schrieb David Faure:
> On Saturday 09 April 2016 17:04:06 Friedrich W. H. Kossebau wrote:
> > Though perhaps the versions should be added to bugs.kde.org on time or
> > even
> > before bumping the version number in the sources. B
Am Samstag, 9. April 2016, 12:09:30 CEST schrieb David Faure:
> On Friday 08 April 2016 02:10:15 Friedrich W. H. Kossebau wrote:
> > Hi,
> >
> > please do not forget to also add versions to KF5 products on bugs.kde.org
> > on new releases.
>
> I don't, it's
ved here exactly :)
- Friedrich W. H. Kossebau
On May 3, 2016, 12:39 a.m., Friedrich W. H. Kossebau wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127655/#review95002
-----------
On April 28, 2016, 1:04 a.m., Friedrich W. H. Kossebau wrote:
>
> ---
Hi David,
Am Samstag, 9. April 2016, 12:09:30 CEST schrieb David Faure:
> On Friday 08 April 2016 02:10:15 Friedrich W. H. Kossebau wrote:
> > Right now it seems at least the 5.21.0 version misses with all KF5
> > products, though some also seem to miss the version 5.20.0 (e.g.
Am Sonntag, 10. April 2016, 09:33:51 CEST schrieb David Faure:
> On Saturday 09 April 2016 19:02:02 Friedrich W. H. Kossebau wrote:
> > IIRC elsewhere I have seen people using a version called "git" in issue
> > trackers, which would be used by developers for random s
/kaboutdataapplicationdatatest.cpp PRE-CREATION
src/lib/kaboutdata.h 97c0f2b
src/lib/kaboutdata.cpp ceb0c06
Diff: https://git.reviewboard.kde.org/r/127655/diff/
Testing
---
Added autotests pass.
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127655/#review95147
---
On May 4, 2016, 2:47 p.m., Friedrich W. H. Kossebau wrote:
>
>
ard.kde.org/r/127655/#review95189
---
On May 4, 2016, 9:41 p.m., Friedrich W. H. Kossebau wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
marked as submitted.
Review request for KDE Frameworks, Alex Richardson and Michael Pyne.
Changes
---
Submitted with commit a43fc021366eeaf630902827935d697c0d1f09b1 by Friedrich W.
H. Kossebau to branch master.
Repository: kcoreaddons
Description
---
There is code in e.g. KXMLGUI
by the user. Alex, any thoughts?
>
> I agree with Michael, it seems strage it overwriting what you may have
> set in setAboutData.
>
> Friedrich W. H. Kossebau wrote:
> Hm. Would it not be more strange if one cannot be sure that
> KAboutData::applicationData().displ
)
-
autotests/kaboutdatatest.cpp f31e7f3
src/lib/kaboutdata.h 97c0f2b
src/lib/kaboutdata.cpp ceb0c06
Diff: https://git.reviewboard.kde.org/r/127655/diff/
Testing
---
Added autotests pass.
Thanks,
Friedrich W. H. Kossebau
___
Kde
.
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
, thanks for pushing this further.
- Friedrich W. H. Kossebau
On July 24, 2016, 9:14 p.m., David Faure wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
here completes the autotests, also matches that previous
patch found in Marble and still works fine in Marble, it has my "Ship it" :)
Thanks for picking this up and getting to a proper test and seemingly better
fix, Sune & David.
- Friedrich W. H. Kossebau
On July 24, 2016, 9:
-
src/kdescendantsproxymodel.cpp 477cd96
Diff: https://git.reviewboard.kde.org/r/128398/diff/
Testing
---
Existing kitemmodels unit tests still pass.
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
675e71
Diff: https://git.reviewboard.kde.org/r/128594/diff/
Testing
---
Installed the template, then created a new wallpaper plugin using kapptemplate
and following the README, then selected in wallpaper config, incl. editing the
plugin config by entering a new text.
Thanks,
Frie
a "Copy" button next to the calculated checksum label, with proper
tooltip.
That should both simplify usage and also make things more discoverable.
- Friedrich W. H. Kossebau
On July 8, 2016, 1:51 p.m., Elvis Angelaccio wrote:
>
> --
/128398/diff/
Testing
---
Existing kitemmodels unit tests still pass.
Thanks,
Friedrich W. H. Kossebau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks, Plasma and Marco Martin.
Changes
---
Submitted with commit d4f10cd67e8c4811d3a39fbd44e1f16655c9b2fc by Friedrich W.
H. Kossebau to branch master.
Repository: plasma-framework
Description
---
This template should allow people
.DisplayText || i18n("")
```
- Friedrich W. H. Kossebau
On Aug. 5, 2016, 1:56 p.m., David Edmundson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
e142552
src/plasma/data/servicetypes/plasma-dataengine.desktop 9280645
src/plasma/pluginloader.h 80cd1e9
Diff: https://git.reviewboard.kde.org/r/128616/diff/
Testing
---
Thanks,
Friedrich W. H. Kossebau
, unless you are sure it is not an issue.
- Friedrich W. H. Kossebau
On June 29, 2016, 2:37 p.m., Elvis Angelaccio wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.revi
kossebau added a comment.
messagetest for me always ran with this result:
Totals: 4 passed, 0 failed, 0 skipped, 0 blacklisted, 3603ms
Though I had to hack into KTextEditor to make it actually also call
animatedShow & animatedHide(), to test if there is any effect ;)
true ->
kossebau added a comment.
If no-one objects or has further comments, I would commit this soon after
5.31 release.
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D4130
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
kossebau updated this revision to Diff 10874.
kossebau added a comment.
rebase to latest msater, also prepare for rather KF 5.32
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4130?vs=10285=10874
BRANCH
readChangeSignalFromMetaObject
REVISION
kossebau updated this revision to Diff 10836.
kossebau marked an inline comment as done.
kossebau added a comment.
adapt to local syntax style for pointer types
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4392?vs=10818=10836
BRANCH
kossebau updated this revision to Diff 10838.
kossebau added a comment.
add a note to the "500" value in code to keep test in sync
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4329?vs=10837=10838
BRANCH
fixKMessageWidgetInstantShowHide
kossebau updated this revision to Diff 10837.
kossebau marked 5 inline comments as done.
kossebau added a comment.
updates to code style, avoid unneeded include
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4329?vs=10669=10837
BRANCH
kossebau updated this revision to Diff 10817.
kossebau added a comment.
Update to catch some more unwanted focus losts
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4392?vs=10811=10817
BRANCH
makeKListEditWidgetNotLoseFocus
REVISION DETAIL
kossebau updated this revision to Diff 10818.
kossebau added a comment.
remove QDebug include again
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4392?vs=10817=10818
BRANCH
makeKListEditWidgetNotLoseFocus
REVISION DETAIL
kossebau created this revision.
kossebau added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
When the user triggers the Add button by keyboard focus or mouse,
the button has focus when it gets disabled in the addItem() handler.
Which results in
kossebau retitled this revision from "Fix KEditListWidget losing the focus on
click of Add button" to "Fix KEditListWidget losing the focus on click of
buttons".
kossebau updated the summary for this revision.
kossebau updated the test plan for this revision.
REPOSITORY
R236 KWidgetsAddons
kossebau added a comment.
@cfeck, thanks for review so far. No(one a) further comment on this fix? Will
push on Feb 15th then unless someone objects.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D4392
EMAIL PREFERENCES
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:ec02ee4b85a4: KMessageWidget: fix behaviour on
overlapping calls of animatedShow/animatedHide (authored by kossebau).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
kossebau updated this revision to Diff 10669.
kossebau added a comment.
deduplicate unit tests
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4329?vs=10667=10669
BRANCH
fixKMessageWidgetInstantShowHide
REVISION DETAIL
1 - 100 of 1913 matches
Mail list logo