Re: Icons missing on ssh -X, or: no real system default for icon theme

Am Sonntag, 6. Dezember 2015, 23:39:13 schrieb Albert Astals Cid: > El Sunday 06 December 2015, a les 13:56:19, Thorsten Zachmann va escriure: > > Hello all, > > > > I use a separate user for running calligra. I use ssh -X to login from my > > normal desktop user to my kde running user. However wh

Re: KIOGui ?

Am Mittwoch, 13. Januar 2016, 00:33:36 schrieb David Faure: > I'm about to write a class to handle favicons in a KIO library, rather than > using DBus communication to a (currently kded, could be kiod otherwise) > module. > > I think there just isn't any point in using a central DBus module to han

Reminder: Please add "Since" version info also to cmake macros and arguments

Hi, please remember to add some info about for which version of KF5 or ECM a new cmake macro or argument was added (or changed behaviour). So people with a newer version of ECM/KF5 installed on their system, but working on a software using ECM/KF5 with lower minimal version requirements can qu

Re: Reminder: Please add "Since" version info also to cmake macros and arguments

Am Donnerstag, 14. Januar 2016, 09:50:05 schrieb Friedrich W. H. Kossebau: > I am happy to fix at least KF5CoreAddonsMacros.cmake now that I came across > it, appending the Since behind the example, if that is the current syntax? > > # Example: > # kcoreaddons_add_plugin(kdecon

Please add new versions on bugs.kde.org products on KF5 releases

Hi, please do not forget to also add versions to KF5 products on bugs.kde.org on new releases. Was there not a script provided by some good developers meanwhile to help with that? Right now it seems at least the 5.21.0 version misses with all KF5 products, though some also seem to miss the ve

Re: Please add new versions on bugs.kde.org products on KF5 releases

Am Samstag, 9. April 2016, 12:09:30 CEST schrieb David Faure: > On Friday 08 April 2016 02:10:15 Friedrich W. H. Kossebau wrote: > > Hi, > > > > please do not forget to also add versions to KF5 products on bugs.kde.org > > on new releases. > > I don't,

Re: Please add new versions on bugs.kde.org products on KF5 releases

Am Samstag, 9. April 2016, 18:33:33 CEST schrieb David Faure: > On Saturday 09 April 2016 17:04:06 Friedrich W. H. Kossebau wrote: > > Though perhaps the versions should be added to bugs.kde.org on time or > > even > > before bumping the version number in the sources. B

Review Request 127655: Fix KAboutData::applicationData() to sync to current Q*Application metadata

. Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Version 5.21.0 for ECM missing (was: Re: Please add new versions on bugs.kde.org products on KF5 releases)

Hi David, Am Samstag, 9. April 2016, 12:09:30 CEST schrieb David Faure: > On Friday 08 April 2016 02:10:15 Friedrich W. H. Kossebau wrote: > > Right now it seems at least the 5.21.0 version misses with all KF5 > > products, though some also seem to miss the version 5.20.0 (e.g.

DISCARDED: proposal for devel-versions with KF5 (was: Re: Please add new versions on bugs.kde.org products on KF5 releases)

Am Sonntag, 10. April 2016, 09:33:51 CEST schrieb David Faure: > On Saturday 09 April 2016 19:02:02 Friedrich W. H. Kossebau wrote: > > IIRC elsewhere I have seen people using a version called "git" in issue > > trackers, which would be used by developers for random s

Re: Review Request 127655: Fix KAboutData::applicationData() to sync to current Q*Application metadata

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/#review95002 --- On April 28, 2016, 1:04 a.m., Friedrich W. H. Kossebau wrote: > >

Re: Review Request 127655: Fix KAboutData::applicationData() to sync to current Q*Application metadata

already set by the user. Alex, any thoughts? > > I agree with Michael, it seems strage it overwriting what you may have > set in setAboutData. > > Friedrich W. H. Kossebau wrote: > Hm. Would it not be more strange if one cannot be sure that > KAboutData::applicat

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

) - autotests/kaboutdatatest.cpp f31e7f3 src/lib/kaboutdata.h 97c0f2b src/lib/kaboutdata.cpp ceb0c06 Diff: https://git.reviewboard.kde.org/r/127655/diff/ Testing --- Added autotests pass. Thanks, Friedrich W. H. Kossebau ___ Kde

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

ved here exactly :) - Friedrich W. H. Kossebau On May 3, 2016, 12:39 a.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

/kaboutdataapplicationdatatest.cpp PRE-CREATION src/lib/kaboutdata.h 97c0f2b src/lib/kaboutdata.cpp ceb0c06 Diff: https://git.reviewboard.kde.org/r/127655/diff/ Testing --- Added autotests pass. Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

W. H. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/#review95147 --- On May 4, 2016, 2:47 p.m., Friedrich W. H. Kossebau wrote:

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

marked as submitted. Review request for KDE Frameworks, Alex Richardson and Michael Pyne. Changes --- Submitted with commit a43fc021366eeaf630902827935d697c0d1f09b1 by Friedrich W. H. Kossebau to branch master. Repository: kcoreaddons Description --- There is code in e.g. KXMLGUI

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

---- On May 4, 2016, 9:41 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: kdelibs/interfaces/khexedit

Hi David, Am Samstag, 9. November 2013, 00:39:27 schrieb David Faure: > Hi Friedrich, > > I'm looking at interfaces/khexedit in kdelibs-frameworks, and wondering what > to do with it. > > Are you still happy with it? Should we bring it into the KF5 world? > > If so, we need to find a place for

What are the plans with CamelCase includes?

Hi, what are the plans with offering CamelCase includes in KF5 (e.g. #include )? On a quick search could not find anything mentioned somewhere. If I saw correctly, then currently CamelCase includes (for existing classes) are only available by KF5::KDE4Support, due to being the module which has

Re: What are the plans with CamelCase includes?

Am Dienstag, 24. Dezember 2013, 18:17:48 schrieb Bhushan Shah: > Hello, > > On Tue, Dec 24, 2013 at 5:59 PM, Aleix Pol wrote: > > I'll try to take some time after the 26th to do it. If somebody wants to > > do > > it meanwhile, please do and I'll review it. > > I have some spare time and want to

Re: What are the plans with CamelCase includes?

Am Samstag, 28. Dezember 2013, 12:32:43 schrieb Kevin Ottens: > On Saturday 28 December 2013 11:55:56 David Faure wrote: > > On Friday 27 December 2013 19:01:09 Friedrich W. H. Kossebau wrote: > > > So existing code ported from kdelibs would have to explicitely prefix > > &

Re: What are the plans with CamelCase includes?

Am Sonntag, 29. Dezember 2013, 17:39:47 schrieb Kevin Ottens: > On Sunday 29 December 2013 17:11:36 Friedrich W. H. Kossebau wrote: > > So possibly something more that needs to be decided on: where should > > plain headers end up? > > Consensus was: same place. The camel case

KF5 include problems on the build.kde.org?

Hi, I am currently struggling to have the KF5 port of Okteta not only build locally (what it does fine), but also on KDE's build server: could anybody hint to me why on the build server the file KLocalizedString is not found for include on building of the static lib kastencoretestio: >From http

Re: KF5 include problems on the build.kde.org?

Am Samstag, 4. Januar 2014, 15:39:52 schrieb Martin Graesslin: > On Saturday 04 January 2014 15:04:58 Friedrich W. H. Kossebau wrote: > > Hi, > > > > I am currently struggling to have the KF5 port of Okteta not only build > > locally (what it does fine), but also on KD

KNewStuff3 vs. KNS3 vs. KNewStuff (was: Re: What are the plans with CamelCase includes?)

Am Donnerstag, 2. Januar 2014, 15:30:20 schrieb David Faure: > On Thursday 02 January 2014 14:06:47 Kevin Ottens wrote: > > On Thursday 02 January 2014 12:25:47 David Faure wrote: > > > On Thursday 02 January 2014 11:35:43 David Faure wrote: > > > > See attached patch. > > > > > > I forgot to atta

Review Request 114988: Fix PREFIX parameter to ecm_generate_headers to match namespace KNS3

: https://git.reviewboard.kde.org/r/114988/diff/ Testing --- Applied and run make install: CamelCase includes are installed in [...]/include/KF5/KNewStuff3/KNS3 directory, code which #includes KNS3/* without KDE4Support builds. Thanks, Friedrich W. H. Kossebau

Re: KNewStuff3 vs. KNS3 vs. KNewStuff (was: Re: What are the plans with CamelCase includes?)

Am Montag, 13. Januar 2014, 09:40:57 schrieb David Faure: > On Saturday 11 January 2014 02:42:20 Friedrich W. H. Kossebau wrote: > > There the used namespace does not match the module name: > > namespace is "KNS3", the module name "KNewStuff3". > > That

Review Request 115005: Install forwarding headers for plain knewstuff3 headers

N src/knewstuff3/knewstuffbutton.h PRE-CREATION src/knewstuff3/uploaddialog.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115005/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-framewor

Re: Review Request 114988: Fix PREFIX parameter to ecm_generate_headers to match namespace KNS3

ry, code which #includes KNS3/* without KDE4Support builds. Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115005: Install forwarding headers for plain knewstuff3 headers

- Friedrich W. H. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115005/#review47371 --- On Jan. 13, 2014, 11:39 p.m., Friedrich W

Re: Review Request 115005: Install forwarding headers for plain knewstuff3 headers

CREATION src/knewstuff3/entry.h PRE-CREATION src/knewstuff3/knewstuffaction.h PRE-CREATION src/knewstuff3/knewstuffbutton.h PRE-CREATION src/knewstuff3/uploaddialog.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115005/diff/ Testing --- Thanks, Friedrich W. H.

Re: Review Request 114988: Fix PREFIX parameter to ecm_generate_headers to match namespace KNS3

de which #includes KNS3/* without KDE4Support builds. Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

/Localization/i18n_Semantics Diffs (updated) - src/kuitmarkup.cpp fa76e5f Diff: https://git.reviewboard.kde.org/r/115047/diff/ Testing --- DrKonqi dialogs get proper links with the patch used. Thanks, Friedrich W. H. Kossebau ___ Kde

Review Request 115047: Fix substitution order for some KUIT elements with attributes

/diff/ Testing --- DrKonqi dialogs get proper links with the patch used. Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Q: Rules on inclusion of own headers? how to provide header inclusion kde4-compat? (was: Re: Extending ecm_generate_headers to create cross-forwarding headers?)

Am Mittwoch, 15. Januar 2014, 12:14:59 schrieb David Faure: > On Wednesday 15 January 2014 11:01:55 Friedrich W. H. Kossebau wrote: > > Guess you already started to tackle that? :) Or should I give it a try > > tonight? > > Go ahead :) Some questions while I go ahead: 1. H

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

) - autotests/klocalizedstringtest.cpp 30f5bc1 src/kuitmarkup.cpp fa76e5f Diff: https://git.reviewboard.kde.org/r/115047/diff/ Testing (updated) --- DrKonqi dialogs get proper links with the patch used. And all existing and new autotests pass as expected. Thanks, Friedrich W. H

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

://git.reviewboard.kde.org/r/115047/diff/ Testing --- DrKonqi dialogs get proper links with the patch used. And all existing and new autotests pass as expected. Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

patch used. And all existing and new autotests pass as expected. Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

existing and new autotests pass as expected. Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115097: KParts: Move each class into its own header/source file pair

TION src/browserinterface.h cf10499 Diff: https://git.reviewboard.kde.org/r/115097/diff/ Testing --- kdesrc-build/kf5-qt5-build-include builds fine for me with all the patches. Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mai

Review Request 115098: Adapt KParts compat-forwarding headers to new one-header-per-class policy in KParts

/includes/KParts/ListingExtension 38598f9 src/includes/KParts/LiveConnectExtension c3e9e59 src/includes/KParts/MainWindow 452e115 Diff: https://git.reviewboard.kde.org/r/115098/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde

Re: Review Request 115098: Adapt KParts compat-forwarding headers to new one-header-per-class policy in KParts

'>', but a relative link seems safer to me) - Friedrich W. H. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115098/#review47627 -------------

Re: Review Request 115098: Adapt KParts compat-forwarding headers to new one-header-per-class policy in KParts

> On Jan. 18, 2014, 8:58 a.m., David Faure wrote: > > Why does this remove some forwarding headers? > > Friedrich W. H. Kossebau wrote: > Because they are installed from the KParts module itself already, with > the same forwarding include path. So no need

Re: Review Request 115098: Adapt KParts compat-forwarding headers to new one-header-per-class policy in KParts

dabdd2f src/includes/KParts/PartBase bcb6c5e src/includes/KParts/PartSelectEvent dabdd2f src/includes/KParts/ReadOnlyPart bcb6c5e src/includes/KParts/ReadWritePart bcb6c5e Diff: https://git.reviewboard.kde.org/r/115098/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: Review Request 115097: KParts: Move each class into its own header/source file pair

erextension.cpp a367de9 src/browserhostextension.h PRE-CREATION src/browserhostextension.cpp PRE-CREATION src/browserinterface.h cf10499 Diff: https://git.reviewboard.kde.org/r/115097/diff/ Testing --- kdesrc-build/kf5-qt5-build-include builds fine for me with all the patches. Tha

Re: Review Request 115098: Adapt KParts compat-forwarding headers to new one-header-per-class policy in KParts

/includes/KParts/PartSelectEvent dabdd2f src/includes/KParts/ReadOnlyPart bcb6c5e src/includes/KParts/ReadWritePart bcb6c5e Diff: https://git.reviewboard.kde.org/r/115098/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks

KIO::convertSize(.,.) vs. KFormat::formatByteSize(...)

Hi, I see a few overlappings between methods in KFormat (KCoreAddons) and KIO (KIOCore), mainly this pair: namespace KIO { typedef qulonglong filesize_t; KIOCORE_EXPORT QString convertSize(KIO::filesize_t size); } [[Takes the binary unit dialect to use from a config file given by QStandardPath

Re: KIO::convertSize(.,.) vs. KFormat::formatByteSize(...)

Hi David, Michael, everyone, Am Freitag, 24. Januar 2014, 09:40:00 schrieb David Faure: > On Thursday 23 January 2014 23:43:36 Friedrich W. H. Kossebau wrote: > > Hi, > > > > I see a few overlappings between methods in KFormat (KCoreAddons) and KIO > >

Re: KIO::convertSize(.,.) vs. KFormat::formatByteSize(...)

Am Samstag, 25. Januar 2014, 21:20:25 schrieb Michael Pyne: > On Sun, January 26, 2014 00:20:02 Friedrich W. H. Kossebau wrote: > > In a Plasma Workspace I expect the bytesize parameter defaults to be > > configurable, like it used to be. And any program which wants to properly >

Re: Which package will provide the common KDE library version number ?

Am Freitag, 17. Februar 2012, 19:48:33 schrieb Alexander Neundorf: > Hi, > > right now the common version number for libraries in kdelibs/KDE is defined > in KDE4Defaults.cmake: > > # define the generic version of the libraries here > # this makes it easy to advance it when the next KDE release c

Re: RFC: a replacement for KPluginLoader

Am Samstag, 4. Mai 2013, 17:06:21 schrieb David Faure: > About KPluginFactory: registerPlugin is always used, it's the only way to > declare your plugin class to the macro. The reason for that strange api > though, was to be able to have multiple classes in one plugin, identified by > a keyword (=

Review Request 120024: Prevent some false positive critical warnings for KStandardActions

: https://git.reviewboard.kde.org/r/120024/diff/ Testing --- With this and the other patches, I can see no more of those warnings for standard actions, both KWrite and Okteta. Also all unit tests still work. Thanks, Friedrich W. H. Kossebau ___ Kde

Review Request 120025: Have KStandardAction::create(...) call KActionCollection::setDefaultShortcuts()

4/ to make KActionCollection::setDefaultShortcuts() invokable. Diffs - src/kstandardaction.cpp a18527b Diff: https://git.reviewboard.kde.org/r/120025/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-framew

Review Request 120026: Pass KActionCollection to KHelpMenu for KParts::MainWindow

--- See https://git.reviewboard.kde.org/r/120024/, to be committed after that one. Diffs - src/mainwindow.cpp 7e2ad9c Diff: https://git.reviewboard.kde.org/r/120026/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks

Re: Review Request 120026: Pass KActionCollection to KHelpMenu for KParts::MainWindow

. Repository: kparts Description --- See https://git.reviewboard.kde.org/r/120024/, to be committed after that one. Diffs - src/mainwindow.cpp 7e2ad9c Diff: https://git.reviewboard.kde.org/r/120026/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: Review Request 120025: Have KStandardAction::create(...) call KActionCollection::setDefaultShortcuts()

eeds https://git.reviewboard.kde.org/r/120024/ to make KActionCollection::setDefaultShortcuts() invokable. Diffs - src/kstandardaction.cpp a18527b Diff: https://git.reviewboard.kde.org/r/120025/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-

Re: Review Request 120025: Have KStandardAction::create(...) call KActionCollection::setDefaultShortcuts()

a created action into one, same branch Needs https://git.reviewboard.kde.org/r/120024/ to make KActionCollection::setDefaultShortcuts() invokable. Diffs - src/kstandardaction.cpp a18527b Diff: https://git.reviewboard.kde.org/r/120025/diff/ Testing --- Thanks, Friedrich W. H

Re: Review Request 120025: Have KStandardAction::create(...) call KActionCollection::setDefaultShortcuts()

ctively I would say No to that, but perhaps others are more pragmatic and do not do byte-counting? - Friedrich W. H. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120025/#review65624 --

Re: Review Request 120025: Have KStandardAction::create(...) call KActionCollection::setDefaultShortcuts()

Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120024: Prevent some false positive critical warnings for KStandardActions

. Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120026: Pass KActionCollection to KHelpMenu for KParts::MainWindow

, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Detailed dependencies of frameworks on external resources like icons

Hi, are there any plans to document which external resources like icons are exactly needed by the individual framework modules? Problem: Imagine a developer planning to use KDE frameworks to write a program for a platform with no proper package system, so all deps of the program need to be co-

Review Request 121265: Make modified flag work for KMainWindow::setCaption(QString, bool)

r perhaps can even integrate better into the platform (not sure if there is a hook yet). Diffs - src/kmainwindow.cpp 9562318 Diff: https://git.reviewboard.kde.org/r/121265/diff/ Testing --- Modified is now properly marked to Off or On in the window title, when 'KMainWindow::setC

Re: Review Request 122495: CMake nitpicking on KDiagram

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122495/#review75704 --- Ship it! Ship It! - Friedrich W. H. Kossebau On Feb. 9

Review Request 122579: Stop failing on ZIP files with redundant data descriptors

ng --- All KArchive tests pass, Calligra can load the ODT files created by DokuWiki and still other ODT files. Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122579: Stop failing on ZIP files with redundant data descriptors

st.cpp 4dc016e src/kzip.cpp fd9a5e0 Diff: https://git.reviewboard.kde.org/r/122579/diff/ Testing --- All KArchive tests pass, Calligra can load the ODT files created by DokuWiki and still other ODT files. Thanks, Friedrich W. H. Kossebau __

Re: Review Request 122579: Stop failing on ZIP files with redundant data descriptors

ommit, if this patch is okay-ed. - Friedrich W. H. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122579/#review76084 ----------- On Feb. 16

Re: Review Request 122579: Stop failing on ZIP files with redundant data descriptors

st.cpp 4dc016e src/kzip.cpp fd9a5e0 Diff: https://git.reviewboard.kde.org/r/122579/diff/ Testing --- All KArchive tests pass, Calligra can load the ODT files created by DokuWiki and still other ODT files. Thanks, Friedrich W. H. Kossebau __

Review Request 122682: Respect KZip::extraField setting also when writing central header entries

current unit tests not failing and having read the code changes 4x. Diffs - src/kzip.cpp 73121f3 Diff: https://git.reviewboard.kde.org/r/122682/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list

Re: Review Request 122682: Respect KZip::extraField setting also when writing central header entries

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 9175940dc2e85f53621923a0fff253ec6f68e498 by Friedrich W. H. Kossebau to branch master. Repository: karchive Description --- Currently KZip when writing the central headers

Re: Review Request 121265: Make modified flag work for KMainWindow::setCaption(QString, bool)

ied is now properly marked to Off or On in the window title, when 'KMainWindow::setCaption(QString,bool)' is used. Tested with Okteta. Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 124101: Reenable support for KDateTime streaming to kDebug/qDebug, for more SC

kde.org/r/124101/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124101: Reenable support for KDateTime streaming to kDebug/qDebug, for more SC

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit bcad4105178086b09c6b80014377fc79fdf558b2 by Friedrich W. H. Kossebau to branch master. Repository: kdelibs4support Description --- When porting code to KF5 while using kdelibs4support

Re: Accidentally exported private classes

Hi Volker and all, Am Montag, 10. August 2015, 11:47:43 schrieb Volker Krause: > it turns out KF5 (and PIM, which is where I started looking into this) have > quite some unintentionally exported private symbols (2000+ for PIM and the > KF5 subset used by it, I'd not entirely trust the tool yet tho

Re: Naming scheme for Qt5/KF5-based libraries outside of KF5

Hi Alexander & all, thanks for pushing this further. Am Samstag, 26. September 2015, 18:41:01 schrieb Alexander Potashev: > Hi everyone, > > We had a little discussion on how to name shared libraries in > kde-core-devel@ thread "Porting to frameworks 2: libkcompactdisc" [1], > but we did not com

Re: Naming scheme for Qt5/KF5-based libraries outside of KF5

Hi Boudhayan, Am Sonntag, 27. September 2015, 04:01:26 schrieb Boudhayan Gupta: > We could kill two birds with one stone here, creating a new KDE module > just for libraries (say, KDE Companion Libraries or something) and put > everything in the KC5 (or whatever we decide) namespace. > > I'm all

Re: The return of ASAN issues

Hi, Am Montag, 30. Mai 2016, 19:42:38 CEST schrieb Ben Cooksley: > As you may recall, some time ago the CI scripts were adapted to > forcibly inject ASAN into all test processes launched on the CI system > to fix Marble's tests, as Marble does not use ECM and thus does not > enable ASAN as a resul

Review Request 128243: Fix parsing of env vars in KLocalizedStringPrivateStatics::initializeLocaleLanguages()

uot;LC_MESSAGES=". Or is that on purpose? Diffs - src/klocalizedstring.cpp fc80135 Diff: https://git.reviewboard.kde.org/r/128243/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128243: Fix parsing of env vars in KLocalizedStringPrivateStatics::initializeLocaleLanguages()

rated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128243/#review96702 --- On June 18, 2016, 8:36 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automa

Re: Review Request 128243: Fix parsing of env vars in KLocalizedStringPrivateStatics::initializeLocaleLanguages()

he > > system trying to be smart. > > Friedrich W. H. Kossebau wrote: > a) possibly stayed undetected as there might be no locales in real world > which have both modifier and charset set. Still is better to have the code > straight, less confusing for anyone who might c

Re: Review Request 128243: Fix parsing of env vars in KLocalizedStringPrivateStatics::initializeLocaleLanguages()

he > > system trying to be smart. > > Friedrich W. H. Kossebau wrote: > a) possibly stayed undetected as there might be no locales in real world > which have both modifier and charset set. Still is better to have the code > straight, less confusing for anyone who might c

Re: Review Request 128243: Fix parsing of env vars in KLocalizedStringPrivateStatics::initializeLocaleLanguages()

he > > system trying to be smart. > > Friedrich W. H. Kossebau wrote: > a) possibly stayed undetected as there might be no locales in real world > which have both modifier and charset set. Still is better to have the code > straight, less confusing for anyone who might c

Re: Review Request 128243: Fix parsing of env vars in KLocalizedStringPrivateStatics::initializeLocaleLanguages()

marked as submitted. Review request for KDE Frameworks and Chusslove Illich. Changes --- Submitted with commit be4f8d73c3090bbb5cad8d7e590f54b7068bf6a7 by Friedrich W. H. Kossebau to branch master. Repository: ki18n Description --- This patch fixes two things: a) `splitLocale

Re: Review Request 128243: Fix parsing of env vars in KLocalizedStringPrivateStatics::initializeLocaleLanguages()

marked as submitted. Review request for KDE Frameworks and Chusslove Illich. Changes --- Submitted with commit be4f8d73c3090bbb5cad8d7e590f54b7068bf6a7 by Friedrich W. H. Kossebau to branch master. Repository: ki18n Description --- This patch fixes two things: a) `splitLocale

Re: Review Request 128283: Add checksums tab to the properties dialog

less you are sure it is not an issue. - Friedrich W. H. Kossebau On June 29, 2016, 2:37 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

/128398/diff/ Testing --- Existing kitemmodels unit tests still pass. Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128283: Add checksums tab to the properties dialog

quot;Copy" button next to the calculated checksum label, with proper tooltip. That should both simplify usage and also make things more discoverable. - Friedrich W. H. Kossebau On July 8, 2016, 1:51 p.m., Elvis Angelaccio wrote: > > --

Re: Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

, thanks for pushing this further. - Friedrich W. H. Kossebau On July 24, 2016, 9:14 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

here completes the autotests, also matches that previous patch found in Marble and still works fine in Marble, it has my "Ship it" :) Thanks for picking this up and getting to a proper test and seemingly better fix, Sune & David. - Friedrich W. H. Kossebau On July 24, 2016, 9:

Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

- src/kdescendantsproxymodel.cpp 477cd96 Diff: https://git.reviewboard.kde.org/r/128398/diff/ Testing --- Existing kitemmodels unit tests still pass. Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 128594: Add a kapptemplate for Plasma Wallpaper

675e71 Diff: https://git.reviewboard.kde.org/r/128594/diff/ Testing --- Installed the template, then created a new wallpaper plugin using kapptemplate and following the README, then selected in wallpaper config, incl. editing the plugin config by entering a new text. Thanks, Frie

Re: Review Request 128594: Add a kapptemplate for Plasma Wallpaper

marked as submitted. Review request for KDE Frameworks, Plasma and Marco Martin. Changes --- Submitted with commit d4f10cd67e8c4811d3a39fbd44e1f16655c9b2fc by Friedrich W. H. Kossebau to branch master. Repository: plasma-framework Description --- This template should allow people to

Re: Review Request 128612: Add translation domain to wallpaper QML object

.DisplayText || i18n("") ``` - Friedrich W. H. Kossebau On Aug. 5, 2016, 1:56 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Review Request 128616: Fix wrong or missing "X-KDE-ParentApp" in desktop file definitions (and fix copy&paste errors in API dox)

et.desktop e142552 src/plasma/data/servicetypes/plasma-dataengine.desktop 9280645 src/plasma/pluginloader.h 80cd1e9 Diff: https://git.reviewboard.kde.org/r/128616/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: Review Request 128616: Fix wrong or missing "X-KDE-ParentApp" in desktop file definitions (and fix copy&paste errors in API dox)

marked as submitted. Review request for KDE Frameworks, Plasma and Marco Martin. Changes --- Submitted with commit 4bf1ef7ea6b30a37170ded7bdb3ac826b87a9b94 by Friedrich W. H. Kossebau to branch master. Repository: plasma-framework Description --- plasma-dataengine.desktop misses at

Re: Review Request 128616: Fix wrong or missing "X-KDE-ParentApp" in desktop file definitions (and fix copy&paste errors in API dox)

marked as submitted. Review request for KDE Frameworks, Plasma and Marco Martin. Changes --- Submitted with commit 4bf1ef7ea6b30a37170ded7bdb3ac826b87a9b94 by Friedrich W. H. Kossebau to branch master. Repository: plasma-framework Description --- plasma-dataengine.desktop misses at

Re: Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation

report? Thanks. And perhaps add a comment to this code block in ki18n about it's fragile state :) - Friedrich W. H. Kossebau On March 8, 2016, 11:34 a.m., Andre Heinecke wrote: > > --- > This is an automatica

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Oct. 15, 2016, 4:05 p.m., David Faure wrote: > > src/k7zip.cpp, line 2343 > > > > > > QObject::tr() is bad practice in Qt code (the context class name is > > then "QObject" instead of e.g. K7Zip). > >

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po") ecm_install_po_files_as_qm(po) endif() ``` - Friedrich W. H. Kossebau On Oct. 15, 2016, 3:08 a.m., Romário Rios wrote: > > --- > This is an automatically generated e-m

  1   2   3   4   5   6   7   8   9   10   >