D27504: smb faster copy to local

mmustac added a comment. Those look very lovely. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham, cfeck, #frameworks, #dolphin Cc: mmustac, meven, hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, nikolaik, pberesto

D11569: Improve consistency of "Open With" UI by always showing top app inline

mmustac added a comment. I have two questions regarding this "open with" topic. Is the displayed app the one which is also set as default for this file type or the first alternative (2nd app) ? If it's the default one why should someone make a right click on a file to open it with his/her d

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

mmustac added a comment. Great, I even didn't know that this was possible *lol* But wouldn't it be more consistent with dolphin to add the list view also ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks Cc: mmustac, broulik, michaelh, ng

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac marked an inline comment as done. mmustac added a comment. No problem David, it's okay :) I will work on your suggestions and update this revision accordingly. > But actually, shouldn't we still have New Folder and New Text File at the top before everything else? Kai mentio

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac updated this revision to Diff 35173. mmustac added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Updated to the latest comments. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10363?vs=26753&id=35173 REVISION DETAIL http

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac marked 5 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10363 To: mmustac, #frameworks, dfaure Cc: kde-frameworks-devel, broulik, ngraham, michaelh, bruns

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac added a comment. @dfaure Can you commit these changes as I don't have the access to ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10363 To: mmustac, #frameworks, dfaure Cc: kde-frameworks-devel, broulik, ngraham, michaelh, bruns

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac added a comment. I would not close the bug yet. Unfortunately I am busy at the moment so I can't tell you when I will find to take a deeper look at the main problem from the bug: Although we have support for the template directory now, it is still very difficult to display your own

D20735: [KPropertiesDialog] Add octal permissions

mmustac added a comment. We could also make the permissions interactive and explaining at the same time. I could imagine something like this: F6790404: permissions.png REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20735 To: s

D20693: Remove pixelated border

mmustac added a comment. @ngraham: Fo sure, I will add my post from the forum here for better reference. > Today I thougtht about the design of the "Get new Hot Stuff" dialog. I think there is some room for improvements and to get a better overview. > I tried to put my thought into a

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

mmustac added a comment. Does this patch then also affects the speed of the copy operation? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D9840 To: jtamate, #frameworks Cc: mmustac

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac created this revision. mmustac added a reviewer: Frameworks. Restricted Application added a project: Frameworks. mmustac requested review of this revision. REVISION SUMMARY This patch adds the support for templates in the XDG_TEMPLATES_DIR location which points in default to: [en] /ho

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10363 To: mmustac, #frameworks Cc: michaelh, ngraham

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac added a comment. @broulik Thanks :-) My idea was to add a submenu "own templates" to the menu but this would greatly exceed my knowledge. At the moment this is more try, error and debgugging, learning by doing ^^ Will try to improve this match further. REPOSITORY R241 KIO REVI

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac added a comment. @dfaure Thank you for your answer :-) As I am still at the beginnings I am really grateful for such constructive and valuable feedback like yours it helps me to become better and improve my code. Regarding your points: First of all I agree that a nice name is

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac updated this revision to Diff 26753. mmustac added a comment. Addressed the mentioned issues. F5698366: Screenshot_20180208_103832.png REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10363?vs=26702&id=26753 REVI

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac marked 6 inline comments as done. mmustac added inline comments. INLINE COMMENTS > dfaure wrote in knewfilemenu.cpp:904 > the 2nd arg isn't necessary, just do line.mid(19) It is because we need to get rid of the " before and at the end of the path. REPOSITORY R241 KIO REVISION DETAIL

D10365: New icon for Elisa music player

mmustac added a comment. Old-school rules! Also just think of the floppy 💾 disk icon which is mostly everywhere the save icon. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10365 To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien Cc: m

D10494: update handle- icons for kirigami

mmustac added a comment. I agree with Andreas and think that the new icon is a huge improvement. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: mmustac, ngraham, #frameworks, michaelh

D10508: [KStandardAction] Add additional icons to menus

mmustac created this revision. mmustac added reviewers: Frameworks, ngraham. Restricted Application added a project: Frameworks. mmustac requested review of this revision. REVISION SUMMARY I added also here the icons for the "replace" and "deselect" action. REPOSITORY R265 KConfigWidgets REV

D10508: Add icons for KStandardActions Deselect and Replace

mmustac retitled this revision from "[KStandardAction] Add additional icons to menus" to "Add icons for KStandardActions Deselect and Replace". REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10508 To: mmustac, #frameworks, ngraham Cc: michaelh

D10508: Add icons for KStandardActions Deselect and Replace

mmustac added a comment. I can't access the link at the moment but changed the title according ;) And kate picks up this change automatically because they relay on this framework already or did I get you wrong? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/

D10509: Add icons for KTextEditor Document-Export, Bookmark-Remove and Formatting Text Upppercase, Lowercase and Capitalize

mmustac created this revision. mmustac added reviewers: KTextEditor, ngraham. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. mmustac requested review of this revision. REVISION SUMMARY This patch adds some more icons to the menus.

D10508: Add icons for KStandardActions Deselect and Replace

mmustac edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10508 To: mmustac, #frameworks, ngraham Cc: michaelh

D22884: [RFC] Don't show title on page by default

mmustac added a comment. I agree that it looks quite strange or at least unusual to me. Find myself always sliding to the left do regonize which topic is selected currently it seems not self explaining and I would miss the header. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://