Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

://git.reviewboard.kde.org/r/120139 - Sune Vuorela On Jan. 2, 2016, 7:24 p.m., Pino Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 120139: kill warning

/kwidgetitemdelegatepool.cpp d61802e Diff: https://git.reviewboard.kde.org/r/120139/diff/ Testing --- Warning not printed. Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 115496: Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers

more than a week? - Sune Vuorela On Feb. 18, 2014, 3:26 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

KPassivePopup should be in kwidgets ?

Hi I was just looking at knotification, and for some reason, KPassivePopup is ended up here. I was quite surprised to see it there, as it is used for 'popping up stuff' all over the place, and isn't really notification specific. Shouldn't it rather be in kwidgets? /Sune - hoping for a widgets f

Re: Review Request 112560: Remove KNotification dependency in KCompletion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112560/#review39651 --- Ship it! Ship It! - Sune Vuorela On Sept. 6, 2013, 3:04

Re: Splitting out a KX11Extras frameworks from KWindowSystems

On 2013-09-16, Martin Graesslin wrote: > The KWindowSystems framework would need to become a tier2 framework and as > it needs to depend on NETwm (X11 implementation uses it and the defines are > used). It would contain: > * KKeyServer > * KWindowEffects (this could also stay in X11Extras) > * K

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

ttp://git.reviewboard.kde.org/r/112816/#comment29951> My initial reaction is that it could return a bool wether or not things went okay, given there is a 'path that does nothing' in the code. Besides that, everything looks great. - Sune Vuorela On Sept. 24, 2013, 2:19 p.m., Aurél

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

> On Sept. 24, 2013, 2:23 p.m., Sune Vuorela wrote: > > tier1/kguiaddons/src/lib/colors/kcolorutils.cpp, line 42 > > <http://git.reviewboard.kde.org/r/112816/diff/1/?file=190519#file190519line42> > > > > My initial reaction is that it could return a bool we

Re: Making KDocTools independent of KArchive

> Maybe we can bundle the generated documentation? Distributions in general don't want pregenerated . /Sune ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KIOWidgets and KFile

On 2013-09-29, David Faure wrote: > Help :) maybe KIOBookmarks should just be merged into KIOFileWidgets ? /Sune ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

#x27; for people to do 'bad things' that wasn't possible in the past. I'm not sure we want that. - Sune Vuorela On Oct. 11, 2013, 5:59 p.m., Mark Gaiser wrote: > > --- > This is an automatica

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

On Oct. 11, 2013, 9:51 p.m., Mark Gaiser wrote: > > We are here making a 'hole' for people to do 'bad things' that wasn't > > possible in the past. I'm not sure we want that. > > Mark Gaiser wrote: > Interesting. > So that mean we simply can't use the new signal/slot syntax because of

Flaky kcodecs test depending on qt configuration

Hi Depending on the Qt configuration (built with or without ICU), the KCharsetsTest::testEncodingNames() test fails (in the #if) block. If Qt built with ICU, the tests succeeds and the ISO 8859-16, jis7 and winsami2 codecs are as expected not found. If Qt is built without ICU, those codecs are

KDirWatch vs QFileSystemWatcher

Hi If your KDirWatch backend is QFileSystemWatcher, one of the testcases fails. The last QVERIFY in testMoveTo never receives the signal dirty-signal it is looking for. Apparantly, the watch.removeFile apparantly somehow turns off the QFSW to not do any further notifications for what happens in

Re: Google Code-In

On 2013-10-25, Kevin Ottens wrote: > I got contacted by Lydia because the Google Code-In will soon start and= > we=20 > could maybe give out tasks to people. I think that's a good idea, and o= > ne area=20 > is "port kdeexamples to KF5". If we split it per example in the repo, i= > t makes=20 > f

Re: KDirWatch vs QFileSystemWatcher

On 2013-10-27, David Faure wrote: >> testMoveTo passes most of the time (finally got a failure after 10 runs or >> so)... > > Fixed as well (9c6cc615676a5bb) (not a real bug, a unittest bug). > 4: QDEBUG : KDirWatch_UnitTest::testMoveTo() Added Dir "C:/Users/Administrator/A ppData/Local/Temp/2/kd

Re: KDirWatch vs QFileSystemWatcher

On 2013-10-28, David Faure wrote: > On Sunday 27 October 2013 22:02:18 Sune Vuorela wrote: >> Seems to still consistently failing here on windows :/ > > Good, consistency is good, we can debug that :) > > Can you apply this patch and try again, so I get more d

Re: Google Code-In

On 2013-10-25, Kevin Ottens wrote: > Excellent! Could you get in touch with Lydia about it? I'd rather have = > a=20 > support role, but we need someone to keep track of things and you seem = > like a=20 > good candidate. :-) >=20 I've scrolled over kdeexamples and added 4 tasks. Ensure kdeexamp

Re: Use of the WIN32 executable property

On 2013-10-27, David Faure wrote: > I withdraw my objection then, I guess. Let them have a console, for easier > debugging. \o/ Let's get all windows test apps to get a console. /Sune ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.or

Re: Review Request 113479: fix kshareddatacache on windows

hanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113479: fix kshareddatacache on windows

org/r/113479/diff/ Testing --- Test suite passes Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113497: Install kiofilewidgets_export.h in /kio

, shipit. - Sune Vuorela On Oct. 29, 2013, 12:24 p.m., Aurélien Gâteau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 113483: Copy KDE4 macro to install all icons in the current source dir

On 2013-10-29, Alexander Neundorf wrote: > Good point. > As it is, IMO for being "ECM", it needs way more documentation. > It needs to be documented so that it can be used by people who know nothing > about KDE or KDE's icon scheme. > > Or should that be in the framework which deals with icon loa

Review Request 113503: make dbus dependency optional in JobWidgets

575a6 tier2/kjobwidgets/src/config-kjobwidgets.h.cmake 35b64a2 tier2/kjobwidgets/tests/kjobtrackerstest.cpp 7a61407 Diff: http://git.reviewboard.kde.org/r/113503/diff/ Testing --- build tested on windows without dbus. not yet tested on other platforms Thanks, Sune Vu

Re: Review Request 113503: make dbus dependency optional in JobWidgets

files are properly added, always returns false, so doesn't build with dbus. needs fixing - Sune Vuorela On Oct. 29, 2013, 10:27 p.m., Sune Vuorela wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 113503: make dbus dependency optional in JobWidgets

ed on windows without dbus. not yet tested on other platforms Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Flaky kcodecs test depending on qt configuration

On 2013-11-01, David Faure wrote: > On Wednesday 23 October 2013 21:43:59 Sune Vuorela wrote: >> Hi >> >> Depending on the Qt configuration (built with or without ICU), the >> KCharsetsTest::testEncodingNames() test fails (in the #if) block. >> >> If Qt

Re: Getting ecm files from the ECM package

On 2013-11-01, Mirko Boehm wrote: > and so forth. That would be a real breakthrough. It is related to the > approach taken by Maven and others. All it takes is a built-in way for CMake > to download the find_modules into a cache location and update them when > needed, or on request. > > This w

Re: Getting ecm files from the ECM package

On 2013-11-01, Kevin Ottens wrote: > So far we chose the "have it in cmake/ecm" route. If we had what Mirko = > refers=20 > to, then that'd open the door to another solution. And it would open the first door towards alienating linux distributions. Of course, we could say "and so what?". But that

Re: Getting ecm files from the ECM package

On 2013-11-01, Mirko Boehm wrote: > Anyone up for hacking this up next week? I am available starting Monday > afternoon. Before you start hacking, please consider the following: http vs https? should http even be allowed? certificate handling? how to do ssl? a library? will cmake accept a

Re: Getting ecm files from the ECM package

On 2013-11-01, Alexander Neundorf wrote: > Anyway, attached is a quick experiment, which adds the 3 KDE*.cmake files= > from=20 > extra-cmake-modules/ to kf5umbrella/, by that turning it into tier0/, wit= > h the=20 > optional ability (-DWITH_ECM) to download ECM and install ECM when buildi= > ng

Re: Getting ecm files from the ECM package

On 2013-11-01, Mirko Boehm wrote: > To me, "build systems should not download anything" sounds like a movie > from the 80ies. To me, "build systems fetches code and executes it" sounds like a bad horror movie. > For example, from a developers point of view, what is the difference between > me

Re: Getting ecm files from the ECM package

On 2013-11-03, Alexander Neundorf wrote: > This code unconditionally searches for QtCore (and sets a target property > where I'm not sure how many people here can understand what's going on). It is hopefully a temporary hack that shouldn't be in that file. Sometimes, temporary hacks in developm

Re: Exceptions in KDE Frameworks

On 2013-11-02, Mirko Boehm wrote: > I get from that that I can enable exceptions for threadweaver without > affecting the other libraries. This makes my job a lot easier. note though that most of Qt isn't really compatiple with exceptions. see also long threads on qt-dev list. /Sune __

Re: Having a Tier 0 for cmake and git submodules

On 2013-11-10, Kevin Ottens wrote: > Since there's been several times discussions about having a kind of "Ti= > er 0"=20 > for building our frameworks containing what is right now in ECM kde-mod= > ules=20 > directory, but the idea was never really on the table because of the ex= > tra=20 > depend

Re: Having a Tier 0 for cmake and git submodules

HTjbs > Content-Transfer-Encoding: quoted-printable > Content-Type: text/plain; charset="iso-8859-1" > > On Sunday 10 November 2013 17:12:02 Sune Vuorela wrote: >> Why move it out of e-c-m ? > > To make e-c-m a neutral ground again, not something purely for KDE need= >

Review Request 113805: Do not change the build types available with cmake

, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113805: Do not change the build types available with cmake

ls to hack on stuff. 2) IF we want to add such things, it should be in a "ECMAddProfileBuildType" or similar. 3) For the other compilers, the build types aren't touched. ANd note that this doesn't modify the flags that covers everything. That I'm saving f

Re: Getting ecm files from the ECM package

On 2013-11-11, Aaron J. Seigo wrote: > would that work for everyone? I don't think it solves the actual hard point: Where should the final home for the stuff in ecm/kde-modules be ? I'll like to reiterate what I suggested should happen with it: KDEInstallDirs.cmake : Keep it as is, just like

Re: Review Request 113805: Do not change the build types available with cmake

t; >set(SOME_CXX_FLAGS_ALREADY_PRESET TRUE CACHE BOOL "docs..." ) > > set(SOME_CXX_FLAGS "--some-flag --another-flag" CACHE STRING "docs..." > > FORCE) > > endif() > > > > This way it would be only on the initial cmake run forc

Re: Review Request 113805: Do not change the build types available with cmake

t; >set(SOME_CXX_FLAGS_ALREADY_PRESET TRUE CACHE BOOL "docs..." ) > > set(SOME_CXX_FLAGS "--some-flag --another-flag" CACHE STRING "docs..." > > FORCE) > > endif() > > > > This way it would be only on the initial cmake run forc

Re: Review Request 113503: make dbus dependency optional in JobWidgets

ndows without dbus. not yet tested on other platforms Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113805: Do not change the build types available with cmake

://git.reviewboard.kde.org/r/113805/diff/ Testing --- Built kdelibs on linux with gcc. Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Which package will provide the common KDE library version number ?

On 2012-02-17, Alexander Neundorf wrote: > Do we still want a such a common version number ? > If yes, who (which file/package) should define it ? No. It basically doesn't make sense. Also not in its current usage. if I e.g. take a kdepimlibs 4.3 and build against kdelibs 4.8, all my pimlibs lib

Re: Which package will provide the common KDE library version number ?

On 2012-02-23, Alexander Neundorf wrote: >> I'd be fine with a "find_package(KF5BuildSpecs 5.3.0)", assuming the >> version number would be mandatory, as now there'd be no risk of a >> kwhatever 5.3.0 claiming to be a kwhatever 5.10.0. > > This can be done. > Then this line has to be kept in sync

Re: Which package will provide the common KDE library version number ?

On 2012-02-24, Alexander Neundorf wrote: > * the version numbers of the projects themselves > * the required Qt version This might differ across frameworks. I see no reason to artificial bump required version. > * the required CMake version similar. > * the required extra-cmake-modules version

Re: KF5 Volunteer day 2 next week?

> On Sunday 18 March 2012 20:11:20 Kevin Ottens wrote: >> So, doable? Any volunteers (aha) to drive the volunteer day? :-) > > Dario indicated to me he could be available part of the afternoon, that= > 's nice=20 > but likely not enough. > I'll most likely be around, but I*m not sure of my ability

Re: KF5 Volunteer day 2: How did it go?

On 2012-03-26, Kevin Ottens wrote: > Since I couldn't attend this second volunteer day, just wondering how i= > t went.=20 > People attending? Stuff done? given that I ended up being the only driver until around 4, I didn't try to drive it too hard. Claus Christensen, previously known from dani

Re: Where to put KDE Frameworks cmake stuff...

On 2012-04-20, Alexander Neundorf wrote: > * we will have a separate KF5 package, which will be a build-time requirement > for building KDE frameworks libraries. It will offer the following features > ** KDE approved compiler settings > ** KDE conforming install dirs > ** finding consistent insta

Re: API review: KDBusApplicationStarter

On 2012-05-22, David Faure wrote: > bool waitForReady(int msecs = 3); This one waits and has a timeout > static bool execute(const QString &program, const QString > &expectedServiceName, > const QStringList &arguments = QStringList(), QString > *error = 0);

Re: Which package will provide the common KDE library version number ?

On 2012-02-18, Alexander Neundorf wrote: > set_target_properties(Foo PROPERTIES VERSION ${VERSION_NUMBER} > SOVERSION ${SOVERSION_NUMBER} ) > > These two version numbers should always have sensible values. > I didn't test, but I'm not sure a libfoo.so.3dea0a0c6

Re: Which package will provide the common KDE library version number ?

On 2012-06-20, Sune Vuorela wrote: > On 2012-02-18, Alexander Neundorf wrote: GMane had here put in a couple of delays in the transmissions. /Sune ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mail

Re: dependency issue (KService* -> KPluginLoader -> KLocale)

On 2012-08-29, David Faure wrote: > KService, KServiceTypeTrader and KMimeTypeTrader (all of which I moved to a > new "kservice" framework), all have a template method (createInstance*) which > uses KPluginLoader to load the plugin described by the given service, or > trader query. > > Which gi

Re: Notifications-future, a recap

On 2012-09-17, Dario Freddi wrote: > Hello everyone, > > you might or might not know by now of my intention of revamping the > way we deal with notifications in KDE as I explained in my last blog > post > http://drfav.wordpress.com/2012/09/17/the-notifications-issue-part-3-the-possible-solution/

Re: KArchive for Qt4

On 2012-11-15, David Faure wrote: > This pointed out some interesting issues, especially in the cmakelists. I > removed the dependency on ECM, and as a result I saw many things for which I > thought "this should be in upstream cmake". Especially the LIB_INSTALL_DIR > stuff looks way too complic

Re: Dialogs, KMessage box and job widgets

On 2012-11-14, Valentin Rusu wrote: > Hello, > > I have a question about KMessage class from kdeui/dialogs. > > According to the epics page, kdeui/dialogs will go to tier3. > On the other hand, kdeui/jobs will go to tier2, only the class > KDialogJobUiDelegate is actually using KMessageBox. > If

Re: KArchive for Qt4

On 2012-11-15, Alexander Neundorf wrote: >> I thought we earlier agreed on things like "you should not inherit >> sonames from other modules" and such. We have apparantly a ECM_SOVERSION coming from somewhere and used. >> >> and we just have layers of added complexity that seems to be added f

Re: KArchive for Qt4

On 2012-11-17, Alexander Neundorf wrote: > On Thursday 15 November 2012, Sune Vuorela wrote: >> On 2012-11-15, Alexander Neundorf wrote: >> >> I thought we earlier agreed on things like "you should not inherit >> >> sonames from other modules" and such

Re: KArchive for Qt4

On 2012-11-18, Alexander Neundorf wrote: > On Sunday 18 November 2012, Alexander Neundorf wrote: >> On Saturday 17 November 2012, Sune Vuorela wrote: >> > at least the two following things (which is taken from memory, so there >> > might be typing issues) >> >

Re: KArchive for Qt4

On 2012-11-18, Stephen Kelly wrote: > Sune Vuorela wrote: >> I'm currently trying to get threadweaver built separately (for qt4). and >> the build system is way too complicated. and way too complex. and way >> too wrong. >> >> I thought we earlier agreed

Re: KArchive for Qt4

On 2012-11-19, Stephen Kelly wrote: >> I don't have a link to 'you should not inherit sonames from other >> modules'. but it sholud kind of be common sense as we also see in >> various areas of current KDE land where e.g. libkmailprivate from kdepim >> 4.4 is not having a matching SONAME, but gets

Re: kemoticons is now in staging

On 2012-11-19, David Faure wrote: > Let me say this differently: look at the huge mass of code in Qt: almost none > of it uses QSettings to let the users configure things "from underneath". > Most of the time, the apps themselves have control over the various settings > offered by the Qt API. >

Re: add_library NO_PREFIX

On 2012-11-29, Alexander Neundorf wrote: > At least it is possible: It is possible on some systems. I think it might be limited to a GNU userland on unix-like systems, if not limited to GNU userland on linux. It is at least according to some windows people not possible to do so on windows. /Sun

Re: Review Request: [PATCH 1/4] kcalendarsystem: Fix lengthOfWeek to 7

On 2012-12-13, Jon Severinsson wrote: > Week length depends on the week system (i.e. KLocale::WeekNumberSystem) use= > d, > not the calendar used, and is 7 for all week systems supported by KDE. won't this prevent the french revolutionary calendar to ever be supported? /Sune ___

Re: Separating everything ?

On 2013-02-08, Mirko Boehm wrote: > As Frank said: "I haven't seen any convincing argument yet why multiple > repositories are better." > +1. There are several things here intermixed 1) is the release tarball layout 2) is the way the software is built 3) is the repository layout all of them i

Re: "kde5" or "kf5" ?

On 2013-02-16, Alexander Neundorf wrote: > _set_fancy(LIBEXEC_INSTALL_DIR "${LIB_INSTALL_DIR}/kde5/libexec") I still don't see a reason for a *shared* libexec directory. libexec is implementation details of specific libraries, just like one shouldn't mess around with each others private's in the

Re: "kde5" or "kf5" ?

On 2013-02-16, Alexander Neundorf wrote: > The tool kde4-config has also been renamed to kde5-config. What's the purpose of this tool in a non-monolithic world? /Sune ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.

Re: KF5 Update Meeting Minutes 2013-w27

On 2013-07-02, Alexander Neundorf wrote: > E.g. kplotting and kwidgets have the same dependencies. I wouldn't mind > having > kplotting as part of kwidgets. I do think that consideratiotns like these are very important, but I also think we should wait with looking at merging them just a bit unt

Re: KIO progress towards tier 1 framework?

On 2013-07-10, Kevin Ottens wrote: > OK thanks for the clarification. I don't know where I got that impressi= > on that=20 > QtScript and Qml were using the same JS engine then... it was that way in qt4 :) /Sune ___ Kde-frameworks-devel mailing list K

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

ere For inspiration for doing simple command line tools, you could also take a look at https://codereview.qt-project.org/#change,60560,patchset=5 which has a simpler 'top down' structure which is how CLI-apps usually ar

install paths

Hi peoples. The following popped up in the chat channel today: |kf5 sonnet is looking for plugins in |$prefix/lib/x86_64-linux-gnu/plugins/sonnet_clients/ but installs them |in $prefix/lib/x86_64-linux-gnu/plugins/kf5/plugins/sonnet_clients or if I try to shorten it a bit |kf5 sonnet is looking

Re: Review Request 111937: Port to KF5/Qt5

e qt5 versions. It is these days quite normal to have both qt4 and qt5 installed and available. - Sune Vuorela On Aug. 7, 2013, 5:15 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: KF5 Update Meeting Minutes 2013-w31

On 2013-08-22, Kevin Ottens wrote: >> There's cmake --warn-uninitialized: "Print a warning when an >> uninitialized variable is used." > > Now that's interesting... Any way to control that from the CMakeLists.t= > xt or=20 > to turn that into an error? (just wondering how far that can be pushed)=

Re: Smart D-Ptr in KCoreAddons

On 2013-08-22, Ivan Čukić wrote: > We had some discussions on plasma-devel regarding the use of a smart non- > inherited D-Pointer[1] and Kevin proposed moving the pointer into KCoreAddons. > The only listed downside of including it into plasma is that it is too low > level and generic to belong

Re: Smart D-Ptr in KCoreAddons

On 2013-08-23, Ivan Čukić wrote: >> oh. and I think it also looks a bit like your d-ptr gets in the way when >> you need a d-ptr hierachy. > > As I said, this is for non-inherited privates. That alone is - I think - a reason to not have it. The few cases where I have needed d-ptr hierachies,

Re: qt5 polkit-qt-1 and kdesrc-build

On 2014-06-27, David Faure wrote: > On Saturday 01 March 2014 17:33:45 David Faure wrote: >> > I don't mind adding it - but what about releasing? >> > Is anyone taking care of releasing polkit-qt-? >> > Or should we make it a framework so I release it with the rest of the >> > stuff >> > ? Cc'ing

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

> On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote: > > I would rather change the code. The Qt behaviour was changed for a reason, > > to prevent accidental use of dangerous behaviour, and I'm not too keen on > > undoing that move for all software that uses KDECompilerSettings. agreed. - Sune

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

matter of "taste" and will let Alex comment on it: * should the qmake-query function be a secret underscore function * should the setting of the qmake_exe var happen inside the function or not - Sune Vuorela On Aug. 22, 2014, 12:40 p.m., Rohan

Review Request 120139: kill warning

/diff/ Testing --- Warning not printed. Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: desktoptojson man page

On 2014-09-15, Alexander Richardson wrote: > However, is this even possible? Building manpages seems to require KDocTools > and kcoreaddons is a tier1 framework which would make this impossible. > Do we really need a manpage for it? It seems to me that it is only > used in cmake code Or rewrite t

Re: Review Request 121712: Add install target for the KF5 Book

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121712/#review72687 --- looks right to me - Sune Vuorela On Dec. 28, 2014, 11:58

Making prison a framework

Hi The KDESupport library, libprison, a bar code rendering abstraction layer could be heading forward for the first release of a qt5, widgets free version. People also suggesting to make it a framework. So please, take a look at kde:prison and let's try to get it reviewed for frameworks /Sune

Review Request 124105: Adhere a bit better to the spec

https://git.reviewboard.kde.org/r/124105/diff/ Testing --- Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124105: Adhere a bit better to the spec

code do the same. Diffs (updated) - autotests/breeze.theme 8aef88d autotests/kiconloader_unittest.cpp d1a52fc src/kicontheme.cpp 4f0e522 Diff: https://git.reviewboard.kde.org/r/124105/diff/ Testing --- Thanks, Sune Vuorela __

Re: Review Request 124105: Adhere a bit better to the spec

- Sune --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124105/#review81499 --- On June 16, 2015, 5:59 a.m., Sune Vuor

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

29) <https://git.reviewboard.kde.org/r/124281/#comment56872> Unused ? src/notifybypopup.cpp (line 561) <https://git.reviewboard.kde.org/r/124281/#comment56873> Isn,t QFont() the same as QApplication::font(), and then the #include seems unused. - Sune Vuorela On July 9

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

ta so that other roles are actually supported? (In my similar, but not as thorough implementations of this, I've often needed other roles like color and/or decoration) - Sune Vuorela On July 13, 2015, 8:31 a.m., David Faure wrote: > > --- &

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

and filter out the column. - Sune Vuorela On July 14, 2015, 10:42 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.

Re: Review Request 124105: Adhere a bit better to the spec

marked as submitted. Review request for KDE Frameworks, Aleix Pol Gonzalez, Christoph Feck, David Faure, Eike Hein, and Martin Klapetek. Changes --- Submitted with commit c834ba2196ffbeec5277a224e7a03a5a1f4798ea by Sune Vuorela to branch master. Repository: kiconthemes Description

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84226 --- Ship it! I'm not Harald, but no. it won't. - Su

Re: Review Request 124963: New widget: KNewPasswordWidget

> On Aug. 28, 2015, 11:30 a.m., Lamarque Souza wrote: > > src/knewpasswordwidget.cpp, line 75 > > > > > > i18n instead of tr Aren't we in a tier1 framework where i18n and friends aren't available? - Sune

Re: Review Request 124963: New widget: KNewPasswordWidget

> On Aug. 28, 2015, 11:30 a.m., Lamarque Souza wrote: > > src/knewpasswordwidget.cpp, line 75 > > <https://git.reviewboard.kde.org/r/124963/diff/1/?file=399453#file399453line75> > > > > i18n instead of tr > > Sune Vuorela wrote: > Aren't

Re: Review Request 125318: KBuildSycocaProgressDialog: use Qt's builtin busy indicator.

;s use the 'infinite spinner' instead of fake calculations. I'm not sure I'm enough into the kservice code to actually give a shipit, so I'll refrain from that. - Sune Vuorela On Sept. 19, 2015, 10:58 p.m., David Faure wrote: > > ---

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

links ? - Sune Vuorela On Sept. 19, 2015, 11:29 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 125308: KSycoca: make ensureCacheValid() part of the public API.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125308/#review85684 --- Ship it! Ship It! - Sune Vuorela On Sept. 19, 2015, 8:24

Re: Review Request 125325: New widget KCollapsibleGroupBox

sibleGroupBoxPrivate. The harder way is to ... build the right NOT_EXPORT macro - Sune Vuorela On Sept. 20, 2015, 1:48 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mai

Re: kcrash when started from terminal

On 2015-09-24, Harald Sitter wrote: > Uh, ah, but, CMake is too smart :P > If you add a target_link_library that isn't actually used it won't be > linked. So what every application would have to do is add the target It is not cmake that is too smart, but the linker when passed --as-needed (which

Re: Review Request 125418: Add method to revert knotifyconfigwidget to default notifications

tps://git.reviewboard.kde.org/r/125418/#comment59352> This function name for a setter looks weird to me. setDefaults() reset() restoreDefaults() would be better names in my opinion. defaults() doesn't look like an action, so it must be a getter. - Sune Vuorela On Sep

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

order? I am wondering if either a QList - or let the plugin do the squashing - just QIcon - is a better return value. the naming "getOverlays" feels a bit java-esque. oh. and should it be const? I think I like the concept, and it feels like kio is the right home for it.

Re: phonon dep in knotifications

On 2015-10-12, Christoph Cullmann wrote: > Hi, > > I would like to make this dependency optional. > Would that be ok? Is not that much work, but if it is not wanted, don't want > to waste my time. > E.g. on Win/Mac its a real hassle to build and most applications don't need > it anyway but > mig

  1   2   3   >