D17623: Add YaST icons

ndavis added a comment. We still haven't figured out where to put all of the `yast-*` icons. Most of them are now symlinks to preferences icons, but that doesn't fix the fact that this patch can't pass the scalable test. This is because `apps/32` is a fixed size directory. I don't think

D17623: Add YaST icons

ndavis added a comment. In D17623#380743 , @fvogt wrote: > Turns out it's a trivial issue: breeze's index.theme doesn't contain the parameters for `apps/64` so it's like that directory doesn't even exist. > > I don't know how to fix it

D17623: Add YaST icons

fvogt added a comment. In D17623#380551 , @ndavis wrote: > In D17623#380549 , @fvogt wrote: > > > In D17623#380511 , @ndavis wrote: > > > > > @fvogt

D17623: Add YaST icons

ndavis added a comment. In D17623#380549 , @fvogt wrote: > In D17623#380511 , @ndavis wrote: > > > @fvogt @hellcp For some reason YaST Control Center only works with 32px icons from Breeze but it

D17623: Add YaST icons

fvogt added a comment. In D17623#380511 , @ndavis wrote: > @fvogt @hellcp For some reason YaST Control Center only works with 32px icons from Breeze but it can work with seemingly any size icon from hicolor. If either of you could help me

D17623: Add YaST icons

ndavis added a comment. @fvogt @hellcp For some reason YaST Control Center only works with 32px icons from Breeze but it can work with seemingly any size icon from hicolor. If either of you could help me figure out why that is, I would appreciate it. REPOSITORY R266 Breeze Icons REVISION

D17623: Add YaST icons

ngraham added a comment. In D17623#380204 , @ndavis wrote: > In D17623#378670 , @ngraham wrote: > > > apps/32/yast-checkmedia.svg preferences/32/preferences-devices-drive-optical-ok.svg >

D17623: Add YaST icons

ndavis added a comment. In D17623#378670 , @ngraham wrote: > apps/32/yast-checkmedia.svg preferences/32/preferences-devices-drive-optical-ok.svg Why `ok`? This is a preferences icon, so it doesn't make sense for there to be

D17623: Add YaST icons

ndavis added a comment. In D17623#378989 , @ngraham wrote: > In D17623#378783 , @ndavis wrote: > > > 2. It's supposed to be a newspaper. I tried to make it look similar to `message-news`: F6486579:

D17623: Add YaST icons

ngraham added a comment. In D17623#378783 , @ndavis wrote: > 2. It's supposed to be a newspaper. I tried to make it look similar to `message-news`: F6486579: Screenshot_20181218_073508.png > - An

D17623: Add YaST icons

ndavis added a comment. In D17623#378670 , @ngraham wrote: > Also, here are my only aesthetic suggestions: > > - Messages icon: how about making this look more like the utilities-log-viewer icon? Maybe a 32px version of that? > - Release

D17623: Add YaST icons

ngraham added a comment. Thanks! Here's a preliminary suggestion: Current icon What it should be a symlink to apps/32/yast-apparmor.svg preferences/32/preferences-security-apparmor.svg

D17623: Add YaST icons

ndavis added a comment. In D17623#378553 , @ngraham wrote: > In D17623#378253 , @ndavis wrote: > > > We can turn the `yast-*` into symlinks and rename the real icons to proper names when we need

D17623: Add YaST icons

ngraham added a comment. In D17623#378253 , @ndavis wrote: > We can turn the `yast-*` into symlinks and rename the real icons to proper names when we need them. You're asking me to guess what the right names for the future would be before we

D17623: Add YaST icons

ndavis added a comment. In D17623#378248 , @ngraham wrote: > In D17623#378023 , @ndavis wrote: > > > When the time comes, we can make symlinks with more appropriate names and different sizes. >

D17623: Add YaST icons

ndavis added a comment. LCP, the other openSUSE designer I've been working with, had this to say: > I have to disagree with ngraham here, imagine how many potential conflicts in hicolor we could get if yast icons had no prefix and we can't load those icons from resource like

D17623: Add YaST icons

ngraham added reviewers: cfeck, broulik, elvisangelaccio. ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. In D17623#378023 , @ndavis wrote: > I'd have to make PRs for ~60 GitHub

D17623: Add YaST icons

ndavis added a comment. In D17623#378006 , @ngraham wrote: > Nice work, these are good icons! > > However, I wonder whether we really want to use the `yast-` prefix for these images, especially the ones without explicit opensuse iconography.

D17623: Add YaST icons

ngraham added a comment. Nice work, these are good icons! However, I wonder whether we really want to use the `yast-` prefix for these images, especially the ones without explicit opensuse iconography. I can imagine some of these being useful in other apps' settings dialogs as well, but

D17623: Add YaST icons

ndavis updated this revision to Diff 47674. ndavis added a comment. Change printer and scanner icons to 32px since YaST Control Center doesn't want to work with symlinks to 64px device icons. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D17623: Add YaST icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Most of these icons are meant to be used in YaST Control Center. There is currently an