D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[David Faure]

dfaure added a comment.


  (remember to remove the [WIP] from the commit log, if you still have it 
locally)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> dfaure wrote in slavebase.h:262
> Does this break API docs generation? Suddenly the /** ... */ comment is 
> separated from the enum.

The comment didn't affect the doc generation. But the placement was awkward so 
I changed it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 71754.
chinmoyr added a comment.


  updated kf5 version.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21783?vs=71041=71754

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> slavebase.h:262
>   */
> -enum MessageBoxType { QuestionYesNo = 1, WarningYesNo = 2, 
> WarningContinueCancel = 3, WarningYesNoCancel = 4, Information = 5, 
> SSLMessageBox = 6 };
> +//In KMessageBox::DialogType; Sorry = 7, Error = 8, QuestionYesNoCancel 
> = 9
> +enum MessageBoxType { QuestionYesNo = 1, WarningYesNo = 2, 
> WarningContinueCancel = 3, WarningYesNoCancel = 4, Information = 5, 
> SSLMessageBox = 6, WarningContinueCancelDetailed = 10,  };

Does this break API docs generation? Suddenly the /** ... */ comment is 
separated from the enum.

> slavebase.h:1004
>   * @see PrivilegeOperationStatus
> - * @since 5.43
> + * @since 5.65
>   */

I was too slow, it's 5.66 now. Please change it everywhere.

Well by waiting we didn't break the message freeze with all these new i18n 
calls.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 71041.
chinmoyr added a comment.


  Rebased, compiled and tested. Changes work as expected.
  Double checked file_unix.cpp. Would be a shame if it happens yet again.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21783?vs=71025=71041

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I'm concerned that you didn't compile this (because of dependency issues, 
from what I gather), which means it's not tested either.
  
  I tried to compile it but it doesn't cleanly apply to git master. Can you 
rebase it?

INLINE COMMENTS

> slaveinterface.cpp:295
>  }
> +} else if (m.contains("privilege_conf_details")) { // KF6 TODO 
> Remove this conditional.
> +d->privilegeConfMetaData = m;

This fails to build for me...

slaveinterface.cpp:291:55: error: ‘QString::QString(const char*)’ is private 
within this context

It needs QStringLiteral like the previous one.

> dfaure wrote in file_unix.cpp:87
> no space before ':' in English

Not done

> dfaure wrote in file_unix.cpp:91
> same

same

> dfaure wrote in file_unix.cpp:121
> weird indentation

still there

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> dfaure wrote in slaveinterface_p.h:56
> Please explain how, for when the time comes (in case you're not around to do 
> it).

Removing each of its occurence (of which there are 3) and the surrounding `if`. 
 I will add comments where its needed to be removed.

> dfaure wrote in jobuidelegate.h:155
> what would be the proper API you have in mind?

I think adding a QString parameter for operation details should be sufficient. 
Then the API should be kept in sync with SlaveBase, SalveInterface, and 
JobUiDelegateExtension.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 71025.
chinmoyr marked 10 inline comments as done.
chinmoyr added a comment.


  Addressed the issues.
  Annotated code to be removed in KF6.
  My build env is outdated so I couldn't compile the new depracation macro. 
Copied as it is.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21783?vs=70914=71025

BRANCH
  arcpatch-D21783

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> slavebase.cpp:1525
> +
> +#ifndef KIOCORE_NO_DEPRECATED
> +PrivilegeOperationStatus SlaveBase::requestPrivilegeOperation()

`#if KIOCORE_BUILD_DEPRECATED_SINCE(5, 65) `

(notice BUILD, not ENABLE)

> slavebase.h:960
> +
> +#ifndef KIOCORE_NO_DEPRECATED
> +KIOCORE_DEPRECATED PrivilegeOperationStatus requestPrivilegeOperation();

The modern way is `#if KIOCORE_ENABLE_DEPRECATED_SINCE(5, 65)`

> slavebase.h:961
> +#ifndef KIOCORE_NO_DEPRECATED
> +KIOCORE_DEPRECATED PrivilegeOperationStatus requestPrivilegeOperation();
> +#endif

`KIOCORE_DEPRECATED_VERSION(5, 65, "Pass QString action to 
requestPrivilegeOperation")`

> slaveinterface.h:89
>  MSG_PRIVILEGE_EXEC,
> -MSG_SLAVE_STATUS_V2
> +MSG_SLAVE_STATUS_V2,
>  // add new ones here once a release is done, to avoid breaking binary 
> compatibility

unrelated/unneeded anymore

> slaveinterface_p.h:56
> +// Since 5.65 this is used for sending privilege operation details.
> +// KF6 TODO remove this hack.
> +MetaData privilegeConfMetaData;

Please explain how, for when the time comes (in case you're not around to do 
it).

> file_unix.cpp:84
> +QString action, detail;
> +switch(actionType) {
> +case CHMOD:

missing space after `switch` (same rule as `if`, `for` etc.)

> dfaure wrote in file_unix.cpp:81
> `const QVariantList &`

marked as done, but not done

> jobuidelegate.cpp:375
> +const QString details = 
> metaData.value(QStringLiteral("privilege_conf_details"));
> +result =  KMessageBox::warningContinueCancelDetailed(
> +  window(), text, caption, KStandardGuiItem::cont(), 
> KStandardGuiItem::cancel(), dontAskAgainName,

two spaces after `=`, remove one

> jobuidelegate.cpp:377
> +  window(), text, caption, KStandardGuiItem::cont(), 
> KStandardGuiItem::cancel(), dontAskAgainName,
> +  KMessageBox::Options(KMessageBox::Dangerous | 
> KMessageBox::WindowModal), details);
> +break;

I don't think you need the `KMessageBox::Options(` around the value?

> jobuidelegate.h:155
>const QString  = QString(),
> -  const KIO::MetaData  = 
> KIO::MetaData()) override;
> +  const KIO::MetaData  = KIO::MetaData()) 
> override; // KF6 TODO Add proper API
>  

what would be the proper API you have in mind?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> dfaure wrote in jobuidelegateextension.h:279
> Sorry, you can't add a new virtual method to an exported+installed class.
> 
> BIC rules (where "rules" is a noun, not a verb...) ;-)
> 
> Possible solutions:
> 
> - creating a new, separate, type of extension, say 
> `JobUiDelegatePrivilegeExtension`. This requires adding another defautFoo() 
> and setFoo() method like this file has at the bottom.
> - creating a "JobUiDelegateExtensionV2", derived from JobUiDelegateExtension, 
> with a KF6 TODO to merge it with JobUiDelegateExtension. Then you can 
> dynamic_cast the result of `defaultJobUiDelegateExtension()` to V2 to see if 
> the extension implements V2.

> Sorry, you can't add a new virtual method to an exported+installed class.
> 
> BIC rules (where "rules" is a noun, not a verb...) ;-)

LOL! Either way it's true.

> Possible solutions:
> 
> *creating a new, separate, type of extension, say 
> JobUiDelegatePrivilegeExtension. This requires adding another defautFoo() and 
> setFoo() >method like this file has at the bottom.
> *creating a "JobUiDelegateExtensionV2", derived from JobUiDelegateExtension, 
> with a KF6 TODO to merge it with JobUiDelegateExtension. >Then you can 
> dynamic_cast the result of defaultJobUiDelegateExtension() to V2 to see if 
> the extension implements V2.

IMO trying to pass job details from SlaveBase to KMessageBox without breaking 
compatibility would result in an unnecessarily large patch.
So I went ahead with reusing sslMetaData which was hacky but the resulting 
patch wasn't an eye-sore.  I hope we can keep this and later add proper API in 
KF6.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Nathaniel Graham]

ngraham accepted this revision as: VDG.
ngraham added a comment.


  UI looks fine to me. @dfaure?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 70914.
chinmoyr marked 4 inline comments as done.
chinmoyr added a comment.


  Addressed the issues.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21783?vs=67955=70914

BRANCH
  arcpatch-D21783

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface.h
  src/core/slaveinterface_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Nathaniel Graham]

ngraham added a task: T8075: Fix security issues with KAuth support in KIO.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> jobuidelegateextension.h:279
> + */
> +virtual bool askPrivilegeOperationConfirmation(const QString 
> ,
> +   const QString 
> ,

Sorry, you can't add a new virtual method to an exported+installed class.

BIC rules (where "rules" is a noun, not a verb...) ;-)

Possible solutions:

- creating a new, separate, type of extension, say 
`JobUiDelegatePrivilegeExtension`. This requires adding another defautFoo() and 
setFoo() method like this file has at the bottom.
- creating a "JobUiDelegateExtensionV2", derived from JobUiDelegateExtension, 
with a KF6 TODO to merge it with JobUiDelegateExtension. Then you can 
dynamic_cast the result of `defaultJobUiDelegateExtension()` to V2 to see if 
the extension implements V2.

> slavebase.h:956
> +/**
> + * @deprecated since 5.64
> + */

`, use requestPrivilegeOperation(QString)`

> file_unix.cpp:81
>  
> +static QString actionDetails(ActionType actionType, QVariantList args)
> +{

`const QVariantList &`

> file_unix.cpp:87
> +action = i18n("Change File Permissions");
> +detail = i18n("New Permissions : %1", args[1].toInt());
> +break;

no space before ':' in English

> file_unix.cpp:91
> +action = i18n("Change File Owner");
> +detail = i18n("New Owner : UID=%1, GID=%2", args[1].toInt(), 
> args[2].toInt());
> +break;

same

> file_unix.cpp:121
> +default:
> +action = i18n("Unknown Action");
> +break;

weird indentation

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> dfaure wrote in slavebase.h:964
> Missing "m" prefix like the other members, but wait isn't this BIC? 
> Adding a new member to an exported class certainly is. This needs to go into 
> the SlaveBasePrivate class instead.

Since we need details from the ioslave somehow, I deprecated 
requestPrivilegeOperation() in favor of an overload that accepts details as 
argument.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 67955.
chinmoyr marked 3 inline comments as done.
chinmoyr added a comment.


  Addressed the comments.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21783?vs=59738=67955

BRANCH
  arcpatch-D21783

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface.h
  src/core/usernotificationhandler.cpp
  src/core/usernotificationhandler_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Nathaniel Graham]

ngraham added a comment.


  Ping :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.

INLINE COMMENTS

> slavebase.cpp:1511
> +KIO_DATA << d->m_warningCaption << d->m_warningMessage << 
> privilegeOperationDetails;
> +send(INF_PRIVILEGE_CONF, data);
> +if (waitForAnswer(INF_PRIVILEGE_CONF, 0, data) != -1) {

INF is for one-way information, isn't it? Why isn't this MSG_ like the one 
above?

> slavebase.h:964
>  
> +QString privilegeOperationDetails;
> +

Missing "m" prefix like the other members, but wait isn't this BIC? Adding 
a new member to an exported class certainly is. This needs to go into the 
SlaveBasePrivate class instead.

> file_unix.cpp:85
> +switch(actionType) {
> +case CHMOD: {
> +action = i18n("Change File Permissions");

all those { ... } braces are unnecessary in this switch, which doesn't define 
any new variables

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr planned changes to this revision.
chinmoyr added a comment.


  TODO
  
  - Change the UI of the warning dialog
  - We still need more details

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Nathaniel Graham]

ngraham added a comment.


  Totally awesome :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D21783#479187 , @ngraham wrote:
  
  > Thanks! Is this for T8075 ?
  
  
  Yes it is.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Nathaniel Graham]

ngraham added a comment.


  Thanks! Is this for T8075 ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 59738.
chinmoyr added a comment.


  Fix typo

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21783?vs=59737=59738

BRANCH
  warn

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface.h
  src/core/usernotificationhandler.cpp
  src/core/usernotificationhandler_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: VDG, Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Currently it uses the dialog from D21782  
to provide the current action being performed, the source file and any
  action specific detail.
  
  F6887442: warningdialog.png 
  
  The initial plan was to show all the files needing elevated privileges but 
due to KIO jobs processing one file at
  a time only limited info could be provided. There's also the option for 
determing this during the stat phase but it
  caused my VM to slow down to a crawl. Any more ideas here?

REPOSITORY
  R241 KIO

BRANCH
  warn

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface.h
  src/core/usernotificationhandler.cpp
  src/core/usernotificationhandler_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns