mlaurent updated this revision to Diff 17470.
mlaurent added a comment.
Create a real class for private class as requested
+ fix signal
etc.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7011?vs=17469=17470
REVISION DETAIL
https://phabricator.kde.org/D7011
AFFECTED FILES
kossebau added inline comments.
INLINE COMMENTS
> kpasswordlineedit.cpp:30
> +
> +class KPasswordLineEdit::KPasswordLineEditPrivate : public QObject
> +{
Make this a normal class KPasswordLineEditPrivate here, following fixes
proposed above for the header.
> kpasswordlineedit.h:25
> +class
mlaurent updated this revision to Diff 17469.
mlaurent added a comment.
I renamed class/test apps/autotests as requested
I fixed autotest with new autotest from master
I fixed all comment on this review
etc.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7011?vs=17420=17469
mlaurent marked 7 inline comments as done.
REVISION DETAIL
https://phabricator.kde.org/D7011
To: mlaurent, cfeck, dfaure, elvisangelaccio
Cc: kossebau, elvisangelaccio, #frameworks
kossebau added inline comments.
INLINE COMMENTS
> mlaurent wrote in knewpasswordwidgettest.cpp:63
> Nope as setPassword not authorize to see icon (it's a security when we
> setPassword from apps you don't want to see it)
Could you add this as comment to this line? it is not directly obvious,
mlaurent marked 5 inline comments as done.
REVISION DETAIL
https://phabricator.kde.org/D7011
To: mlaurent, cfeck, dfaure, elvisangelaccio
Cc: kossebau, elvisangelaccio, #frameworks
mlaurent added inline comments.
INLINE COMMENTS
> cfeck wrote in knewpasswordwidgettest.cpp:63
> Does using setPassword() not work for these tests?
Nope as setPassword not authorize to see icon (it's a security when we
setPassword from apps you don't want to see it)
> cfeck wrote in
cfeck requested changes to this revision.
REVISION DETAIL
https://phabricator.kde.org/D7011
To: mlaurent, cfeck, dfaure, elvisangelaccio
Cc: elvisangelaccio, #frameworks
cfeck added a comment.
Any reason it should be PasswordLineEdit, and not KPasswordLineEdit? I do not
care about names, but I care about consistency.
INLINE COMMENTS
> knewpasswordwidgettest.cpp:63
> const QString password = QStringLiteral("1234");
> -
elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.
I spotted one small regression, I added a test case for it in
https://phabricator.kde.org/R236:380b35439a39950769fcca63f7ec31cc6170707a.
For manual test you
mlaurent updated this revision to Diff 17420.
mlaurent added a comment.
I renamed class name.
I ported KNewPasswordWidget .
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7011?vs=17413=17420
REVISION DETAIL
https://phabricator.kde.org/D7011
AFFECTED FILES
elvisangelaccio added a comment.
Can you try to use this new widget also in KNewPasswordWidget?
I'm also not sure about the name. I think PasswordLineEdit would be more
clear? (since this is a line edit, not a password).
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Now we can use lineedit password outside kpassworddialog.
It's useful in kdepim for example.
TEST PLAN
I added autotest and test apps.
13 matches
Mail list logo