Re: Review Request 129293: Add a CMake option to switch between HAL and UDisks managers on FreeBSD.

2016-10-31 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129293/ --- (Updated Oct. 31, 2016, 7:38 p.m.) Status -- This change has been

Re: Review Request 129293: Add a CMake option to switch between HAL and UDisks managers on FreeBSD.

2016-10-31 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129293/#review100452 --- Ship it! Ship It! - Lamarque Souza On Oct. 31, 2016,

Re: Review Request 129293: Add a CMake option to switch between HAL and UDisks managers on FreeBSD.

2016-10-31 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129293/#review100439 --- src/solid/devices/CMakeLists.txt (line 98)

Re: Review Request 129293: Add a CMake option to switch between HAL and UDisks managers on FreeBSD.

2016-10-31 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129293/ --- (Updated Oct. 31, 2016, 3:58 p.m.) Review request for Solid and Tobias

Re: Review Request 129293: Add a CMake option to switch between HAL and UDisks managers on FreeBSD.

2016-10-31 Thread Gleb Popov
> On Oct. 31, 2016, 3:40 p.m., Lamarque Souza wrote: > > src/solid/devices/CMakeLists.txt, line 117 > > > > > > Your patch still compiles hal even though it will not be used. That was intended. HAL backend can

Re: Review Request 129293: Add a CMake option to switch between HAL and UDisks managers on FreeBSD.

2016-10-31 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129293/#review100432 --- src/solid/devices/CMakeLists.txt (line 97)

Review Request 129293: Add a CMake option to switch between HAL and UDisks managers on FreeBSD.

2016-10-31 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129293/ --- Review request for Solid and Tobias Berner. Repository: solid