Re: Review Request 126510: ktp-kded-module KActivities for status handler multiple account presence

[James Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126510/
---

(Updated July 28, 2017, 12:05 p.m.)


Status
--

This change has been discarded.


Review request for Telepathy.


Bugs: 284517
http://bugs.kde.org/show_bug.cgi?id=284517


Repository: ktp-kded-module


Description
---

New features:
-Saves per-activity account presences between activities.


Diffs
-

  CMakeLists.txt 4dbaab64189d819a27e5b36fd10098f0fac3dbc6 
  account-status-helper.h PRE-CREATION 
  account-status-helper.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126510/diff/


Testing
---

Compile, run.


Thanks,

James Smith

Re: Review Request 126510: ktp-kded-module KActivities for status handler multiple account presence

[James Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126510/
---

(Updated Feb. 14, 2017, 6:29 p.m.)


Review request for Telepathy.


Changes
---

1) Check for activity service running before processing 
currentActivityChanged() signal.


Bugs: 284517
http://bugs.kde.org/show_bug.cgi?id=284517


Repository: ktp-kded-module


Description
---

New features:
-Saves per-activity account presences between activities.


Diffs (updated)
-

  CMakeLists.txt 4dbaab64189d819a27e5b36fd10098f0fac3dbc6 
  account-status-helper.h PRE-CREATION 
  account-status-helper.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126510/diff/


Testing (updated)
---

Compile, run.


Thanks,

James Smith

Re: Review Request 126510: ktp-kded-module KActivities for status handler multiple account presence

[James Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126510/
---

(Updated Jan. 28, 2017, 4:54 p.m.)


Review request for Telepathy.


Changes
---

1) Rebase.
2) Move activityRemoved() inline.
3) Use signal value.


Bugs: 284517
http://bugs.kde.org/show_bug.cgi?id=284517


Repository: ktp-kded-module


Description
---

New features:
-Saves per-activity account presences between activities.


Diffs (updated)
-

  CMakeLists.txt 4dbaab64189d819a27e5b36fd10098f0fac3dbc6 
  account-status-helper.h PRE-CREATION 
  account-status-helper.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126510/diff/


Testing (updated)
---

Compile, run.

Disabling restore last presence on login doesn't work because of a spurious 
signal in KActivities <= 5.30. https://bugs.kde.org/show_bug.cgi?id=371924


Thanks,

James Smith

Re: Review Request 126510: ktp-kded-module KActivities for status handler multiple account presence

[James Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126510/
---

(Updated Dec. 14, 2016, 3:09 p.m.)


Review request for Telepathy.


Changes
---

Add bug URL.


Bugs: 284517
http://bugs.kde.org/show_bug.cgi?id=284517


Repository: ktp-kded-module


Description
---

New features:
-Saves per-activity account presences between activities.


Diffs
-

  CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5 
  account-status-helper.h PRE-CREATION 
  account-status-helper.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126510/diff/


Testing (updated)
---

Compile, run.

Disabling restore last presence on login doesn't work because of a spurious 
signal in KActivities <= 5.27. https://bugs.kde.org/show_bug.cgi?id=371924


Thanks,

James Smith

Re: Review Request 126510: ktp-kded-module KActivities for status handler multiple account presence

[James Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126510/
---

(Updated Nov. 21, 2016, 10:29 p.m.)


Review request for Telepathy.


Changes
---

1) New-style signals and slots.
2) Tidier signal / slot function inlining.
3) Trigger a presence update when the activity service state changes.
4) Clarify activity service not running debug warning; disable for unknown 
service state.
5) Remove setDiskPresence() debug warning.


Bugs: 284517
http://bugs.kde.org/show_bug.cgi?id=284517


Repository: ktp-kded-module


Description
---

New features:
-Saves per-activity account presences between activities.


Diffs (updated)
-

  CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5 
  account-status-helper.h PRE-CREATION 
  account-status-helper.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126510/diff/


Testing (updated)
---

Compile, run.

Disabling restore last presence on login doesn't work because of a spurious 
signal in KActivities <= 5.27.


Thanks,

James Smith

Re: Review Request 126510: ktp-kded-module KActivities for status handler multiple account presence

[James Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126510/
---

(Updated Sept. 17, 2016, 10:03 p.m.)


Review request for Telepathy.


Changes
---

Use c++11 for loops instead of Q_FOREACH for new code.


Bugs: 284517
http://bugs.kde.org/show_bug.cgi?id=284517


Repository: ktp-kded-module


Description
---

New features:
-Saves per-activity account presences between activities.


Diffs (updated)
-

  CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5 
  account-status-helper.h PRE-CREATION 
  account-status-helper.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126510/diff/


Testing
---

Compile, run.


Thanks,

James Smith

Re: Review Request 126510: ktp-kded-module KActivities for status handler multiple account presence

[James Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126510/
---

(Updated June 24, 2016, 3:37 a.m.)


Review request for Telepathy.


Changes
---

Rebase for r123485 fixes.


Bugs: 284517
http://bugs.kde.org/show_bug.cgi?id=284517


Repository: ktp-kded-module


Description
---

New features:
-Saves per-activity account presences between activities.


Diffs (updated)
-

  CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5 
  account-status-helper.h PRE-CREATION 
  account-status-helper.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126510/diff/


Testing
---

Compile, run.


Thanks,

James Smith

___
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

Re: Review Request 126510: ktp-kded-module KActivities for status handler multiple account presence

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126510/#review94407
---


Ship it!




Ship It!

- David Edmundson


On April 4, 2016, 6:52 p.m., James Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126510/
> ---
> 
> (Updated April 4, 2016, 6:52 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 284517
> http://bugs.kde.org/show_bug.cgi?id=284517
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> ---
> 
> New features:
> -Saves per-activity account presences between activities.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5 
>   account-status-helper.h PRE-CREATION 
>   account-status-helper.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126510/diff/
> 
> 
> Testing
> ---
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

___
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

Re: Review Request 126510: ktp-kded-module KActivities for status handler multiple account presence

[James Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126510/
---

(Updated April 4, 2016, 6:52 p.m.)


Review request for Telepathy.


Changes
---

1) Incorporate AccountStatusHelper enable / disable account fix.


Bugs: 284517
http://bugs.kde.org/show_bug.cgi?id=284517


Repository: ktp-kded-module


Description
---

New features:
-Saves per-activity account presences between activities.


Diffs (updated)
-

  CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5 
  account-status-helper.h PRE-CREATION 
  account-status-helper.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126510/diff/


Testing
---

Compile, run.


Thanks,

James Smith

___
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

Re: Review Request 126510: ktp-kded-module KActivities for status handler multiple account presence

[James Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126510/
---

(Updated April 4, 2016, 4:20 a.m.)


Review request for Telepathy.


Changes
---

AccountStatusHelper:
1)Fix m_requestedGlobalPresence in the context of changing activity.
2)Warning debug when the activity service is not running.


Bugs: 284517
http://bugs.kde.org/show_bug.cgi?id=284517


Repository: ktp-kded-module


Description
---

New features:
-Saves per-activity account presences between activities.


Diffs (updated)
-

  CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5 
  account-status-helper.h PRE-CREATION 
  account-status-helper.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126510/diff/


Testing
---

Compile, run.


Thanks,

James Smith

___
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

Re: Review Request 126510: ktp-kded-module KActivities for status handler multiple account presence

[James Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126510/
---

(Updated March 12, 2016, 7:40 a.m.)


Review request for Telepathy.


Changes
---

AccountStatusHelper changes.


Bugs: 284517
http://bugs.kde.org/show_bug.cgi?id=284517


Repository: ktp-kded-module


Description
---

New features:
-Saves per-activity account presences between activities.


Diffs (updated)
-

  CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5 
  account-status-helper.h PRE-CREATION 
  account-status-helper.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126510/diff/


Testing
---

Compile, run.


Thanks,

James Smith

___
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

Re: Review Request 126510: ktp-kded-module KActivities for status handler multiple account presence

[James Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126510/
---

(Updated March 7, 2016, 6:50 a.m.)


Review request for Telepathy.


Bugs: 284517
http://bugs.kde.org/show_bug.cgi?id=284517


Repository: ktp-kded-module


Description
---

New features:
-Saves per-activity account presences between activities.


Diffs (updated)
-

  CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5 
  account-status-helper.h PRE-CREATION 
  account-status-helper.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126510/diff/


Testing
---

Compile, run.


Thanks,

James Smith

___
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

Re: Review Request 126510: ktp-kded-module KActivities for status handler multiple account presence

[James Smith]

> On March 3, 2016, 10:48 p.m., David Edmundson wrote:
> > account-status-helper.cpp, line 274
> > 
> >
> > else if KTp::Presence(m_requestedGlobalPresence).isValid()  ?

Tp::SimplePresence has no isValid() check, so this wraps the Tp::SimplePresence 
in KTp::Presence to use its validator without using the result.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126510/#review93145
---


On March 7, 2016, 6:50 a.m., James Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126510/
> ---
> 
> (Updated March 7, 2016, 6:50 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 284517
> http://bugs.kde.org/show_bug.cgi?id=284517
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> ---
> 
> New features:
> -Saves per-activity account presences between activities.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5 
>   account-status-helper.h PRE-CREATION 
>   account-status-helper.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126510/diff/
> 
> 
> Testing
> ---
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

___
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

Re: Review Request 126510: ktp-kded-module KActivities for status handler multiple account presence

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126510/#review93145
---



seems good


account-status-helper.cpp (line 44)


leaks



account-status-helper.cpp (line 46)


you need to wait for the consumer to load otherwise you get an empty (or 
"0--") string here



account-status-helper.cpp (line 262)


else if KTp::Presence(m_requestedGlobalPresence).isValid()  ?


- David Edmundson


On Feb. 22, 2016, 9:30 a.m., James Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126510/
> ---
> 
> (Updated Feb. 22, 2016, 9:30 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 284517
> http://bugs.kde.org/show_bug.cgi?id=284517
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> ---
> 
> New features:
> -Saves per-activity account presences between activities.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5 
>   account-status-helper.h PRE-CREATION 
>   account-status-helper.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126510/diff/
> 
> 
> Testing
> ---
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

___
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy