[kdenlive] Review Request 125520: Fix for media controller events not being lost because they get send to NULL parent

rd.kde.org/r/125520/diff/ Testing --- Yes; using a ShuttlePRO v2 media controller on Kdenlive Applications/15.08 branch. Thanks, The DiveO ___ kdenlive mailing list kdenlive@kde.org https://mail.kde.org/mailman/listinfo/kdenlive

Re: [kdenlive] Review Request 125520: Fix for media controller events not being lost because they get send to NULL parent

/r/125520/#review86348 --- On Okt. 4, 2015, 6:20 nachm., The DiveO wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: [kdenlive] Review Request 125520: Fix for media controller events not being lost because they get send to NULL parent

controller on Kdenlive Applications/15.08 branch. Thanks, The DiveO ___ kdenlive mailing list kdenlive@kde.org https://mail.kde.org/mailman/listinfo/kdenlive

[kdenlive] Review Request 125548: Configuration dialog UI improvement: show action texts assigned to jog buttons without "&"; easier to read; sorts according to user expectations

nts can successfully be changed and work correctly. Thanks, The DiveO ___ kdenlive mailing list kdenlive@kde.org https://mail.kde.org/mailman/listinfo/kdenlive

Re: [kdenlive] Review Request 125548: Configuration dialog UI improvement: show action texts assigned to jog buttons without "&"; easier to read; sorts according to user expectations

marked as submitted. Review request for Kdenlive. Changes --- Submitted with commit 6c9464d4cd99ade8316df61c370f5c5d43818ffb by Vincent Pinon on behalf of The DiveO to branch Applications/15.08. Repository: kdenlive Description --- This proposed patch improves the configuration

[kdenlive] Review Request 125707: fix: Timeline incorrectly checks track index bounds crash

://git.reviewboard.kde.org/r/125707/diff/ Testing --- Tested against recent Kdenlive branch Applications/15.08, on Kubuntu 15.04 64bit system. Tested with a converted 15.04 Kdenlive project that exhibits this bug when trying to add new tracks to the timeline. Thanks, The DiveO

Re: [kdenlive] Review Request 125707: fix: Timeline incorrectly checks track index bounds crash

fb5bf90 Diff: https://git.reviewboard.kde.org/r/125707/diff/ Testing --- Tested against recent Kdenlive branch Applications/15.08, on Kubuntu 15.04 64bit system. Tested with a converted 15.04 Kdenlive project that exhibits this bug when trying to add new tracks to the timeline. Thanks, The

[kdenlive] Review Request 125708: Applications/15.08: fix clipping of audio signal view db marks

iff: https://git.reviewboard.kde.org/r/125708/diff/ Testing --- On Kdenlive Applications/15.08 branch on Kubuntu 15.04 64bit installation. Thanks, The DiveO ___ kdenlive mailing list kdenlive@kde.org https://mail.kde.org/mailman/listinfo/kdenlive

Re: [kdenlive] Review Request 125707: Applications/15.08 fix: Timeline incorrectly checks track index bounds crash

15.04 Kdenlive project that exhibits this bug when trying to add new tracks to the timeline. Thanks, The DiveO ___ kdenlive mailing list kdenlive@kde.org https://mail.kde.org/mailman/listinfo/kdenlive

Re: [kdenlive] Review Request 125708: Applications/15.08: fix clipping of audio signal view db marks

-- On Kdenlive Applications/15.08 branch on Kubuntu 15.04 64bit installation. Thanks, The DiveO ___ kdenlive mailing list kdenlive@kde.org https://mail.kde.org/mailman/listinfo/kdenlive

Re: [kdenlive] Review Request 125707: Applications/15.08 fix: Timeline incorrectly checks track index bounds crash

recent Kdenlive branch Applications/15.08, on Kubuntu 15.04 64bit system. Tested with a converted 15.04 Kdenlive project that exhibits this bug when trying to add new tracks to the timeline. Thanks, The DiveO ___ kdenlive mailing list kdenlive

Review Request 128782: Rounded/straight corners for timeline clips and transitions

https://git.reviewboard.kde.org/r/128782/diff/ Testing --- Testing done on Kubuntu 16.04LTS with latest backports updates installed for KF5 and Qt. Thanks, The DiveO

Review Request 128783: Configure default duration for newly created transitions

/customtrackview.cpp d5247c43bbcdb027815c47c0e9a3b51584152956 src/ui/configmisc_ui.ui 4fe88fded59e1104142dd8b76b708cf3a0f49e1e Diff: https://git.reviewboard.kde.org/r/128783/diff/ Testing --- Tested on Kubuntu 16.04LTS with latest backports updates installed for KF5 and Qt. Thanks, The DiveO

Re: Review Request 128783: Configure default duration for newly created transitions

/configmisc_ui.ui 4fe88fded59e1104142dd8b76b708cf3a0f49e1e Diff: https://git.reviewboard.kde.org/r/128783/diff/ Testing --- Tested on Kubuntu 16.04LTS with latest backports updates installed for KF5 and Qt. Thanks, The DiveO

Re: Review Request 128782: Rounded/straight corners for timeline clips and transitions

n.cpp 1a898ad8abb093e0ca2728b30b4e10f51da3cf6b src/ui/configtimeline_ui.ui 21eba34ac4d79674cdeb87637a914599a7b66db9 Diff: https://git.reviewboard.kde.org/r/128782/diff/ Testing --- Testing done on Kubuntu 16.04LTS with latest backports updates installed for KF5 and Qt. Thanks, The DiveO

Review Request 128798: Show actual MLT version used by Kdenlive

iewboard.kde.org/r/128798/diff/ Testing --- Tested on Kubuntu 16.04LTS with all KF5/Qt updates installed. Kdenlive is as of today's recent git master. Thanks, The DiveO

Re: Review Request 128798: Show actual MLT version used by Kdenlive

on used. Diffs - src/main.cpp 5bc2722e74a17e4c75ede3759c0526d650809c88 Diff: https://git.reviewboard.kde.org/r/128798/diff/ Testing --- Tested on Kubuntu 16.04LTS with all KF5/Qt updates installed. Kdenlive is as of today's recent git master. Thanks, The DiveO

Review Request 128879: allow users to control "automatic" property of newly created transitions; corrected handling during copy+paste

line_ui.ui a56940f Diff: https://git.reviewboard.kde.org/r/128879/diff/ Testing --- Testing done using recent Kdenlive git master on Kubuntu 16.04LTS with recent Qt and KF5 updates installed. Thanks, The DiveO

Re: Review Request 128879: allow users to control "automatic" property of newly created transitions; corrected handling during copy+paste

Testing --- Testing done using recent Kdenlive git master on Kubuntu 16.04LTS with recent Qt and KF5 updates installed. Thanks, The DiveO

Review Request 128921: support file size display in clip properties display

particular, proper units and separators are used. Diffs - src/mltcontroller/clippropertiescontroller.cpp bdc30ed Diff: https://git.reviewboard.kde.org/r/128921/diff/ Testing --- Testing on recent Kdenlive git master on Kubuntu 16.04LTS with recent KF5 and Qt updates. Thanks, The DiveO

Re: Review Request 128921: support file size display in clip properties display

S with recent KF5 and Qt updates. Thanks, The DiveO

Review Request 128923: Deselect -- as opposite to Select All

enlive git master on Kubuntu 16.04LTS with recent KF5 and Qt updates installed. Thanks, The DiveO

Re: Review Request 128921: support file size display in clip properties display

src/mltcontroller/clippropertiescontroller.cpp bdc30ed Diff: https://git.reviewboard.kde.org/r/128921/diff/ Testing --- Testing on recent Kdenlive git master on Kubuntu 16.04LTS with recent KF5 and Qt updates. Thanks, The DiveO

Re: Review Request 128923: Deselect -- as opposite to Select All

8923/diff/ Testing --- Tested on recent Kdenlive git master on Kubuntu 16.04LTS with recent KF5 and Qt updates installed. Thanks, The DiveO

Re: Review Request 128923: Deselect -- as opposite to Select All

dow.h 95629ae src/mainwindow.cpp a9b4c2f Diff: https://git.reviewboard.kde.org/r/128923/diff/ Testing --- Tested on recent Kdenlive git master on Kubuntu 16.04LTS with recent KF5 and Qt updates installed. Thanks, The DiveO

Review Request 128928: auto transition icon: fix missing type attribute in style element

eeze-light/lt_auto-transition.svg PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128928/diff/ Testing --- Thanks, The DiveO

Review Request 128929: extract image to project

ply reroutes to slotExtractCurrentFrame using the optional flag. Diffs - src/monitor/monitor.h 39679d8 src/monitor/monitor.cpp 8d77d8b Diff: https://git.reviewboard.kde.org/r/128929/diff/ Testing --- Testing on recent Kdenlive git master. Thanks, The DiveO

Re: Review Request 128928: auto transition icon: fix missing type attribute in style element

.kde.org/r/128928/diff/ Testing --- Thanks, The DiveO

Re: Review Request 128929: extract image to project

actCurrentFrameToProject, which simply reroutes to slotExtractCurrentFrame using the optional flag. Diffs (updated) - src/monitor/monitor.h 39679d8 src/monitor/monitor.cpp 8d77d8b Diff: https://git.reviewboard.kde.org/r/128929/diff/ Testing --- Testing on recent Kdenlive git master. Thanks, The DiveO

Re: Review Request 128929: extract image to project

ly generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128929/#review99250 ------- On Sept. 18, 2016, 1:18 p.m., The DiveO wrote: > > --- > Th

Re: Review Request 128929: extract image to project

-- src/monitor/monitor.h 39679d8 src/monitor/monitor.cpp 8d77d8b Diff: https://git.reviewboard.kde.org/r/128929/diff/ Testing --- Testing on recent Kdenlive git master. Thanks, The DiveO

Review Request 128937: fix extract image extracting from proxy producer instead of original producer

least the preceeding comment mentions to use the original clip url ... and that strongly points towards the property "kdenlive:originalurl". Diffs - src/monitor/monitor.cpp 9d452aa Diff: https://git.reviewboard.kde.org/r/128937/diff/ Testing --- Using fresh recent Kdenl

Re: Review Request 128937: fix extract image extracting from proxy producer instead of original producer

that strongly points towards the property "kdenlive:originalurl". Diffs - src/monitor/monitor.cpp 9d452aa Diff: https://git.reviewboard.kde.org/r/128937/diff/ Testing --- Using fresh recent Kdenlive git master. Thanks, The DiveO

Review Request 129000: allow users to config when to raise the properties dialog

ecent Kdenlive git master. Thanks, The DiveO

Review Request 129011: spend some love on Kdenlive's library: fix resource paths on playlist expansion, improve user interaction and error reporting

reated. Diffs - src/bin/bin.cpp 00d9587 src/library/librarywidget.cpp 7620bbe src/mainwindow.cpp 806 src/timeline/customtrackview.cpp 3462496 Diff: https://git.reviewboard.kde.org/r/129011/diff/ Testing --- Tested on recent Kdenlive git master. Thanks, The DiveO

Re: Review Request 129000: allow users to config when to raise the properties dialog

eline tab config dialog. Diffs - src/kdenlivesettings.kcfg 5145fa2 src/mainwindow.cpp 806 src/ui/configtimeline_ui.ui 165f903 Diff: https://git.reviewboard.kde.org/r/129000/diff/ Testing --- Recent Kdenlive git master. Thanks, The DiveO

Re: Review Request 129011: spend some love on Kdenlive's library: fix resource paths on playlist expansion, improve user interaction and error reporting

d after a library playlist clip has been created. Diffs (updated) - src/bin/bin.cpp 00d9587 src/library/librarywidget.cpp 7620bbe src/mainwindow.cpp 806 src/timeline/customtrackview.cpp 3462496 Diff: https://git.reviewboard.kde.org/r/129011/diff/ Testing --- Tested on re

Re: Review Request 129011: spend some love on Kdenlive's library: fix resource paths on playlist expansion, improve user interaction and error reporting

29011/diff/ Testing --- Tested on recent Kdenlive git master. Thanks, The DiveO

Re: Review Request 129011: spend some love on Kdenlive's library: fix resource paths on playlist expansion, improve user interaction and error reporting

library/librarywidget.cpp 7620bbe src/mainwindow.cpp 806 src/timeline/customtrackview.cpp 3462496 Diff: https://git.reviewboard.kde.org/r/129011/diff/ Testing --- Tested on recent Kdenlive git master. Thanks, The DiveO

Review Request 129023: more Kdenlive library love: improve playlist expansion

ustomtrackview.cpp 4ba92d9 Diff: https://git.reviewboard.kde.org/r/129023/diff/ Testing --- On recent Kdenlive git master. Thanks, The DiveO

Re: Review Request 129023: more Kdenlive library love: improve playlist expansion

29023/diff/ Testing --- On recent Kdenlive git master. Thanks, The DiveO

Review Request 129034: improve library/playlist clip import by detecting duplicate producers

6338296 Diff: https://git.reviewboard.kde.org/r/129034/diff/ Testing --- Tested on recent git master. Thanks, The DiveO

Review Request 129056: Fix wording in Preview Render Menu; add new icon

" Diffs - data/pics/CMakeLists.txt 8f108ff data/pics/breeze-dark/dk_preview-remove-all.svg PRE-CREATION data/pics/breeze-light/lt_preview-remove-all.svg PRE-CREATION src/mainwindow.cpp 9dd7d3c Diff: https://git.reviewboard.kde.org/r/129056/diff/ Testing --- Testing done on recent Kdenlive git master. Thanks, The DiveO

Re: Review Request 129034: improve library/playlist clip import by detecting duplicate producers

--- Tested on recent git master. Thanks, The DiveO

Re: Review Request 129056: Fix wording in Preview Render Menu; add new icon

dark/dk_preview-remove-all.svg PRE-CREATION data/pics/breeze-light/lt_preview-remove-all.svg PRE-CREATION src/mainwindow.cpp 9dd7d3c Diff: https://git.reviewboard.kde.org/r/129056/diff/ Testing --- Testing done on recent Kdenlive git master. Thanks, The DiveO

Review Request 129068: fix wording in project load dialog

. Thanks, The DiveO