Re: [OS-BUILD PATCH] redhat/Makefile, Makefile.common: introduce GIT macro

2020-09-09 Thread Don Zickus
On Sat, Sep 05, 2020 at 03:57:14AM -, GitLab Bridge on behalf of bcrocker wrote: > From: Ben Crocker > > In redhat/Makefile and redhat/Makefile.common, introduce a > GIT macro: > > GIT ?= git > > which takes on the value from the environment, if it > exists, and defaults to 'git'

Re: [OS-BUILD PATCHv5 1/2] redhat/Makefile, Makefile.common: introduce GIT macro

2020-09-09 Thread Don Zickus
On Sat, Sep 05, 2020 at 04:10:31AM -, GitLab Bridge on behalf of bcrocker wrote: > From: Ben Crocker > > In redhat/Makefile and redhat/Makefile.common, introduce a > GIT macro: > > GIT ?= git > > which takes on the value from the environment, if it > exists, and defaults to 'git'

Re: [OS-BUILD PATCH] Combine Red Hat patches into single patch

2020-10-06 Thread Don Zickus
On Tue, Oct 06, 2020 at 07:12:44AM -0500, Justin Forbes wrote: > > Would be nice if those could be links to the commits in question, > > as that makes it easy to look at them. How about something like this: > > > > $ git log --no-merges --pretty=oneline --no-decorate master..$EXCLUDE_FILES > > |

Re: [OS-BUILD PATCH] [redhat] New configs in drivers/gpu

2020-10-20 Thread Don Zickus
On Mon, Oct 19, 2020 at 01:39:34PM -0400, Lyude Paul wrote: > lgtm Hi Lyude, Could you respond with an Acked-by instead? Thanks! Cheers, Don > > On Fri, 2020-10-16 at 15:29 +, GitLab Bridge on behalf of jeremycline > wrote: > > From: Fedora Kernel Team > > > > Hi, > > > > As part of

Re: [OS-BUILD PATCH] [redhat] New configs in drivers/video

2020-10-20 Thread Don Zickus
On Mon, Oct 19, 2020 at 01:40:17PM -0400, Lyude Paul wrote: > lgtm Could you respond with an Acked-by here too. Thanks! Cheers, Don > > On Fri, 2020-10-16 at 15:29 +, GitLab Bridge on behalf of jeremycline > wrote: > > From: Fedora Kernel Team > > > > Hi, > > > > As part of the ongoing

Re: ❌ FAIL: Test report for kernel 5.9.0-42.test.fc33 (ark)

2020-10-19 Thread Don Zickus
On Mon, Oct 19, 2020 at 11:09:57AM +0200, Jiri Benc wrote: > On Thu, 15 Oct 2020 12:20:41 +0200, Jiri Benc wrote: > > On Thu, 15 Oct 2020 09:13:27 -, CKI Project wrote: > > > Overall result: FAILED (see details below) > > > Merge: OK > > >Compile: FAILED > > > >

Re: ❌ FAIL: Test report for kernel 5.9.0-42.test.fc33 (ark)

2020-10-19 Thread Don Zickus
On Mon, Oct 19, 2020 at 11:09:57AM +0200, Jiri Benc wrote: > On Thu, 15 Oct 2020 12:20:41 +0200, Jiri Benc wrote: > > On Thu, 15 Oct 2020 09:13:27 -, CKI Project wrote: > > > Overall result: FAILED (see details below) > > > Merge: OK > > >Compile: FAILED > > > >

Re: [OS-BUILD PATCHv2] redhat: Implement Makefile.dist

2020-08-25 Thread Don Zickus
On Tue, Aug 25, 2020 at 09:51:17AM -0400, Prarit Bhargava wrote: > On 8/24/20 11:52 AM, Don Zickus wrote: > > make mrproper > > mkdir output > > make O=output dist-configs > > Here's a simpler case: > > make dist-config *works*. > > However, make dist-

Re: [OS-BUILD PATCH] redhat: Implement Makefile.dist

2020-08-21 Thread Don Zickus
On Fri, Aug 21, 2020 at 01:44:55PM -, GitLab Bridge on behalf of prarit wrote: > diff --git a/Makefile.rhelver b/Makefile.dist > similarity index 77% > rename from Makefile.rhelver > rename to Makefile.dist > index 8fceabade7c8..0b4f2d28e7b8 100644 > --- a/Makefile.rhelver > +++

Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-24 Thread Don Zickus
On Sat, Aug 22, 2020 at 06:56:29AM -0400, Prarit Bhargava wrote: > > and final files are not tagged with 'rhel'. > > That's the current way dist-configs does things. I debated adding a rename > function to the os specific configs targets but think that should be a > separate > patch. *This*

Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-24 Thread Don Zickus
On Mon, Aug 24, 2020 at 10:25:21AM -0400, Prarit Bhargava wrote: > > dist-configs would be supported but not as an expected common command and > > would only be seen through dist-full-help? > > Yeah, I think that's what he's getting at. dist-configs would be an internal > only target.

Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-24 Thread Don Zickus
On Mon, Aug 24, 2020 at 09:31:53AM -0500, Justin Forbes wrote: > > Right. rh-configs and fedora-configs are nice in that they build ONLY those > > configs. > > > I don't see a problem with having them broken out for specific cases, > but really by default people should be in the habit of

Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

2020-08-24 Thread Don Zickus
On Mon, Aug 24, 2020 at 03:24:28PM -0300, Marcelo Ricardo Leitner wrote: > > But yeah, some will complain that now they need to copy a different > file to import the .config, but at least they will be sure of what > they are copying. Ah ok, so both rhel and fedora was built, one was tossed and

Re: [OS-BUILD PATCHv2] redhat: Implement Makefile.dist

2020-08-24 Thread Don Zickus
On Sun, Aug 23, 2020 at 12:25:17PM -, GitLab Bridge on behalf of prarit wrote: > diff --git a/Makefile.rhelver b/Makefile.dist > similarity index 78% > rename from Makefile.rhelver > rename to Makefile.dist > index 8fceabade7c8..1b3b3ca89bf3 100644 > --- a/Makefile.rhelver > +++

Re: Changing kernel configuration options related to the SquashFS decompression

2020-09-29 Thread Don Zickus
On Fri, Sep 18, 2020 at 10:49:09AM +0200, Bohdan Khomutskyi wrote: > Hello, > > While working on the change proposal > https://fedoraproject.org/wiki/Changes/OptimizeSquashFS > > I discovered that several kernel configuration options are set sub-optimally > in Fedora. In RHEL 8, the optimal

Re: [OS-BUILD PATCHv2] redhat/configs: Cleanup CONFIG_CRYPTO_SHA512

2020-09-28 Thread Don Zickus
On Mon, Sep 28, 2020 at 02:58:26PM -, GitLab Bridge on behalf of prarit wrote: > From: Prarit Bhargava > > Sending new version, previous version not acked. Acked-by: Don Zickus > > P. > > --8<-- > > dzickus pointed out that my change is not optima

Re: [OS-BUILD PATCH] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-10-02 Thread Don Zickus
On Fri, Oct 02, 2020 at 01:19:07PM -0400, Don Zickus wrote: > On Thu, Oct 01, 2020 at 12:44:27AM -, GitLab Bridge on behalf of bcrocker > wrote: > > From: Ben Crocker > > > > GIT ?= git > > > > and replace literal occurrences of 'git' with $(GIT). &g

Re: [OS-BUILD PATCH] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-10-02 Thread Don Zickus
On Fri, Oct 02, 2020 at 01:19:07PM -0400, Don Zickus wrote: > On Thu, Oct 01, 2020 at 12:44:27AM -, GitLab Bridge on behalf of bcrocker > wrote: > > From: Ben Crocker > > > > GIT ?= git > > > > and replace literal occurrences of 'git' with $(GIT). &g

Re: Changing kernel configuration options related to the SquashFS decompression

2020-10-02 Thread Don Zickus
lready accepted it! Cheers, Don > > Kind regards, > > On 29/09/2020 16:34, Don Zickus wrote: > > On Fri, Sep 18, 2020 at 10:49:09AM +0200, Bohdan Khomutskyi wrote: > > > Hello, > > > > > > While working on the change proposal > > > https://fedo

Re: [OS-BUILD PATCH] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-10-02 Thread Don Zickus
hat prints additional information > and/or does additional processing before and/or after (or > even instead of) invoking /usr/bin/git. Acked-by: Don Zickus > > Signed-off-by: Ben Crocker > --- > redhat/Makefile| 29 +++-- > redhat/Makefile.commo

Re: [OS-BUILD PATCH] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-10-02 Thread Don Zickus
On Fri, Oct 02, 2020 at 01:19:07PM -0400, Don Zickus wrote: > On Thu, Oct 01, 2020 at 12:44:27AM -, GitLab Bridge on behalf of bcrocker > wrote: > > From: Ben Crocker > > > > GIT ?= git > > > > and replace literal occurrences of 'git' with $(GIT). &g

Re: [OS-BUILD PATCH] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-10-02 Thread Don Zickus
On Thu, Oct 01, 2020 at 12:44:27AM -, GitLab Bridge on behalf of bcrocker wrote: > From: Ben Crocker > > GIT ?= git > > and replace literal occurrences of 'git' with $(GIT). > This change enables us to override 'git' with, e.g., some > arbitrary shell script that prints additional

Re: [OS-BUILD PATCH] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-10-02 Thread Don Zickus
On Fri, Oct 02, 2020 at 01:19:07PM -0400, Don Zickus wrote: > On Thu, Oct 01, 2020 at 12:44:27AM -, GitLab Bridge on behalf of bcrocker > wrote: > > From: Ben Crocker > > > > GIT ?= git > > > > and replace literal occurrences of 'git' with $(GIT). &g

Re: [OS-BUILD PATCH] redhat/Makefile: Fix RHEL8 python warning

2020-05-21 Thread Don Zickus
-s /usr/bin/python3 /usr/libexec/platform-python > > Change the message to be distribution agnostic. Acked-by: Don Zickus > > Signed-off-by: Prarit Bhargava > --- > redhat/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/redhat

Re: [OS-BUILD PATCHv2] Allow building of kernel-tools standalone

2020-10-28 Thread Don Zickus
On Wed, Oct 28, 2020 at 09:46:37AM -0400, Brian Masney wrote: > On Wed, Oct 28, 2020 at 12:44:14PM -, GitLab Bridge on behalf of > dzickusrh wrote: > > From: Don Zickus > > > > For CKI and its cross-compile environment, it can not cross > > compile userspace

Re: [OS-BUILD PATCHv2] Allow building of kernel-tools standalone

2020-10-28 Thread Don Zickus
On Wed, Oct 28, 2020 at 09:46:37AM -0400, Brian Masney wrote: > On Wed, Oct 28, 2020 at 12:44:14PM -, GitLab Bridge on behalf of > dzickusrh wrote: > > From: Don Zickus > > > > For CKI and its cross-compile environment, it can not cross > > compile userspace

Re: [OS-BUILD PATCH] Point pathfix to the new location for gen_compile_commands.py

2020-10-28 Thread Don Zickus
d another script has been added there as well, > so fix up the directory. Acked-by: Don Zickus > > Signed-off-by: Justin M. Forbes > --- > redhat/kernel.spec.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/redhat/kernel.spec.template b

Re: [OS-BUILD PATCH] redhat/Makefile.common: Fix MARKER

2020-07-31 Thread Don Zickus
stored in TAG which is used by MARKER. The value of MARKER is set > using a cut command on 'g' which results in MARKER being set to > "it69119673bd50.1" instead of "d76dfb51aa86" Hmm, surprising it is showing up now. Acked-by: Don Zickus > > The problem with con

Re: [OS-BUILD PATCHv2] redhat/Makefile: Fix 'rh-configs' and 'fedora-configs' targets

2020-07-31 Thread Don Zickus
On Fri, Jul 31, 2020 at 02:55:54PM -, GitLab Bridge on behalf of prarit wrote: > dist-configs-prep: dist-clean-configs > - cd $(REDHAT)/configs; TARGET=$(DIST_TARGET) ./build_configs.sh > $(PACKAGE_NAME) $(ARCH_MACH) > + cd $(REDHAT)/configs; ./build_configs.sh $(PACKAGE_NAME)

Re: [OS-BUILD PATCH] gitattributes: Remove unnecesary export restrictions

2020-07-31 Thread Don Zickus
/ and the makefile. As agreed.. Acked-by: Don Zickus > > Signed-off-by: Prarit Bhargava > --- > .gitattributes | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/.gitattributes b/.gitattributes > index 33d4be033ae5..4b32eaa9571e 100644 > --- a/.gitattributes &g

Re: [ARK PATCH 0/17] rebase Pinephone screen patches

2020-07-13 Thread Don Zickus
On Sun, Jul 12, 2020 at 01:09:18PM -, GitLab Bridge on behalf of pbrobinson wrote: > From: pbrobinson on gitlab.com > > Revert the old version of the patches, apply the latest upstream > version: Hi Peter, It looks like most of your patches are git cherry-picks? If so, just using 'git

Re: [ARK PATCH 0/17] rebase Pinephone screen patches

2020-07-13 Thread Don Zickus
On Mon, Jul 13, 2020 at 05:07:35PM +0100, Peter Robinson wrote: > > On Sun, Jul 12, 2020 at 01:09:18PM -, GitLab Bridge on behalf of > > pbrobinson wrote: > > > From: pbrobinson on gitlab.com > > > > > > Revert the old version of the patches, apply the latest upstream > > > version: > > > >

Re: [OS-BUILD PATCHv2] redhat/Makefile: Add fedora-configs and rh-configs make targets

2020-06-18 Thread Don Zickus
On Thu, Jun 18, 2020 at 01:01:25PM -0400, Prarit Bhargava wrote: > On 6/18/20 12:52 PM, Don Zickus wrote: > > On Wed, Jun 17, 2020 at 03:44:16PM -, GitLab Bridge on behalf of prarit > > wrote: > >> From: Prarit Bhargava > >> > >> There are times wh

Re: [OS-BUILD PATCHv2] redhat/Makefile: Add fedora-configs and rh-configs make targets

2020-06-18 Thread Don Zickus
rh-configs make targets. Regardless, I like this idea and as bonus keeps muscle memory for rh-configs. Acked-by: Don Zickus > > v2: Add rh-help entries. > > Signed-off-by: Prarit Bhargava > --- > redhat/Makefile | 8 > 1 file changed, 8 insertions(+) >

Re: [OS-BUILD PATCH] redhat/configs: Use SHA512 for module signing

2020-06-18 Thread Don Zickus
On Tue, Jun 16, 2020 at 11:47:20PM -, GitLab Bridge on behalf of prarit wrote: > From: Prarit Bhargava > > kernsec.org recommends using SHA512 [1] for kernel module signing. There > isn't any reason not to do this and the benefit is a stronger module > hash. > > [1] >

Re: [ARK PATCH] arch/x86: Remove vendor specific CPU ID checks

2020-06-26 Thread Don Zickus
). > Certification is adopting a new process in which CPU certifications will > be tracked on https://catalog.redhat.com. > > Remove the vendor specific CPU ID checks from rh_check_supported(). Acked-by: Don Zickus I could argue the whole rh_check_supported() could go. The whole s

Re: [OS-BUILD PATCH] [redhat] New configs in drivers/hwmon

2020-06-05 Thread Don Zickus
On Fri, Jun 05, 2020 at 05:19:22PM +0100, Peter Robinson wrote: > > > > Well, I don't mind a few more mails, I already get a lot and they make > > not much of a difference, *if* they are useful somehow. But to be useful > > they are currently to hard to parse/understand: you have to scroll down >

Re: Streamlining the ARK config process

2020-06-09 Thread Don Zickus
On Mon, Jun 08, 2020 at 03:19:52PM -0400, Jeremy Cline wrote: > On Mon, Jun 08, 2020 at 03:10:15PM -0400, Prarit Bhargava wrote: > > On 6/8/20 2:58 PM, Jeremy Cline wrote: > > > Hey folks, > > > > > > Seeing the merge window configs rolling in along with people starting to > > > open GitLab merge

Re: [OS-BUILD PATCH] [redhat] New configs in drivers/hwmon

2020-06-05 Thread Don Zickus
Hi Knurd, Thanks for the feedback! On Fri, Jun 05, 2020 at 02:24:13PM +0200, Thorsten Leemhuis wrote: > Lo! I'm slightly puzzled. These messages are now sent to > fedora-kernel-list, which kinda sounds like input from the fedora > community is wanted. But all this discussions look RHEL-specific

Re: [OS-BUILD PATCHv2 0/3] Evaluate configs

2020-07-21 Thread Don Zickus
On Tue, Jul 21, 2020 at 10:38:09AM -0400, Prarit Bhargava wrote: > On 7/20/20 9:45 AM, Don Zickus wrote: > > On Fri, Jul 17, 2020 at 12:07:53PM -, GitLab Bridge on behalf of prarit > > wrote: > >> From: prarit on gitlab.com > >> > >> The merge request

Re: [OS-BUILD PATCH 0/2] Kernel secure boot dual signing changes

2020-07-30 Thread Don Zickus
ewer keys while updating to fix the "boothole" CVEs. Acked-by: Don Zickus > ___ > kernel mailing list -- kernel@lists.fedoraproject.org > To unsubscribe send an email to kernel-le...@lists.fedoraproject.org > Fedora Code of Condu

Re: [OS-BUILD PATCHv2 0/3] Evaluate configs

2020-07-20 Thread Don Zickus
On Fri, Jul 17, 2020 at 12:07:53PM -, GitLab Bridge on behalf of prarit wrote: > From: prarit on gitlab.com > > The merge request had no description. Any thoughts of adding a simple cover letter? The above description will go in as a merge changelog and looks kinda funny. Merge request

Re: [OS-BUILD PATCH] redhat/docs: Add Fedora RPM tagging date

2020-07-20 Thread Don Zickus
l very recently. > > Add a comment about when we started tagging Fedora RPMs in the ARK tree. Acked-by: Don Zickus > > Signed-off-by: Prarit Bhargava > Cc: jfor...@redhat.com > --- > redhat/docs/repository-layout.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff -

Re: [OS-BUILD PATCH] efi: The EFI_VARS is legacy and now x86 only

2021-01-07 Thread Don Zickus
On Mon, Dec 21, 2020 at 09:43:52AM -0600, Justin Forbes wrote: > On Sat, Dec 19, 2020 at 1:42 PM GitLab Bridge on behalf of pbrobinson > wrote: > > > > From: pbrobinson on gitlab.com > > https://gitlab.com/cki-project/kernel-ark/-/merge_requests/825#note_470649351 > > > > No idea why that failed,

Re: How to build vanilla kernel from ark (was: Re: [OS-BUILD PATCH] docs: Update docs to reflect newer workflow.)

2020-11-25 Thread Don Zickus
On Wed, Nov 25, 2020 at 06:10:21AM +0100, Thorsten Leemhuis wrote: > Lo! > > Am 24.11.20 um 23:22 schrieb GitLab Bridge on behalf of dzickusrh: > > From: Don Zickus > > > > The workflow has recently changed such that all development is done > > on the 'os-build'

Re: [OS-BUILD PATCHv5 1/4] Correct orc_types failure whilst running `make prepare` https://bugzilla.redhat.com/show_bug.cgi?id=1882854

2020-11-24 Thread Don Zickus
On Sat, Nov 21, 2020 at 04:55:49PM -, GitLab Bridge on behalf of pecastro wrote: > From: "Paulo E. Castro" > > In file included from scripts/sorttable.c:191: > scripts/sorttable.h:89:10: fatal error: asm/orc_types.h: No such file or > directory >89 | #include > |

Re: [OS-BUILD PATCHv5 0/4] Fix bug 1882854

2020-11-24 Thread Don Zickus
On Sat, Nov 21, 2020 at 04:55:49PM -, GitLab Bridge on behalf of pecastro wrote: > From: pecastro on gitlab.com > > `make prepare` fails when trying to build external kernel modules. > Details in https://bugzilla.redhat.com/show_bug.cgi?id=1882854 and > previous related bugs. First, thank

Re: [OS-BUILD PATCHv18 0/4] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-11-24 Thread Don Zickus
On Tue, Nov 24, 2020 at 09:37:57PM -, GitLab Bridge on behalf of Don Zickus wrote: > From: Don Zickus on gitlab.com > https://gitlab.com/cki-project/kernel-ark/-/issues/35#note_453840783 > > Should be resolved now with the new spec file changes introduced last > month. Sor

Re: [OS-BUILD PATCHv18 0/4] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-11-24 Thread Don Zickus
; > This change enables us to override 'git' with, e.g., some\ > arbitrary shell script that prints additional information\ > and/or does additional processing before and/or after (or\ > even instead of) invoking /usr/bin/git. Acked-by: Don Z

Re: [OS-BUILD PATCH] [redhat] New configs in net/xfrm

2020-11-24 Thread Don Zickus
On Mon, Oct 19, 2020 at 11:58:59PM +0200, Sabrina Dubroca wrote: > 2020-10-19, 13:35:11 -0300, Marcelo Ricardo Leitner wrote: > > On Fri, Oct 16, 2020 at 03:29:58PM -, GitLab Bridge on behalf of > > jeremycline wrote: > > > --- /dev/null > > > +++

Re: Reporting kernel building docs problems?

2020-11-24 Thread Don Zickus
On Thu, Oct 22, 2020 at 10:59:02AM -0400, Bastien Nocera wrote: > Hey, > > A couple of months ago I filed bugs about the kernel-cki build > process and some problems I encountered: > https://gitlab.com/cki-project/kernel-ark/-/issues > > Today, I wanted to build a test kernel for a Fedora user

Re: [OS-BUILD PATCH] configs: Enable CONFIG_DEBUG_INFO_BTF

2020-11-24 Thread Don Zickus
forgot to cc Jiri On Tue, Nov 24, 2020 at 06:11:13PM -, GitLab Bridge on behalf of dzickusrh wrote: > From: Don Zickus > > This option is needed to allow the latest features of bpftool > to compile correctly. Currently it was disabled because of > a gcc bug around DWARF

Re: [OS-BUILD PATCHv19 0/4] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-12-09 Thread Don Zickus
On Fri, Dec 04, 2020 at 02:23:11PM -, GitLab Bridge on behalf of bcrocker wrote: > From: bcrocker on gitlab.com > > Add a GIT macro to Makefile: > > GIT ?= git > > and replace literal occurrences of 'git' with $(GIT)\ > in Makefile and Makefile.commo

Re: [OS-BUILD PATCH] docs: Update docs to reflect newer workflow.

2020-12-02 Thread Don Zickus
On Tue, Dec 01, 2020 at 10:27:58AM -0500, Bastien Nocera wrote: > > - git checkout linus/master > > - git merge -m "Merge branch 'os-build'" os-build > > - # Fedora carries a patch to alter this setting, so we need to change the > > configuration to build a vanilla tree. > > - # If you're

Re: [OS-BUILD PATCH] docs: Update docs to reflect newer workflow.

2020-12-02 Thread Don Zickus
On Tue, Dec 01, 2020 at 10:27:58AM -0500, Bastien Nocera wrote: > > > - Original Message - > > From: Don Zickus > > > > The workflow has recently changed such that all development is done > > on the 'os-build' branch. Update the docs to show how easy i

Re: dist-get-latest target

2020-12-10 Thread Don Zickus
On Wed, Dec 09, 2020 at 09:06:08PM -0500, Ben Crocker wrote: > Hi! > > Can anyone tell me how to get useful information from > > make dist-get-latest? > > I've tried putting various strings in ./localversion, leaving it empty > or even removing it entirely. > > When I do > > make

Re: "No CCs" label & cki-bot

2020-12-23 Thread Don Zickus
On Wed, Dec 23, 2020 at 07:39:26AM -0500, Prarit Bhargava wrote: > > > > Err. Nope. That was the how the original public webhook worked until > > someone started posting commits with empty merge request descriptions. > > > > *cough*Prarit*cough* > > Me? Moi? > > /me looks around innocently >

Re: "No CCs" label & cki-bot

2020-12-22 Thread Don Zickus
On Tue, Dec 22, 2020 at 01:17:43PM -0500, Prarit Bhargava wrote: > It seems that cki-bot doesn't like it when I remove the "No CCs" label from an > MR. You can see this odd behaviour in !741: > > https://gitlab.com/cki-project/kernel-ark/-/merge_requests/741 > > I ran a script to identify all

Re: "No CCs" label & cki-bot

2020-12-22 Thread Don Zickus
On Tue, Dec 22, 2020 at 02:56:19PM -0500, Don Zickus wrote: > On Tue, Dec 22, 2020 at 01:17:43PM -0500, Prarit Bhargava wrote: > > It seems that cki-bot doesn't like it when I remove the "No CCs" label from > > an > > MR. You can see this odd behaviour in !741:

Re: [OS-BUILD PATCH 0/20] [redhat] All shell scripts: Fix syntax flagged by shellcheck

2020-11-16 Thread Don Zickus
Ben! It seems to be reasonable. Lots of cookie cutter conversions. Hopefully the normal workflow will expose any quirks, but after reading this over 3 times (over the last couple of weeks), I think we should be fine. Acked-by: Don Zickus > > http://pastebin.test.redhat.com/917268 > >

Re: [OS-BUILD PATCH] Temporarily backout parallel xz script

2020-11-20 Thread Don Zickus
r to back that change out in the short term. This reverts us to > the way that Fedora used to compress the modules. Hopefully it isn't that much slower. But yeah stability over speed. Acked-by: Don Zickus > > Signed-off-by: Justin M. Forbes > --- > redhat/kernel.spec.template

Re: [OS-BUILD PATCHv12 0/5] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-11-20 Thread Don Zickus
On Fri, Nov 20, 2020 at 12:17:01AM -, GitLab Bridge on behalf of bcrocker wrote: > From: bcrocker on gitlab.com > > Add a GIT macro to Makefile: > > GIT ?= git > > and replace literal occurrences of 'git' with $(GIT)\ > in Makefile and Makefile.commo

Re: [OS-BUILD PATCHv2 0/20] [redhat] All shell scripts: Fix syntax flagged by shellcheck

2020-11-20 Thread Don Zickus
d at: > > http://pastebin.test.redhat.com/917268 It was hard for me to know what has changed since the previous version, but I will assume this version addresses all of Jiri's concerns. Acked-by: Don Zickus > > SC2001: See if you can use ${variable//search/replace} instead.\ > SC2002: Use

Re: [OS-BUILD PATCHv7 2/5] [redhat] egit.sh initial commit

2020-11-18 Thread Don Zickus
On Mon, Nov 16, 2020 at 09:34:36PM -, GitLab Bridge on behalf of bcrocker wrote: > +merge-base ) > +if [ -n "$EGIT_OVERRIDE_MERGE_BASE" ] > +then > +# This should be an SHA1: > +echo "$EGIT_OVERRIDE_MERGE_BASE" > +else > +git

Re: [OS-BUILD PATCHv6 0/8] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-11-16 Thread Don Zickus
On Fri, Nov 13, 2020 at 09:11:36PM -, GitLab Bridge on behalf of bcrocker wrote: > From: bcrocker on gitlab.com > > Add a GIT macro to Makefile: > > GIT ?= git > > and replace literal occurrences of 'git' with $(GIT)\ > in Makefile and Makefile.common. > > This change enables us to

Re: [OS-BUILD PATCHv2] Allow building of kernel-tools standalone

2020-10-28 Thread Don Zickus
On Wed, Oct 28, 2020 at 09:46:37AM -0400, Brian Masney wrote: > On Wed, Oct 28, 2020 at 12:44:14PM -, GitLab Bridge on behalf of > dzickusrh wrote: > > From: Don Zickus > > > > For CKI and its cross-compile environment, it can not cross > > compile userspace

Re: [OS-BUILD PATCH] Run MR testing in CKI pipeline

2021-01-12 Thread Don Zickus
o include schedule jobs and pages deployment (Don Zickus) > > Signed-off-by: Veronika Kabatova > --- > .gitlab-ci.yml | 179 ++--- > 1 file changed, 169 insertions(+), 10 deletions(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml >

Re: [OS-BUILD PATCH] Add new entries to RHMAINTAINERS

2020-12-11 Thread Don Zickus
gt; Signed-off-by: Wei Huang Thanks for this work! Acked-by: Don Zickus > --- > redhat/rhdocs/MAINTAINERS/RHMAINTAINERS | 156 +++- > 1 file changed, 155 insertions(+), 1 deletion(-) > > diff --git a/redhat/rhdocs/MAINTAINERS/RHMAINTAINERS > b/redhat/rhdoc

Re: [OS-BUILD PATCHv4 0/2] Combine duplicate configs across ark and fedora into common

2021-04-06 Thread Don Zickus
On Mon, Apr 05, 2021 at 11:35:13PM +0200, Paul Bolle wrote: > Hi Don, > > Don Zickus (via Email Bridge) schreef op ma 05-04-2021 om 21:27 [+]: > > Also ran some bash scripts to find another 60 or so duplicates. > > Lazy question (I had trouble skimming the diffs): what

Re: How to build vanilla kernel from ark (was: Re: [OS-BUILD PATCH] docs: Update docs to reflect newer workflow.)

2021-03-10 Thread Don Zickus
On Thu, Mar 04, 2021 at 06:27:04PM +0100, Thorsten Leemhuis wrote: > > * I take os-build spin off the 'redhat' directory (and other infra pieces) > > into a branch called 'redhat-infra'??? or something better > > I'd prefer to not have "redhat" in there (but I can live with it if we > don't

Re: How to build vanilla kernel from ark (was: Re: [OS-BUILD PATCH] docs: Update docs to reflect newer workflow.)

2021-03-04 Thread Don Zickus
is wrote: > > Am 25.11.20 um 15:43 schrieb Don Zickus: > >> On Wed, Nov 25, 2020 at 06:10:21AM +0100, Thorsten Leemhuis wrote: > >>> Am 24.11.20 um 23:22 schrieb GitLab Bridge on behalf of dzickusrh: > >>>> From: Don Zickus > >>>> The workflow has

Re: How to build vanilla kernel from ark (was: Re: [OS-BUILD PATCH] docs: Update docs to reflect newer workflow.)

2021-03-04 Thread Don Zickus
On Thu, Mar 04, 2021 at 06:27:04PM +0100, Thorsten Leemhuis wrote: > > Just to remind myself of your expectation. > > > > * I take os-build spin off the 'redhat' directory (and other infra pieces) > > into a branch called 'redhat-infra'??? or something better > > I'd prefer to not have

Re: [OS-BUILD PATCHv4 0/2] Combine duplicate configs across ark and fedora into common

2021-04-07 Thread Don Zickus
On Wed, Apr 07, 2021 at 07:17:44PM +0200, Paul Bolle wrote: > Don Zickus schreef op wo 07-04-2021 om 12:38 [-0400]: > > I welcome any feedback as someone who tried to help. :-D > > Well, I've just done my first web-based merge-request. (Actually my first > merge-request ever.

Re: [OS-BUILD PATCHv4 0/2] Combine duplicate configs across ark and fedora into common

2021-04-07 Thread Don Zickus
On Wed, Apr 07, 2021 at 04:14:28PM +0200, Paul Bolle wrote: > Don Zickus schreef op di 06-04-2021 om 10:30 [-0400]: > > To me, duplicates meant that same config setting in fedora and (common or > > ark). > > common is for settings that are identical in fedora and ark, ri

[INFO] Email bridge spam reduction

2021-02-15 Thread Don Zickus
Hi, A couple of us have been fixing bug in the email bridge in the last week. Most changes won't be noticed. However, one notable exception is 'bot spam' filtering. The email bridge will no longer send emails from the various bots about webhook or other admin things. As a submitter of the MR

Re: [ARK PATCHv2] x86: Fix compile issues with rh_check_supported()

2020-05-18 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/362#note_344755261 Dropped patch1 because internally Red Hat may drop the whole patch anyway. Let's just fix the Fedora compile problem for now. ___ kernel

Re: [ARK PATCHv2 0/2] Temporary fix, no need to review, it won't be merged.

2020-09-10 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/598#note_410579156 another test. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org

Re: [OS-BUILD PATCHv4 0/4] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-10-09 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/670#note_427359494 @bcrocker - Yes, I acked the 666 patch to get you a self-tests directory. Let's convert this back to a WIP to stop the email spam and rebase this patch set on top of 666. Then you can

Re: [OS-BUILD PATCHv2] New configs in kernel/trace

2020-10-20 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/443#note_432877518 Re-adding Acked-by label as the only change was a changelog addition of 'cc'. ___ kernel mailing list -- kernel@lists.fedoraproject.org

Re: [OS-BUILD PATCH 0/2] build system: run parallel make for bpf and kselftests install

2020-08-17 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/591#note_397300894 Seems like a no-brainer.. Acked-by: Don Zickus ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email

Re: [OS-BUILD PATCH 0/3] Make configs fix

2020-08-21 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/600#note_400207726 Indeed, I referenced the wrong script. Your example is very helpful. I rescind my objection and bow to your bash awesomeness... :-) ___ kernel

Re: [OS-BUILD PATCH 0/3] Make configs fix

2020-08-21 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/600#note_400102618 What happens when FLAVOR is 'not defined'. I am worried build_configs.sh shifts the variables and '1' is accidentally used as FLAVOR

Re: [ARK PATCH] Fixes "acpi: prefer booting with ACPI over DTS" to be RHEL only

2020-08-04 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/504#note_390849521 merged locally because gitlab can't handle updating MRs on a rebasing branch. ___ kernel mailing list -- kernel@lists.fedoraproject.org

Re: [OS-BUILD PATCH] Makefile.common: Do not pre-maturely bump version number during merge window

2020-06-10 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/442#note_358936367 I will close this and in preference to Justin's change. Cheers, Don ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe

Re: [OS-BUILD PATCHv3 0/3] [redhat] New configs in drivers/i2c

2020-12-07 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/741#note_461857999 > > Signed-off-by: Fedora Kernel Team > > > > > Hi, > > This patchset seems a little obtuse to me. As far as I can tell this should > just be one sing

Re: [OS-BUILD PATCHv18 0/4] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-11-24 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/issues/32#note_453843747 That is stale document data. Your clone should set you up at os-build (default branch) and everything should just work as expected. The 'master' branch just follows upstream but is merged nightly

Re: [OS-BUILD PATCHv18 0/4] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-11-24 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/issues/33#note_453842283 Hmm, not sure why the new docs have not been updated on that page. We now recommend everyone start on 'os-build' and apply changes there. Does that address your concern

Re: [OS-BUILD PATCHv18 0/4] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-11-24 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/issues/35#note_453840783 Should be resolved now with the new spec file changes introduced last month. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe

Re: [OS-BUILD PATCHv7 0/5] Fix bug 1882854

2020-12-09 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/761#note_463631448 @pecastro Thanks! Acked-by: Don Zickus ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le

Re: [OS-BUILD PATCHv18 0/4] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-12-02 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/issues/35#note_459195031 Ok. Should be resolved with a documentation update [diffs](https://gitlab.com/cki-project/kernel- ark/-/merge_requests/772/diffs). Does executing "git branch master --track upstream/m

Re: [OS-BUILD PATCHv2] docs: Update docs to reflect newer workflow.

2020-12-11 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/772#note_465400429 I assume you are referring to internal scripts reference to 'master'. If so, I worry that not everyone will use 'upstream' as their reference name. And they may not 'git fetch upstream

Re: [OS-BUILD PATCHv2] docs: Update docs to reflect newer workflow.

2020-12-11 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/772#note_465400566 Yeah, I can remove that. Thanks! ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le

Re: [OS-BUILD PATCHv3 0/4] redhat/configs/ark: Enable CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL and dependencies

2020-12-14 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/786#note_466539358 @jpoimboe reverted the requested change. Sorry about that, trying to debug other CI issues. ___ kernel mailing list -- kernel

Re: [OS-BUILD PATCHv4 0/4] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-11-10 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/670#note_445200383 Nitpick, can we not use 'dnf' here? It is slow. I think a 'test -x $(which bats)' or something similar is faster and just as effective

Re: [OS-BUILD PATCHv4 0/4] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-11-10 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/670#note_445201118 Another 'dnf list' ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le

Re: [OS-BUILD PATCHv4 0/4] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-11-10 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/670#note_445201003 Same here, maybe use 'test -x' instead of 'dnf list'? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email

Re: [OS-BUILD PATCH 0/4] dist-release target fixes

2020-11-11 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/764#note_445885090 Other than the git-update-index command, which seems odd, but I guess necessary, I am ok with it. Acked-by: Don Zickus ___ kernel mailing list

Re: [OS-BUILD PATCHv7 0/5] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-11-17 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/670#note_449451551 last one. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora

Re: [OS-BUILD PATCHv7 0/5] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-11-17 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/670#note_449432599 Just a test comment ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le

Re: [OS-BUILD PATCHv7 0/5] [redhat] Add GIT macro to Makefile and Makefile.common:

2020-11-17 Thread GitLab Bridge on behalf of Don Zickus
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/670#note_449453970 double email ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org

<    1   2   3   4   5   6   7   8   >