Re: [OS-BUILD PATCH] Keep sctp and l2tp modules in modules-extra

2021-05-07 Thread Justin Forbes (via Email Bridge)
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1117#note_570447318 I don't know that it would be worthwhile, I think it might be easier to write something to check it after the fact, or even the script to verify against sources. Honestly, if we stop

Re: [OS-BUILD PATCH] Keep sctp and l2tp modules in modules-extra

2021-05-07 Thread Paul Bolle (via Email Bridge)
From: Paul Bolle on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1117#note_570440114 filter-modules.sh and friends are arch-aware. (I hacked them into being noisy about bogus modules and that should work on all arches.) I realize that your plate is full already, but it

Re: [OS-BUILD PATCH] Keep sctp and l2tp modules in modules-extra

2021-05-07 Thread Justin Forbes (via Email Bridge)
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1117#note_570334250 It should work both ways, the email bridge seems a big laggy today though. instead of instant, it is on a delay. Email comments end up on gitlab and gitlab comments should end up in

Re: [OS-BUILD PATCH] Keep sctp and l2tp modules in modules-extra

2021-05-07 Thread Paul Bolle
Don Zickus (via Email Bridge) schreef op vr 07-05-2021 om 19:46 [+]: > That was my first thought until I wondered if every module in > modules-extra.list is applicable to every arch. Is it possible that > some of those modules are not built for an arch or its variant? We seem to be

Re: [OS-BUILD PATCH] Keep sctp and l2tp modules in modules-extra

2021-05-07 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1117#note_570311270 > > > > CKI Gitlab commented: > > > Marcelo Ricardo Leitner commented via email: > ``` > > https://gitlab.com/cki-project/kernel- ark/-/merge_requests/1117#note_570213935 > > > > >

Re: [OS-BUILD PATCH] Keep sctp and l2tp modules in modules-extra

2021-05-07 Thread Justin Forbes (via Email Bridge)
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1117#note_570289882 We do want it to ignore files that do not actually exist, othrewise we would have to change the extras list to be per arch, and frankly that sounds like more than I want to deal with.

Re: [OS-BUILD PATCH] Keep sctp and l2tp modules in modules-extra

2021-05-07 Thread Paul Bolle
Marcelo Ricardo Leitner schreef op vr 07-05-2021 om 12:11 [-0700]: > Or treat mod-extra.list (and others) as mandatory. If it's there, and > the module is not listed in the final file list, as in: > %{expand:%%files -f %{name}-%{?3:%{3}-}modules-extra.list > %{?3:%{3}-}modules-extra}\ > it's a

Re: [OS-BUILD PATCH] Keep sctp and l2tp modules in modules-extra

2021-05-07 Thread Paul Bolle (via Email Bridge)
From: Paul Bolle on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1117#note_570266165 Somewhere deep in a horrific rpmmacro I noticed: %{expand:%%files -f kernel-%{?3:%{3}-}modules-extra.list %{?3:%{3}-}modules-extra} My guess is that "%files -f " is liberal, i.e. it

Re: [OS-BUILD PATCH] Keep sctp and l2tp modules in modules-extra

2021-05-07 Thread Marcelo Ricardo Leitner
On Fri, May 07, 2021 at 07:02:27PM -, Justin Forbes (via Email Bridge) wrote: > From: Justin Forbes on gitlab.com > https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1117#note_570213935 > > > Anyway, the commands I used are: time find . -name "Makefile\*" -exec > grep '.o' {} ; >

Re: [OS-BUILD PATCH] Keep sctp and l2tp modules in modules-extra

2021-05-07 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1117#note_570181632 So I hacked up a script that can catch this. The trick is where to run this. I think a self-test area is perfect, but the current self-tests is a little heavy and only makes sense as a

Re: [OS-BUILD PATCH] Keep sctp and l2tp modules in modules-extra

2021-05-06 Thread Marcelo Ricardo Leitner
On Thu, May 06, 2021 at 10:15:12PM -, Don Zickus (via Email Bridge) wrote: > From: Don Zickus > > Keep sctp and l2tp modules in modules-extra > > There are two modules: sctp_diag and l2tp_ip6 that are in kernel-modules > that accidentally dragged the rest of the sctp and l2tp mdoules in >

Re: [OS-BUILD PATCH] Keep sctp and l2tp modules in modules-extra

2021-05-06 Thread Justin Forbes (via Email Bridge)
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1117#note_569297906 There is something coming that will help with that. When rpminspect is used for autoqa in bodhi, we should see a notification when files move.

Re: [OS-BUILD PATCH] Keep sctp and l2tp modules in modules-extra

2021-05-06 Thread Paul Bolle
Don Zickus (via Email Bridge) schreef op do 06-05-2021 om 22:15 [+]: > There are two modules: sctp_diag and l2tp_ip6 that are in kernel-modules > that accidentally dragged the rest of the sctp and l2tp mdoules in > there. Instead all those modules should stay in modules-extra. > > Move the

[OS-BUILD PATCH] Keep sctp and l2tp modules in modules-extra

2021-05-06 Thread Don Zickus (via Email Bridge)
From: Don Zickus Keep sctp and l2tp modules in modules-extra There are two modules: sctp_diag and l2tp_ip6 that are in kernel-modules that accidentally dragged the rest of the sctp and l2tp mdoules in there. Instead all those modules should stay in modules-extra. Move the offending modules